"Change Set: ParagraphEditor-iSearch-rkris Date: 28 July 2004 Author: Ram Krishnan
Adds incremental search (similar to emacs but forward search only) to ParagraphEditor. This changeset remaps the Ctl-S key, which used to invoke the #search: selector, to the #incrementalSearch: selector. While in the incrementalSearch mode, Ctl-W can be used to extend the search term and Backspace to shorten it. This changeset has only been tested with Squeak3.7. It will fail in Squeak3.6 as there seem to be some conflicting changes in ParagraphEditor between the two revisions."
The search works fine. However, I find that a non-match is misleading. If for example you search for "abd" in a text containing "xxxxabcxxx", "a" will be first highlighted, then "ab", then nothing (which is not distinct from the default non-search mode). "ab" should be highlighted in another color (red?) if possible, and no character should be added to the search string when there are no matches.
Samuel,
Thanks for the feedback. The non-match behavior is definitely misleading. I've pushed another changeset to the squeak-dev list which should address that issue. I also briefly looked at how to visually indicate whether or not a ParagraphEditor instance is in iSearch mode. That will require some changes to the class NewParagraph.
Peace.
-ram
Samuel Tardieu wrote:
The search works fine. However, I find that a non-match is misleading. If for example you search for "abd" in a text containing "xxxxabcxxx", "a" will be first highlighted, then "ab", then nothing (which is not distinct from the default non-search mode). "ab" should be highlighted in another color (red?) if possible, and no character should be added to the search string when there are no matches.
squeak-dev@lists.squeakfoundation.org
-
Ram Krishnan -
rkris＠kriyative.net
-
Samuel Tardieu