testRevertMostRecentRemovesLatestVersion is still failing -- could use a little help on that one.
On Fri, Oct 25, 2013 at 10:41 AM, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.606.mcz
==================== Summary ====================
Name: System-cmm.606 Author: cmm Time: 25 October 2013, 10:41:38.197 am UUID: 6a901946-a756-42d8-a453-f727b8dfad32 Ancestors: System-dtl.605
- Correct initialization of RecentMessages in case a new instance is ever made (and for the test cases).
- Fix revertMostRecent.
=============== Diff against System-dtl.605 ===============
Item was changed: ----- Method: RecentMessages>>initialize (in category 'initialize-release') ----- initialize super initialize.
methodReferences := OrderedCollection new: (maximumSubmissionCount := 30).
isSuspended := false!
methodReferences := OrderedCollection new: 30!
Item was changed: ----- Method: RecentMessages>>revertMostRecent (in category 'accessing') ----- revertMostRecent "If the most recent method submission was a method change, revert that change, and if it was a submission of a brand-new method, remove that method." | changeRecords lastSubmission theClass theSelector | methodReferences ifEmpty: [ ^ Beeper beep ].
lastSubmission := self mostRecent.
!lastSubmission := methodReferences last. theClass := lastSubmission actualClass ifNil: [ ^ Beeper beep ]. theSelector := lastSubmission methodSymbol. changeRecords := theClass changeRecordsAt: theSelector. changeRecords isEmptyOrNil ifTrue: [ ^ Beeper beep ]. changeRecords size = 1 ifTrue: [ "method has no prior version, so reverting in this case means removing" theClass removeSelector: theSelector ] ifFalse: [ changeRecords second fileIn ]
System-ul.607 should fix it. The problem was that the class of the method is in a custom environment, but the code was looking for it in Smalltalk.
Levente
On Fri, 25 Oct 2013, Chris Muller wrote:
testRevertMostRecentRemovesLatestVersion is still failing -- could use a little help on that one.
On Fri, Oct 25, 2013 at 10:41 AM, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.606.mcz
==================== Summary ====================
Name: System-cmm.606 Author: cmm Time: 25 October 2013, 10:41:38.197 am UUID: 6a901946-a756-42d8-a453-f727b8dfad32 Ancestors: System-dtl.605
- Correct initialization of RecentMessages in case a new instance is ever made (and for the test cases).
- Fix revertMostRecent.
=============== Diff against System-dtl.605 ===============
Item was changed: ----- Method: RecentMessages>>initialize (in category 'initialize-release') ----- initialize super initialize.
methodReferences := OrderedCollection new: (maximumSubmissionCount := 30).
isSuspended := false!
methodReferences := OrderedCollection new: 30!
Item was changed: ----- Method: RecentMessages>>revertMostRecent (in category 'accessing') ----- revertMostRecent "If the most recent method submission was a method change, revert that change, and if it was a submission of a brand-new method, remove that method." | changeRecords lastSubmission theClass theSelector | methodReferences ifEmpty: [ ^ Beeper beep ].
lastSubmission := self mostRecent.
!lastSubmission := methodReferences last. theClass := lastSubmission actualClass ifNil: [ ^ Beeper beep ]. theSelector := lastSubmission methodSymbol. changeRecords := theClass changeRecordsAt: theSelector. changeRecords isEmptyOrNil ifTrue: [ ^ Beeper beep ]. changeRecords size = 1 ifTrue: [ "method has no prior version, so reverting in this case means removing" theClass removeSelector: theSelector ] ifFalse: [ changeRecords second fileIn ]
squeak-dev@lists.squeakfoundation.org