"Change Set: SysNavFix-ar Date: 28 May 2005 Author: Andreas Raab
Fix a few uses of #isMemberOf: Symbol."!
'From Squeak3.8gamma of ''24 November 2004'' [latest update: #6662] on 28 May 2005 at 12:41:14 pm'! "Change Set: SysNavFix-ar Date: 28 May 2005 Author: Andreas Raab
Fix a few uses of #isMemberOf: Symbol."!
!SystemNavigation methodsFor: 'query' stamp: 'ar 5/28/2005 12:32'! allCallsOn: aLiteral "Answer a Collection of all the methods that call on aLiteral even deeply embedded in literal array." "self new browseAllCallsOn: #open:label:." | aCollection special thorough aList byte | aCollection _ OrderedCollection new. special _ Smalltalk hasSpecialSelector: aLiteral ifTrueSetByte: [:b | byte _ b]. thorough _ (aLiteral isSymbol) and: ["Possibly search for symbols imbedded in literal arrays" Preferences thoroughSenders]. Cursor wait showWhile: [self allBehaviorsDo: [:class | aList _ thorough ifTrue: [class thoroughWhichSelectorsReferTo: aLiteral special: special byte: byte] ifFalse: [class whichSelectorsReferTo: aLiteral special: special byte: byte]. aList do: [:sel | sel == #DoIt ifFalse: [aCollection add: (MethodReference new setStandardClass: class methodSymbol: sel)]]]]. ^ aCollection! !
!SystemNavigation methodsFor: 'query' stamp: 'ar 5/28/2005 12:33'! allSentMessagesWithout: classesAndMessagesPair "Answer the set of selectors which are sent somewhere in the system, computed in the absence of the supplied classes and messages." | sent absentClasses absentSelectors | sent _ IdentitySet new: CompiledMethod instanceCount. absentClasses _ classesAndMessagesPair first. absentSelectors _ classesAndMessagesPair second. self flag: #shouldBeRewrittenUsingSmalltalkAllClassesDo:. "sd 29/04/03" Cursor execute showWhile: [Smalltalk classNames do: [:cName | ((absentClasses includes: cName) ifTrue: [{}] ifFalse: [{Smalltalk at: cName. (Smalltalk at: cName) class}]) do: [:cl | (absentSelectors isEmpty ifTrue: [cl selectors] ifFalse: [cl selectors copyWithoutAll: absentSelectors]) do: [:sel | "Include all sels, but not if sent by self" (cl compiledMethodAt: sel) literals do: [:m | (m isSymbol) ifTrue: ["might be sent" m == sel ifFalse: [sent add: m]]. (m isMemberOf: Array) ifTrue: ["might be performed" m do: [:x | (x isSymbol) ifTrue: [x == sel ifFalse: [sent add: x]]]]]]]]. "The following may be sent without being in any literal frame" 1 to: Smalltalk specialSelectorSize do: [:index | sent add: (Smalltalk specialSelectorAt: index)]]. Smalltalk presumedSentMessages do: [:sel | sent add: sel]. ^ sent! !
Andreas
Can you resent as cs attached and I will push it in 3.9 because now I'm worried that I will have crlf..related problems.
Stef
"Change Set: SysNavFix-ar Date: 28 May 2005 Author: Andreas Raab
Fix a few uses of #isMemberOf: Symbol."! 'From Squeak3.8gamma of ''24 November 2004'' [latest update: #6662] on 28 May 2005 at 12:41:14 pm'! "Change Set: SysNavFix-ar Date: 28 May 2005 Author: Andreas Raab
Fix a few uses of #isMemberOf: Symbol."!
!SystemNavigation methodsFor: 'query' stamp: 'ar 5/28/2005 12:32'! allCallsOn: aLiteral "Answer a Collection of all the methods that call on aLiteral even deeply embedded in literal array." "self new browseAllCallsOn: #open:label:." | aCollection special thorough aList byte | aCollection _ OrderedCollection new. special _ Smalltalk hasSpecialSelector: aLiteral ifTrueSetByte: [:b | byte _ b]. thorough _ (aLiteral isSymbol) and: ["Possibly search for symbols imbedded in literal arrays" Preferences thoroughSenders]. Cursor wait showWhile: [self allBehaviorsDo: [:class | aList _ thorough ifTrue: [class
thoroughWhichSelectorsReferTo: aLiteral special: special byte: byte] ifFalse: [class whichSelectorsReferTo: aLiteral special: special byte: byte]. aList do: [:sel | sel == #DoIt ifFalse: [aCollection add: (MethodReference new setStandardClass: class methodSymbol: sel)]]]]. ^ aCollection! !
!SystemNavigation methodsFor: 'query' stamp: 'ar 5/28/2005 12:33'! allSentMessagesWithout: classesAndMessagesPair "Answer the set of selectors which are sent somewhere in the system, computed in the absence of the supplied classes and messages." | sent absentClasses absentSelectors | sent _ IdentitySet new: CompiledMethod instanceCount. absentClasses _ classesAndMessagesPair first. absentSelectors _ classesAndMessagesPair second. self flag: #shouldBeRewrittenUsingSmalltalkAllClassesDo:. "sd 29/04/03" Cursor execute showWhile: [Smalltalk classNames do: [:cName | ((absentClasses includes: cName) ifTrue: [{}] ifFalse: [{Smalltalk at: cName. (Smalltalk at: cName) class}]) do: [:cl | (absentSelectors isEmpty ifTrue: [cl selectors] ifFalse: [cl selectors copyWithoutAll: absentSelectors]) do: [:sel | "Include all sels, but not if sent by self" (cl compiledMethodAt: sel) literals do: [:m | (m isSymbol) ifTrue: ["might be sent" m == sel ifFalse: [sent add: m]]. (m isMemberOf: Array) ifTrue: ["might be performed" m do: [:x | (x isSymbol)
ifTrue: [x == sel
ifFalse: [sent add: x]]]]]]]]. "The following may be sent without being in any literal frame" 1 to: Smalltalk specialSelectorSize do: [:index | sent add: (Smalltalk specialSelectorAt: index)]]. Smalltalk presumedSentMessages do: [:sel | sent add: sel]. ^ sent! !
Maybe you guys should fix your Email clients ;-) The CS was sent as attachment but let's see if compressing it helps.
Cheers, - Andreas
Are you using Thunderbird by any chance? I was sending changesets as attachments, and it was including them inline. If so, let me know, and I'll tell you the fix.
Josh
Andreas Raab wrote:
Maybe you guys should fix your Email clients ;-) The CS was sent as attachment but let's see if compressing it helps.
Cheers,
- Andreas
which client do you use? may be this is the new version of safari because I did not change email client since years (except recently with tiger so it should be it).
On 30 mai 05, at 2:57, Andreas Raab wrote:
Maybe you guys should fix your Email clients ;-) The CS was sent as attachment but let's see if compressing it helps.
Cheers,
- Andreas
<SysNavFix-ar.cs.gz>
Am 30.05.2005 um 02:57 schrieb Andreas Raab:
Maybe you guys should fix your Email clients ;-) The CS was sent as attachment but
Actually, it had "Content-Disposition: inline" rather than "Content- Disposition: attachment". Which causes a proper client to treat that part as inline, unsurprisingly, rather than as attachment.
let's see if compressing it helps.
Cheers,
- Andreas
<SysNavFix-ar.cs.gz>
Yes, helps. Seems like Thunderbird is trying to be "helpful" with plain-text attachments.
- Bert -
This has already been fixed in 3.8-final and this fix has been added to the update stream in update 6668 for 3.9.
Ken
thanks I should have looked at that and may be should remove it from 3.9....
Stef On 30 mai 05, at 18:37, Ken Causey wrote:
This has already been fixed in 3.8-final and this fix has been added to the update stream in update 6668 for 3.9.
Ken
squeak-dev@lists.squeakfoundation.org