On Tue, Jun 29, 2004 at 07:34:00PM -0400, ned@squeakland.org wrote:
[FIX] [3.7b] EnsureEssentialProcesses-nk ( Review needed, please! )
For some reason, Ned's original [FIX] does not seem to have made it to the BFAV list. I have attached a copy of his change set, and here is the message that he originally posted:
-----
This prevents the potentially serious consequences of killing off the WeakArray finalization process. Please review this soon!
from preamble:
"Change Set: EnsureEssentialProcesses-nk Date: 21 June 2004 Author: Ned Konz
It's possible to kill off the WeakArray finalization process, and it never gets restarted.
This can cause many hard-to-diagnose problems.
This change set ensures that the WeakArray finalization process is started at every start up.
It also shuts down the EventSensor's interruptWatcherProcess and eventTicklerProcess at shutdown time (and starts them at startUp time, of course).
"!
This contains a number of changes, but they all look clean and straightforward based on reading the code. I tried killing the WeakArray finalization process, then saving and restarting the image, and everything came back fine. It's late in the release cycle, but this change set may prevent serious and hard-to-debug problems for Squeak users. It is relatively low risk, so I recommend including in 3.7 if possible.
Very minor nit (that should not prevent inclusion in 3.7): InputSensor class>>startUp should not be in this change set. It just adds an unneeded carriage return to the source but otherwise does not change anything.
squeak-dev@lists.squeakfoundation.org
-
David T. Lewis -
lewis＠mail.msen.com