On Sat, Jul 11, 2009 at 11:16:30PM +0100, Keith Hodges wrote:

David T. Lewis wrote:

...

Brent, G?ran,

I have a patch for Chronology on http://bugs.squeak.org/view.php?id=7356 (7356: DateAndTime fromSeconds: 0.5 => walkback, broken since Mantis 4669). If there are no objections, I'll apply the update to the Kernel package on source.squeak.org/trunk.

The patch seems to result in about an 8% slowdown for DateAndTime class>>now, but is presumably still much faster than was the case prior to applying Mantis 4669: [ENH] TimeForSpeed.

I think this change is the right thing to do, but I want to check with you before applying it.

Thanks,

Dave

DateAndTime now is very fast I spent a fair bit of time on it. I can only suppose you havent read the comments.

Keith,

On the contrary, I could not help but notice your optimizations. Most are OK, but please see Mantis 7357: "DateAndTime class>>localOffset broken since Mantis 474" concerning one change that definitely is not.

Dave