Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1058.mcz
==================== Summary ====================
Name: Collections-ct.1058 Author: ct Time: 2 December 2023, 10:54:28.858859 pm UUID: 544526d5-2714-6d44-8bfa-54429ce1ecf8 Ancestors: Collections-ct.1056
When clicking on a TextInspectIt, do not send #inspect to the result as it might be a proxy. This aligns with the implementation of #inspectIt (note to myself: we should also add an explaining comment there).
=============== Diff against Collections-ct.1056 ===============
Item was changed: ----- Method: TextInspectIt>>actOnClickFor:in:at:editor: (in category 'mouse events') ----- actOnClickFor: anObject in: aParagraph at: clickPoint editor: editor "Note: evalString gets evaluated IN THE CONTEXT OF anObject -- meaning that self and all instVars are accessible" Project current addDeferredUIMessage: [ + ToolSet inspect: "do not send #inspect because the result might be a proxy" + (self target + ifNil: [(Compiler evaluate: evalString for: anObject)] + ifNotNil: [:object | object]) ]. - self target - ifNil: [(Compiler evaluate: evalString for: anObject) inspect] - ifNotNil: [:object | object inspect] ]. ^ true !
+1
Am 02.12.2023 22:54:54 schrieb commits@source.squeak.org commits@source.squeak.org:
Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1058.mcz
==================== Summary ====================
Name: Collections-ct.1058 Author: ct Time: 2 December 2023, 10:54:28.858859 pm UUID: 544526d5-2714-6d44-8bfa-54429ce1ecf8 Ancestors: Collections-ct.1056
When clicking on a TextInspectIt, do not send #inspect to the result as it might be a proxy. This aligns with the implementation of #inspectIt (note to myself: we should also add an explaining comment there).
=============== Diff against Collections-ct.1056 ===============
Item was changed: ----- Method: TextInspectIt>>actOnClickFor:in:at:editor: (in category 'mouse events') ----- actOnClickFor: anObject in: aParagraph at: clickPoint editor: editor "Note: evalString gets evaluated IN THE CONTEXT OF anObject -- meaning that self and all instVars are accessible" Project current addDeferredUIMessage: [ + ToolSet inspect: "do not send #inspect because the result might be a proxy" + (self target + ifNil: [(Compiler evaluate: evalString for: anObject)] + ifNotNil: [:object | object]) ]. - self target - ifNil: [(Compiler evaluate: evalString for: anObject) inspect] - ifNotNil: [:object | object inspect] ]. ^ true !
squeak-dev@lists.squeakfoundation.org