Hi Stef!
This might have edges, but maybe starting point.
Alex
So what do you prefer? I like the idea of alexander. Alexander do you want to do it? I can review it that way. Now I'm the middle of an export/import facility for ThreadNavigator so that I stop to lose time for building demoes.
from preamble:
"Change Set: IntegerPrintOnPadding Date: 29 March 2004 Author: Alexander Lazarevic
This changeset improves and changes (a little) the way integers can be printend in different numeratives.
* The meaning of printStringBase has changed. printStringBase: will just print a number in any base and the (new) storeStringBase: will print the number with a leading base.
Examples:
3994 printStringBase: 16 --> 'F9A' 3994 storeStringBase: 16 --> '16rF9A'
* The new method printOn:base:length:padded: (et al) helps formatting output a little.
Examples:
3735928559 printStringBase: 16 length: 20 padded: false --> ' DEADBEEF' 3735928559 printStringBase: 16 length: 20 padded: true --> '000000000000DEADBEEF' 3735928559 storeStringBase: 16 length: 20 padded: true --> '16r000000000DEADBEEF' -3735928559 storeStringBase: 16 length: 20 padded: false --> ' -16rDEADBEEF'
* Some redundant code got removed, some methods got deprecated and some moved.As one result Fractions now can also respond to printOn:base: like Integers and Floats (just to be consistent).
Examples: (15/11) printStringBase: 16 --> '(F/B)' (15/11) storeStringBase: 16 --> '(16rF/16rB)' The following worked before: (16rF/16rB) printString --> '(15/11)'
* For more examples see the IntegerPrintOnPaddingTests changeset and the classes IntegerTests and FrationTests "!
I will have a look at that. :)
On 29 mars 04, at 19:47, Alexander@Lazarevic.de wrote:
Hi Stef!
This might have edges, but maybe starting point.
Alex
So what do you prefer? I like the idea of alexander. Alexander do you want to do it? I can review it that way. Now I'm the middle of an export/import facility for ThreadNavigator so that I stop to lose time for building demoes.
from preamble:
"Change Set: IntegerPrintOnPadding Date: 29 March 2004 Author: Alexander Lazarevic
This changeset improves and changes (a little) the way integers can be printend in different numeratives.
- The meaning of printStringBase has changed. printStringBase: will
just print a number in any base and the (new) storeStringBase: will print the number with a leading base.
Examples:
3994 printStringBase: 16 --> 'F9A' 3994 storeStringBase: 16 --> '16rF9A'
- The new method printOn:base:length:padded: (et al) helps formatting
output a little.
Examples:
3735928559 printStringBase: 16 length: 20 padded: false --> ' DEADBEEF' 3735928559 printStringBase: 16 length: 20 padded: true --> '000000000000DEADBEEF' 3735928559 storeStringBase: 16 length: 20 padded: true --> '16r000000000DEADBEEF' -3735928559 storeStringBase: 16 length: 20 padded: false --> ' -16rDEADBEEF'
- Some redundant code got removed, some methods got deprecated and some
moved.As one result Fractions now can also respond to printOn:base: like Integers and Floats (just to be consistent).
Examples: (15/11) printStringBase: 16 --> '(F/B)' (15/11) storeStringBase: 16 --> '(16rF/16rB)' The following worked before: (16rF/16rB) printString --> '(15/11)'
- For more examples see the IntegerPrintOnPaddingTests changeset and
the classes IntegerTests and FrationTests "! <IntegerPrintOnPadding.cs.gz>
Maybe you would like to wait a little. I found some stupid bugs (what else) and post an update later today.
Aex -----Ursprüngliche Nachricht----- Von: squeak-dev-bounces@lists.squeakfoundation.org [mailto:squeak-dev-bounces@lists.squeakfoundation.org] Im Auftrag von stéphane ducasse Gesendet: Dienstag, 30. März 2004 11:15 An: The general-purpose Squeak developers list Betreff: Re: [ENH] IntegerPrintOnPadding
I will have a look at that. :)
On 29 mars 04, at 19:47, Alexander@Lazarevic.de wrote:
Hi Stef!
This might have edges, but maybe starting point.
Alex
So what do you prefer? I like the idea of alexander. Alexander do you
want to do it? I can review it that way. Now I'm the middle of an export/import facility for ThreadNavigator so that I stop to lose time for building demoes.
from preamble:
"Change Set: IntegerPrintOnPadding Date: 29 March 2004 Author: Alexander Lazarevic
This changeset improves and changes (a little) the way integers can be
printend in different numeratives.
- The meaning of printStringBase has changed. printStringBase: will
just print a number in any base and the (new) storeStringBase: will print the number with a leading base.
Examples:
3994 printStringBase: 16 --> 'F9A' 3994 storeStringBase: 16 --> '16rF9A'
- The new method printOn:base:length:padded: (et al) helps formatting
output a little.
Examples:
3735928559 printStringBase: 16 length: 20 padded: false -->
'
DEADBEEF' 3735928559 printStringBase: 16 length: 20 padded: true --> '000000000000DEADBEEF' 3735928559 storeStringBase: 16 length: 20 padded: true --> '16r000000000DEADBEEF' -3735928559 storeStringBase: 16 length: 20 padded: false -->
'
-16rDEADBEEF'
- Some redundant code got removed, some methods got deprecated and
some moved.As one result Fractions now can also respond to printOn:base: like Integers and Floats (just to be consistent).
Examples: (15/11) printStringBase: 16 --> '(F/B)' (15/11) storeStringBase: 16 --> '(16rF/16rB)' The following worked before: (16rF/16rB) printString --> '(15/11)'
- For more examples see the IntegerPrintOnPaddingTests changeset and
the classes IntegerTests and FrationTests "! <IntegerPrintOnPadding.cs.gz>
Hi alexander
apparently there is a conflict with your changes with 3.8 (unstable)-6203 I could not completely checked because I do not have an image with the complete history of changes.
But could you have a look (Integer>>printOn:base:) is conflicting. Then once I load you changes+colateral one of the test breaks: Test integerByteEncoded. Once you fix that could you submit one single fix containing everything (tests, enh+ colateral changes)
Thanks
Stef
squeak-dev@lists.squeakfoundation.org
-
Alexander Lazarevic -
Alexander＠Lazarevic.de
-
ducasse＠iam.unibe.ch -
stéphane ducasse