[Seaside-dev] Issue 199 in seaside: review WAStandardFiles

[codesite-noreply at google.com]

Issue 199: review WAStandardFiles
http://code.google.com/p/seaside/issues/detail?id=199

New issue report by jfitzell:
After moving WAStandardFiles out of Core and into Environment, I updated
the class comment with the following usage information:

=====================================================
#shortcutJs creates the JavaScript used by WATagBrush>>addShortcut:.
#miscJs creates JavaScript used by:
	- WACheckboxTag>>submitFormNamed:
	- WAFormInputTag>>setFocus
	- WAAbstractTextAreaTag>>setSelectionFrom:to:
	- (the rest of the JS functions appear to be uncalled in the Seaside  
codebase)
#externalAnchorJs sets a target of _blank for any anchor that has a "rel"
attribute of "external". However, the JS function does not appear to be
called anywhere in Seaside.
#windowCss styles the HTML created by WAWindowDecoration.
#kalseyTabCss styles the HTML created by WANavigation
=============================================

Based on my digging, I see the following problems:

+ there seems to be some abandoned JavaScript in #miscJs and  
#externalAnchorJs
+ the other JavaScript *must* be present in order for the canvas methods to
work. Either these methods should be added by the Environment as well or
(probably better) a separate library should be created in the Canvas
package for these.
+ It's possible the minimal structural parts of #windowCss and
#kalseyTablCss should be provided on a FileLibrary in the Component
package. These could actually be added to the HTML root in WANavigation and
WAWindowDecoration so that they are not loaded for every page, even when
not needed. The colouring and other styling should, in my opinion, remain
in the Environment package.


Issue attributes:
	Status: Accepted
	Owner: ----
	Labels: Type-CleanUp Priority-Medium Version-Seaside2.9

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings