[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.18.mcz

[Gerhard Obermann]

Thanks Lukas!

See my answers below!

Gerhard

On Tue, Sep 29, 2009 at 9:51 AM, Lukas Renggli <renggli at gmail.com> wrote:

> I really like the new configuration interface. It seems to be much
> easier to navigate than the old one.
>
> There are a few technical issues I discovered:
>
> - WADispatcherCommand is in the WAPlugin hierarchy but it has a
> completely different naming convention than the rest of the classes. I
> suggest to stick with the existing naming conventions, e.g.
> WA${Action}DipatcherPlugin
>

 Ok, will be changed!


> - There are several senders of #ifNotNil: with an argument. This is
> not portable.
>

 Ok, will be changed!

>
> - Otherwise the code looks extremely clean and works very well.
>
> - The configuration interface of a particular application is no longer
> restful.
>

 I know, If it is really necessary I could add it again!


> - WADispatcherBrowser is using a different infrastructure. Maybe we
> want to merge that?
>

I am not sure about that?


>
> For the design I also have some comments:
>
> - The navigation of the dispatcher tree is not really intuitive to me.
> When clicking on '+' something unexpected happens.
>

Well, I don't like it too.
Maybe I should use a real tree instead of jumping between the dispatchers.
Any other suggestions?


> - The help button is an excellent idea, but instead of toggling it on
> and off it would probably be more convenient just to have a tooltip or
> open the text in a separate popup window. If there is no help, the
> help buttons shouldn't be displayed at all.
>

Ok, disabling the help buttons is easy.
Do you mean open a popup window with e.g. lightbox ?
And a tooltip should work with Ajax?
I dont want to create new dependencies.


> - The buttons on the +/-/up/down are not really intuitive. I suggest
> that we use the same icon-set as we do for the halos.
>

Ok,  I will change that too.


> - In general the design feels a bit boxy (old) to me. If you don't
> mind I'll have a look at the CSS?
>

Of course I dont mind. The CSS is still not optimized anyway.

>
> Lukas
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20090929/8c48d3ab/attachment.htm