Squeak-dev August 2014

squeak-dev@lists.squeakfoundation.org

38 participants
130 discussions

The Trunk: Files-eem.137.mcz
by commits＠source.squeak.org 15 Aug '14

15 Aug '14

Eliot Miranda uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-eem.137.mcz ==================== Summary ==================== Name: Files-eem.137 Author: eem Time: 14 August 2014, 4:09:05.676 pm UUID: 833a2130-ce18-454b-8a67-f82db8a299af Ancestors: Files-eem.136 Fix UnixFileDirectory directoryExists: & fileOrDirectoryExists: for cases such as 'foo/bar' '../foo/bar' etc. =============== Diff against Files-eem.136 =============== Item was changed: ----- Method: UnixFileDirectory>>directoryExists: (in category 'testing') ----- directoryExists: filenameOrPath + "Answers true if the directory exists. Overrides to handle the root directory / + and relative paths." + | fName dir | - "Handles the special case of testing for the root dir: there isn't a - possibility to express the root dir as full pathname like '/foo'." + filenameOrPath = '/' ifTrue: + [^true]. + + DirectoryClass + splitName: filenameOrPath + to: [:filePath :name | + fName := name. + dir := filePath isEmpty + ifTrue: [self] + ifFalse: + [FileDirectory on: (filePath first = $/ + ifTrue: [filePath] + ifFalse: [self fullName, '/', filePath])]]. + + ^dir exists + and: [(dir directoryEntryForName: fName) + ifNotNil: [:e| e isDirectory] + ifNil: [false]]! - ^ filenameOrPath = '/' or: [super directoryExists: filenameOrPath]! Item was changed: ----- Method: UnixFileDirectory>>fileOrDirectoryExists: (in category 'testing') ----- + fileOrDirectoryExists: filenameOrPath + "Answer true if either a file or a directory file of the given name exists. The given name + may be either a full path name or a local name within this directory. Overrides to handle + the root directory / and relative paths." + | fName dir | - fileOrDirectoryExists: filenameOrPath - "Handles the special case of testing for the root dir: there isn't a - possibility to express the root dir as full pathname like '/foo'." + filenameOrPath = '/' ifTrue: + [^true]. + + DirectoryClass + splitName: filenameOrPath + to: [:filePath :name | + fName := name. + dir := filePath isEmpty + ifTrue: [self] + ifFalse: + [FileDirectory on: (filePath first = $/ + ifTrue: [filePath] + ifFalse: [self fullName, '/', filePath])]]. + + ^dir exists + and: [(dir includesKey: fName) or: [fName isEmpty and: [dir entries size > 1]]]! - ^ filenameOrPath = '/' or: [super fileOrDirectoryExists: filenameOrPath]!

1 0

The Inbox: Multilingual-cbc.200.mcz
by commits＠source.squeak.org 14 Aug '14

14 Aug '14

A new version of Multilingual was added to project The Inbox: http://source.squeak.org/inbox/Multilingual-cbc.200.mcz ==================== Summary ==================== Name: Multilingual-cbc.200 Author: cbc Time: 14 August 2014, 1:32:39.389 pm UUID: 82f3111f-cca2-2941-9d64-1a9132c45dae Ancestors: Multilingual-ul.199 Set the variable wantsLineEndConversions to true (in MultiByteFileStream initialize) if the platform line endings are no #cr. This results in default file writing to convert all #cr to whatever the default is for that platform. On platforms where #cr is the default, it does no conversions. =============== Diff against Multilingual-ul.199 =============== Item was changed: ----- Method: MultiByteFileStream>>initialize (in category 'initialize-release') ----- initialize super initialize. + wantsLineEndConversion := (LineEndDefault = #cr) not. - wantsLineEndConversion := false. self initializeConverter!

1 0

MutliByteFileStream and CrLfFileStream (and windows)
by Chris Cunningham 14 Aug '14

14 Aug '14

Hi. so, for a while now, I've been annoyed that the newer Squeak's didn't really handle Windows nicely - at least, not writing to files to handle outside of Squeak. Today I finally dug into the code to find out why. Many moons ago, MultiByteFileStream was created as the replacement fo rCrLfFileStream, and most references to CrLfFileStream went away. Which is even commented in the code(!), as: It also combined the good old CrLfFileStream. CrLfFileStream class>>new now returns an instance of MultiByteFileStream. However, the conversion wasn't complete. In particular: FileDirectory>>newFileNamed: (and related things) just get a new MutliByteFileStream, which doesn't activate any of the CrLf lineEnding magic - it assume there is no line ending conversions wanted at all. In fact, no way to use MutliBytFileStream (except as CrLfFileStream new, from that obsoleted class) really use it (exceptions being FileList and BDFFontReader). This is annoying on a system that doesn't use cr as the default line endings (are there any left?). Further, if you do set it up to detect line endings, as far as I can tell, it never actually does any conversions! Would anyone mind if I finished putting the CrLfFileStream functionality into MultiByteFileStream? and if I did it, would anyone else use it? -cbc

5 9

The Inbox: Files-cbc.137.mcz
by commits＠source.squeak.org 14 Aug '14

14 Aug '14

A new version of Files was added to project The Inbox: http://source.squeak.org/inbox/Files-cbc.137.mcz ==================== Summary ==================== Name: Files-cbc.137 Author: cbc Time: 14 August 2014, 12:58:30.28 pm UUID: d0cae3e8-88fc-db40-a2ee-05ccc2714789 Ancestors: Files-eem.136 Fix FileStream class>>startUp: to call super startUp:. This allows normal startup routines (such as MutliByteFileStream) to determine what kind of line endings the platform uses at startup time (in other words, normal startup activities). =============== Diff against Files-eem.136 =============== Item was changed: ----- Method: FileStream class>>startUp: (in category 'system startup') ----- startUp: resuming resuming ifTrue: [ self voidStdioFiles. [ TheStdioHandles := self stdioHandles ] on: Error do: [:ex| TheStdioHandles isArray ifFalse: [ + TheStdioHandles := Array new: 3 ] ] ]. + "Allow regular #startUp activity as well" + super startUp: resuming! - TheStdioHandles := Array new: 3 ] ] ]!

1 0

Broken link to squeaksource.com on www.squeak.org/Development
by David T. Lewis 14 Aug '14

14 Aug '14

The link on our Squeak site points to the nonexistent http://www.squeaksource.org. It should of course be http://www.squeaksource.com. Can someone with web site access please fix the link? Thanks, Dave

3 4

Re: [squeak-dev] squeak.org back to normal
by Chris Cunnington 14 Aug '14

14 Aug '14

> On Aug 13, 2014, at 10:26 PM, Chris Cunnington <brasspen(a)gmail.com> wrote: > > >> On Aug 13, 2014, at 10:11 PM, David T. Lewis <lewis(a)mail.msen.com> wrote: >> >> On Wed, Aug 13, 2014 at 08:19:37PM -0500, Chris Muller wrote: >>> On Wed, Aug 13, 2014 at 10:20 AM, Chris Cunnington <brasspen(a)gmail.com> >>> wrote: >>> >>>> Jesus, that was an unpleasant tour of my own mind. >>>> >>> >>> LOL!!! >>> >> >> I am not amused. We used to have a good web presence hosted on the excellent >> and well-supported Aida web framework. > >> That site was in need of updates to >> its content and design. >> >> We now have a site that is running on software that seems to be poorly >> understood by most of us, including the one person in the community who >> is willing and able to work on it. >> >> Updating a single broken link requires tortuous mental excursions? Really?!? >> And there is only one person who can do it? Seriously?!? >> >>> >>>> The link to squeaksource.com is updated. >> >> Thank you. You’re welcome. And thank you for saying thank you. You’re rant is heartfelt, but pretty much wrong on every point. I don’t mind though, I think your rant is sort of transitional. Sometimes people complain when things are getting better. I had a history teacher, Mr. Godfrey, who made it clear that people don’t cry for revolution when they’re downtrodden. They do it when they have made a gain they don’t want to lose. You didn’t talk like this in 2012. And that you are talking like this is probably a good thing. You’re famous for being tactful. I don’t think I’ve seen you cut loose like this, so that’s all to the good. Aida was a well supported web framework? Nope. Software always requires support. Ultimately there is no software only people to tend things. Janko had become staggering difficult to deal with. All efforts were made to accommodate him. No dice. Poorly understood software? I think that’s called growth. Altitude is cool. Xtreams is cool. It’s worth taking a few pains to grow and evolve things. Stasis, I’d say, was what helped contributed to some of the problems Squeak is working to recover from. A single broken link equals torturous mental excursions? Not really. I was in an off state of mind making problems for myself. You only know that, because if I make a mistake, it’s my policy to alert that community that something is amiss. I consider that being professional. My personality is my personality, but that is my policy. I’d like to point out also, that with regards to the homepage, I’m changing the nature of silence. With the “well-supported Aida web framework” silence, which everybody could edit, but only one person could code changes into, it meant slow bit rot and everybody could feel it. Silence meant decay. Now things are different. I check the site every day. It’s like a 747 where there are long periods of nothing happening and then brief periods of turbulence, which I make you explicitly aware of. Silence now means ‘All is well’. Only one person who can do it? Is that a problem? Only Janko could code Aida. I recall passing out the code for squeak.org. Tim’s looked it over. Do you like Xtreams? Yes? Well this is part of the process of growing towards incorporating them. I cannot wait to hear what you’ve got to say about the SqueakMap server I’m still working on. Feel free to freak out about it, David. You’ll use it and be glad you did. And if I may so, the UI is shaping up pretty well. I’m shearing all the goggle-eyed-programmer-madness that usually infests user interfaces built by excellent programmers. Keep your chin up. If you keep ranting, I’ll have to quote Tampico’s most famous son at you and say: “There you go again!”. (It worked on Jimmy.) Chris >> Dave >> >> >

2 1

decompiler testing
by Florin Mateoc 14 Aug '14

14 Aug '14

Hi, I made some changes to the decompiler tests to do some more thorough checking after noticing that sometimes the result of decompilation was uncompileable. I had also noticed that class-side methods were skipped, so I added them to the check. Then, since all this lead to errors and many more failures, I also tried to make the check a little more forgiving than simple string comparison for sources, mainly by using abstractSymbolic, which I conjecture also means that the methods are "the same". I then also had to fix abstractSymbolic generation itself. One other avoidable source of differences was the fact that, although Character space is a literal and is used as such in many method sources, Character>>printOn: and Character>>shouldBePrintedAsLiteral claimed that it was not a literal, so they were generating 'Character space' instead of '$ '. And then I also pushed some decompiler fixes. Still, the end result for now is that there are many more failures. Some of them seem related to the methodNode generation, e.g. LargeNegativeIntegerTest>>testReplaceFromToWithStartingAt has in the source | lni20 lni7 | .... (1 to: 5) , (11 to: 20) do: [:e | | digit | digit := lni20 digitAt: e. self assert: e equals: digit]. 6 to: 10 do: [:e | | digit replacementDigit | digit := lni20 digitAt: e. replacementDigit := lni7 digitAt: e - 4. self assert: replacementDigit equals: digit] so the tempName digit is used both in an optimized block and in a non-optimized block. But in the parsed methodNode this gets replaced by | lni20 lni7 digit | .... (1 to: 5) , (11 to: 20) do: [:e | | digit | digit := lni20 digitAt: e. self assert: e equals: digit]. 6 to: 10 do: [ digit := lni20 digitAt: e. replacementDigit := lni7 digitAt: e - 4. self assert: replacementDigit equals: digit] Apparently code generation has no problem with this parsed methodNode, but the decompiled source is not compileable. Unfortunately, the methodNode obtained through decompilation can not re-generate a compiled method either, so there is no way to claim that decompilation succeeded. Othertimes it seems that we peek behind the curtain: parsing ArchiveViewer>>extractAllPossibleInDirectory: gives a MethodNode with a first statement that reads: <0-26> := a NewArrayNode. which seems ignored at code generation, although as source it would be uncompileable, and this is the only difference in the decompiled source and the formatted source. Well, it was bound to get a little worse before it got better :) Florin

1 0

The Inbox: Tests-fm.302.mcz
by commits＠source.squeak.org 14 Aug '14

14 Aug '14

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-fm.302.mcz ==================== Summary ==================== Name: Tests-fm.302 Author: fm Time: 13 August 2014, 10:42:44.901 pm UUID: ce0f51fa-97a9-4c48-be91-c281f9a63c7b Ancestors: Tests-fbs.301 make the decompiler tests also check class-side methods, they were skipped do some more thorough checking for methods: make sure the decompiled code is compileable also check decompiling without temp names, even if temp names are available, since the code paths are slightly different try to be more forgiving than exact string comparison for sources by checking first if the compiled methods are equal, then, if that fails, if the compiled methods' abstractSymbolic strings are equal and only if that also fails do the full source comparison =============== Diff against Tests-fbs.301 =============== Item was changed: ----- Method: DecompilerTests>>checkDecompileMethod: (in category 'utilities') ----- + checkDecompileMethod: meth - checkDecompileMethod: oldMethod + | cls selector tempNames source methNode recompiled dMethNode dReparsed dRecompiled ungeneratedMethNode comparable + successWithTempNames | + cls := meth methodClass. + selector := meth selector. + source := meth getSourceNoDecompile. + source notNil ifTrue: + [methNode := [cls newCompiler + parse: source + in: cls + notifying: nil] + on: SyntaxErrorNotification + do: [:ex| + ex errorMessage = 'Cannot store into' ifTrue: + [ex return: #badStore]. + ex pass]. + "Ignore cannot store into block arg errors; they're not our issue." + methNode == #badStore ifTrue: + [^self]. + methNode nodesDo: [:n | n comment: nil]. + recompiled := [methNode generate: CompiledMethodTrailer defaultMethodTrailer] + on: UndeclaredVariableWarning + do: [:ex| + ex return: #undeclared]. + ungeneratedMethNode := cls newCompiler + parse: source + in: cls + notifying: nil. + ungeneratedMethNode nodesDo: [:n | n comment: nil]]. + meth holdsTempNames + ifTrue: [tempNames := meth tempNamesString] + ifFalse: + [source notNil ifTrue: + ["Do not ignore (or auto-declare as globals) undeclared variables" + recompiled ~~ #undeclared ifTrue: + [tempNames := methNode schematicTempNamesString]]]. + + tempNames notNil ifTrue: + [dMethNode := [(meth decompilerClass new withTempNames: tempNames) + decompile: selector + in: cls + method: meth] + on: UndeclaredVariableWarning + do: [:ex| + ex return: #outOfBoundsInstvar]. + dMethNode ~~ #outOfBoundsInstvar ifTrue: + [[dMethNode properties includesKey: #warning] whileTrue: + [dMethNode properties removeKey: #warning]. + dReparsed := [cls newCompiler + parse: dMethNode decompileString + in: cls + notifying: nil] + on: SyntaxErrorNotification + do: [:ex| + ex return: #unparseableDecompiled]. + dReparsed ~~ #unparseableDecompiled ifTrue: + [dRecompiled := [dReparsed generate: CompiledMethodTrailer defaultMethodTrailer] + on: UndeclaredVariableWarning + do: [:ex| + ex return: #undeclared]]]. + successWithTempNames := dRecompiled ~~ #undeclared and: + [dMethNode ~~ #outOfBoundsInstvar and: + [dReparsed ~~ #unparseableDecompiled and: + [meth = dRecompiled or: + [meth abstractSymbolic = dRecompiled abstractSymbolic or: + [(recompiled notNil and: [recompiled ~~ #undeclared and: [ + recompiled = dRecompiled or: + [recompiled abstractSymbolic = dRecompiled abstractSymbolic]]]) or: + [(methNode notNil and: [methNode decompileString = dMethNode decompileString]) or: + [ungeneratedMethNode notNil and: [ungeneratedMethNode decompileString = dMethNode decompileString]]]]]]]]. + self assert: successWithTempNames + description: cls name asString, ' ', selector asString + resumable: true. + (tempNames = '' or: [successWithTempNames not]) ifTrue: + "we already did the check ''without'' tempNames, or we already failed" + [^self] + ]. + + "Do a check without tempNames even if we did check with tempNames, since it tests different codepaths" + dMethNode := [meth decompilerClass new + decompile: selector + in: cls + method: meth] + on: UndeclaredVariableWarning - | cls selector oldMethodNode methodNode newMethod oldCodeString newCodeString | - cls := oldMethod methodClass. - selector := oldMethod selector. - oldMethodNode := (cls decompilerClass new withTempNames: oldMethod methodNode schematicTempNamesString) - decompile: selector - in: cls - method: oldMethod methodForDecompile. - [oldMethodNode properties includesKey: #warning] whileTrue: - [oldMethodNode properties removeKey: #warning]. - oldCodeString := oldMethodNode decompileString. - methodNode := [cls newCompiler - compile: oldCodeString - in: cls - notifying: nil - ifFail: []] - on: SyntaxErrorNotification do: [:ex| + ex return: #outOfBoundsInstvar]. + dMethNode ~~ #outOfBoundsInstvar ifTrue: + [[dMethNode properties includesKey: #warning] whileTrue: + [dMethNode properties removeKey: #warning]. + dReparsed := [cls newCompiler + parse: dMethNode decompileString + in: cls + notifying: nil] + on: SyntaxErrorNotification + do: [:ex| + ex return: #unparseableDecompiled]. + dReparsed ~~ #unparseableDecompiled ifTrue: + [dRecompiled := [dReparsed generate] + on: UndeclaredVariableWarning + do: [:ex| + ex return: #undeclared]]. + source notNil ifTrue: + [recompiled := [(cls newCompiler + parse: source + in: cls + notifying: nil) + generate] + on: UndeclaredVariableWarning + do: [:ex| + ex return: #undeclared]]]. + comparable := meth copyWithTrailerBytes: CompiledMethodTrailer empty. + self assert: (dRecompiled ~~ #undeclared and: [dMethNode ~~ #outOfBoundsInstvar and: [dReparsed ~~ #unparseableDecompiled and: + [comparable = dRecompiled or: + [comparable abstractSymbolic = dRecompiled abstractSymbolic or: + [(recompiled notNil and: [recompiled ~~ #undeclared and: [ + recompiled = dRecompiled or: + [recompiled abstractSymbolic = dRecompiled abstractSymbolic]]]) or: + "there is no point in doing the source comparison checks if the method has args or temps" + [tempNames isNil and: [source notNil and: + [methNode schematicTempNamesString ~= '' or: + [methNode decompileString = dMethNode decompileString or: + [ungeneratedMethNode decompileString = dMethNode decompileString]]]]]]]]]]) - ex errorMessage = 'Cannot store into' ifTrue: - [ex return: #badStore]. - ex pass]. - "Ignore cannot store into block arg errors; they're not our issue." - methodNode ~~ #badStore ifTrue: - [newMethod := methodNode generate. - newCodeString := ((cls decompilerClass new withTempNames: methodNode schematicTempNamesString) - decompile: selector - in: cls - method: newMethod methodForDecompile) decompileString. - "(StringHolder new textContents: - (TextDiffBuilder buildDisplayPatchFrom: oldCodeString to: newCodeString)) - openLabel: 'Decompilation Differences for ', cls name,'>>',selector" - "(StringHolder new textContents: - (TextDiffBuilder buildDisplayPatchFrom: oldMethod abstractSymbolic to: newMethod abstractSymbolic)) - openLabel: 'Bytecode Differences for ', cls name,'>>',selector" - self assert: oldCodeString = newCodeString description: cls name asString, ' ', selector asString + resumable: true! - resumable: true]! Item was changed: ----- Method: DecompilerTests>>decompileClassesSelect: (in category 'utilities') ----- decompileClassesSelect: aBlock CurrentReadOnlySourceFiles cacheDuring: [ (self classNames select: aBlock) do: [:cn | | cls | cls := Smalltalk globals at: cn. cls selectorsAndMethodsDo: [:selector :meth | (self isFailure: cls sel: selector) ifFalse: + [self checkDecompileMethod: meth methodForDecompile]]. + cls := cls theMetaClass. + cls selectorsAndMethodsDo: + [:selector :meth | + (self isFailure: cls sel: selector) ifFalse: + [self checkDecompileMethod: meth methodForDecompile]]]] + ! - [self checkDecompileMethod: meth]]]]!

1 0

The Inbox: Compiler-fm.288.mcz
by commits＠source.squeak.org 14 Aug '14

14 Aug '14

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-fm.288.mcz ==================== Summary ==================== Name: Compiler-fm.288 Author: fm Time: 13 August 2014, 10:35:42.664 pm UUID: 4138a85c-25c8-3147-b9b9-092e2ef26e45 Ancestors: Compiler-fm.287, Compiler-eem.287 merged with eem.287 Fix literals in decompiled method nodes, they were screwed up - they were not unique, they had wrong indices. Fix temp names generation in decompiled methods when no temp names are provided - no check was made that the names were not clashing with instvars (and they were clashing sometimes) Decompiler>>pushConstant: did not recognize some of the special constants make the decompiler raise a warning if an unknown instvar is encountered - the original would just silently generate a node named 'unkown', but this obviously leads to uncompileable code =============== Diff against Compiler-fm.287 =============== Item was changed: ----- Method: Decompiler>>pushConstant: (in category 'instruction decoding') ----- pushConstant: value | node | node := value == true ifTrue: [constTable at: 2] ifFalse: [value == false ifTrue: [constTable at: 3] ifFalse: [value == nil ifTrue: [constTable at: 4] + ifFalse: [value == -1 ifTrue: [constTable at: 5] + ifFalse: [value == 0 ifTrue: [constTable at: 6] + ifFalse: [value == 1 ifTrue: [constTable at: 7] + ifFalse: [value == 2 ifTrue: [constTable at: 8] + ifFalse: [constructor codeAnyLiteral: value]]]]]]]. - ifFalse: [constructor codeAnyLiteral: value]]]. stack addLast: node! Item was changed: ----- Method: DecompilerConstructor>>codeAnyLitInd: (in category 'constructor') ----- codeAnyLitInd: association ^VariableNode new name: association key key: association + index: ((1 to: literalValues size) detect: [:i | association literalEqual: (literalValues at: i)]) - 1 - index: 0 type: LdLitIndType! Item was changed: ----- Method: DecompilerConstructor>>codeAnyLiteral: (in category 'constructor') ----- codeAnyLiteral: value ^LiteralNode new key: value + index: ((1 to: literalValues size) detect: [:i | value literalEqual: (literalValues at: i)]) - 1 - index: 0 type: LdLitType! Item was changed: ----- Method: DecompilerConstructor>>codeAnySelector: (in category 'constructor') ----- codeAnySelector: selector ^SelectorNode new key: selector + index: ((1 to: literalValues size) + detect: [:i | selector literalEqual: (literalValues at: i)] + ifNone: [^StdSelectors at: selector]) - 1 - index: 0 type: SendType! Item was changed: ----- Method: Encoder>>temps:literals:class: (in category 'initialize-release') ----- temps: tempVars literals: lits class: cl "Initialize this encoder for decompilation." self setCue: (CompilationCue class: cl). supered := false. nTemps := tempVars size. tempVars do: [:node | scopeTable at: node name put: node]. literalStream := WriteStream on: (Array new: lits size). literalStream nextPutAll: lits. sourceRanges := Dictionary new: 32. + globalSourceRanges := OrderedCollection new: 32. + addedSelectorAndMethodClassLiterals := true. + ! - globalSourceRanges := OrderedCollection new: 32.! Item was changed: ----- Method: MethodNode>>generate:using: (in category 'code generation') ----- generate: trailer using: aCompiledMethodClass "The receiver is the root of a parse tree. Answer an instance of aCompiledMethodClass. The argument, trailer, is arbitrary but is typically either the reference to the source code that is stored with every CompiledMethod, or an encoding of the method's temporary names." | primErrNode blkSize nLits literals stack method | self generate: trailer using: aCompiledMethodClass ifQuick: [:m | + encoder noteBlockExtent: (0 to: 2) hasLocals: arguments. + m literalAt: 2 put: encoder associationForClass; - m literalAt: 2 put: encoder associationForClass; properties: properties. + ^m]. - ^m]. primErrNode := self primitiveErrorVariableName ifNotNil: [encoder fixTemp: self primitiveErrorVariableName]. encoder supportsClosureOpcodes ifTrue: [self ensureClosureAnalysisDone. encoder rootNode: self. "this is for BlockNode>>sizeCodeForClosureValue:"]. blkSize := (block sizeCodeForEvaluatedValue: encoder) + (primErrNode ifNil: [0] ifNotNil: [primErrNode index: arguments size + temporaries size; sizeCodeForStore: encoder "The VM relies on storeIntoTemp: (129)"]). method := aCompiledMethodClass newBytes: blkSize trailerBytes: trailer nArgs: arguments size nTemps: (encoder supportsClosureOpcodes ifTrue: [| locals | locals := arguments, temporaries, (primErrNode ifNil: [#()] ifNotNil: [{primErrNode}]). encoder noteBlockExtent: block blockExtent hasLocals: locals. locals size] ifFalse: [encoder maxTemp]) nStack: 0 nLits: (nLits := (literals := encoder allLiterals) size) primitive: primitive. nLits > 255 ifTrue: [^self error: 'Too many literals referenced']. 1 to: nLits do: [:lit | method literalAt: lit put: (literals at: lit)]. encoder streamToMethod: method. stack := ParseStack new init. primErrNode ifNotNil: [primErrNode emitCodeForStore: stack encoder: encoder]. stack position: method numTemps. [block emitCodeForEvaluatedValue: stack encoder: encoder] on: Error "If an attempt is made to write too much code the method will be asked" do: [:ex| "to grow, and the grow attempt will fail in CompiledMethod class>>#new:" ex signalerContext sender method = (CompiledMethod class>>#new:) ifTrue: [^self error: 'Compiler code size discrepancy'] ifFalse: [ex pass]]. stack position ~= (method numTemps + 1) ifTrue: [^self error: 'Compiler stack discrepancy']. encoder methodStreamPosition ~= (method size - trailer size) ifTrue: [^self error: 'Compiler code size discrepancy']. method needsFrameSize: stack size - method numTemps. method properties: properties. ^method!

1 0

The Inbox: Collections-fm.581.mcz
by commits＠source.squeak.org 14 Aug '14

14 Aug '14

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-fm.581.mcz ==================== Summary ==================== Name: Collections-fm.581 Author: fm Time: 13 August 2014, 10:17:12.868 pm UUID: ce67809a-6c9a-584c-a4f3-51b6f069f1f8 Ancestors: Collections-nice.580 Expanded the range of character literals to cover Character space. Character space was being treated as unprintable (as a literal), although it obviously is printable -albeit funny to read- which leads to say #($ ) inspected to print as {Character space}. It also makes the decompiler replace '$ ' by 'Character space' (which changes not just the source but also the (re)compilation result) =============== Diff against Collections-nice.580 =============== Item was changed: ----- Method: Character>>printOn: (in category 'printing') ----- printOn: aStream | name | + self shouldBePrintedAsLiteral - (value > 32 and: [value ~= 127]) ifTrue: [ aStream nextPut: $$; nextPut: self ] ifFalse: [ name := self class constantNameFor: self. name notNil ifTrue: [ aStream nextPutAll: self class name; space; nextPutAll: name ] ifFalse: [ aStream nextPutAll: self class name; nextPutAll: ' value: '; print: value ] ].! Item was changed: ----- Method: Character>>shouldBePrintedAsLiteral (in category 'testing') ----- shouldBePrintedAsLiteral + ^(value between: 32 and: 255) and: [value ~= 127]! - ^(value between: 33 and: 255) and: [value ~= 127]!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
13
Older →