Squeak-dev September 2023

squeak-dev@lists.squeakfoundation.org

27 participants
82 discussions

Tiles error
by Vaidotas Didžbalis 15 Nov '23

15 Nov '23

Hello, Try dragging and dropping the Tile object into the PasteUp (World) and try clicking on it. It disappears when clicked. The same is for Flaps. Version 5.1 is the last one it worked correctly. regards, Vaidotas

2 4

The Trunk: Collections-pre.857.mcz
by commits＠source.squeak.org 09 Nov '23

09 Nov '23

Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.857.mcz ==================== Summary ==================== Name: Collections-pre.857 Author: pre Time: 4 October 2019, 11:04:30.363303 am UUID: 5ef00b65-3884-c445-b276-0cc01f0b10a1 Ancestors: Collections-pre.856 Adds startOfHeader to Character, adds empty abstract implementations of scanFrom:, writeScanOn: to TextAttribute to allow for Texts which include TextAttributes which do not implement serialization to still be serialized, adds a comment to these methods. =============== Diff against Collections-pre.856 =============== Item was added: + ----- Method: Character class>>startOfHeader (in category 'accessing untypeable characters') ----- + startOfHeader + + ^ self value: 1 ! Item was added: + ----- Method: TextAttribute class>>scanFrom: (in category 'fileIn/Out') ----- + scanFrom: strm + "Read the text attribute properties from the stream. When this method has + been called the concrete TextAttribute class has already been selected via + scanCharacter. (see TextAttribute class>>#newFrom:). + For writing the format see TextAttribute>>#writeScanOn:"! Item was added: + ----- Method: TextAttribute>>writeScanOn: (in category 'fileIn/fileOut') ----- + writeScanOn: strm + "Implement this method for a text attribute to define how it it should be written + to a serialized form of a text object. The form should correspond to the source + file format, i.e. use a scan character to denote its subclass. + As TextAttributes are stored in RunArrays, this method is mostly called from RunArray>>#write scan. + For reading the written information see TextAttribute class>>#scanFrom:" + + "Do nothing because of abstract class"!

8 18

On the rejection of Promises due to errors
by Jakob Reschke 09 Nov '23

09 Nov '23

Hi all, Tony has recently fixed our Promise implementation to make it more Promises/A+ compliant, thank you! In the discussion that lead to this fix [1], I already pointed out a difference between exceptions in Smalltalk and in JavaScript, where the Promises/A+ specification originates: Smalltalk exceptions can be resumed, while JavaScript exceptions cannot be resumed and always unroll the stack. The spec [2] says that if the onFulfilled or onRejected callback of a #then call on a promise throws an exception, then the promise returned by the #then call shall be rejected with the exception thrown. Our current Promise implementation matches this for the blocks supplied to #then:, #ifRejected: or #then:ifRejected, by catching all Errors in the blocks and rejecting the promise. But this does not allow a Squeak user to deal with exceptions in a debugger if they are signalled in the callbacks, because they are caught. The same also applies to #future promises. The latter are not really covered by the Promises/A+ spec (because it does not force the resolution or rejection of a promise that is not the result of a #then, and there is no #future in JavaScript), but futures exhibit the same problem of not being resumable in the debugger. Example: promise := 1 future / 0. "<= inspect it => promise is rejected, regardless of your actions in the debugger" Number compile: 'methodWithTypo ^ self asstring'. promise := 1 future methodWithTypo. "<= inspect it => promise is rejected, no chance to fix the misspelling of asString in the debugger and proceed" I could imagine instead letting all exceptions pass during the future or callback block evaluation, and only reject the promise if the evaluation is eventually curtailed due to the exception (be it an Error or not, think of Warning or ModificationForbidden). Example expectations: promise := 1 future / 0. "<= inspect it, press Proceed in the debugger, => promise is resolved" promise := 1 future / 0. "<= inspect it, press Abandon in the debugger, => promise is rejected" promise := 1 future methodWithTypo. "<= inspect it, fix the typo of asString in the debugger, proceed, => promise is resolved with '1'" It could be done by fulfilling a Promise about aBlock similar to this: [ self resolveWith: aBlock value ] on: Exception do: [ :ex | | resumed | resumed := false. [ | result | result := ex outer. resumed := true. ex resume: result] ifCurtailed: [resumed ifFalse: [self future rejectWith: ex]]] (Find the current implementations here: Promise>>#fulfillWith:passErrors: and Promise>>#then:ifRejected:) Note that the #outer send would only trigger handlers in the Project/World loop, or the defaultAction of the exception. The #future in front of #rejectWith: is there to avoid curtailing the unwind block context of ifCurtailed: itself if there are further errors in the rejection callbacks of the promise. The behavior of non-local exits from unwind contexts is undefined in the Smalltalk ANSI standard (just like resume: or return: in a defaultAction, or not sending resume: or return: in an on:do: exception handler at all -- VA Smalltalk interprets that as resume, while Squeak does return, for example). This implementation would also allow all deferred Notifications to pass and not reject the promise. That is because true notifications just resume silently if they are not handled. promise := [Notification signal: 'hi there'. 42] future value. "<= inspect it => Expected: resolved with 42. Actual (today): it is needlessly rejected with Notification 'hi there'" Pressing Proceed in the debugger on officially non-resumable errors (which is possible) would also not reject the promise. But further errors/debuggers are likely to appear, of which one may eventually be used to abort the execution. If the execution finishes after repeatedly pressing Proceed, then fine, resolve the promise with whatever the outcome was. promise := [self error: 'Fatal error'. 42] future value. "<= inspect it, proceed after the so-called fatal error, => Expected: resolved with 42. Actual: there is no debugger, the promise is immediately rejected." promise := [1 / 0 + 3] future value. "<= Cannot be resumed/proceeded because if ZeroDivide is resumed, it will return the exception, and ZeroDivide does not understand +, which cannot be resumed without changing the code. So you'd have to curtail the block execution => Expected: rejected with ZeroDivide or MessageNotUnderstood (depending on when you press Abandon or recompile the DoIt)." promise := [1 / 0 + 3] future value. "... or instead of changing the code or aborting, you could choose 'return entered value' in one of the debuggers, and thereby complete the evaluation of the block => Expected: resolved with whatever you entered to return in the debugger" Promises with whenRejected:/ifRejected: callbacks would no longer swallow errors, and would only be rejected when the user aborts in the debuggers, or if the future execution catches errors by itself and converts them to rejected promises, so the future promise will also be rejected. This could pose a compatibility problem for existing code. promise := (1 future / 0) then: [:result | result + 3] ifRejected: [:reason | #cancelled]. "<= inspect it => Actual: resolved with #cancelled immediately. Expected with my proposed changes: it would first show the ZeroDivide debugger, which you can abandon to resolve with #cancelled, or proceed to a MessageNotUnderstood +. If you abandon the MNU, the promise would be rejected with the MNU, not #cancelled, in accordance with the Promises/A+ spec." How to get back a catch-all->reject-immediately future under these circumstances: promise := [[1 / 0] on: Error do: [:e | e return: (Promise new rejectWith: e)]] future value. promise := [1 future + 1 then: [:n | [n / 0] on: Error do: [:e | e return: (Promise new rejectWith: e)]] future value. We could also introduce a convenience constructor for immediately-rejected promises like in JavaScript: Promise rejected: e. Or a convenience exception handler: [...] rejectOn: Error. Or [...] rejectIfCurtailed (the fullfill/then methods would probably use this as well). What do you think? As Tom Beckmann has already suggested in the last thread on the topic [1], I could also use a custom class of Promise to get just the behavior I want. But then I cannot solve it for the use of #future. At least not without patching something about the compiler in my package preamble... ;-) [1] http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-April/208546.ht… [2] https://promisesaplus.com/ Kind regards, Jakob

6 19

MQTT, PostgreSQL, PlotMorphs, and the WeatherStation project
by Tim Rowledge 29 Oct '23

29 Oct '23

I've been enjoying bringing some packages up to date recently and the WeatherStation project is much improved. I know a few people out there have either used it or been inspired by some of the code ideas, so it seems like a good time to update everyone. First job was to connect up a proper database for storing the data, rather than the "leave it in the image and hope" approach. Since I had been using Levente's PostgresV3 package for work (more on that later) it seemed an obvious thing to use in a less... convoluted... manner as a learning exercise. The current system is using a simple pair of SQL tables, one small table for a list of sensors in use, and a rather bigger table with the sensor readings. I chose to have a 'type' column to discriminate between temperature, humidity, pressure, windspeed, rainfall & wind direction readings, though I imagine there might be good reasons to have separate tables for each despite the fact they would be of the same layout. One column for each reading is a foreign key pointing to the relevant sensor entry and I can't tell you how smug I felt when I got that to work. Those of you that know me well, know I've worked *quite hard* to avoid dealing with databases for about 40 years, so all this was quite an adventure. No. 2 was making sure the MQTT system still works in Squeak 6.1alpha - which it seems to do perfectly well. Which is nice. I hope to update it to the MQTT v5.0 spec sometime. Part 3 was making a subclass of PlotMorph that reads the data from a database, which turns out to be quite effective. Having a query that fetches all the data and timestamps within a range and for a specific sensor & reading type is pretty neat, and the performance is, frankly, amazing. A few tens of thousands of rows can be read and instantiated in 50mS or so *on a Raspberry Pi*. Combine this with having a step time of 60 seconds and the cost of the DB read is negligible. Even fetching 1.5million rows as a test only takes about 12 seconds. So, the PlotMorphs package has been slightly updated to support the DB subclass, the MQTT package is 'certified' as being 6.1 compatible, and the Weather Station package is updated quite a bit. Thing is, there's a *lot* of stuff you could monitor and track with some MQTT and a database and a way to display it. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: SEOB: Set Every Other Bit

9 19

Pi 5 coming soon
by Tim Rowledge 23 Oct '23

23 Oct '23

The Raspberry Pi 5 has been announced and looks likely to be about 3X faster for our purposes. We should probably see around 1.5Gbytecode/sec and 130million sends/sec, for example. It also includes a PCIE connector that will support (with a HAT) M2 type SSDs, so storage should be much faster. I don't know about but I find the idea that we can get tiny computers for ~$80 with 8Gb ram and so on quite mind-boggling. That's about ¼ the cost of my first mouse... tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim dilate - live long

6 17

SqueakMap sha1 checking failure when trying to install new package
by Tim Rowledge 20 Oct '23

20 Oct '23

I've just been making a SqueakMap entry for the WeatherStation (it's been a long time since I last added a package!) and it seems we have some issue with calculating the sha1 checksums. The attempt to load from SM failed and initially looked like something had prevented the server from responding (the error message was a complaint from HttpUrl>>#normalizeContents:) but the Transcript also shewed "(http://map.squeak.org/accountbyid/4340a66e-2296-48b7-9aa8-5305d303752f/file…) failed with this exception: Incorrect SHA checksum of file from original URL Trying server cache instead." Digging in to the debugger tells us that the smpackagerelease has a sha1 of 1044864536495630331656691098454436905765045645695 but the calculated value for the (correctly!) downloaded install file is 401855207151508086727566629532522206807045316227 - so things start to go wrong in SMPackageRelease>>#correctSha1sum: Loading some older packages seems to work. Checking the squeakmap web page shows that the sha1 value is indeed 1044864..... Looking at the stored sha1 values for 'Command Shell' for example tells me that they match what is calculated by #correctSha1sum: for the downloaded install scripts. Checking in a 5.3 image for the sha1 of the downloaded install script agrees with my trunk image. I tried marking the package as 'published' in case I had simply forgotten sometihng; no change IIRC the SM image is ancient and I could imagine we've changed sometihng that would affect this but this is very odd. I'd almost think line-ends but the script was written and saved in Squeak. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Ventis secundis, tene cursum. = Go with the flow.

2 4

The Inbox: Morphic-ct.1718.mcz
by commits＠source.squeak.org 16 Oct '23

16 Oct '23

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1718.mcz ==================== Summary ==================== Name: Morphic-ct.1718 Author: ct Time: 24 January 2021, 5:22:59.352273 pm UUID: f630cc0f-15e2-5642-94f6-6277bb8d7bd4 Ancestors: Morphic-mt.1710 PluggableTextMorph: Fixes #selectAll to keep the current scroll position intact, as it is best practice in most modern editor implementations such as Chromium. I'm very open to refactoring proposals, but otherwise I don't care if you merge this as-is. :-) =============== Diff against Morphic-mt.1710 =============== Item was changed: ----- Method: Editor>>selectAll: (in category 'typing/selecting keys') ----- selectAll: aKeyboardEvent "select everything, invoked by cmd-a. 1/17/96 sw" self insertAndCloseTypeIn. self selectFrom: 1 to: self string size. + morph skipOnceScrollSelectionIntoView. ^ true! Item was changed: ----- Method: PluggableTextMorph>>scrollSelectionIntoView: (in category 'editor access') ----- scrollSelectionIntoView: event "Scroll my text into view. Due to line composition mechanism, we must never use the right of a character block because the lines last character block right value always comes from a global container and is *not* line specific." self rememberSelectionInterval. + (self valueOfProperty: #skipScrollSelectionIntoView ifAbsent: [false]) ifTrue: [ + self removeProperty: #skipScrollSelectionIntoView. + ^ true]. + textMorph editor hasSelection ifFalse: [self scrollToShow: (textMorph editor startBlock withWidth: 1)] ifTrue: [ self scrollToShow: (textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft). self scrollToShow: (textMorph editor pointBlock withWidth: 1). "Ensure text cursor visibility."]. ^ true! Item was added: + ----- Method: TextMorph>>skipOnceScrollSelectionIntoView (in category 'as yet unclassified') ----- + skipOnceScrollSelectionIntoView + + self owner owner setProperty: #skipScrollSelectionIntoView toValue: true.!

4 4

The Trunk: Morphic-mt.2116.mcz
by commits＠source.squeak.org 15 Oct '23

15 Oct '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2116.mcz ==================== Summary ==================== Name: Morphic-mt.2116 Author: mt Time: 26 July 2023, 5:15:38.140063 pm UUID: ccde047a-5845-5345-8989-e1f2c738612c Ancestors: Morphic-mt.2115 In Morphic, redesign how text actions are processed: - underline actions on mouse hover - integrate with Morphic UI loop, i.e., no busy wait for mouse-up - allow for selecting text from within text-action ranges for a better support of the preference "Interactive print-it" Unfortunately, the current text selection is not preserved anymore when just clicking a text action at the moment. Hmmm... =============== Diff against Morphic-mt.2115 =============== Item was removed: - ----- Method: NewParagraph>>clickAt:for:controller: (in category 'editing') ----- - clickAt: clickPoint for: model controller: editor - "Give sensitive text a chance to fire. Display flash: (100@100 extent: 100@100)." - | startBlock action | - action := false. - startBlock := self characterBlockAtPoint: clickPoint. - (text attributesAt: startBlock stringIndex forStyle: textStyle) - do: [:att | | range target box boxes | - att mayActOnClick ifTrue: - [(target := model) ifNil: [target := editor morph]. - range := text rangeOf: att startingAt: startBlock stringIndex. - boxes := self selectionRectsFrom: (self characterBlockForIndex: range first) - to: (self characterBlockForIndex: range last+1). - box := boxes detect: [:each | each containsPoint: clickPoint] ifNone: [nil]. - box ifNotNil: - [ box := (editor transformFrom: nil) invertBoundsRect: box. - editor morph allOwnersDo: [ :m | box := box intersect: (m boundsInWorld) ]. - self flag: #fix. "mt: Make it stateful and with real events." - Utilities awaitMouseUpIn: box - repeating: [] - ifSucceed: [(att actOnClickFor: target in: self at: clickPoint editor: editor) ifTrue: [action := true]]. - Cursor currentCursor == Cursor webLink ifTrue:[Cursor normal show]. - ]]]. - ^ action! Item was changed: ----- Method: TextEditor>>mouseDown: (in category 'events') ----- mouseDown: evt "Either 1) handle text actions in the paragraph, 2) begin a text drag operation, or 3) modify the caret/selection." - | clickPoint b | - oldInterval := self selectionInterval. + (self mouseDownOnTextAction: evt) ifTrue: [^ self]. - clickPoint := evt cursorPoint. - b := paragraph characterBlockAtPoint: clickPoint. - (paragraph clickAt: clickPoint for: model controller: self) ifTrue: [ - self flag: #note. "mt: Do not reset the current text selection for successful text actions. Leave markBlock and pointBlock as is. This behavior matches the one in web browsers when clicking on links." - evt hand releaseKeyboardFocus: morph. - evt hand releaseMouseFocus: morph. - ^ self ]. - (morph dragEnabled and: [self isEventInSelection: evt]) ifTrue: [ evt hand waitForClicksOrDrag: morph event: evt selectors: {#click:. nil. nil. #startDrag:} threshold: HandMorph dragThreshold. morph setProperty: #waitingForTextDrag toValue: true. ^ self]. evt shiftPressed + ifFalse: [ | b | - ifFalse: [ self closeTypeIn. + b := paragraph characterBlockAtPoint: evt position. markBlock := b. pointBlock := b ] ifTrue: [ self closeTypeIn. self mouseMove: evt ]. + + self storeSelectionInParagraph.! - self storeSelectionInParagraph! Item was added: + ----- Method: TextEditor>>mouseDownOnTextAction: (in category 'events') ----- + mouseDownOnTextAction: evt + + self flag: #todo. "mt: Do not reset the current text selection for successful text actions. Leave markBlock and pointBlock as is. This behavior matches the one in web browsers when clicking on links." + ^ false! Item was added: + ----- Method: TextEditor>>mouseEnterOnTextAction: (in category 'events') ----- + mouseEnterOnTextAction: evt + "Manage mouse-hovering effects for text actions." + + | index highlights | + self removeHighlightedTextActions. + + index := (paragraph characterBlockAtPoint: evt position) stringIndex. + (paragraph text attributesAt: index forStyle: paragraph textStyle) + do: [:attr | | highlight range | + attr mayActOnClick ifTrue: [ + highlights ifNil: [ + morph + setProperty: #highlightedTextActions + toValue: (highlights := OrderedCollection new)]. + highlight := TextEmphasis underlined. + range := paragraph text rangeOf: attr startingAt: index. + highlights add: {attr. highlight. range}. + paragraph text + addAttribute: highlight + from: range start to: range stop]]. + + highlights + ifNil: [self updateCursorForEvent: evt] + ifNotNil: [ + morph updateFromParagraph. + evt hand showTemporaryCursor: Cursor webLink].! Item was changed: ----- Method: TextEditor>>mouseUp: (in category 'events') ----- mouseUp: evt "An attempt to break up the old processRedButton code into threee phases" + "0) Click on text actions." + (self mouseUpOnTextAction: evt) ifTrue: [^ self]. + + "1) A 'double-click' will result in selecting the whole word." + (self hasCaret and: [oldInterval = self selectionInterval]) - oldInterval ifNil: [^ self]. "Patched during clickAt: repair" - (self hasCaret - and: [oldInterval = self selectionInterval]) ifTrue: [self selectWord]. + + "2) For the next type-in, configure emphasis. We don't want to do this on + every key-press for performance reasons." self setEmphasisHere. + + "3) Notice selection changes." + (self isDisjointFrom: oldInterval) + ifTrue: [otherInterval := oldInterval]. - (self isDisjointFrom: oldInterval) ifTrue: - [otherInterval := oldInterval]. self storeSelectionInParagraph. + "4) Reset mouse cursor to account for selection changes." self updateCursorForEvent: evt. morph removeProperty: #waitingForTextDrag.! Item was added: + ----- Method: TextEditor>>mouseUpOnTextAction: (in category 'events') ----- + mouseUpOnTextAction: evt + + | target | + "Do not trigger text action if start and stop of the selection are within that action range." + self hasCaret ifFalse: [ + self removeHighlightedTextActions. + ^ false]. + + (morph hasProperty: #highlightedTextActions) ifTrue: [ + target := model ifNil: [morph]. + (morph valueOfProperty: #highlightedTextActions) do: [:ea | + ea first + actOnClickFor: target + in: paragraph + at: evt position + editor: self]. + + self removeHighlightedTextActions. + morph removeProperty: #waitingForTextDrag. + evt hand releaseKeyboardFocus: morph. + evt hand releaseMouseFocus: morph. + ^ true]. + + ^ false! Item was added: + ----- Method: TextEditor>>removeHighlightedTextActions (in category 'events') ----- + removeHighlightedTextActions + + (morph hasProperty: #highlightedTextActions) + ifTrue: [ + (morph valueOfProperty: #highlightedTextActions) do: [:ea | + paragraph text + removeAttribute: ea second + from: ea third start to: ea third stop]. + morph removeProperty: #highlightedTextActions. + morph updateFromParagraph].! Item was removed: - ----- Method: TextMorph>>enterClickableRegion: (in category 'editing') ----- - enterClickableRegion: evt - | index isLink | - evt hand hasSubmorphs ifTrue:[^false]. - paragraph ifNotNil:[ - index := (paragraph characterBlockAtPoint: evt position) stringIndex. - isLink := (paragraph text attributesAt: index forStyle: paragraph textStyle) - anySatisfy:[:attr| attr mayActOnClick]. - isLink ifTrue: [ - evt hand showTemporaryCursor: Cursor webLink. - ^ true]]. - ^ false - ! Item was removed: - ----- Method: TextMorph>>handleMouseMove: (in category 'events-processing') ----- - handleMouseMove: anEvent - "Re-implemented to allow for mouse-up move events" - anEvent wasHandled ifTrue:[^self]. "not interested" - (anEvent hand hasSubmorphs) ifTrue:[^self]. - anEvent wasHandled: true. - self mouseMove: anEvent. - (anEvent anyButtonPressed and:[anEvent hand mouseFocus == self]) ifFalse:[^self]. - (self handlesMouseStillDown: anEvent) ifTrue:[ - "Step at the new location" - self startStepping: #handleMouseStillDown: - at: Time millisecondClockValue - arguments: {anEvent copy resetHandlerFields} - stepTime: 1]. - ! Item was added: + ----- Method: TextMorph>>handlesMouseMove: (in category 'event handling') ----- + handlesMouseMove: anEvent + "Handle all mouse-move events unless something is attached to the hand." + + ^ anEvent hand hasSubmorphs not! Item was added: + ----- Method: TextMorph>>handlesMouseStillDown: (in category 'event handling') ----- + handlesMouseStillDown: anEvent + + (anEvent anyButtonPressed and: [anEvent hand mouseFocus == self]) ifFalse: [^ false]. + ^ super handlesMouseStillDown: anEvent! Item was changed: ----- Method: TextMorph>>mouseLeave: (in category 'event handling') ----- mouseLeave: evt + evt hand showTemporaryCursor: nil. + self editor removeHighlightedTextActions.! - evt hand showTemporaryCursor: nil.! Item was changed: ----- Method: TextMorph>>mouseMove: (in category 'event handling') ----- mouseMove: evt evt redButtonPressed ifFalse: [ + "Avoid expensive #handleInteraction:fromEvent: wrapper here." + self editor mouseEnterOnTextAction: evt. - (self enterClickableRegion: evt) - ifFalse: [self editor updateCursorForEvent: evt]. ^ self]. self handleInteraction: [self editor mouseMove: evt] fromEvent: evt.! Item was changed: ----- Method: TextMorph>>startDrag: (in category 'event handling') ----- startDrag: evt self removeProperty: #waitingForTextDrag. + self editor removeHighlightedTextActions. [evt hand grabMorph: (TransferMorph withPassenger: self selection from: self)] ensure: [evt hand releaseMouseFocus: self].!

3 4

The Trunk: Kernel-eem.1523.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1523.mcz ==================== Summary ==================== Name: Kernel-eem.1523 Author: eem Time: 22 August 2023, 12:55:52.155147 pm UUID: a4d61d2f-cc75-4b8c-9615-cef127a2b3fd Ancestors: Kernel-ct.1522 Rename Process's threadId inst var to threadAffinity while we still can. This is in response to Leon Matthes correctly pointing out that the variable is an affinity, not an id. Thanks! =============== Diff against Kernel-ct.1522 =============== Item was changed: Link subclass: #Process + instanceVariableNames: 'suspendedContext priority myList threadAffinity effectiveProcess name island env' - instanceVariableNames: 'suspendedContext priority myList threadId effectiveProcess name island env' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Processes'! + !Process commentStamp: 'eem 8/22/2023 12:52' prior: 0! - !Process commentStamp: 'eem 10/9/2021 15:34' prior: 0! I represent an independent path of control in the system. This path of control may be stopped (by sending the message suspend) in such a way that it can later be restarted (by sending the message resume). When any one of several paths of control can be advanced, the single instance of ProcessorScheduler named Processor determines which one will actually be advanced, partly using the value of priority. Instance Variables: N.B. The first four are used by the virtual machine. They must be defined, and defined in this order, suspendedContext: <Context|nil> priority: <Integer> myList: <LinkedList|nil> + threadAffinity: <Integer|nil> - threadId: <Integer|nil> effectiveProcess: <Process|nil> name: <String|nil> island: <Island|nil> env: <Dictionary|nil> effectiveProcess - if not nil effectiveProcess is a process I am running on behalf of. Used by the execution simulation machinery (used by the debugger) to ensure that Processor activeProcess et al answer the expected result when simulating execution (e.g. when debugging). See evaluate:onBehalfOf: and senders. env - if not nil this is a Dictionary providing process-specific variables. See e.g. environmentAt:*, DynamicVariable and ProcessSpecificVariable. island - used by Tweak and Croquet to partition the image into multiple address spaces myList - if nil, I am either suspended or the active process. If not nil it is either some condition variable (Semaphore, Mutex) that I am blocked waiting on, or it is the LinkedList in ProcessorScheduler quiescentProcesses that holds the processes for my priority that are not the current active process but still runnable. name - if not nil this is my name, used for information, see e.g. the names of processes displayed in the ProcessBrowser priority - my scheduling priority, which corresponds to the index in ProcessorScheduler quiescentProcesses that holds the LinkedList of processes at this priority. If I am running but quiescent, changing priority involves changing priority and myList. suspendedContext - if nil, then I am either the active process or I have been terminated. If not nil it is the Context at the hot end of my stack + threadAffinity + - if not nil then it is an integer value set by the VM that controls how I interact with underlying native threads. If positive, the threadAffinity is that of some native thread known to the VM, and the VM will ensure that when I am running, I will be running on that native thread. If negative, the absolute value of threadAffinity is that of some thread known to the VM, and the VM will ensure that when I am running, I will *not* be running on that native thread. Set by the VM. Not to be set manually. Meaningful only on threaded VMs (which do not mean VMs with a threaded heartbeat). It is required to be my fourth instance variable. See SmalltalkImage >> #processHasThreadAffinityInstVar: for further information.! - threadId - - if not nil then it is an integer value set by the VM that controls how I interact with underlying native threads. If positive, the threadId is that of some native thread known to the VM, and the VM will ensure that when I am running, I will be running on that native thread. If negative, the absolute value of threadId is that of some thread known to the VM, and the VM will ensure that when I am running, I will *not* be running on that native thread. Set by the VM. Not to be set manually. Meaningful only on threaded VMs (which do not mean VMs with a threaded heartbeat). It is required to be my fourth instance variable. See SmalltalkImage >> #processHasThreadIdInstVar: for further information.! Item was changed: + (PackageInfo named: 'Kernel') postscript: '"Make sure the 4th inst var of Process is threadAffinity, not threadId" - (PackageInfo named: 'Kernel') postscript: '"Turn on the enableIPv6 preference for trunk." + (Process instVarNames at: 4) = ''threadId'' ifTrue: + [Process instVarNames at: 4 put: ''threadAffinity'' copy]'! - NetNameResolver enableIPv6: true. - '!

2 1

Review Request: Clean up background styling of PluggableTextMorphPlus
by christoph.thiede＠student.hpi.uni-potsdam.de 12 Oct '23

12 Oct '23

Context: At the moment, PluggableTextMorph runs the text styler immediately (#updateStyleNow) or in the background (#updateStyle) depending on the trigger: * Immediately: The user accepts a text; we change the text programmatically (e.g., when opening a browser or selecting a different method). However, the text must be shorter than 4096 characters for this. * In the background: All other triggers: the user types or cancels; we change the style programmatically (e.g., after a preference change); accepting or changing a text longer than 4095 characters.* So, this strategy tries to balance maintaining a responsive UI for longer texts (especially during typing) and minimizing flickering. Problem: There are situations where we still have too much flickering. You may have a chance to observe this when you cancel (cmd+l) in a method in a browser. (It is best observable when keeping cmd+l pressed for a while.) Much more critical than for code editing, however, this effect is in other applications that employ frequent text updates and use a faster styler than Shout. Proposal: Give either the styler control over when to run in the background. Move the hard-coded 4096 to this check from PluggableTextMorphPlus>>#setText:. Introduce a second test hook with a smaller threshold for running all style requests (#updateStyle) immediately. E.g.: PluggableTextMorphPlus>>setText: aText self okToStyle ifFalse:[^super setText: aText]. super setText: (styler format: aText asText). (styler willItBeVeryExpensiveToStyle: aText) ifFalse: [self updateStyleNow] ifTrue: [self updateStyle] PluggableTextMorphPlus>>updateStyle | text | self okToStyle ifFalse: [^ self]. text := textMorph contents. (styler willItBeExpensiveToStyle: text) ifFalse: [self updateStyleNow] ifTrue: [styler styleInBackgroundProcess: textMorph contents]. Open to better names, of course. We can add a #respondsTo: check before sending these messages to the styler to keep the required styler interface minimal and fall back to "expensive, but not very expensive". In Shout, we could implement these selector like this: SHTextStylerST80>>willItBeExpensiveToStyle: aText ^ aText size >= 4096 SHTextStylerST80>>willItBeVeryExpensiveToStyle: aText ^ aText size >= 16384 Optionally, either PluggableTextMorphPlus or the styler could also check Smalltalk isLowerPerformance. Workaround: Until now, I will manually invoke the styler from the getText selector in my application in addition to registering it to the text morph to avoid any flickering. Looking forward to your opinions! Best, Christoph *NB: If we edit huge text, there can still be a larger delay but this comes from text layouting not from styling. --- Sent from Squeak Inbox Talk

3 6

← Newer
1
2
3
4
5
6
7
8
9
Older →