Squeak-dev September 2023

squeak-dev@lists.squeakfoundation.org

27 participants
82 discussions

The Trunk: ToolsTests-mt.123.mcz
by commits＠source.squeak.org 13 Sep '23

13 Sep '23

Marcel Taeumel uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-mt.123.mcz ==================== Summary ==================== Name: ToolsTests-mt.123 Author: mt Time: 13 September 2023, 4:02:00.258147 pm UUID: 4cc4562c-0922-cf40-a784-654b46732b17 Ancestors: ToolsTests-mt.122 Adds a test that documents whether the TreeBrowser still hides classes due to strange class-category layout. =============== Diff against ToolsTests-mt.122 =============== Item was added: + ----- Method: TreeBrowserTest>>testClassListNoMissing (in category 'tests - system category list') ----- + testClassListNoMissing + "Check whether the tree of classes is complete for each class category. This means that also classes with missing intermediate parents are there somehow." + + | allIssues | + allIssues := OrderedCollection new. + + browser systemOrganizer categories do: [:cat | + | expected found toCheck | + browser selectSystemCategory: cat. + expected := browser allClassesInCategory. + found := #() asOrderedCollection. + toCheck := browser classRoots asOrderedCollection. + [toCheck notEmpty] whileTrue: [ + found addLast: toCheck removeFirst. + toCheck addAll: (browser classChildren: found last)]. + (expected copyWithoutAll: found) ifNotEmpty: [:issues | + allIssues add: cat -> issues]]. + + self + assert: allIssues isEmpty + description: ('{1} classes missing in {2} categories.' + format: {allIssues inject: 0 into: [:sum :issue | sum + issue value size]. allIssues size}).!

2 1

source.squeak.org (partially) down?
by christoph.thiede＠student.hpi.uni-potsdam.de 12 Sep '23

12 Sep '23

Hi all, I cannot update any of my images today and we also saw this in our CI: Squeak Trunk: ConnectionClosed Squeak 6.0: Error: ZipArchive cannot find EOCD position in a stream When trying to save a new inbox version: NetworkError: Could not access https://source.squeak.org/inbox (status code 500) However, browsing versions in the web interface seems to work. Could any of the server admins maybe take a look at this? :-) Best, Christoph --- Sent from Squeak Inbox Talk

2 2

Any recommendations on a Postgresql data type to store "pairs" such that I can run Dictionary newFromPairs: "type needed here"
by gettimothy 07 Sep '23

07 Sep '23

https://www.postgresql.org/docs/current/datatype.html I am leaning "Array types" but figure I should ask first. cordially

3 10

WebServer and CORS
by Eric Gade 07 Sep '23

07 Sep '23

Hello all! I would like to start using Squeak as the glue that connects different applications on my machine(s). I've decided that the best way to do this without having to deal with too much Unixy mambo-jumbo is to build little web apis and have the servers run in Squeak. That said, I've run into a problem: WebServer currently has no way to configure itself for CORS <https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS>. Usually this wouldn't be an issue -- I could add the appropriate headers on my Response objects as needed manually. However, WebServer opaquely handles certain requests itself, specifically the OPTIONS request, which is used as a preflight fetch. A clear example of a use case is the one I'm building now: a bookmarklet <https://en.wikipedia.org/wiki/Bookmarklet> that saves some info about the current page I'm on, and then sends that info to my little Squeak mini web server locally on the same machine. This ends up being a cross-origin request, however, and as it stands WebServer cannot deal with it (throws a CORS error on the client side). So, two questions. First: has anyone already dealt with this and am I missing some simple technique/package? Second: if not, what do we think is the best move here? Should we create something like a CrossOriginPolicy object, have a default instance present on WebServer that does what it currently does (which is nothing), but make it configurable? If the latter seems reasonable then I can take it on. Thanks! -- Eric

3 2

The Inbox: System-ct.1424.mcz
by commits＠source.squeak.org 06 Sep '23

06 Sep '23

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1424.mcz ==================== Summary ==================== Name: System-ct.1424 Author: ct Time: 29 August 2023, 7:41:28.345934 pm UUID: 9af4e7bf-a99d-8a43-9de5-87c8ed70ce94 Ancestors: System-mt.1423 Revises RealEstateAgent logic for placing collapsed windows to deal with more windows than fit in one column by arranging them next to each other. Speeds up the logic for high-DPI displays by honoring the current scaleFactor. =============== Diff against System-mt.1423 =============== Item was changed: ----- Method: RealEstateAgent class>>assignCollapseFrameFor: (in category 'utilities') ----- assignCollapseFrameFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid verticalBorderDistance horizontalBorderDistance otherFrames viewBox collapsedFrame extent top column countInColumn topLeft newFrame row rowLeft rowFrame | + grid := 8 px. + verticalBorderDistance := 8 px. + horizontalBorderDistance := 8 px. + - | grid otherFrames topLeft viewBox collapsedFrame extent newFrame verticalBorderDistance top | - grid := 8. - verticalBorderDistance := 8. aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | w ~= aSSView]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view ~= aSSView ifTrue: [aController view collapsedFrame]] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. collapsedFrame := aSSView collapsedFrame. extent := collapsedFrame notNil ifTrue: [collapsedFrame extent] ifFalse: [aSSView isMorph + ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2 px)] + ifFalse: [(aSSView labelText extent x + 70 px) @ aSSView labelHeight - ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2)] - ifFalse: [(aSSView labelText extent x + 70) @ aSSView labelHeight min: aSSView labelDisplayBox extent]]. collapsedFrame notNil ifTrue: [(otherFrames anySatisfy: [:f | collapsedFrame intersects: f]) ifFalse: ["non overlapping" ^ collapsedFrame]]. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [top := viewBox top + verticalBorderDistance. + countInColumn := 0. + [topLeft := viewBox left @ top. + newFrame := topLeft extent: extent. + newFrame bottom <= (viewBox height - verticalBorderDistance)] + whileTrue: + [row := otherFrames select: [:w | newFrame intersects: w]. + column > 0 ifFalse: [rowFrame := newFrame] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + horizontalBorderDistance. + rowFrame := newFrame translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | rowFrame intersects: w]]. + (viewBox containsRect: rowFrame) ifTrue: [ + row ifEmpty: ["no overlap" + ^ rowFrame]. + countInColumn := countInColumn + 1]. + top := top + grid]. + column := column + 1]. + + "If all else fails... (really too many wins here)" - top := viewBox top + verticalBorderDistance. - [topLeft := viewBox left @ top. - newFrame := topLeft extent: extent. - newFrame bottom <= (viewBox height - verticalBorderDistance)] - whileTrue: - [(otherFrames anySatisfy: [:w | newFrame intersects: w]) - ifFalse: ["no overlap" - ^ newFrame]. - top := top + grid]. - "If all else fails... (really to many wins here)" aSSView isMorph ifTrue:[ Project current showWorldMainDockingBar ifTrue:[^ (0 @ Project current world mainDockingBars first height) extent: extent]]. ^ 0 @ 0 extent: extent! Item was changed: ----- Method: RealEstateAgent class>>assignCollapsePointFor: (in category 'utilities') ----- assignCollapsePointFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid otherFrames viewBox column countInColumn y row topLeft currentRowLeft rowLeft | + grid := 24 px. "should be mult of 8, since manual move is gridded by 8 px" - | grid otherFrames y free topLeft viewBox | - grid := 24. "should be mult of 8, since manual move is gridded by 8" aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | true]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [y := viewBox top. + countInColumn := 0. + [(y := y + grid) <= (viewBox height - grid)] + whileTrue: + [topLeft := viewBox left@y. + row := otherFrames select: [:w | topLeft = w topLeft]. + column > 0 ifFalse: [currentRowLeft := topLeft] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + grid. + currentRowLeft := topLeft translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | currentRowLeft = w topLeft]]. + (viewBox containsPoint: topLeft) ifTrue: [ + row ifEmpty: ["no overlap" + ^ topLeft]. + countInColumn := countInColumn + 1]]. + column := column + 1]. + - y := viewBox top. - [(y := y + grid) <= (viewBox height - grid)] - whileTrue: - [topLeft := viewBox left@y. - free := true. - otherFrames do: [:w | free := free & (topLeft ~= w topLeft)]. - free ifTrue: [^ topLeft]]. "If all else fails..." ^ 0 @ 0!

6 14

Your suggestions for uuseful Preferences?
by rabbit 05 Sep '23

05 Sep '23

I am trying to figure my proper environment Preferences. I'm grateful for your suggestions. Here's my list so far... > enable <Update from server at startup> > enable <Open Tools Attached to Mouse Cursor> > enable <Use colorful windows> > enable <Click on label to edit> > enable <Extra debugger buttons> > disable <Use Soft Drop Shadow> -- ••• rabbit ❤️‍🔥🐰

7 20

Legal framework. Contracts and the resolution of it's events.
by rabbit 05 Sep '23

05 Sep '23

I feel the need to say, from a mention of the 3 Laws, that we need a legal framework of contracts that would handle exceptional events / default and have a process of judicial reasoning about these laws, instituted by those wit the capability to introduce laws. Ad-hoc Community Elections. I think that would be cool Squeakin' . .. ... .... ..... '..^,^ -- h ••• rabbit ❤️‍🔥🐰

1 4

no mail received since 8/8 was Re: Squeak-dev Digest, Vol 248, Issue 20
by Hal Eden 04 Sep '23

04 Sep '23

is something wrong with the list or is it just me (nothing in “junk” either) thanks, hal

4 3

[BUG] Tree browsers lose unaccepted methods in several cases
by christoph.thiede＠student.hpi.uni-potsdam.de 04 Sep '23

04 Sep '23

Hi Marcel, hi all, here is a couple of simple way to reproduce: Browse a class in the tree browser. Select message category A. Start typing a method but do not yet accept it ('myMethod ^self greatNewInvention...') Turn on mouseOverForKeyboardFocus, hover the message category list, press arrow up/down to select a different category. Oh no! Your new unaccepted method is lost! Other triggers of this bug include removing the currently selected message category in a tree browser from a second browser (or adding the first category which will remoev the default 'no messages' category). Quickfix to recover your changes (maybe): String allSubInstances select: [:ea | ea includesSubstring: 'greatNewInvention']. Insights from my examination: There is a missing #okToChange in Browser>>selectMessageCategoryNamed:. The bug does not occur when selecting a different category through the mouse because PluggableListMorph and SimpleHierarchicalListMorph send #okToChange to the model before handling mouse click events. PluggableListMorph also sends this for keyboard events (such as keyDown), but SimpleHierarchicalListMorph doesn't. When the selection is triggered programmatically, e.g., through #updateCodePaneIfNeeded, neither sends #okToChange first. So, how can we fix this? I think we should be sure to send #okToChange prior to all selection changes in browsers. We should not rely on the widget to send this in any case, flag existing uses with a comment, and maybe ultimately remove these sends. Sending #okToChange from the widgets seems to be bad style to me - it is hard to discover, existing triggers such as user interactions vs programmatic events are disputable, and importantly, this style introduces global state. I think I have also seen more than one model in the past where I was spammed with irrelevant 'Is it OK to cancel those changes?' messages because the actual interaction would not actually cancel any changes, but I unfortunately can't find these right now. Best, Christoph --- Sent from Squeak Inbox Talk

2 5

The Inbox: Morphic-ct.2127.mcz
by commits＠source.squeak.org 01 Sep '23

01 Sep '23

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2127.mcz ==================== Summary ==================== Name: Morphic-ct.2127 Author: ct Time: 1 September 2023, 1:29:26.309701 pm UUID: 7a729ae8-2ad8-0c45-b98d-aa25605321f8 Ancestors: Morphic-ct.2125 Revises #insertTextReplacement proposal for PluggableTextMorph by avoiding changes to #replaceSelectionWith: and #zapSelectionWith: in TextEditor. Fixes selection restoration for edge cases such as inverse selection. Indeed an ancestor of Morphic-ct.2125. =============== Diff against Morphic-ct.2125 =============== Item was changed: ----- Method: TextEditor>>insertText:from:to:invisibly: (in category 'accessing') ----- insertText: newText from: start to: stop invisibly: invisibly + | priorSelection replacement replacementStart replacementStop newSelection inverseSelection | + priorSelection := self markIndex to: self pointIndex - 1. - | priorSelection | - priorSelection := self selectionInterval. self selectInvisiblyFrom: start to: stop. + replacementStart := self startIndex. + replacementStop := self stopIndex. + self openTypeIn. + replacement := newText isText + ifTrue: [newText] + ifFalse: [Text string: newText attributes: + ((paragraph text attributesAt: (self pointIndex - 1 max: 1) forStyle: paragraph textStyle) + select: [:att | att mayBeExtended])]. + self text replaceFrom: replacementStart to: replacementStop - 1 with: replacement. + paragraph + recomposeFrom: replacementStart + to: replacementStart + replacement size - 1 + delta: replacement size - (replacementStop - replacementStart). + self markIndex: replacementStart pointIndex: replacementStart + replacement size. + otherInterval := self selectionInterval. + invisibly ifFalse: [ + self userHasEdited]. + self closeTypeIn. - self restoreEmphasisHereAfter: [ - self setEmphasisHere. - self replaceSelectionWith: newText invisibly: invisibly]. invisibly ifFalse: [^ self]. "Restore previous selection. Also update it if behind insertion." + inverseSelection := priorSelection start > (priorSelection stop + 1). + inverseSelection ifTrue: [priorSelection := priorSelection stop to: priorSelection start]. + newSelection := priorSelection. + priorSelection start >= replacementStop ifTrue: [ + newSelection := (newSelection start + replacement size - (stop - start) - 1) to: newSelection stop]. + ""(priorSelection start between: start and: stop) ifTrue: [ + newSelection := (newSelection start clampHigh: (replacementStart + replacement size - 1)) to: newSelection stop]."" + priorSelection stop >= replacementStop ifTrue: [ + newSelection := newSelection start to: newSelection stop + replacement size - (stop - start) - 1]. + (priorSelection stop between: start and: stop) ifTrue: [ + newSelection := newSelection start to: (newSelection stop clampLow: newSelection start - 1 high: replacementStart + replacement size)]. + inverseSelection ifTrue: [newSelection := newSelection stop to: newSelection start]. + self selectInvisiblyFrom: newSelection start to: newSelection stop.! - priorSelection start >= start ifTrue: [ - priorSelection := priorSelection start + newText size - (stop - start) - 1 to: priorSelection stop]. - priorSelection stop >= start ifTrue: [ - priorSelection := priorSelection start to: priorSelection stop + newText size - (stop - start) - 1]. - self selectInvisiblyFrom: priorSelection start to: priorSelection stop.! Item was changed: ----- Method: TextEditor>>replaceSelectionWith: (in category 'undo') ----- replaceSelectionWith: aText + "Remember the selection text in UndoSelection. + Deselect, and replace the selection text by aText. + Remember the resulting selectionInterval in UndoInterval and PriorInterval. + Set up undo to use UndoReplace." + self openTypeIn. + self zapSelectionWith: aText. + self closeTypeIn.! - ^ self replaceSelectionWith: aText invisibly: false! Item was removed: - ----- Method: TextEditor>>replaceSelectionWith:invisibly: (in category 'undo') ----- - replaceSelectionWith: aText invisibly: invisibly - "Remember the selection text in UndoSelection. - Deselect, and replace the selection text by aText. - Remember the resulting selectionInterval in UndoInterval and PriorInterval. - Set up undo to use UndoReplace. - Unless invisibly, notify the text morph about the change." - - self openTypeIn. - self zapSelectionWith: aText invisibly: invisibly. - self closeTypeIn.! Item was removed: - ----- Method: TextEditor>>restoreEmphasisHereAfter: (in category 'accessing') ----- - restoreEmphasisHereAfter: aBlock - - | priorEmphasis | - priorEmphasis := emphasisHere. - ^ aBlock ensure: [ - emphasisHere := priorEmphasis]! Item was changed: ----- Method: TextEditor>>zapSelectionWith: (in category 'mvc compatibility') ----- zapSelectionWith: replacement + | start stop rep | + morph readOnly ifTrue: [^ self]. + start := self startIndex. + stop := self stopIndex. + (replacement isEmpty and: [stop > start]) ifTrue: [ + "If deleting, then set emphasisHere from 1st character of the deletion" + emphasisHere := (self text attributesAt: start) select: [:att | att mayBeExtended]]. + (start = stop and: [ replacement isEmpty ]) ifFalse: [ + morph plainTextOnly + ifTrue: [ + "We support TextAlignment but nothing else. Rely on emphasisHere." + rep := Text string: replacement asString attributes: emphasisHere ] + ifFalse: [ replacement isText + ifTrue: [ rep := replacement] + ifFalse: [ rep := Text string: replacement attributes: emphasisHere ] ]. + + self text replaceFrom: start to: stop - 1 with: rep. + paragraph + recomposeFrom: start + to: start + rep size - 1 + delta: rep size - (stop-start). + self markIndex: start pointIndex: start + rep size. + otherInterval := self selectionInterval]. + + self userHasEdited " -- note text now dirty"! - ^ self zapSelectionWith: replacement invisibly: false! Item was removed: - ----- Method: TextEditor>>zapSelectionWith:invisibly: (in category 'mvc compatibility') ----- - zapSelectionWith: replacement invisibly: invisibly - - | start stop rep | - morph readOnly ifTrue: [^ self]. - start := self startIndex. - stop := self stopIndex. - (replacement isEmpty and: [stop > start]) ifTrue: [ - "If deleting, then set emphasisHere from 1st character of the deletion" - emphasisHere := (self text attributesAt: start) select: [:att | att mayBeExtended]]. - (start = stop and: [ replacement isEmpty ]) ifFalse: [ - morph plainTextOnly - ifTrue: [ - "We support TextAlignment but nothing else. Rely on emphasisHere." - rep := Text string: replacement asString attributes: emphasisHere ] - ifFalse: [ replacement isText - ifTrue: [ rep := replacement] - ifFalse: [ rep := Text string: replacement attributes: emphasisHere ] ]. - - self text replaceFrom: start to: stop - 1 with: rep. - paragraph - recomposeFrom: start - to: start + rep size - 1 - delta: rep size - (stop-start). - self markIndex: start pointIndex: start + rep size. - otherInterval := self selectionInterval]. - - invisibly ifFalse: [ - self userHasEdited " -- note text now dirty"].!

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →