Squeak-dev September 2023

squeak-dev@lists.squeakfoundation.org

27 participants
82 discussions

The Trunk: Collections-mt.1051.mcz
by commits＠source.squeak.org 28 Sep '23

28 Sep '23

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.1051.mcz ==================== Summary ==================== Name: Collections-mt.1051 Author: mt Time: 28 September 2023, 10:21:07.80602 am UUID: a30c75a0-0736-404f-8a8d-88518a1de17c Ancestors: Collections-mt.1050 Always #rehash hashed collections that come from disk. Note that #compact does not always work depending on the current size of the incoming objects. Thanks to Jakob (jr) for the hint! =============== Diff against Collections-mt.1050 =============== Item was changed: ----- Method: HashedCollection>>comeFullyUpOnReload: (in category 'objects from disk') ----- comeFullyUpOnReload: smartRefStream "Symbols have new hashes in this image." + self rehash.! - self compact!

1 0

Squeak 6.0: Morphic-mt.2031.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

Marcel Taeumel uploaded a new version of Morphic to project Squeak 6.0: http://source.squeak.org/squeak60/Morphic-mt.2031.mcz ==================== Summary ==================== Name: Morphic-mt.2031 Author: mt Time: 27 September 2023, 3:15:03.200726 pm UUID: db5985ca-f59e-7545-9711-16235a5fcb93 Ancestors: Morphic-mt.2030 Fixes another visual regression from Morphic-mt.2028 concerning #shrinkWrap in ScrollPane. (If this gets worse, I will revert to mt.2027. This is a really bad example of how and when to backport fixes. Sigh.) =============== Diff against Morphic-mt.2030 =============== Item was changed: ----- Method: ScrollPane>>submorphBoundsForShrinkWrap (in category 'layout') ----- submorphBoundsForShrinkWrap + "Like #newScrollerBounds but uses the current scroller bounds, which were already shrink-wrapped at this point. See #hResizing: and #vResizing:." + + | inner bottomOffset leftOffset rightOffset | + (retractableScrollBar or: [self vIsScrollbarShowing not]) + ifTrue: [leftOffset := rightOffset := 0] + ifFalse: [ + scrollBarOnLeft + ifTrue: [ + leftOffset := self scrollBarThickness - self borderWidth. + rightOffset := 0.] + ifFalse: [ + leftOffset := 0. + rightOffset := self scrollBarThickness - self borderWidth]]. + + (retractableScrollBar or: [self hIsScrollbarShowing not]) + ifTrue: [bottomOffset := 0] + ifFalse: [bottomOffset := self scrollBarThickness - self borderWidth]. - "No need to consider scrollbars because those are placed outside the #innerBounds like a border. See #resizeScroller." + inner := scroller bounds. + ^ (inner left - leftOffset) @ (inner top "+ topOffset") + corner: (inner right + rightOffset) @ (inner bottom + bottomOffset)! - ^ scroller bounds!

1 0

The Trunk: Morphic-mt.2132.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2132.mcz ==================== Summary ==================== Name: Morphic-mt.2132 Author: mt Time: 27 September 2023, 3:12:01.629684 pm UUID: bc398f97-66d1-2348-bf3a-f6595dafc0a2 Ancestors: Morphic-mt.2131 Fixes TableLayoutTests and thus #shrinkWrap configuration for ScrollPane, which got broken in Morphic-mt.2129. Sigh. =============== Diff against Morphic-mt.2131 =============== Item was changed: ----- Method: ScrollPane>>submorphBoundsForShrinkWrap (in category 'layout') ----- submorphBoundsForShrinkWrap + "Like #newScrollerBounds but uses the current scroller bounds, which were already shrink-wrapped at this point. See #hResizing: and #vResizing:." + + | inner bottomOffset leftOffset rightOffset | + (retractableScrollBar or: [self vIsScrollbarShowing not]) + ifTrue: [leftOffset := rightOffset := 0] + ifFalse: [ + scrollBarOnLeft + ifTrue: [ + leftOffset := self scrollBarThickness - self borderWidth. + rightOffset := 0.] + ifFalse: [ + leftOffset := 0. + rightOffset := self scrollBarThickness - self borderWidth]]. + + (retractableScrollBar or: [self hIsScrollbarShowing not]) + ifTrue: [bottomOffset := 0] + ifFalse: [bottomOffset := self scrollBarThickness - self borderWidth]. - "No need to consider scrollbars because those are placed outside the #innerBounds like a border. See #resizeScroller." + inner := scroller bounds. + ^ (inner left - leftOffset) @ (inner top "+ topOffset") + corner: (inner right + rightOffset) @ (inner bottom + bottomOffset)! - ^ scroller bounds!

1 0

The Trunk: MorphicTests-mt.93.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.93.mcz ==================== Summary ==================== Name: MorphicTests-mt.93 Author: mt Time: 27 September 2023, 2:35:14.135019 pm UUID: b14d13ff-88ec-ac42-86df-0867be7d6a91 Ancestors: MorphicTests-mt.92 Adds a failing test to document an existing layout bug. =============== Diff against MorphicTests-mt.92 =============== Item was added: + ----- Method: TableLayoutTest>>testHeightForWidthContents (in category 'tests - example layouts') ----- + testHeightForWidthContents + "Combine a height-for-width widget with a too small container. Two-pass layout should be enough." + + | vertical list spacer | + container := Morph new + color: Color blue; + changeTableLayout; + layoutInset: 5; + vResizing: #rigid; + hResizing: #rigid; + yourself. + vertical := Morph new + color: Color green; + changeTableLayout; + layoutInset: 5; + listDirection: #topToBottom; + vResizing: #spaceFill; + hResizing: #spaceFill; + yourself. + list := Morph new + color: Color red; + changeTableLayout; + listDirection: #leftToRight; + wrapDirection: #topToBottom; + layoutInset: 5; cellGap: 5; + hResizing: #spaceFill; + vResizing: #shrinkWrap; + addAllMorphs: (5 timesCollect: [Morph new extent: 20@20; color: Color yellow]); + yourself. + spacer := Morph new + color: Color white; + hResizing: #rigid; + vResizing: #spaceFill; + yourself. + + list width: 30. "1 column, 5 rows" + spacer width: 5. + + vertical extent: 999@999. + container extent: 100@100. "3 columns, 2 rows" + + vertical addMorphBack: list. + vertical addMorphBack: spacer. + container addMorph: vertical. + + self ensureLayout: container. + "container layoutChanged." "--- WORKAROUND" + self assert: 100@100 equals: container fullBounds extent.!

1 0

The Trunk: System-tpr.1411.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

tim Rowledge uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tpr.1411.mcz ==================== Summary ==================== Name: System-tpr.1411 Author: tpr Time: 8 April 2023, 12:40:44.232921 pm UUID: ce793344-787e-4e47-9823-c49991f1e8c2 Ancestors: System-eem.1410 Bring in Stephane Rollandin's fix for SmartRefStream loading; it solves the .morph loading issue raised by https://lists.squeakfoundation.org/archives/list/squeak-dev@lists.squeakfou… =============== Diff against System-eem.1410 =============== Item was changed: ----- Method: SmartRefStream>>next (in category 'read write') ----- next "Really write three objects: (version, class structure, object). But only when called from the outside. " | version ss object | ^ topCall == nil ifTrue: [topCall := #marked. version := super next. version class == SmallInteger ifFalse: [^ version]. "version number, else just a regular object, not in our format, " self checkCrLf. ss := super next. ss class == Array ifFalse: [^ ss]. "just a regular object" (ss at: 1) = 'class structure' ifFalse: [^ ss]. + structures := (ss at: 2) rehash. - structures := ss at: 2. superclasses := (ss size > 3 and: [(ss at: 3) = 'superclasses']) + ifTrue: [(ss at: 4) rehash] "class name -> superclass name" - ifTrue: [ss at: 4] "class name -> superclass name" ifFalse: [Dictionary new]. (self verifyStructure = 'conversion method needed') ifTrue: [^ nil]. + object := super next rehash. "all the action here" - object := super next. "all the action here" self restoreClassInstVars. "for UniClasses. version 4" topCall := nil. "reset it" object] ifFalse: + [super next rehash] - [super next] !

2 1

SmartRefStream tweak?
by Stéphane Rollandin 27 Sep '23

27 Sep '23

I am in the process of porting my code to 6.0, and I found that I had to tweak the #next method in SmartRefStream in order to load properly some morphs that were serialized from a 5.1 image. I had to add four calls to #rehash (see attached code). Would that be something useful to have, or am I (again) missing something? Stef

3 3

The Trunk: System-mt.1424.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1424.mcz ==================== Summary ==================== Name: System-mt.1424 Author: mt Time: 27 September 2023, 1:39:22.934019 pm UUID: d830c5c0-4931-a546-b8ee-fd493ca7b1d3 Ancestors: System-mt.1423 Complement Kernel-mt.1526 =============== Diff against System-mt.1423 =============== Item was changed: ----- Method: SmartRefStream>>next (in category 'read write') ----- next "Really write three objects: (version, class structure, object). But only when called from the outside. " | version ss object | ^ topCall == nil ifTrue: [topCall := #marked. version := super next. version class == SmallInteger ifFalse: [^ version]. "version number, else just a regular object, not in our format, " self checkCrLf. ss := super next. ss class == Array ifFalse: [^ ss]. "just a regular object" (ss at: 1) = 'class structure' ifFalse: [^ ss]. structures := (ss at: 2) rehash. superclasses := (ss size > 3 and: [(ss at: 3) = 'superclasses']) ifTrue: [(ss at: 4) rehash] "class name -> superclass name" ifFalse: [Dictionary new]. (self verifyStructure = 'conversion method needed') ifTrue: [^ nil]. + object := super next. "all the action here" - object := super next rehash. "all the action here" self restoreClassInstVars. "for UniClasses. version 4" topCall := nil. "reset it" object] ifFalse: + [super next] - [super next rehash] !

1 0

The Trunk: Kernel-mt.1526.mcz
by commits＠source.squeak.org 27 Sep '23

27 Sep '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1526.mcz ==================== Summary ==================== Name: Kernel-mt.1526 Author: mt Time: 27 September 2023, 1:38:59.304019 pm UUID: 9bbe749b-d516-e146-8af2-4f5f7962faa0 Ancestors: Kernel-mt.1525 Fixes regression in DataStream from System-tpr.1411 to make SqueakMap catalog update again. Send #rehash only when the object is complete, not in the middle of a #next call that might be incomplete for cyclic dependencies. =============== Diff against Kernel-mt.1525 =============== Item was changed: ----- Method: Object>>readDataFrom:size: (in category 'objects from disk') ----- readDataFrom: aDataStream size: varsOnDisk "Fill in the fields of self based on the contents of aDataStream. Return self. Read in the instance-variables written by Object>>storeDataOn:. NOTE: This method must send beginReference: before reading any objects from aDataStream that might reference it. Allow aDataStream to have fewer inst vars. See SmartRefStream." | cntInstVars cntIndexedVars | cntInstVars := self class instSize. self class isVariable ifTrue: [cntIndexedVars := varsOnDisk - cntInstVars. cntIndexedVars < 0 ifTrue: [ self error: 'Class has changed too much. Define a convertxxx method']] ifFalse: [cntIndexedVars := 0. cntInstVars := varsOnDisk]. "OK if fewer than now" aDataStream beginReference: self. 1 to: cntInstVars do: [:i | self instVarAt: i put: aDataStream next]. 1 to: cntIndexedVars do: [:i | self basicAt: i put: aDataStream next]. "Total number read MUST be equal to varsOnDisk!!" + self rehash. ^ self "If we ever return something other than self, fix calls on (super readDataFrom: aDataStream size: anInteger)"!

1 0

UK Smalltalk User Group meeting - ESUG 2023 Recap - 27 September 2023
by Giovanni Corriga 26 Sep '23

26 Sep '23

The ESUG conference returned once more this past summer when Smalltalkers from all over the world met in Lyon, France for a week of presentations, and socials ( https://esug.github.io/2023-Conference/conf2023.html ). For this month's meeting, we'll have an open discussion about what was presented at the conference. If you've been there, join us to tell us what you liked, and why. If you could not go, join us and discover what went down in Lyon! This will be an online meeting from home. If you'd like to join us, please sign up in advance on the meeting's Meetup page ( https://www.meetup.com/ukstug/events/295958488/ ) to receive the meeting details. Don’t forget to bring your laptop and drinks!

1 0

Do HelpTopics support Lists and Tables?
by gettimothy 26 Sep '23

26 Sep '23

thx in advance.

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →