Squeak-dev March 2010

squeak-dev@lists.squeakfoundation.org

158 participants
767 discussions

Windows menu
by Torsten Bergmann 03 Mar '10

03 Mar '10

I like the browser in pharo-dev here - not spawning new windows but spawning new panes inside the same window and using the scrollbar to return back to any point in browsing history. Or the sender/implementor/messages browser in Smalltalk/MT (see [1] for a screenshot) Bye Torsten [1] http://lists.gforge.inria.fr/pipermail/pharo-project/2009-November/015521.h… -- Sicherer, schneller und einfacher. Die aktuellen Internet-Browser - jetzt kostenlos herunterladen! http://portal.gmx.net/de/go/chbrowser

3 3

[cuis] Kernel Development Model
by keith 03 Mar '10

03 Mar '10

Hi Juan et al, I have been working on a kernel development process for Cuis2, for a while now, and it is ready for a tour around the block. Those working on tricky refactorings within squeak/pharo may also find this useful. The instructions on http://smalltalkers.pbworks.com/Getting-Started lead you through manually setting up a development area for squeak pharo and cuis. The purpose of loading these tools into squeak and pharo is to enable slices of code within either squeak or pharo to be marked up and periodically exported for import into cuis. I have also developed an extensible bash script framework, called "grow" (opposite of shrink) which we can extend to provide meta- facilities, such as automatically setting things up, checking for vm updates, handling multiple repositories etc (much like "repo" for android) Grow, allows you to define a configuration, of VM, Starting Image, and Bootstrap code, per working directory. #> cd squeak-wk #> grow configure squeak --here #> cd ../cuis-wk #> grow configure cuis --here This will find the configured VM and open the latest version of the base-dev.N.image. #> grow launch base-dev --latest Please do let me know if anything in the instructions is not clear. There is a fair bit of documentation knocking around on the wiki. regards Keith

1 2

[Q] Why we can't use - before a number?
by Edgar J. De Cleene 03 Mar '10

03 Mar '10

To my previous question mixedWith: aSoundBuffer | start end | start := - 32767 . ³you can¹t use it , Squeak is not FORTRAN , you should use 0 aninteger instead ³ end := 32767. ^ ((aSoundBuffer size >= self size) ifTrue: [aSoundBuffer] ifFalse: [self]) collectWithIndex: [:s :i | (s + (self at: i ifAbsent: [0])) forceIn: (Interval from: start to: end)]. Edgar

2 1

(EventSensor>>#eventTickler) decompile bug
by Nicolas Cellier 03 Mar '10

03 Mar '10

I think I narrowed a bit the offending code: eventTickler2 "For debugging Decompiler" [| delta | [delta := true] yourself. delta ] whileTrue. (EventSensor>>#eventTickler2) decompile eventTickler2 [[_r1 := true] yourself. _r1] whileTrue 17 <8A 01> push: (Array new: 1) 19 <68> popIntoTemp: 0 20 <10> pushTemp: 0 21 <8F 10 00 05> closureNumCopied: 1 numArgs: 0 bytes 25 to 29 25 <71> pushConstant: true 26 <8D 00 00> storeIntoTemp: 0 inVectorAt: 0 29 <7D> blockReturn 30 <D0> send: yourself 31 <87> pop 32 <8C 00 00> pushTemp: 0 inVectorAt: 0 35 <99> jumpFalse: 38 36 <A3 EB> jumpTo: 17 38 <78> returnSelf All is well untill Decompiler tries to interpret instruction 35 <99> jumpFalse: 38 We enter Decompiler>>#jump:if: ...snip... "if jump goes back, then it's a loop" thenJump < elseStart ifTrue: ["Must be a while loop... thenJump will jump to the beginning of the while expr. In the case of while's with a block in the condition, the while expr should include more than just the last expression: find all the statements needed by re-decompiling." stack := saveStack. pc := thenJump. blockBody := self statementsTo: elsePc. We go back and reinterpret what we already interpreted... But this time we already get a RemoteTempVectorNode in the tempVars... And we are gonna create a RemoteTempVectorNode on a RemoteTempVectorNode next time we interpret the closure byte code 17 <8A 01> push: (Array new: 1)... So the second pass will decompile _r1 instead of t1... I don't feel like correcting the monster Decompiler>>#jump:if: Maybe I will just set a tweak in RemoteTempVectorNode creation... Nicolas

2 2

[Q] How should be this method ?
by Edgar J. De Cleene 03 Mar '10

03 Mar '10

!SoundBuffer methodsFor: '*MuO-Music' stamp: 'spfa 11/18/2009 18:16'! mixedWith: aSoundBuffer ^ ((aSoundBuffer size >= self size) ifTrue: [aSoundBuffer] ifFalse: [self]) collectWithIndex: [:s :i | (s + (self at: i ifAbsent: [0])) forceIn: (- 32767 to: 32767)]. Importing in trunk 9553 the compiler say is wrong mixedWith: aSoundBuffer ^ ((aSoundBuffer size >= self size) ifTrue: [aSoundBuffer] ifFalse: [self]) collectWithIndex: [:s :i | (s + (self at: i ifAbsent: [0])) forceIn: ( expression expected ->- 32767 to: 32767)]. Could explain ? Edgar

3 6

The Trunk: Tools-laza.199.mcz
by commits＠source.squeak.org 03 Mar '10

03 Mar '10

Alexander Lazarević uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-laza.199.mcz ==================== Summary ==================== Name: Tools-laza.199 Author: laza Time: 3 March 2010, 11:19:55.355 am UUID: 42375dd4-166f-0747-afc4-c2e1644a916d Ancestors: Tools-ar.198 Fixes ChangeSorter find =============== Diff against Tools-ar.198 =============== Item was changed: ----- Method: ChangeSorter>>findCngSet (in category 'changeSet menu') ----- findCngSet "Search for a changeSet by name. Pop up a menu of all changeSets whose name contains the string entered by the user. If only one matches, then the pop-up menu is bypassed" | index pattern candidates nameList | self okToChange ifFalse: [^ self]. pattern := UIManager default request: 'ChangeSet name or fragment?'. pattern isEmpty ifTrue: [^ self]. nameList := self changeSetList asSet. candidates := ChangeSet allChangeSets select: [:c | (nameList includes: c name) and: [c name includesSubstring: pattern caseSensitive: false]]. candidates size = 0 ifTrue: [^ Beeper beep]. candidates size = 1 ifTrue: [^ self showChangeSet: candidates first]. + index := UIManager default chooseFrom: (candidates collect: [:each | each name]). - index := (UIManager default chooseFrom: - (candidates collect: [:each | each name]) asStringWithCr). index = 0 ifFalse: [self showChangeSet: (candidates at: index)]. !

1 0

[ENH] ArchiveViewer extracting file
by Edgar J. De Cleene 03 Mar '10

03 Mar '10

Current code shows a file selection window , but you have the file member name, right ?. And the odd is you wish put into your working dir. My proposal is change for the attached , which works in FunSqueak. Any is against? Speak now or .... Tomorrow is to late. Edgar

1 0

[BUG] ProportionalSplitterMorph dnu panelRect
by Edgar J. De Cleene 03 Mar '10

03 Mar '10

Steps for walkback: Open a .sar via drag and drop. Select open as .zip , now yo have the ArchiveViewer window. On the lower pane, try to change for having a bigger selection as yo got by default. Edgar

1 0

PackageDependencyTest
by Andreas Raab 03 Mar '10

03 Mar '10

Folks - I just posted a set of tests for various package dependencies. I'm hoping that this will serve two purposes: 1) Inspire people to pick up and remove unneeded dependencies. For example, if look at testCollections you'll find MorphicExtras listed among the Collection dependencies. If you remove the dependency from the test the test will fail and you can look at the dependencies to see that there's a dependency on BookMorph. A bit of digging leads you to TextSqkPageLink in Collections-Text and you can now look at how to rewrite this to avoid the dependency. (we should keep better track of the dependencies; keeping original method references would be good) Effectively this is sort of a test driven untanglement approach - you pick a particular dependency, make the test fail, track it down, remove it, make the test pass. 2) Keep track of the existing dependencies and ensure they don't get any worse than they are today. These tests can hopefully raise awareness to these issues by documenting the dependencies and failing if new ones get added carelessly. Cheers, - Andreas

6 11

The Trunk: Tools-ar.198.mcz
by commits＠source.squeak.org 03 Mar '10

03 Mar '10

Andreas Raab uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ar.198.mcz ==================== Summary ==================== Name: Tools-ar.198 Author: ar Time: 2 March 2010, 10:21:17.225 pm UUID: d25c2788-0ae0-be4e-a0f2-466c93f7b78d Ancestors: Tools-laza.197 A quick adoption of DependencyBrowser. =============== Diff against Tools-laza.197 =============== Item was added: + ----- Method: DependencyBrowser classSide>>open (in category 'opening') ----- + open + "DependencyBrowser open" + ^ToolBuilder open: self! Item was added: + ----- Method: DependencyBrowser>>classDepsIndex: (in category 'class deps') ----- + classDepsIndex: idx + "Class dependency selection" + classDepsIndex := idx. + self classListIndex: 0. + self changed: #classDepsIndex. + self changed: #classList. + ! Item was added: + ----- Method: DependencyBrowser>>classDepsIndex (in category 'class deps') ----- + classDepsIndex + "Class dependency selection" + ^classDepsIndex ifNil:[0]! Item was added: + ----- Method: DependencyBrowser>>aboutToStyle: (in category 'contents') ----- + aboutToStyle: aStyler + "This is a notification that aStyler is about to re-style its text. + Set the classOrMetaClass in aStyler, so that identifiers + will be resolved correctly. + Answer true to allow styling to proceed, or false to veto the styling" + | selectedClass | + selectedClass := self classListSelection ifNil:[^false]. + aStyler classOrMetaClass: ((self messageListSelection == #Definition) ifFalse:[Smalltalk classNamed: selectedClass]). + ^true! Item was added: + ----- Method: DependencyBrowser>>classListIndex: (in category 'class list') ----- + classListIndex: idx + "Class list selection" + classListIndex := idx. + self messageListIndex: 0. + self changed: #classListIndex. + self changed: #messageList. + ! Item was added: + ----- Method: DependencyBrowser>>classDepsSelection (in category 'class deps') ----- + classDepsSelection + "Class dependency selection" + ^(self classDepsIndex between: 1 and: self classDeps size) + ifTrue:[self classDeps at: self classDepsIndex].! Item was added: + ----- Method: DependencyBrowser>>classList (in category 'class list') ----- + classList + "List of classes that refer to dependencies" + ^((classDeps at: self classDepsSelection ifAbsent:[#()]) + collect:[:mref| mref classSymbol] as: Set) asArray sort! Item was added: + ----- Method: DependencyBrowser>>classListSelection (in category 'class list') ----- + classListSelection + "Class list selection" + ^(self classListIndex between: 1 and: self classList size) + ifTrue:[self classList at: self classListIndex]! Item was added: + ----- Method: DependencyBrowser>>selectedMessage (in category 'contents') ----- + selectedMessage + "Source code for currently selected message" + | className methodName mref | + className := self classListSelection. + methodName := self messageListSelection. + mref := (classDeps at: self classDepsSelection ifAbsent:[#()]) + detect:[:mr| mr classSymbol = className + and:[mr methodSymbol = methodName]] + ifNone:[nil]. + mref ifNil:[^'']. + mref methodSymbol == #Definition ifTrue:[^mref actualClass definition]. + ^mref sourceCode! Item was added: + ----- Method: DependencyBrowser>>packageDepsSelection (in category 'package deps') ----- + packageDepsSelection + "Current package dependencies selection" + ^(self packageDepsIndex between: 1 and: self packageDeps size) + ifTrue:[self packageDeps at: self packageDepsIndex]! Item was added: + ----- Method: DependencyBrowser>>packageDepsIndex: (in category 'package deps') ----- + packageDepsIndex: aNumber + "Current package dependencies selection" + packageDepsIndex := aNumber. + self classDepsIndex: 0. + self changed: #packageDepsIndex. + self changed: #classDeps. + ! Item was added: + CodeHolder subclass: #DependencyBrowser + instanceVariableNames: 'packageList packageDeps classDeps classList messageList packageListIndex packageDepsIndex classDepsIndex classListIndex messageListIndex' + classVariableNames: '' + poolDictionaries: '' + category: 'Tools-Browser'! + + !DependencyBrowser commentStamp: 'ar 3/2/2010 22:19' prior: 0! + A simple dependency browser showing five panes: + [1]: Packages: The list of available packages in the system. + [2]: Package Dependencies: The dependent packages of the currently selected package. + [3]: Class Dependencies: The classes causing the dependencies. + [4]: Class List: The classes introducing the dependencies. + [5]: Messages: The messages introducing the dependencies. + ! Item was added: + ----- Method: DependencyBrowser>>messageListIndex: (in category 'message list') ----- + messageListIndex: idx + "Message list selection" + messageListIndex := idx. + self changed: #messageListIndex. + self changed: #contents.! Item was added: + ----- Method: DependencyBrowser>>packageListSelection (in category 'package list') ----- + packageListSelection + "Current package list selection" + ^(self packageListIndex between: 1 and: self packageList size) + ifTrue:[self packageList at: self packageListIndex]! Item was added: + ----- Method: DependencyBrowser>>packageDepsIndex (in category 'package deps') ----- + packageDepsIndex + "Current package dependencies selection" + ^packageDepsIndex ifNil:[0]! Item was added: + ----- Method: DependencyBrowser>>packageList (in category 'package list') ----- + packageList + "The base list of packages in the system" + ^packageList ifNil:[packageList := (MCWorkingCopy allManagers collect:[:each| each packageName]) sort]! Item was added: + ----- Method: DependencyBrowser>>computePackageDependencies: (in category 'package deps') ----- + computePackageDependencies: pkgName + "Compute the dependencies for the given package" + | pi | + classDeps := Dictionary new. + packageDeps := Dictionary new. + pkgName ifNil:[^self]. + pi := PackageOrganizer default packageNamed: pkgName ifAbsent:[^self]. "unloaded" + pi classes do:[:pkgClass| + (classDeps at: (pkgClass superclass ifNil:[ProtoObject]) name + ifAbsentPut:[OrderedCollection new]) add: + (MethodReference class: pkgClass selector: #Definition)]. + + pi methods do:[:mref| | cm | + cm := mref compiledMethod. + 1 to: cm numLiterals do:[:i| | lit | + ((lit := cm literalAt: i) isVariableBinding and:[lit value isBehavior]) ifTrue:[ + (classDeps at: lit value name ifAbsentPut:[OrderedCollection new]) + add: (MethodReference class: cm methodClass selector: cm selector)]]]. + + classDeps keys do:[:className| | aClass pkg | + aClass := Smalltalk classNamed: className. + pkg := PackageOrganizer default packageOfClass: aClass ifNone:[nil]. + pkg ifNil:[ + Transcript cr; show: 'WARNING: No package for ', className. + (classDeps removeKey: className) do:[:each| Transcript crtab; show: each]. + ] ifNotNil:[ + (packageDeps at: pkg name ifAbsentPut:[OrderedCollection new]) add: className. + ]. + ]. + + (packageDeps removeKey: pkgName ifAbsent:[#()]) do:[:each| + classDeps removeKey: each ifAbsent:[]. + ].! Item was added: + ----- Method: DependencyBrowser>>classDeps (in category 'class deps') ----- + classDeps + "Class dependencies for the currently selected package" + ^(packageDeps at: self packageDepsSelection ifAbsent:[#()]) sort! Item was added: + ----- Method: DependencyBrowser>>messageListIndex (in category 'message list') ----- + messageListIndex + "Message list selection" + ^messageListIndex ifNil:[0]! Item was added: + ----- Method: DependencyBrowser>>buildPackageListWith: (in category 'toolbuilder') ----- + buildPackageListWith: builder + | listSpec | + listSpec := builder pluggableListSpec new. + listSpec + model: self; + list: #packageList; + getIndex: #packageListIndex; + setIndex: #packageListIndex:; + menu: #packageListMenu:; + keyPress: #packageListKey:from:. + ^listSpec + ! Item was added: + ----- Method: DependencyBrowser>>messageListSelection (in category 'message list') ----- + messageListSelection + "Message list selection" + ^(self messageListIndex between: 1 and: self messageList size) + ifTrue:[self messageList at: self messageListIndex]! Item was added: + ----- Method: DependencyBrowser>>buildClassListWith: (in category 'toolbuilder') ----- + buildClassListWith: builder + | listSpec | + listSpec := builder pluggableListSpec new. + listSpec + model: self; + list: #classList; + getIndex: #classListIndex; + setIndex: #classListIndex:; + menu: #classListMenu:; + keyPress: #classListKey:from:. + ^listSpec + ! Item was added: + ----- Method: DependencyBrowser>>buildWith: (in category 'toolbuilder') ----- + buildWith: builder + "Create the ui for the browser" + | windowSpec max | + max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. + windowSpec := self buildWindowWith: builder specs: { + (0@0 corner: 0.2@max) -> [self buildPackageListWith: builder]. + (0.2@0 corner: 0.4@max) -> [self buildPackageDepsWith: builder]. + (0.4@0 corner: 0.6@max) -> [self buildClassDepsWith: builder]. + (0.6@0 corner: 0.8@max) -> [self buildClassListWith: builder]. + (0.8@0 corner: 1.0@max) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + ^builder build: windowSpec! Item was added: + ----- Method: DependencyBrowser>>packageListIndex (in category 'package list') ----- + packageListIndex + "Current package list selection" + ^packageListIndex ifNil:[0]! Item was added: + ----- Method: DependencyBrowser>>packageDeps (in category 'package deps') ----- + packageDeps + "Package dependencies for the currently selected package" + packageDeps ifNil:[ + packageDeps := Dictionary new. + Cursor wait showWhile:[ + self computePackageDependencies: self packageListSelection. + ]. + ]. + ^packageDeps keys sort! Item was added: + ----- Method: DependencyBrowser>>buildPackageDepsWith: (in category 'toolbuilder') ----- + buildPackageDepsWith: builder + | listSpec | + listSpec := builder pluggableListSpec new. + listSpec + model: self; + list: #packageDeps; + getIndex: #packageDepsIndex; + setIndex: #packageDepsIndex:; + menu: #packageDepsMenu:; + keyPress: #packageDepsKey:from:. + ^listSpec + ! Item was added: + ----- Method: DependencyBrowser>>classListIndex (in category 'class list') ----- + classListIndex + "Class list selection" + ^classListIndex ifNil:[0]! Item was added: + ----- Method: DependencyBrowser>>packageListIndex: (in category 'package list') ----- + packageListIndex: aNumber + "Current package list selection" + packageListIndex := aNumber. + self changed: #packageListIndex. + self packageDepsIndex: 0. + packageDeps := nil. + self changed: #packageDeps. + ! Item was added: + ----- Method: DependencyBrowser>>messageList (in category 'message list') ----- + messageList + "List of messages creating dependencies" + | selectedClass | + selectedClass := self classListSelection. + ^((classDeps at: self classDepsSelection ifAbsent:[#()]) + select:[:each| each classSymbol = selectedClass] + thenCollect:[:mref| mref methodSymbol]) asArray sort! Item was added: + ----- Method: DependencyBrowser>>buildClassDepsWith: (in category 'toolbuilder') ----- + buildClassDepsWith: builder + | listSpec | + listSpec := builder pluggableListSpec new. + listSpec + model: self; + list: #classDeps; + getIndex: #classDepsIndex; + setIndex: #classDepsIndex:; + menu: #classDepsMenu:; + keyPress: #classDepsKey:from:. + ^listSpec + ! Item was added: + ----- Method: DependencyBrowser>>buildMessageListWith: (in category 'toolbuilder') ----- + buildMessageListWith: builder + | listSpec | + listSpec := builder pluggableListSpec new. + listSpec + model: self; + list: #messageList; + getIndex: #messageListIndex; + setIndex: #messageListIndex:; + menu: #messageListMenu:; + keyPress: #messageListKey:from:. + ^listSpec + !

1 0

← Newer
1
...
70
71
72
73
74
75
76
77
Older →

Jump to page: