Squeak-dev March 2010

squeak-dev@lists.squeakfoundation.org

158 participants
767 discussions

The Trunk: Tests-ar.52.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Andreas Raab uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ar.52.mcz ==================== Summary ==================== Name: Tests-ar.52 Author: ar Time: 1 March 2010, 9:29:11.526 pm UUID: 77ddf070-5524-c44a-8e27-5bdd164fb043 Ancestors: Tests-ul.51 Add PackageDependencyTest to document and track package dependencies. =============== Diff against Tests-ul.51 =============== Item was added: + ----- Method: PackageDependencyTest>>testToolBuilderSUnit (in category 'tests') ----- + testToolBuilderSUnit + self testPackage: 'ToolBuilder-SUnit' dependsOnlyOn: #( + Collections + Kernel + ToolBuilder + 'ToolBuilder-Kernel' + ).! Item was added: + ----- Method: PackageDependencyTest>>testCompression (in category 'tests') ----- + testCompression + self testPackage: 'Compression' dependsOnlyOn: #( + Collections + Exceptions + Files + Graphics + Kernel + Multilingual + SUnit + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testSystem (in category 'tests') ----- + testSystem + self testPackage: 'System' dependsOnlyOn: #( + Collections + Balloon + Compiler + Compression + Exceptions + Files + Graphics + Kernel + Monticello + MonticelloConfigurations + Morphic + MorphicExtras + Multilingual + Network + PackageInfo + Sound + 'ToolBuilder-Kernel' + Tools + TrueType + ).! Item was added: + ----- Method: PackageDependencyTest>>testMonticello (in category 'tests') ----- + testMonticello + self testPackage: 'Monticello' dependsOnlyOn: #( + Collections + Compiler + Compression + Exceptions + Files + Graphics + Kernel + Morphic + Network + PackageInfo + System + Tests + 'ToolBuilder-Kernel' + 'ToolBuilder-Morphic' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testToolBuilder (in category 'tests') ----- + testToolBuilder + self testPackage: 'ToolBuilder-Kernel' dependsOnlyOn: #( + Collections + Files + Graphics + Kernel + SUnit + ).! Item was added: + ----- Method: PackageDependencyTest>>testBalloon (in category 'tests') ----- + testBalloon + self testPackage: 'Balloon' dependsOnlyOn: #( + Kernel Collections Graphics Morphic System + ).! Item was added: + ----- Method: PackageDependencyTest>>testMorphicExtras (in category 'tests') ----- + testMorphicExtras + self testPackage: 'MorphicExtras' dependsOnlyOn: #( + Balloon + Collections + Compiler + Exceptions + Files + Graphics + Kernel + Morphic + Network + Sound + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testCollections (in category 'tests') ----- + testCollections + self testPackage: 'Collections' dependsOnlyOn: #( + Balloon + Compiler + Kernel + Compression + Exceptions + Files + Graphics + Morphic + MorphicExtras + Multilingual + Network + System + 'ToolBuilder-Kernel' + ).! Item was added: + ----- Method: PackageDependencyTest>>testServices (in category 'tests') ----- + testServices + self testPackage: 'Services-Base' dependsOnlyOn: #( + Collections + Compiler + Exceptions + Graphics + Kernel + Morphic + PackageInfo + PreferenceBrowser + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testToolBuilderMorphic (in category 'tests') ----- + testToolBuilderMorphic + self testPackage: 'ToolBuilder-Morphic' dependsOnlyOn: #( + Collections + Exceptions + Graphics + Kernel + Morphic + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + TestCase subclass: #PackageDependencyTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Dependencies'! Item was added: + ----- Method: PackageDependencyTest>>testTrueType (in category 'tests') ----- + testTrueType + self testPackage: 'TrueType' dependsOnlyOn: #( + Collections + Balloon + Exceptions + Files + Graphics + Kernel + Morphic + Multilingual + System + 'ToolBuilder-Kernel' + Tools + ).! Item was changed: SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! + SystemOrganization addCategory: #'Tests-Dependencies'! Item was added: + ----- Method: PackageDependencyTest>>testMultilingual (in category 'tests') ----- + testMultilingual + self testPackage: 'Multilingual' dependsOnlyOn: #( + Collections + Compiler + Compression + Exceptions + Files + Graphics + Kernel + Morphic + Network + System + 'ToolBuilder-Kernel' + Tools + TrueType + ).! Item was added: + ----- Method: PackageDependencyTest>>testEtoys (in category 'tests') ----- + testEtoys + self testPackage: 'EToys' dependsOnlyOn: #( + Balloon + Collections + Compiler + Exceptions + Files + Graphics + Kernel + Morphic + MorphicExtras + Network + Protocols + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testSound (in category 'tests') ----- + testSound + self testPackage: 'Sound' dependsOnlyOn: #( + Collections + Balloon + EToys + Files + Graphics + Kernel + Morphic + MorphicExtras + Network + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testShoutCore (in category 'tests') ----- + testShoutCore + self testPackage: 'ShoutCore' dependsOnlyOn: #( + Collections + Graphics + Kernel + Monticello + System + ).! Item was added: + ----- Method: PackageDependencyTest>>testSUnit (in category 'tests') ----- + testSUnit + self testPackage: 'SUnit' dependsOnlyOn: #( + Collections + Exceptions + Kernel + System + ).! Item was added: + ----- Method: PackageDependencyTest>>testToolBuilderMVC (in category 'tests') ----- + testToolBuilderMVC + self testPackage: 'ToolBuilder-MVC' dependsOnlyOn: #( + Collections + Exceptions + Graphics + ST80 + ToolBuilder + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testNetwork (in category 'tests') ----- + testNetwork + self testPackage: 'Network' dependsOnlyOn: #( + Collections + Compiler + Compression + Exceptions + Files + Graphics + Kernel + Morphic + Multilingual + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testPackage:dependsOnlyOn: (in category 'tests') ----- + testPackage: pkgName dependsOnlyOn: pkgList + "Ensure that the package with the given name depends only on the packages in pkgList" + | classes pi deps | + classes := IdentitySet new. + pi := PackageOrganizer default packageNamed: pkgName ifAbsent:[^self]. "unloaded" + pi classes do:[:pkgClass| classes add: (pkgClass superclass ifNil:[ProtoObject])]. + pi methods do:[:mref| | cm | + cm := mref compiledMethod. + 1 to: cm numLiterals do:[:i| | lit | + ((lit := cm literalAt: i) isVariableBinding + and:[lit value isBehavior]) ifTrue:[classes add: lit value]]]. + deps := Dictionary new. + classes do:[:aClass| | pkg | + pkg := PackageOrganizer default packageOfClass: aClass ifNone:[nil]. + pkg ifNil:[ + Transcript cr; show: 'WARNING: No package for ', pkg. + ] ifNotNil:[ + (deps at: pkg name ifAbsentPut:[OrderedCollection new]) add: aClass. + ]. + ]. + deps removeKey: pkgName ifAbsent:[]. + pkgList do:[:pkg| + self assert: (deps includesKey: pkg). + deps removeKey: pkg. + ]. + self assert: deps isEmpty.! Item was added: + ----- Method: PackageDependencyTest>>testPackageInfo (in category 'tests') ----- + testPackageInfo + self testPackage: 'PackageInfo' dependsOnlyOn: #( + Collections + Compiler + Graphics + Kernel + Morphic + System + 'ToolBuilder-Kernel' + ).! Item was added: + ----- Method: PackageDependencyTest>>testMorphic (in category 'tests') ----- + testMorphic + self testPackage: 'Morphic' dependsOnlyOn: #( + Balloon + Collections + Compiler + EToys + Exceptions + Files + Graphics + Kernel + Monticello + MonticelloConfigurations + 'Morphic-TrueType' "????" + MorphicExtras + Multilingual + Network + PreferenceBrowser + Protocols + ST80 + Sound + System + 'ToolBuilder-Kernel' + 'ToolBuilder-Morphic' + Tools + TrueType + ).! Item was added: + ----- Method: PackageDependencyTest>>testVersionNumber (in category 'tests') ----- + testVersionNumber + self testPackage: 'VersionNumber' dependsOnlyOn: #( + Collections + Kernel + ).! Item was added: + ----- Method: PackageDependencyTest>>testFiles (in category 'tests') ----- + testFiles + self testPackage: 'Files' dependsOnlyOn: #( + Collections + Compression + Exceptions + Graphics + Kernel + Multilingual + Network + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testCompiler (in category 'tests') ----- + testCompiler + self testPackage: 'Compiler' dependsOnlyOn: #( + Collections + Exceptions + Graphics + Kernel + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testKernel (in category 'tests') ----- + testKernel + self testPackage: 'Kernel' dependsOnlyOn: #( + Collections + Compiler + Compression + Exceptions + Files + Graphics + Morphic + MorphicExtras + Multilingual + System + 'ToolBuilder-Kernel' + Tools + Traits + ).! Item was added: + ----- Method: PackageDependencyTest>>testTraits (in category 'tests') ----- + testTraits + self testPackage: 'Traits' dependsOnlyOn: #( + Collections + Compiler + Exceptions + Files + Kernel + Monticello + System + ).! Item was added: + ----- Method: PackageDependencyTest>>testSUnitGUI (in category 'tests') ----- + testSUnitGUI + self testPackage: 'SUnitGUI' dependsOnlyOn: #( + Collections + Graphics + Kernel + PackageInfo + SUnit + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testPreferenceBrowser (in category 'tests') ----- + testPreferenceBrowser + self testPackage: 'PreferenceBrowser' dependsOnlyOn: #( + Collections + EToys + Exceptions + Graphics + Kernel + Morphic + MorphicExtras + System + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testXML (in category 'tests') ----- + testXML + self testPackage: 'XML' dependsOnlyOn: #( + Collections + Exceptions + Files + Kernel + Multilingual + System + Tests + ).! Item was added: + ----- Method: PackageDependencyTest>>testInstaller (in category 'tests') ----- + testInstaller + self testPackage: 'Installer' dependsOnlyOn: #( + Collections + Compression + Exceptions + Files + Kernel + Monticello + MonticelloConfigurations + Multilingual + Network + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testGraphics (in category 'tests') ----- + testGraphics + self testPackage: 'Graphics' dependsOnlyOn: #( + Collections + Compression + Exceptions + Files + Kernel + Morphic + MorphicExtras + Multilingual + Network + System + 'ToolBuilder-Kernel' + Tools + TrueType + ).! Item was added: + ----- Method: PackageDependencyTest>>testNebraska (in category 'tests') ----- + testNebraska + self testPackage: 'Nebraska' dependsOnlyOn: #( + Balloon + Collections + EToys + Exceptions + Files + Graphics + Kernel + Morphic + MorphicExtras + Multilingual + Network + SUnit + Sound + System + 'ToolBuilder-Kernel' + ).! Item was added: + ----- Method: PackageDependencyTest>>testTools (in category 'tests') ----- + testTools + self testPackage: 'Tools' dependsOnlyOn: #( + Collections + Compiler + Compression + Exceptions + Files + Graphics + Kernel + Morphic + MorphicExtras + Multilingual + Network + PackageInfo + ST80 + System + 'ToolBuilder-Kernel' + ).! Item was added: + ----- Method: PackageDependencyTest>>testST80 (in category 'tests') ----- + testST80 + self testPackage: 'ST80' dependsOnlyOn: #( + Collections + Compiler + Exceptions + Files + Graphics + Kernel + Morphic + Multilingual + Network + SUnit + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testProtocols (in category 'tests') ----- + testProtocols + self testPackage: 'Protocols' dependsOnlyOn: #( + Collections + Graphics + Kernel + Morphic + MorphicExtras + System + 'ToolBuilder-Kernel' + Tools + ).! Item was added: + ----- Method: PackageDependencyTest>>testExceptions (in category 'tests') ----- + testExceptions + self testPackage: 'Exceptions' dependsOnlyOn: #( + Collections + Files + Graphics + Kernel + Morphic + System + ).!

1 0

The Trunk: Morphic-ar.368.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Andreas Raab uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ar.368.mcz ==================== Summary ==================== Name: Morphic-ar.368 Author: ar Time: 1 March 2010, 7:43:55.198 pm UUID: 6f160ddd-4ffb-404b-80c7-067f0d2d3d81 Ancestors: Morphic-dtl.367 Add a preference to restore simple rectangular feedback for indicating changes. =============== Diff against Morphic-dtl.367 =============== Item was added: + ----- Method: PluggableTextMorph class>>simpleFrameAdornments: (in category 'frame adornments') ----- + simpleFrameAdornments: aBool + "Sets the simpleFrameAdornment preference + PluggableTextMorph simpleFrameAdornments: true. + PluggableTextMorph simpleFrameAdornments: false. + " + SimpleFrameAdornments := aBool + ! Item was added: + ----- Method: PluggableTextMorph class>>simpleFrameAdornments (in category 'frame adornments') ----- + simpleFrameAdornments + <preference: 'Simple Frame Adornments' + category: 'Morphic' + description: 'When true, use a simple rectangular feedback for indicating unsaved changes in text editors' + type: #Boolean> + ^SimpleFrameAdornments ifNil:[false]! Item was changed: ----- Method: PluggableTextMorph>>drawFrameAdornment:on: (in category 'drawing') ----- drawFrameAdornment: aColor on: aCanvas "Indicate edit status for the text editor" | form | - "The old frame adornment style in case you care" - false ifTrue:[^aCanvas frameRectangle: self innerBounds width: 2 color: aColor]. + self class simpleFrameAdornments + ifTrue:[^aCanvas frameRectangle: self innerBounds width: 2 color: aColor]. + "Class-side adornment cache is currently using pre-multiplied alpha, so we need to use rule 34 which works for < 32bpp, too." form := self class adornmentWithColor: aColor. aCanvas image: form at: (self innerBounds topRight - (form width@0)) sourceRect: form boundingBox rule: 34. ! Item was changed: ScrollPane subclass: #PluggableTextMorph instanceVariableNames: 'textMorph getTextSelector setTextSelector getSelectionSelector hasUnacceptedEdits askBeforeDiscardingEdits selectionInterval hasEditingConflicts' + classVariableNames: 'AdornmentCache SimpleFrameAdornments' - classVariableNames: 'AdornmentCache' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'!

1 0

The Trunk: Kernel-mtf.388.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Matthew Fulmer uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mtf.388.mcz ==================== Summary ==================== Name: Kernel-mtf.388 Author: mtf Time: 4 February 2010, 5:23:44.746 pm UUID: 97896701-ce97-4a36-a281-71ae723ce7e8 Ancestors: Kernel-mtf.387 Made a note about the island and env instance variables in the Process class comment =============== Diff against Kernel-ar.386 =============== Item was changed: Link subclass: #Process + instanceVariableNames: 'suspendedContext priority myList errorHandler name island env' - instanceVariableNames: 'suspendedContext priority myList errorHandler name' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Processes'! + !Process commentStamp: 'mtf 2/4/2010 17:21' prior: 0! - !Process commentStamp: '<historical>' prior: 0! I represent an independent path of control in the system. This path of control may be stopped (by sending the message suspend) in such a way that it can later be restarted (by sending the message resume). When any one of several paths of control can be advanced, the single instance of ProcessorScheduler named Processor determines which one will actually be advanced partly using the value of priority. + (If anyone ever makes a subclass of Process, be sure to use allSubInstances in anyProcessesAbove:.) + + The island and env instance variables are not used by core squeak, but are used by external packages and included here because Monticello cannot handle external instance variables: + island: used by Tweak and Croquet to partition the image into multiple address spaces + env: used by ProcessSpecific to implement per-process variables! - (If anyone ever makes a subclass of Process, be sure to use allSubInstances in anyProcessesAbove:.)!

1 0

The Trunk: Kernel-mtf.389.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Matthew Fulmer uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mtf.389.mcz ==================== Summary ==================== Name: Kernel-mtf.389 Author: mtf Time: 4 February 2010, 7:44:03.918 pm UUID: 6a4c765f-eddf-4ff3-963b-98ca79013299 Ancestors: Kernel-nice.387 7219: Improve Streams Usage Readability http://bugs.squeak.org/view.php?id=7219 Adds << to streams to be mostly like nextPutAll, but uses putOn: so that it works with any object. =============== Diff against Kernel-nice.387 =============== Item was added: + ----- Method: Magnitude>>putOn: (in category 'streaming') ----- + putOn: aStream + + (aStream isBinary ifTrue: [ self asByteArray ] ifFalse: [ self asString]) putOn: aStream + + !

1 0

Re: 0006721: Identity dictionarys sometimes can't find their keys
by Jerome Peace 02 Mar '10

02 Mar '10

Levente Uzonyi leves at elte.hu Sun Feb 28 17:56:00 UTC 2010 replied: >nil was always a valid key for Dictionary and IdentityDictionary. Sets >were the collections which couldn't contain nil. >Levente Ha. I knew there was a good reason for having someone look over your shoulder as you program. I stand corrected. Never the less, the tests were useful in finding bugs. Even if 'nil' can be a legitimate key its presence is often the sign of a bug. The only instance my test found pointed to the initialization of GeeMailMorph being misplaced to UndefinedObject class. So even though I stumbled on to it with a mis-assumption the test found it. I think it's valuable to go looking, then note the legitimate exceptions in the test. I would love to see my tests in the image and your test improvements as well. I am still looking for a MC savvy code partner to take over some of the driving. Cheers --Jer "Debugger's don't need exact knowledge as long at they have interesting tests and a willingness to learn." --Fearless Bugtrackers secret codex

2 1

The Trunk: Monticello-ar.376.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Andreas Raab uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ar.376.mcz ==================== Summary ==================== Name: Monticello-ar.376 Author: ar Time: 1 March 2010, 5:29:08.27 pm UUID: 8742232a-35aa-8647-9f89-7c31dd39a490 Ancestors: Monticello-ul.375 Include Bert's old ExternalStructure initialize fix from Croquet. =============== Diff against Monticello-ul.375 =============== Item was changed: ----- Method: MCMethodDefinition>>postload (in category 'installing') ----- postload + self isInitializer + ifTrue: [self actualClass theNonMetaClass initialize]. + self isExternalStructureFieldDefinition + ifTrue: [self actualClass theNonMetaClass compileFields].! - (self isInitializer and: [ self actualClass isTrait not ]) ifTrue: [ - self actualClass theNonMetaClass initialize]! Item was added: + ----- Method: MCMethodDefinition>>isExternalStructureFieldDefinition (in category 'testing') ----- + isExternalStructureFieldDefinition + ^ selector = #fields + and: [classIsMeta + and: [ + (Smalltalk at: #ExternalStructure ifPresent: [:externalStructure | + self actualClass theNonMetaClass inheritsFrom: externalStructure]) == true]] + + !

1 0

Re: [squeak-dev] The Trunk: Compiler-nice.130.mcz
by Nicolas Cellier 02 Mar '10

02 Mar '10

2010/3/2 <commits(a)source.squeak.org>: > Nicolas Cellier uploaded a new version of Compiler to project The Trunk: > http://source.squeak.org/trunk/Compiler-nice.130.mcz > > ==================== Summary ==================== > > Name: Compiler-nice.130 > Author: nice > Time: 2 March 2010, 1:28:40.263 am > UUID: cdff6f07-1e9b-f746-a7b1-2cd22feb03b4 > Ancestors: Compiler-nice.129 > > Provide a better fix for http://source.squeak.org/trunk/Compiler-nice.129.mcz > Hem, I meant http://bugs.squeak.org/view.php?id=7467 Danger, better not touching Compiler anymore at such a late time ;) Nicolas > BlockNode>>#addRemoteTemp: rootNode: > was always sent to the TempVariableNode definingScope... > > But BlockNode>>#optimizedBlockHoistTempsInto: > might already have moved the temporaries to next upper unoptimized BlockNode (definingBlock actualScope). > This operation does not update the TempVariableNode definingScope (should it ?) > > Thus, only when definingScope temporaries does not include the TempVariableNode, > should we attempt to remove it from actualScope temporaries.... > > Note: this does not solve (EventSensor>>#eventTickler) decompileWithTemps > > =============== Diff against Compiler-nice.129 =============== > > Item was changed: > ----- Method: BlockNode>>addRemoteTemp:rootNode: (in category 'code generation (closures)') ----- > addRemoteTemp: aTempVariableNode rootNode: rootNode "<MethodNode>" > "Add aTempVariableNode to my actualScope's sequence of > remote temps. If I am an optimized block then the actual > scope is my actualScopeIfOptimized, otherwise it is myself." > remoteTempNode == nil ifTrue: > [remoteTempNode := RemoteTempVectorNode new > name: self remoteTempNodeName > index: arguments size + temporaries size > type: LdTempType > scope: 0. > actualScopeIfOptimized > ifNil: > [self addTempNode: remoteTempNode. > remoteTempNode definingScope: self] > ifNotNil: [actualScopeIfOptimized addHoistedTemps: { remoteTempNode }]]. > remoteTempNode addRemoteTemp: aTempVariableNode encoder: rootNode encoder. > "use remove:ifAbsent: because the deferred analysis for optimized > loops can result in the temp has already been hoised into the root." > + self removeTempNode: aTempVariableNode ifAbsent: [ > + self actualScope removeTempNode: aTempVariableNode ifAbsent: ["should not happen"]]. > - self actualScope removeTempNode: aTempVariableNode ifAbsent: []. > ^remoteTempNode! > > >

1 0

The Trunk: Compiler-nice.130.mcz
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Nicolas Cellier uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-nice.130.mcz ==================== Summary ==================== Name: Compiler-nice.130 Author: nice Time: 2 March 2010, 1:28:40.263 am UUID: cdff6f07-1e9b-f746-a7b1-2cd22feb03b4 Ancestors: Compiler-nice.129 Provide a better fix for http://source.squeak.org/trunk/Compiler-nice.129.mcz BlockNode>>#addRemoteTemp: rootNode: was always sent to the TempVariableNode definingScope... But BlockNode>>#optimizedBlockHoistTempsInto: might already have moved the temporaries to next upper unoptimized BlockNode (definingBlock actualScope). This operation does not update the TempVariableNode definingScope (should it ?) Thus, only when definingScope temporaries does not include the TempVariableNode, should we attempt to remove it from actualScope temporaries.... Note: this does not solve (EventSensor>>#eventTickler) decompileWithTemps =============== Diff against Compiler-nice.129 =============== Item was changed: ----- Method: BlockNode>>addRemoteTemp:rootNode: (in category 'code generation (closures)') ----- addRemoteTemp: aTempVariableNode rootNode: rootNode "<MethodNode>" "Add aTempVariableNode to my actualScope's sequence of remote temps. If I am an optimized block then the actual scope is my actualScopeIfOptimized, otherwise it is myself." remoteTempNode == nil ifTrue: [remoteTempNode := RemoteTempVectorNode new name: self remoteTempNodeName index: arguments size + temporaries size type: LdTempType scope: 0. actualScopeIfOptimized ifNil: [self addTempNode: remoteTempNode. remoteTempNode definingScope: self] ifNotNil: [actualScopeIfOptimized addHoistedTemps: { remoteTempNode }]]. remoteTempNode addRemoteTemp: aTempVariableNode encoder: rootNode encoder. "use remove:ifAbsent: because the deferred analysis for optimized loops can result in the temp has already been hoised into the root." + self removeTempNode: aTempVariableNode ifAbsent: [ + self actualScope removeTempNode: aTempVariableNode ifAbsent: ["should not happen"]]. - self actualScope removeTempNode: aTempVariableNode ifAbsent: []. ^remoteTempNode!

1 0

Re: [squeak-dev] The Trunk: Compiler-nice.129.mcz
by Levente Uzonyi 02 Mar '10

02 Mar '10

Thanks for the fix Nicolas. Too bad #asOrderedCollection creates a copy even if it's sent to an OrderedCollection. I wonder if there's a way to fix it without breaking existing code. Levente On Mon, 1 Mar 2010, commits(a)source.squeak.org wrote: > Nicolas Cellier uploaded a new version of Compiler to project The Trunk: > http://source.squeak.org/trunk/Compiler-nice.129.mcz > > ==================== Summary ==================== > > Name: Compiler-nice.129 > Author: nice > Time: 1 March 2010, 11:24:30.271 pm > UUID: a27b827d-1354-1147-bc1a-edeb6e1f0e97 > Ancestors: Compiler-nice.128 > > Fix Compiler/Decompiler temporary slot mismatch > http://bugs.squeak.org/view.php?id=7467 > > See also my comments in response to > http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-March/145280.ht… > > Eliot, please check.... > > =============== Diff against Compiler-nice.128 =============== > > Item was changed: > InstructionStream subclass: #Decompiler > instanceVariableNames: 'constructor method instVars tempVars constTable stack statements lastPc exit caseExits lastJumpPc lastReturnPc limit hasValue blockStackBase numLocalTemps blockStartsToTempVars tempVarCount' > classVariableNames: 'ArgumentFlag CascadeFlag CaseFlag IfNilFlag' > poolDictionaries: '' > category: 'Compiler-Kernel'! > > + !Decompiler commentStamp: 'nice 3/1/2010 19:56' prior: 0! > - !Decompiler commentStamp: '<historical>' prior: 0! > I decompile a method in three phases: > Reverser: postfix byte codes -> prefix symbolic codes (nodes and atoms) > Parser: prefix symbolic codes -> node tree (same as the compiler) > Printer: node tree -> text (done by the nodes) > > > instance vars: > > + constructor <DecompilerConstructor> an auxiliary knowing how to generate Abstract Syntax Tree (node tree) > + method <CompiledMethod> the method being decompiled > + instVars <Array of: String> the instance variables of the class implementing method > + tempVars <String | (OrderedCollection of: String)> hold the names of temporary variables (if known) > + NOTE: POLYMORPHISM WILL BE RESOLVED IN #initSymbols: > + constTable <Collection of: ParseNode> parse node associated with byte encoded constants (nil true false 0 1 -1 etc...) > + stack <OrderedCollection of: (ParseNode | String | Integer) > multipurpose... > + statements <OrderedCollection of: ParseNode> the statements of the method being decompiled > + lastPc <Integer> > + exit <Integer> > + caseExits <OrderedCollection of: Integer> - stack of exit addresses that have been seen in the branches of caseOf:'s > + lastJumpPc <Integer> > + lastReturnPc <Integer> > + limit <Integer> > + hasValue <Boolean> > + blockStackBase <Integer> > + numLocaltemps <Integer | Symbol> - number of temps local to a block; also a flag indicating decompiling a block > + blockStartsToTempVars <Dictionary key: Integer value: (OrderedCollection of: String)> > + tempVarCount <Integer> number of temp vars used by the method! > - constructor > - method > - instVars > - tempVars > - constTable > - stack > - statements > - lastPc > - exit > - caseExits - stack of exit addresses that have been seen in the branches of caseOf:'s > - lastJumpPc > - lastReturnPc > - limit > - hasValue > - blockStackBase > - numLocaltemps - number of temps local to a block; also a flag indicating decompiling a block! > > Item was added: > + ----- Method: BlockNode>>makeTemporariesRemovable (in category 'code generation (closures)') ----- > + makeTemporariesRemovable > + "Utilities for when we want to remove some temporaries." > + > + temporaries isArray ifTrue: > + [temporaries := temporaries asOrderedCollection].! > > Item was changed: > ----- Method: BlockNode>>addRemoteTemp:rootNode: (in category 'code generation (closures)') ----- > addRemoteTemp: aTempVariableNode rootNode: rootNode "<MethodNode>" > "Add aTempVariableNode to my actualScope's sequence of > remote temps. If I am an optimized block then the actual > scope is my actualScopeIfOptimized, otherwise it is myself." > - temporaries isArray ifTrue: > - [temporaries := temporaries asOrderedCollection]. > remoteTempNode == nil ifTrue: > [remoteTempNode := RemoteTempVectorNode new > name: self remoteTempNodeName > index: arguments size + temporaries size > type: LdTempType > scope: 0. > actualScopeIfOptimized > ifNil: > + [self addTempNode: remoteTempNode. > - [temporaries addLast: remoteTempNode. > remoteTempNode definingScope: self] > ifNotNil: [actualScopeIfOptimized addHoistedTemps: { remoteTempNode }]]. > remoteTempNode addRemoteTemp: aTempVariableNode encoder: rootNode encoder. > "use remove:ifAbsent: because the deferred analysis for optimized > loops can result in the temp has already been hoised into the root." > + self actualScope removeTempNode: aTempVariableNode ifAbsent: []. > - temporaries remove: aTempVariableNode ifAbsent: []. > ^remoteTempNode! > > Item was added: > + ----- Method: BlockNode>>addTempNode: (in category 'code generation (closures)') ----- > + addTempNode: aTempVariableNode > + "Utilities for when we want to add some temporaries." > + > + self makeTemporariesRemovable. > + ^temporaries add: aTempVariableNode! > > Item was added: > + ----- Method: BlockNode>>removeTempNode:ifAbsent: (in category 'code generation (closures)') ----- > + removeTempNode: aTempVariableNode ifAbsent: aBlock > + "Utilities for when we want to remove some temporaries." > + > + self makeTemporariesRemovable. > + ^temporaries remove: aTempVariableNode ifAbsent: aBlock > + ! > > >

2 2

Daily Commit Log
by commits＠source.squeak.org 02 Mar '10

02 Mar '10

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2010-March/002878.html Name: EToys-dtl.62 Ancestors: EToys-ar.61 The correct spelling of Etoys is "Etoys". Therefore rename the EToys package to "Etoys" and recategorize all package overrides to "*Etoys". ============================================= http://lists.squeakfoundation.org/pipermail/packages/2010-March/002879.html Name: Compiler-nice.129 Ancestors: Compiler-nice.128 Fix Compiler/Decompiler temporary slot mismatch http://bugs.squeak.org/view.php?id=7467 See also my comments in response to http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-March/145280.ht… Eliot, please check.... =============================================

1 0

Jump to page: