Squeak-dev February 2013

squeak-dev@lists.squeakfoundation.org

61 participants
225 discussions

The Trunk: Tools-nice.448.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-nice.448.mcz ==================== Summary ==================== Name: Tools-nice.448 Author: nice Time: 24 February 2013, 9:20:11.082 pm UUID: 6d5eb1d5-ae18-44eb-95a8-4fbdf02a2e66 Ancestors: Tools-nice.447 FakeClassPool is obsolete in Squeak, remove recent reference to it. Note: we should deprecate this class =============== Diff against Tools-nice.447 =============== Item was changed: ----- Method: Debugger>>runUntil (in category 'code pane menu') ----- runUntil "Step until an expression evaluates to other than false, reporting an erroer if it doesn't evaluate to true. Remember the expression in an inst var. If shift is pressed when the expression is supplied, don't update the UI. If shift is pressed while stepping, stop stepping. Using a user interrupt to break out would be more natural but Squeak currently doesn't provide a UserInterrupt expection. It should do." | expression receiver context method value lastUpdate updateUI breakOnShift | expression := UIManager default request: 'run until expression is true (shift to disable ui update; shift to break).' initialAnswer: (untilExpression ifNil: 'boolean expression'). (expression isNil or: [expression isEmpty]) ifTrue: [^self]. updateUI := breakOnShift := Sensor shiftPressed not. untilExpression := expression. context := self selectedContext. receiver := context receiver. - FakeClassPool adopt: receiver class. method := receiver class evaluatorClass new compiledMethodFor: untilExpression in: context to: receiver notifying: nil + ifFail: [^ #failedDoit] - ifFail: [FakeClassPool adopt: nil. ^ #failedDoit] logged: false. lastUpdate := Time millisecondClockValue. - FakeClassPool adopt: nil. [self selectedContext == context and: [(value := receiver with: context executeMethod: method) == false]] whileTrue: [self doStep. Time millisecondClockValue - lastUpdate > 50 ifTrue: [updateUI ifTrue: [World displayWorldSafely]. breakOnShift ifTrue: [Sensor shiftPressed ifTrue: [^self]] ifFalse: [Sensor shiftPressed ifFalse: [breakOnShift := true]]. lastUpdate := Time millisecondClockValue]]. (value ~~ false and: [value ~~ true]) ifTrue: [UIManager default inform: 'expression ', (untilExpression contractTo: 40), ' answered ', (value printString contractTo: 20), '!!!!']!

1 0

The Trunk: Morphic-nice.641.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-nice.641.mcz ==================== Summary ==================== Name: Morphic-nice.641 Author: nice Time: 24 February 2013, 7:46:46.389 pm UUID: d7085035-2ec9-4937-a927-80ad6419a36c Ancestors: Morphic-nice.640 Correct blinkPrevParen: (only in absence of Shout). simplify an initialization. =============== Diff against Morphic-nice.640 =============== Item was changed: ----- Method: MorphicProject>>initializeMenus (in category 'enter') ----- initializeMenus + "Menu setting for these classes may have been modified by another - "Menu setting for these classes may have have been modified by another Morphic project, e.g. SimpleMorphic. Ensure that they are restored to the expected menus." + Editor initialize.! - TextEditor initialize. - SmalltalkEditor initialize! Item was changed: ----- Method: TextEditor>>blinkPrevParen: (in category 'parenblinking') ----- + blinkPrevParen: aCharacter - blinkPrevParen: aKeyboardEvent "Used if not Shout" | openDelimiter closeDelimiter level string here hereChar | string := paragraph string. here := pointBlock stringIndex. + openDelimiter := aCharacter. - openDelimiter := aKeyboardEvent keyCharacter. closeDelimiter := '([{' at: (')]}' indexOf: openDelimiter). level := 1. [level > 0 and: [here > 1]] whileTrue: [hereChar := string at: (here := here - 1). hereChar = closeDelimiter ifTrue: [level := level - 1. level = 0 ifTrue: [^ self blinkParenAt: here]] ifFalse: [hereChar = openDelimiter ifTrue: [level := level + 1]]]!

1 0

The Inbox: Collections-nice.502.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-nice.502.mcz ==================== Summary ==================== Name: Collections-nice.502 Author: nice Time: 24 February 2013, 7:30:26.441 pm UUID: 493d78e4-ccce-434c-98ae-90f22102cdce Ancestors: Collections-fbs.501 Let String combinations produce Strings rather than Array of Characters. This is not perfect for WideString which are not necessarily simplified to ByteString, but IMO better than Array. =============== Diff against Collections-fbs.501 =============== Item was changed: ----- Method: SequenceableCollection>>combinations:atATimeDo: (in category 'enumerating') ----- combinations: kk atATimeDo: aBlock "Take the items in the receiver, kk at a time, and evaluate the block for each combination. Hand in an array of elements of self as the block argument. Each combination only occurs once, and order of the elements does not matter. There are (self size take: kk) combinations." + " (1 to: 5) combinations: 3 atATimeDo: [:each | Transcript cr; show: each printString]" - " 'abcde' combinations: 3 atATimeDo: [:each | Transcript cr; show: each printString]" | aCollection | aCollection := Array new: kk. self combinationsAt: 1 in: aCollection after: 0 do: aBlock! Item was added: + ----- Method: String>>combinations:atATimeDo: (in category 'enumerating') ----- + combinations: kk atATimeDo: aBlock + "Gather the combinations into a String rather than an Array" + + " 'abcde' combinations: 3 atATimeDo: [:each | Transcript cr; show: each printString]" + + | aCollection | + aCollection := String new: kk. + self combinationsAt: 1 in: aCollection after: 0 do: aBlock!

1 0

The Trunk: Morphic-nice.640.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-nice.640.mcz ==================== Summary ==================== Name: Morphic-nice.640 Author: nice Time: 24 February 2013, 6:35:47.345 pm UUID: ad3e00cc-256f-4358-8879-83ae19baf939 Ancestors: Morphic-tfel.639 Diminish excessive usage of ReadWriteStream =============== Diff against Morphic-tfel.639 =============== Item was removed: - (PackageInfo named: 'Morphic') postscriptOfRemoval: 'nil'! Item was removed: - (PackageInfo named: 'Morphic') preamble: 'nil'! Item was changed: ----- Method: MenuIcons class>>importIconNamed: (in category 'import/export') ----- importIconNamed: aString "self importIconNamed: 'appearanceIcon'" "will create a method appearanceIconContents holding the string representation of the icon, and a method appearanceIcon to access a form built using that string" | writer image stream | writer := GIFReadWriter on: (FileStream fileNamed: './icons/', aString, '.gif'). image := [ writer nextImage] ensure: [writer close]. "store string representation" + stream := String new writeStream. - stream := ReadWriteStream on: (String new). stream nextPutAll: aString, 'Contents' ; cr. stream nextPutAll: (self methodStart: aString). image storeOn: stream. stream nextPutAll: self methodEnd. - stream close. MenuIcons class compile: stream contents classified: 'private - icons' notifying: nil. "create accessor method" + stream := String new writeStream. - stream := ReadWriteStream on: (String new). stream nextPutAll: aString ; cr. stream nextPutAll: (self methodAccessorFor: aString). MenuIcons class compile: stream contents classified: 'accessing - icons' notifying: nil. - ^ stream contents! Item was changed: ----- Method: MenuIcons class>>importPngIconNamed: (in category 'import/export') ----- importPngIconNamed: aString "self importIconNamed: 'appearanceIcon'" "will create a method appearanceIconContents holding the string representation of the icon, and a method appearanceIcon to access a form built using that string" | writer image stream | writer := PNGReadWriter on: (FileStream fileNamed: './icons/', aString, '.png'). image := [ writer nextImage] ensure: [writer close]. "store string representation" + stream := String new writeStream. - stream := ReadWriteStream on: (String new). stream nextPutAll: aString, 'Contents' ; cr. stream nextPutAll: (self methodStart: aString). image storeOn: stream. stream nextPutAll: self methodEnd. - stream close. MenuIcons class compile: stream contents classified: 'private - icons' notifying: nil. "create accessor method" + stream := String new writeStream. - stream := ReadWriteStream on: (String new). stream nextPutAll: aString ; cr. stream nextPutAll: (self methodAccessorFor: aString). MenuIcons class compile: stream contents classified: 'accessing - icons' notifying: nil. - ^ stream contents!

1 0

The Trunk: Tools-nice.447.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-nice.447.mcz ==================== Summary ==================== Name: Tools-nice.447 Author: nice Time: 24 February 2013, 6:32:05.033 pm UUID: c213012a-b66a-4d1e-99cc-a707e054efc9 Ancestors: Tools-fbs.446 Diminish excessive usage of ReadWriteStream =============== Diff against Tools-fbs.446 =============== Item was changed: ----- Method: CodeHolder>>annotationForSelector:ofClass: (in category 'annotation') ----- annotationForSelector: aSelector ofClass: aClass "Provide a line of content for an annotation pane, representing information about the given selector and class" | separator aStream requestList | aSelector == #Comment ifTrue: [^ self annotationForClassCommentFor: aClass]. aSelector == #Definition ifTrue: [^ self annotationForClassDefinitionFor: aClass]. aSelector == #Hierarchy ifTrue: [^ self annotationForHierarchyFor: aClass]. + aStream := (String new: 512) writeStream. - aStream := ReadWriteStream on: ''. requestList := self annotationRequests. separator := requestList size > 1 ifTrue: [self annotationSeparator] ifFalse: ['']. requestList do: [:aRequest | | aString sendersCount aComment aCategory implementorsCount aList stamp | aRequest == #firstComment ifTrue: [aComment := aClass firstCommentAt: aSelector. aComment isEmptyOrNil ifFalse: [aStream nextPutAll: aComment , separator]]. aRequest == #masterComment ifTrue: [aComment := aClass supermostPrecodeCommentFor: aSelector. aComment isEmptyOrNil ifFalse: [aStream nextPutAll: aComment , separator]]. aRequest == #documentation ifTrue: [aComment := aClass precodeCommentOrInheritedCommentFor: aSelector. aComment isEmptyOrNil ifFalse: [aStream nextPutAll: aComment , separator]]. aRequest == #timeStamp ifTrue: [stamp := self timeStamp. aStream nextPutAll: (stamp size > 0 ifTrue: [stamp , separator] ifFalse: ['no timeStamp' , separator])]. aRequest == #messageCategory ifTrue: [aCategory := aClass organization categoryOfElement: aSelector. aCategory ifNotNil: ["woud be nil for a method no longer present, e.g. in a recent-submissions browser" aStream nextPutAll: aCategory , separator]]. aRequest == #sendersCount ifTrue: [sendersCount := (self systemNavigation allCallsOn: aSelector) size. sendersCount := sendersCount = 1 ifTrue: ['1 sender'] ifFalse: [sendersCount printString , ' senders']. aStream nextPutAll: sendersCount , separator]. aRequest == #implementorsCount ifTrue: [implementorsCount := self systemNavigation numberOfImplementorsOf: aSelector. implementorsCount := implementorsCount = 1 ifTrue: ['1 implementor'] ifFalse: [implementorsCount printString , ' implementors']. aStream nextPutAll: implementorsCount , separator]. aRequest == #priorVersionsCount ifTrue: [self addPriorVersionsCountForSelector: aSelector ofClass: aClass to: aStream]. aRequest == #priorTimeStamp ifTrue: [stamp := VersionsBrowser timeStampFor: aSelector class: aClass reverseOrdinal: 2. stamp ifNotNil: [aStream nextPutAll: 'prior time stamp: ' , stamp , separator]]. aRequest == #recentChangeSet ifTrue: [aString := ChangesOrganizer mostRecentChangeSetWithChangeForClass: aClass selector: aSelector. aString size > 0 ifTrue: [aStream nextPutAll: aString , separator]]. aRequest == #allChangeSets ifTrue: [aList := ChangesOrganizer allChangeSetsWithClass: aClass selector: aSelector. aList size > 0 ifTrue: [aList size = 1 ifTrue: [aStream nextPutAll: 'only in change set '] ifFalse: [aStream nextPutAll: 'in change sets: ']. aList do: [:aChangeSet | aStream nextPutAll: aChangeSet name , ' ']] ifFalse: [aStream nextPutAll: 'in no change set']. aStream nextPutAll: separator]]. ^ aStream contents! Item was changed: ----- Method: TimeProfileBrowser>>runBlock:pollingEvery: (in category 'private') ----- runBlock: aBlock pollingEvery: pollPeriod + | list result | - | stream list result | block := MessageSend receiver: self selector: #runBlock:pollingEvery: arguments: { aBlock. pollPeriod}. "so we can re-run it" tally := MessageTally new. tally reportOtherProcesses: false; maxClassNameSize: 1000; maxClassPlusSelectorSize: 1000; maxTabs: 100. result := tally spyEvery: pollPeriod on: aBlock. + list := OrderedCollection withAll: (String streamContents: [ :s | tally report: s]) lines. - stream := ReadWriteStream - with: (String streamContents: [ :s | - tally report: s]). - stream reset. - list := OrderedCollection new. - [stream atEnd] whileFalse: [list add: stream nextLine]. self initializeMessageList: list. self changed: #messageList. self changed: #messageListIndex. ^result! Item was changed: ----- Method: TimeProfileBrowser>>runProcess:forMilliseconds:pollingEvery: (in category 'private') ----- runProcess: aProcess forMilliseconds: msecDuration pollingEvery: pollPeriod + | list result | - | stream list result | block := MessageSend receiver: self selector: #runProcess:forMilliseconds:pollingEvery: arguments: { aProcess. msecDuration. pollPeriod}. "so we can re-run it" tally := MessageTally new. tally reportOtherProcesses: false; maxClassNameSize: 1000; maxClassPlusSelectorSize: 1000; maxTabs: 100. result := tally spyEvery: pollPeriod onProcess: aProcess forMilliseconds: msecDuration. + list := OrderedCollection withAll: (String streamContents: [ :s | tally report: s]) lines. - stream := ReadWriteStream - with: (String streamContents: [ :s | - tally report: s]). - stream reset. - list := OrderedCollection new. - [stream atEnd] whileFalse: [list add: stream nextLine]. self initializeMessageList: list. self changed: #messageList. self changed: #messageListIndex. ^result!

1 0

The Trunk: System-nice.513.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-nice.513.mcz ==================== Summary ==================== Name: System-nice.513 Author: nice Time: 24 February 2013, 6:29:23.564 pm UUID: 496d2bbf-34f3-43cf-9e2f-cae95c1d0604 Ancestors: System-dtl.512 Diminish excessive usage of ReadWriteStream. Bonus: correct outdated code sample in comment =============== Diff against System-dtl.512 =============== Item was changed: ----- Method: Utilities class>>createPageTestWorkspace (in category 'miscellaneous') ----- createPageTestWorkspace "Used to generate a workspace window for testing page up and page down stuff." "Utilities createPageTestWorkspace" | numberOfLines maxStringLength minLineCounterSize lineCounterSize offsetSize stream headerConstant prevStart prevStrLen prevLineNumber | numberOfLines := 400. maxStringLength := 22. minLineCounterSize := 3. lineCounterSize := (numberOfLines log asInteger + 1) max: minLineCounterSize. offsetSize := 5. + stream := String new writeStream. - stream := ReadWriteStream on: ''. headerConstant := lineCounterSize + 1 + offsetSize + 1. prevStart := headerConstant negated. prevStrLen := 0. prevLineNumber := 0. numberOfLines timesRepeat: [ | log stringLen pad lineNumber charIndex start | stringLen := maxStringLength atRandom max: 1. lineNumber := prevLineNumber + 1. start := prevStart + prevStrLen + headerConstant + 1. prevStart := start. prevStrLen := stringLen. prevLineNumber := lineNumber. log := lineNumber log asInteger. pad := lineCounterSize - log - 1. pad timesRepeat: [stream nextPutAll: '0']. stream nextPutAll: lineNumber printString. stream space. log := start log asInteger. pad := offsetSize - log - 1. pad timesRepeat: [stream nextPutAll: '0']. stream nextPutAll: start printString. stream space. charIndex := 'a' first asInteger. stringLen timesRepeat: [ | char | char := Character value: charIndex. charIndex := charIndex + 1. stream nextPut: char]. lineNumber = numberOfLines ifFalse: [stream cr] ]. UIManager default edit: stream contents label: 'Test Data'. ! Item was changed: ----- Method: Utilities class>>instanceComparisonsBetween:and: (in category 'miscellaneous') ----- instanceComparisonsBetween: fileName1 and: fileName2 "For differential results, run printSpaceAnalysis twice with different fileNames, then run this method... + SpaceTally new printSpaceAnalysis: 0 on: 'STspace.text1'. - Smalltalk printSpaceAnalysis: 0 on: 'STspace.text1'. --- do something that uses space here --- + SpaceTally new printSpaceAnalysis: 0 on: 'STspace.text2'. + Utilities instanceComparisonsBetween: 'STspace.text1' and: 'STspace.text2'" - Smalltalk printSpaceAnalysis: 0 on: 'STspace.text2'. - Smalltalk instanceComparisonsBetween: 'STspace.text1' and 'STspace.text2'" | instCountDict report f aString items className newInstCount oldInstCount newSpace oldPair oldSpace | instCountDict := Dictionary new. + report := String new writeStream. - report := ReadWriteStream on: ''. f := FileStream readOnlyFileNamed: fileName1. [f atEnd] whileFalse: [aString := f nextLine. items := aString findTokens: ' '. (items size = 4 or: [items size = 5]) ifTrue: [instCountDict at: items first put: (Array with: items third asNumber with: items fourth asNumber)]]. f close. f := FileStream readOnlyFileNamed: fileName2. [f atEnd] whileFalse: [aString := f nextLine. items := aString findTokens: ' '. (items size = 4 or: [items size = 5]) ifTrue: [className := items first. newInstCount := items third asNumber. newSpace := items fourth asNumber. oldPair := instCountDict at: className ifAbsent: [nil]. oldInstCount := oldPair ifNil: [0] ifNotNil: [oldPair first]. oldSpace := oldPair ifNil: [0] ifNotNil: [oldPair second]. oldInstCount ~= newInstCount ifTrue: [report nextPutAll: (newInstCount - oldInstCount) printString; tab; nextPutAll: (newSpace - oldSpace) printString; tab; nextPutAll: className asString; cr]]]. f close. (StringHolder new contents: report contents) openLabel: 'Instance count differentials between ', fileName1, ' and ', fileName2!

1 0

The Trunk: KernelTests-nice.246.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.246.mcz ==================== Summary ==================== Name: KernelTests-nice.246 Author: nice Time: 24 February 2013, 6:16:47.822 pm UUID: fbe78ded-66b1-4612-b609-6bda2e45e582 Ancestors: KernelTests-nice.245 Diminish excessive usage of ReadWriteStream =============== Diff against KernelTests-nice.245 =============== Item was changed: ----- Method: CompiledMethodTest>>testDecompile (in category 'tests - decompiling') ----- testDecompile "self debug: #testDecompileTree" | method cls stream | Smalltalk removeClassNamed: #TUTU. cls := Object subclass: #TUTU instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'KernelTests-Methods'. cls compile: 'foo ^ 10'. method := cls >> #foo. Smalltalk removeClassNamed: #TUTU. + stream := String new writeStream. - stream := ReadWriteStream on: String new. method decompile printOn: stream. self assert: stream contents = 'foo ^ 10' !

1 0

The Trunk: Kernel-nice.742.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.742.mcz ==================== Summary ==================== Name: Kernel-nice.742 Author: nice Time: 24 February 2013, 6:13:51.724 pm UUID: b2026116-be3c-4da6-a0af-0f223c9521a8 Ancestors: Kernel-nice.741 Diminish excessive usage of ReadWriteStream =============== Diff against Kernel-nice.741 =============== Item was changed: ----- Method: CompiledMethod>>symbolicLinesDo: (in category 'printing') ----- symbolicLinesDo: aBlock "Evaluate aBlock with each of the lines in the symbolic output." | aStream pc | + aStream := (String new: 64) writeStream. - aStream := ReadWriteStream on: (String new: 64). self isQuick ifTrue: [self longPrintOn: aStream. aBlock value: 0 value: aStream contents. ^self]. self primitive ~= 0 ifTrue: [self printPrimitiveOn: aStream. aBlock value: 1 value: aStream contents. aStream resetContents]. pc := self initialPC. (InstructionPrinter on: self) indent: 0; printPC: false; "explorer provides pc anyway" printInstructionsOn: aStream do: [:printer :scanner :stream| | line index | line := stream contents allButLast. (line includes: Character cr) ifTrue: [line := (line copyUpTo: Character cr), '...'' (continues)']. (index := line indexOf: $>) > 0 ifTrue: [[(line at: index + 1) isSeparator] whileTrue: [index := index + 1]. line := ((line copyFrom: 1 to: index) copyReplaceAll: (String with: Character tab) with: (String new: 8 withAll: Character space)), (line copyFrom: index + 1 to: line size)]. aBlock value: pc value: line. pc := scanner pc. stream resetContents]! Item was changed: ----- Method: Month class>>readFrom: (in category 'squeak protocol') ----- readFrom: aStream + | m y | + aStream skipSeparators. + m := aStream upToAnyOf: CharacterSet separators.. + aStream skipSeparators. + y := aStream upToEnd. - - | m y c | - m := (ReadWriteStream with: '') reset. - [(c := aStream next) isSeparator] whileFalse: [m nextPut: c]. - [(c := aStream next) isSeparator] whileTrue. - y := (ReadWriteStream with: '') reset. - y nextPut: c. - [aStream atEnd] whileFalse: [y nextPut: aStream next]. - ^ self + month: m + year: y asInteger - month: m contents - year: y contents asInteger "Month readFrom: 'July 1998' readStream"!

1 0

The Trunk: CollectionsTests-nice.198.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.198.mcz ==================== Summary ==================== Name: CollectionsTests-nice.198 Author: nice Time: 24 February 2013, 6:12:35.434 pm UUID: a4c370ec-5ddf-469a-aae4-1eb8c6d4fc02 Ancestors: CollectionsTests-fbs.197 Diminish excessive usage of ReadWriteStream =============== Diff against CollectionsTests-fbs.197 =============== Item was changed: ----- Method: CollectionTest>>testAsStringOnDelimiter (in category 'testing') ----- testAsStringOnDelimiter | delim | delim := ', '. {OrderedCollection new. Set new.} do: [ :coll | | oneItemStream emptyStream multiItemStream | + emptyStream := String new writeStream. - emptyStream := ReadWriteStream on: ''. coll asStringOn: emptyStream delimiter: delim. self assert: emptyStream contents = ''. coll add: 1. + oneItemStream := String new writeStream. - oneItemStream := ReadWriteStream on: ''. coll asStringOn: oneItemStream delimiter: delim. self assert: oneItemStream contents = '1'. coll add: 2; add: 3. + multiItemStream := String new writeStream. - multiItemStream := ReadWriteStream on: ''. coll asStringOn: multiItemStream delimiter: ', '. self assert: multiItemStream contents = '1, 2, 3'.]! Item was changed: ----- Method: CollectionTest>>testAsStringOnDelimiterLast (in category 'testing') ----- testAsStringOnDelimiterLast | delim last | delim := ', '. last := ' & '. {OrderedCollection new. Set new.} do: [ :coll | | multiItemStream emptyStream oneItemStream | + emptyStream := String new writeStream. - emptyStream := ReadWriteStream on: ''. coll asStringOn: emptyStream delimiter: delim last: last. self assert: emptyStream contents = ''. coll add: 1. + oneItemStream := String new writeStream. - oneItemStream := ReadWriteStream on: ''. coll asStringOn: oneItemStream delimiter: delim last: last. self assert: oneItemStream contents = '1'. coll add: 2; add: 3. + multiItemStream := String new writeStream. - multiItemStream := ReadWriteStream on: ''. coll asStringOn: multiItemStream delimiter: ', ' last: last. self assert: multiItemStream contents = '1, 2 & 3'.]! Item was changed: ----- Method: CollectionTest>>testPrintOnDelimiter (in category 'testing') ----- testPrintOnDelimiter | delim | delim := ', '. {OrderedCollection new. Set new.} do: [ :coll | | emptyStream oneItemStream multiItemStream | + emptyStream := String new writeStream. - emptyStream := ReadWriteStream on: ''. coll printOn: emptyStream delimiter: delim. self assert: emptyStream contents = ''. coll add: 1. + oneItemStream := String new writeStream. - oneItemStream := ReadWriteStream on: ''. coll printOn: oneItemStream delimiter: delim. self assert: oneItemStream contents = '1'. coll add: 2; add: 3. + multiItemStream := String new writeStream. - multiItemStream := ReadWriteStream on: ''. coll printOn: multiItemStream delimiter: ', '. self assert: multiItemStream contents = '1'', ''2'', ''3'.]! Item was changed: ----- Method: CollectionTest>>testPrintOnDelimiterLast (in category 'testing') ----- testPrintOnDelimiterLast | delim last | delim := ', '. last := ' & '. {OrderedCollection new. Set new.} do: [ :coll | | emptyStream oneItemStream multiItemStream | + emptyStream := String new writeStream. - emptyStream := ReadWriteStream on: ''. coll printOn: emptyStream delimiter: delim last: last. self assert: emptyStream contents = ''. coll add: 1. + oneItemStream := String new writeStream. - oneItemStream := ReadWriteStream on: ''. coll printOn: oneItemStream delimiter: delim last: last. self assert: oneItemStream contents = '1'. coll add: 2; add: 3. + multiItemStream := String new writeStream. - multiItemStream := ReadWriteStream on: ''. coll printOn: multiItemStream delimiter: ', ' last: last. self assert: multiItemStream contents = '1'', ''2'' & ''3'.]!

1 0

The Trunk: KernelTests-nice.245.mcz
by commits＠source.squeak.org 24 Feb '13

24 Feb '13

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.245.mcz ==================== Summary ==================== Name: KernelTests-nice.245 Author: nice Time: 24 February 2013, 5:34:23.518 pm UUID: 2a95d1b1-1e90-45e5-9b95-7f5e8a7cf92f Ancestors: KernelTests-nice.244 Reduce the number of hardcoded constants used by #raisedTo:modulo: tests too. =============== Diff against KernelTests-nice.244 =============== Item was changed: ----- Method: IntegerTest>>testMontgomeryMultiplication (in category 'testing - arithmetic') ----- testMontgomeryMultiplication | a m mInv | m := 15485863. + mInv := m montgomeryDigitBase - ((m bitAnd: m montgomeryDigitMax) reciprocalModulo: m montgomeryDigitBase). + a := (m montgomeryDigitBase raisedTo: m montgomeryNumberOfDigits) \\ m. - mInv := 256 - ((m bitAnd: 255) reciprocalModulo: 256). - a := (256 raisedTo: m digitLength) \\ m. #(483933 3871465 8951195) do: [:s | (s montgomeryTimes: a modulo: m mInvModB: mInv) ifNotNil: [:s1 | | s2 sa ssa | self assert: s = s1. sa := s montgomeryTimes: (a * a \\ m) modulo: m mInvModB: mInv. self assert: sa = (s * a \\ m). ssa := sa montgomeryTimes: sa modulo: m mInvModB: mInv. self assert: ssa = (s * s * a \\ m). s2 := ssa montgomeryTimes: 1 modulo: m mInvModB: mInv. self assert: s2 = (s * s \\ m)]].!

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
23
Older →

Jump to page: