Squeak-dev April 2013

squeak-dev@lists.squeakfoundation.org

66 participants
225 discussions

The Trunk: Installer-Core-fbs.367.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Frank Shearar uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-fbs.367.mcz ==================== Summary ==================== Name: Installer-Core-fbs.367 Author: fbs Time: 29 April 2013, 7:32:44.444 pm UUID: e0b1622a-d940-4f2f-a56c-5ed43a07d4c8 Ancestors: Installer-Core-fbs.366 Use #sorted:. =============== Diff against Installer-Core-fbs.366 =============== Item was changed: ----- Method: InstallerMonticello>>mcThing (in category 'monticello') ----- mcThing | loader | loader := self classMCVersionLoader new. "several attempts to read files - repository readableFileNames sometimes fails" self packages do: [:pkg | | versionNames fileToLoad version | versionNames := mc versionNamesForPackageNamed: (pkg asMCVersionName versionNumber = 0 ifTrue: [ "Just a package name specified, use it whole." pkg ] ifFalse: [pkg asMCVersionName packageName]). + versionNames sorted: self mcSortFileBlock. - versionNames asArray sort: self mcSortFileBlock. fileToLoad := versionNames detect: (self mcDetectFileBlock: pkg) ifNone: [ nil ]. fileToLoad ifNotNil: [version := mc versionNamed: fileToLoad. (version isKindOf: MCConfiguration) ifTrue: [^ version] ifFalse: [self normalizedRepositories do: [:repo | MCRepositoryGroup default addRepository: repo]. self normalizedRepositories do: [:repo | version workingCopy repositoryGroup addRepository: repo]. loader addVersion: version]. self logCR: ' found ' , version fileName , '...']]. ^ loader!

1 0

Re: [squeak-dev] The Trunk: Traits-cwp.293.mcz
by Colin Putney 29 Apr '13

29 Apr '13

On Mon, Apr 29, 2013 at 11:08 AM, <commits(a)source.squeak.org> wrote: > Colin Putney uploaded a new version of Traits to project The Trunk: > http://source.squeak.org/trunk/Traits-cwp.293.mcz > > ==================== Summary ==================== > > Name: Traits-cwp.293 > Author: cwp > Time: 29 April 2013, 11:07:42.535 am > UUID: f3c6cade-2e61-41c9-904d-9c77f00030a8 > Ancestors: Traits-cwp.292 > > When registering a Trait, catch and resume AttemptToWriteReadOnlyGlobal, > since there may already be a class binding. > > =============== Diff against Traits-cwp.292 =============== > This ought to fix the traits tests.

2 2

Daily Commit Log
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-April/005881.html Name: System-cwp.526 Ancestors: System-ul.525 Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler. =============================================

2 1

The Trunk: Traits-cwp.293.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Colin Putney uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-cwp.293.mcz ==================== Summary ==================== Name: Traits-cwp.293 Author: cwp Time: 29 April 2013, 11:07:42.535 am UUID: f3c6cade-2e61-41c9-904d-9c77f00030a8 Ancestors: Traits-cwp.292 When registering a Trait, catch and resume AttemptToWriteReadOnlyGlobal, since there may already be a class binding. =============== Diff against Traits-cwp.292 =============== Item was changed: ----- Method: Trait>>setName:andRegisterInCategory:environment: (in category 'initialize') ----- setName: aSymbol andRegisterInCategory: categorySymbol environment: aSystemDictionary (self isValidTraitName: aSymbol) ifFalse: [self error:'Invalid trait name']. (self environment == aSystemDictionary and: [self name = aSymbol and: [self category = categorySymbol]]) ifTrue: [^self]. ((aSystemDictionary includesKey: aSymbol) and: [(aSystemDictionary at: aSymbol) ~~ self]) ifTrue: [self error: 'The name ''' , aSymbol , ''' is already used']. (self environment notNil and: [self name notNil and: [self name ~= aSymbol]]) ifTrue: [ self environment renameClass: self as: aSymbol]. self name: aSymbol. self environment: aSystemDictionary. + [self environment at: self name put: self] + on: AttemptToWriteReadOnlyGlobal + do: [:n | n resume: true]. - self environment at: self name put: self. self environment organization classify: self name under: categorySymbol. ^ true!

1 0

Re: [squeak-dev] The Trunk: System-cwp.526.mcz
by Chris Muller 29 Apr '13

29 Apr '13

Do we need to put out a new alpha image with a recompileAll? On Sun, Apr 28, 2013 at 12:44 PM, <commits(a)source.squeak.org> wrote: > Colin Putney uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cwp.526.mcz > > ==================== Summary ==================== > > Name: System-cwp.526 > Author: cwp > Time: 28 April 2013, 10:43:06.298 am > UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c > Ancestors: System-ul.525 > > Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler. > > =============== Diff against System-ul.525 =============== > > Item was changed: > ----- Method: Behavior>>allCallsOn (in category '*System-Support') ----- > allCallsOn > "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict." > > | theClass | > theClass := self theNonMetaClass. > + ^(self systemNavigation allCallsOn: (self environment bindingOf: theClass name)), > - ^(self systemNavigation allCallsOn: (self environment associationAt: theClass name)), > (Preferences thoroughSenders > ifTrue: [OrderedCollection new] > ifFalse: [self systemNavigation allCallsOn: theClass name]), > (self systemNavigation allClasses > select: [:c| c sharedPools includes: theClass] > thenCollect: > [:c| > ClassReference new > setClassSymbol: c name > classIsMeta: false > stringVersion: c name])! > >

4 7

Re: [squeak-dev] The Trunk: Environments-cwp.25.mcz
by Frank Shearar 29 Apr '13

29 Apr '13

On 29 April 2013 07:58, <commits(a)source.squeak.org> wrote: > Colin Putney uploaded a new version of Environments to project The Trunk: > http://source.squeak.org/trunk/Environments-cwp.25.mcz > > ==================== Summary ==================== > > Name: Environments-cwp.25 > Author: cwp > Time: 28 April 2013, 11:56:36.28 pm > UUID: 0117c0ea-d81e-4eff-a6d6-afd791496d6d > Ancestors: Environments-cwp.24 > > Use aliases for classes imported with a different name, rather than copying the class binding. > > =============== Diff against Environments-cwp.24 =============== This or its predecessor break the Traits tests. For instance: http://build.squeak.org/job/SqueakTrunk/286/testReport/junit/TraitsTests.Ke… I suspect it's just a case of making something Trait-y use #bindingOf: or something? The tests seem to all fail for the same reason. frank

2 1

Re: [squeak-dev] The Trunk: Installer-Core-fbs.366.mcz
by Chris Muller 29 Apr '13

29 Apr '13

Well, I think the proper change may be to make all implementors of #versionNamesForPackageNamed: consistently returning the same thing. It looks like I originally made this method answer an Array since 2011 but, only when I recently added it to MCRepositoryGroup, made THAT ONE answer a Set. I failed to look at the others but instead "just thought about it". If the same version was in more than one repository we don't really need it multiple times. So what is the correct behavior? Perhaps answering a Set is the correct behavior afterall and the others should be changed too? On Mon, Apr 29, 2013 at 6:13 AM, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Installer-Core to project The Trunk: > http://source.squeak.org/trunk/Installer-Core-fbs.366.mcz > > ==================== Summary ==================== > > Name: Installer-Core-fbs.366 > Author: fbs > Time: 29 April 2013, 12:13:46.368 pm > UUID: a93fa0fc-2a93-405a-86df-7aa334ee214b > Ancestors: Installer-Core-fbs.365 > > versionNames is a Set nowadays, but we want to sort it. Hence, convert to an Array. > > =============== Diff against Installer-Core-fbs.365 =============== > > Item was changed: > ----- Method: InstallerMonticello>>mcThing (in category 'monticello') ----- > mcThing > | loader | > loader := self classMCVersionLoader new. > > "several attempts to read files - repository readableFileNames > sometimes fails" > self packages > do: [:pkg | > | versionNames fileToLoad version | > versionNames := mc versionNamesForPackageNamed: > (pkg asMCVersionName versionNumber = 0 > ifTrue: [ "Just a package name specified, use it whole." pkg ] > ifFalse: [pkg asMCVersionName packageName]). > + versionNames asArray sort: self mcSortFileBlock. > - versionNames sort: self mcSortFileBlock. > fileToLoad := versionNames > detect: (self mcDetectFileBlock: pkg) > ifNone: [ nil ]. > fileToLoad > ifNotNil: [version := mc versionNamed: fileToLoad. > (version isKindOf: MCConfiguration) > ifTrue: [^ version] > ifFalse: [self normalizedRepositories do: [:repo | > MCRepositoryGroup default addRepository: repo]. > self normalizedRepositories do: [:repo | > version workingCopy repositoryGroup addRepository: repo]. > loader addVersion: version]. > self logCR: ' found ' , version fileName , '...']]. > ^ loader! > >

2 1

Re: [squeak-dev] The Trunk: Installer-Core-fbs.366.mcz
by Bob Arning 29 Apr '13

29 Apr '13

Does this actually do anything useful? On 4/29/13 11:13 AM, commits(a)source.squeak.org wrote: > + versionNames asArray sort: self mcSortFileBlock. > - versionNames sort: self mcSortFileBlock.

2 1

Re: [squeak-dev] The Trunk: Installer-Core-fbs.366.mcz
by Frank Shearar 29 Apr '13

29 Apr '13

On 29 April 2013 12:13, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Installer-Core to project The Trunk: > http://source.squeak.org/trunk/Installer-Core-fbs.366.mcz > > ==================== Summary ==================== > > Name: Installer-Core-fbs.366 > Author: fbs > Time: 29 April 2013, 12:13:46.368 pm > UUID: a93fa0fc-2a93-405a-86df-7aa334ee214b > Ancestors: Installer-Core-fbs.365 > > versionNames is a Set nowadays, but we want to sort it. Hence, convert to an Array. > > =============== Diff against Installer-Core-fbs.365 =============== This will fix the ReleaseSqueakTrunk build. It _should_ have bailed (because it should have been using CommandLineToolSet). I'll find out why it didn't, and make it do so. frank

1 0

The Trunk: Installer-Core-fbs.366.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Frank Shearar uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-fbs.366.mcz ==================== Summary ==================== Name: Installer-Core-fbs.366 Author: fbs Time: 29 April 2013, 12:13:46.368 pm UUID: a93fa0fc-2a93-405a-86df-7aa334ee214b Ancestors: Installer-Core-fbs.365 versionNames is a Set nowadays, but we want to sort it. Hence, convert to an Array. =============== Diff against Installer-Core-fbs.365 =============== Item was changed: ----- Method: InstallerMonticello>>mcThing (in category 'monticello') ----- mcThing | loader | loader := self classMCVersionLoader new. "several attempts to read files - repository readableFileNames sometimes fails" self packages do: [:pkg | | versionNames fileToLoad version | versionNames := mc versionNamesForPackageNamed: (pkg asMCVersionName versionNumber = 0 ifTrue: [ "Just a package name specified, use it whole." pkg ] ifFalse: [pkg asMCVersionName packageName]). + versionNames asArray sort: self mcSortFileBlock. - versionNames sort: self mcSortFileBlock. fileToLoad := versionNames detect: (self mcDetectFileBlock: pkg) ifNone: [ nil ]. fileToLoad ifNotNil: [version := mc versionNamed: fileToLoad. (version isKindOf: MCConfiguration) ifTrue: [^ version] ifFalse: [self normalizedRepositories do: [:repo | MCRepositoryGroup default addRepository: repo]. self normalizedRepositories do: [:repo | version workingCopy repositoryGroup addRepository: repo]. loader addVersion: version]. self logCR: ' found ' , version fileName , '...']]. ^ loader!

1 0

← Newer
1
2
3
4
5
6
7
...
23
Older →

Jump to page: