Squeak-dev April 2013

squeak-dev@lists.squeakfoundation.org

66 participants
225 discussions

The Trunk: Compiler-nice.263.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Nicolas Cellier uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-nice.263.mcz ==================== Summary ==================== Name: Compiler-nice.263 Author: nice Time: 29 April 2013, 12:36:28.951 pm UUID: 766022c9-7e62-b341-ade2-351101bd8ba4 Ancestors: Compiler-eem.262 Revert the halt in Encoder>>litIndex: =============== Diff against Compiler-eem.262 =============== Item was changed: ----- Method: Encoder>>litIndex: (in category 'encoding') ----- litIndex: literal | p | - (literal isVariableBinding and: [literalStream originalContents identityIncludes: literal]) ifTrue: - [self halt]. p := literalStream position. p = 256 ifTrue: [self notify: 'More than 256 literals referenced. You must split or otherwise simplify this method. The 257th literal is: ', literal printString. ^nil]. "Would like to show where it is in the source code, but that info is hard to get." literalStream nextPut: literal. ^ p!

1 0

Integer>>hex8
by David T. Lewis 29 Apr '13

29 Apr '13

I would like to move Integer>>hex8 out of Kernel and back into VMMaker. It has no obvious use elsewhere, and is specific to 32-bit word sizes. Opinions? The method was moved into trunk here: Name: Kernel-eem.690 Author: eem Time: 20 May 2012, 11:45:51.817 am Add Integer>hex8. Arguablty this should be an extension in VMMaker, but since hex isn't, this isn't either (historical). Refactor CompiledMethodTrailer to allow subclasses to instantiate classes other than CompiledMethod. Add CompiledMethod>referredInstVars Thanks, Dave

2 1

The Trunk: Tests-cwp.202.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.202.mcz ==================== Summary ==================== Name: Tests-cwp.202 Author: cwp Time: 28 April 2013, 11:57:31.042 pm UUID: 30b3fc75-5af9-4c3f-ad99-351b35002d9a Ancestors: Tests-cwp.201 Use aliases for classes imported with a different name, rather than copying the class binding. =============== Diff against Tests-cwp.201 =============== Item was added: + ----- Method: ClassBindingTest>>testAsBindingAlias (in category 'as yet unclassified') ----- + testAsBindingAlias + | binding imported | + binding := ClassBinding key: #Griffle value: value. + imported := binding asBinding: #Plonk. + self assert: imported class == Alias! Item was added: + ----- Method: ClassBindingTest>>testAsBindingWrite (in category 'as yet unclassified') ----- + testAsBindingWrite + | binding imported | + binding := ClassBinding key: #Griffle value: value. + imported := binding asBinding: #Plonk. + self + should: [imported value: Object new] + raise: AttemptToWriteReadOnlyGlobal + !

1 0

The Trunk: Tests-cwp.201.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.201.mcz ==================== Summary ==================== Name: Tests-cwp.201 Author: cwp Time: 28 April 2013, 1:05:18.1 pm UUID: 04c1e394-6df1-4dd6-8eec-c7c9ef7b597a Ancestors: Tests-ul.200 Updated binding tests to ensure that binding identity is preserved whenever possible. =============== Diff against Tests-ul.200 =============== Item was added: + ----- Method: AliasTest>>testAsBindingOriginal (in category 'tests') ----- + testAsBindingOriginal + | alias imported original | + original := #Griffle => value. + alias := original asBinding: #Plonk. + imported := alias asBinding: #Griffle. + self assert: imported == original! Item was added: + ----- Method: ClassBindingTest>>testAsBindingOriginal (in category 'as yet unclassified') ----- + testAsBindingOriginal + | binding imported | + binding := ClassBinding key: #Griffle value: value. + imported := binding asBinding: #Griffle. + self assert: binding == imported! Item was changed: + ----- Method: GlobalTest>>testArrowBinding (in category 'tests') ----- - ----- Method: GlobalTest>>testArrowBinding (in category 'as yet unclassified') ----- testArrowBinding | binding | binding := #Griffle => value. self assert: binding class = Global. self assert: binding key = #Griffle. self assert: binding value == value! Item was added: + ----- Method: GlobalTest>>testAsBindingOriginal (in category 'tests') ----- + testAsBindingOriginal + | global imported | + global := Global key: #Griffle value: Object new. + imported := global asBinding: #Griffle. + self assert: imported == global! Item was changed: ----- Method: GlobalTest>>testAsBindingWrite (in category 'tests') ----- testAsBindingWrite | global imported | global := Global key: key value: Object new. imported := global asBinding: #Griffle. imported value: value. + self assert: global value == value. - self assert: imported value == value. ! Item was changed: + ----- Method: GlobalTest>>testLiteralEqual (in category 'tests') ----- - ----- Method: GlobalTest>>testLiteralEqual (in category 'as yet unclassified') ----- testLiteralEqual | global | global := #Griffle => value. self assert: (global literalEqual: global)! Item was changed: + ----- Method: GlobalTest>>testLiteralUnequal (in category 'tests') ----- - ----- Method: GlobalTest>>testLiteralUnequal (in category 'as yet unclassified') ----- testLiteralUnequal | g1 g2 | g1 := #Griffle => value. g2 := #Griffle => value. self deny: (g1 literalEqual: g2)!

1 0

The Trunk: Environments-cwp.25.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Colin Putney uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-cwp.25.mcz ==================== Summary ==================== Name: Environments-cwp.25 Author: cwp Time: 28 April 2013, 11:56:36.28 pm UUID: 0117c0ea-d81e-4eff-a6d6-afd791496d6d Ancestors: Environments-cwp.24 Use aliases for classes imported with a different name, rather than copying the class binding. =============== Diff against Environments-cwp.24 =============== Item was changed: ----- Method: ClassBinding>>asBinding: (in category 'as yet unclassified') ----- asBinding: aSymbol ^ aSymbol == key ifTrue: [self] + ifFalse: [Alias key: aSymbol source: self]! - ifFalse: [self class key: aSymbol value: value]! Item was changed: ----- Method: Environment>>forgetClass:logged: (in category 'classes and traits') ----- forgetClass: aClass logged: aBool aBool ifTrue: [SystemChangeNotifier uniqueInstance classRemoved: aClass fromCategory: aClass category]. self organization removeElement: aClass name. Smalltalk removeFromStartUpList: aClass. Smalltalk removeFromShutDownList: aClass. + + undeclared declare: aClass name from: contents. + imports forgetName: aClass name. exports forgetName: aClass name. contents removeKey: aClass name ifAbsent: []. + bindings removeKey: aClass name ifAbsent: []. + + [undeclared at: aClass name put: nil] + on: AttemptToWriteReadOnlyGlobal + do: [:n | n resume: true]. + ! - bindings removeKey: aClass name ifAbsent: [].! Item was added: + ----- Method: Environment>>recompileAll (in category 'operations') ----- + recompileAll + bindings removeAll. + self allClassesAndTraits + do: [:classOrTrait | classOrTrait compileAll] + displayingProgress:[:classOrTrait| 'Recompiling ', classOrTrait] + + + ! Item was changed: + ----- Method: Environment>>removeKey:ifAbsent: (in category 'emulating') ----- - ----- Method: Environment>>removeKey:ifAbsent: (in category 'accessing') ----- removeKey: key ifAbsent: aBlock self flag: #review. ^ contents removeKey: key ifAbsent: aBlock! Item was added: + ----- Method: EnvironmentInfo>>packages (in category 'as yet unclassified') ----- + packages + ^ packages!

1 0

The Trunk: Environments-cwp.24.mcz
by commits＠source.squeak.org 29 Apr '13

29 Apr '13

Colin Putney uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-cwp.24.mcz ==================== Summary ==================== Name: Environments-cwp.24 Author: cwp Time: 28 April 2013, 1:09:35.097 pm UUID: e8a1166a-a372-4122-a495-75b489b33fcb Ancestors: Environments-bf.23 Make #asBinding: preserve binding identity whenever possible. =============== Diff against Environments-bf.23 =============== Item was changed: ----- Method: Alias>>asBinding: (in category 'converting') ----- asBinding: aSymbol + ^ aSymbol = source key + ifTrue: [source] + ifFalse: [Alias key: aSymbol source: source]! - ^ Alias key: aSymbol source: source! Item was changed: ----- Method: Association>>asBinding: (in category '*environments') ----- asBinding: aSymbol + ^ aSymbol == key + ifTrue: [self] + ifFalse: [Alias key: aSymbol source: self]! - ^ Alias key: aSymbol source: self! Item was changed: ----- Method: ClassBinding>>asBinding: (in category 'as yet unclassified') ----- asBinding: aSymbol + ^ aSymbol == key + ifTrue: [self] + ifFalse: [self class key: aSymbol value: value]! - ^ self class key: aSymbol value: value! Item was changed: ----- Method: Global>>asBinding: (in category 'as yet unclassified') ----- asBinding: aSymbol + ^ aSymbol == key + ifTrue: [self] + ifFalse: [Alias key: aSymbol source: self]! - ^ Alias key: aSymbol source: self!

1 0

Re: [squeak-dev] The Trunk: System-cwp.526.mcz
by Chris Muller 29 Apr '13

29 Apr '13

Thanks but is it working for you? I'm still missing tons of references to Error when I browse for them. Also, I know you didn't change this but the ifTrue:ifFalse: blocks look backward for the Preferences thoroughSenders question in this method. On Sun, Apr 28, 2013 at 12:44 PM, <commits(a)source.squeak.org> wrote: > Colin Putney uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cwp.526.mcz > > ==================== Summary ==================== > > Name: System-cwp.526 > Author: cwp > Time: 28 April 2013, 10:43:06.298 am > UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c > Ancestors: System-ul.525 > > Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler. > > =============== Diff against System-ul.525 =============== > > Item was changed: > ----- Method: Behavior>>allCallsOn (in category '*System-Support') ----- > allCallsOn > "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict." > > | theClass | > theClass := self theNonMetaClass. > + ^(self systemNavigation allCallsOn: (self environment bindingOf: theClass name)), > - ^(self systemNavigation allCallsOn: (self environment associationAt: theClass name)), > (Preferences thoroughSenders > ifTrue: [OrderedCollection new] > ifFalse: [self systemNavigation allCallsOn: theClass name]), > (self systemNavigation allClasses > select: [:c| c sharedPools includes: theClass] > thenCollect: > [:c| > ClassReference new > setClassSymbol: c name > classIsMeta: false > stringVersion: c name])! > >

1 0

Re: [squeak-dev] The Trunk: System-cwp.526.mcz
by Frank Shearar 28 Apr '13

28 Apr '13

On 28 April 2013 18:44, <commits(a)source.squeak.org> wrote: > Colin Putney uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cwp.526.mcz > > ==================== Summary ==================== > > Name: System-cwp.526 > Author: cwp > Time: 28 April 2013, 10:43:06.298 am > UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c > Ancestors: System-ul.525 > > Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler. > > =============== Diff against System-ul.525 =============== Also, #bindingOf: is the right protocol to use; Colin's keen on moving Environments away from Dictionary's API. frank

1 0

Re: [squeak-dev] The Trunk: Tests-ul.200.mcz
by Nicolas Cellier 28 Apr '13

28 Apr '13

http://en.wikipedia.org/wiki/Schlemiel_the_Painter%27s_algorithm 2013/4/27 <commits(a)source.squeak.org> > Levente Uzonyi uploaded a new version of Tests to project The Trunk: > http://source.squeak.org/trunk/Tests-ul.200.mcz > > ==================== Summary ==================== > > Name: Tests-ul.200 > Author: ul > Time: 27 April 2013, 10:08:43.206 pm > UUID: dfe70287-0768-42f9-97b7-d7ba6fbd6bb6 > Ancestors: Tests-fbs.199 > > - avoid suboptimal string concatentation in ReleaseTest >> > #testMethodsWithUnboundGlobals > > =============== Diff against Tests-fbs.199 =============== > > Item was changed: > ----- Method: ReleaseTest>>testMethodsWithUnboundGlobals (in category > 'testing') ----- > testMethodsWithUnboundGlobals > | unbound | > unbound := SystemNavigation default methodsWithUnboundGlobals. > Smalltalk cleanOutUndeclared. > + self assert: unbound isEmpty description: 'Unbound: ', unbound > asCommaString! > - self assert: unbound isEmpty description: ('Unbound: ', (unbound > reduce: [:acc :each | acc, ', ', each]))! > > >

4 8

The Trunk: System-cwp.526.mcz
by commits＠source.squeak.org 28 Apr '13

28 Apr '13

Colin Putney uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cwp.526.mcz ==================== Summary ==================== Name: System-cwp.526 Author: cwp Time: 28 April 2013, 10:43:06.298 am UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c Ancestors: System-ul.525 Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler. =============== Diff against System-ul.525 =============== Item was changed: ----- Method: Behavior>>allCallsOn (in category '*System-Support') ----- allCallsOn "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict." | theClass | theClass := self theNonMetaClass. + ^(self systemNavigation allCallsOn: (self environment bindingOf: theClass name)), - ^(self systemNavigation allCallsOn: (self environment associationAt: theClass name)), (Preferences thoroughSenders ifTrue: [OrderedCollection new] ifFalse: [self systemNavigation allCallsOn: theClass name]), (self systemNavigation allClasses select: [:c| c sharedPools includes: theClass] thenCollect: [:c| ClassReference new setClassSymbol: c name classIsMeta: false stringVersion: c name])!

1 0

← Newer
1
2
3
4
5
6
7
8
...
23
Older →

Jump to page: