Frank Shearar uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-fbs.212.mcz
==================== Summary ====================
Name: Graphics-fbs.212
Author: fbs
Time: 3 June 2013, 11:06:29.054 pm
UUID: 15a251c4-586f-4e5c-bf18-151dd7a896db
Ancestors: Graphics-fbs.211
Prefer using UIManager default to the proxying Utilities class.
=============== Diff against Graphics-fbs.211 ===============
Item was changed:
----- Method: BDFFontReader class>>convertFilesNamed:toFamilyNamed:inDirectoryNamed: (in category 'file creation') -----
convertFilesNamed: fileName toFamilyNamed: familyName inDirectoryNamed: dirName
"BDFFontReader convertFilesNamed: 'helvR' toFamilyNamed: 'Helvetica' inDirectoryNamed: '' "
"This utility converts X11 BDF font files to Squeak .sf2 StrikeFont files."
"For this utility to work as is, the BDF files must be named 'familyNN.bdf',
and must reside in the directory named by dirName (use '' for the current directory).
The output StrikeFont files will be named familyNN.sf2, and will be placed in the
current directory."
| allFontNames dir |
"Check for matching file names."
dir := dirName isEmpty
ifTrue: [FileDirectory default]
ifFalse: [FileDirectory default directoryNamed: dirName].
allFontNames := dir fileNamesMatching: fileName , '##.bdf'.
allFontNames isEmpty ifTrue: [^ self error: 'No files found like ' , fileName , 'NN.bdf'].
+ UIManager default informUserDuring: [:info |
- Utilities informUserDuring: [:info |
allFontNames do: [:fname | | f sizeChars |
info value: 'Converting ', familyName, ' BDF file ', fname, ' to SF2 format'.
sizeChars := (fname copyFrom: fileName size + 1 to: fname size) copyUpTo: $. .
f := StrikeFont new readBDFFromFile: (dir fullNameFor: fname) name: familyName, sizeChars.
f writeAsStrike2named: familyName, sizeChars, '.sf2'.
].
]!
Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.54.mcz
==================== Summary ====================
Name: ToolBuilder-Kernel-fbs.54
Author: fbs
Time: 3 June 2013, 10:47:06.146 pm
UUID: 1cd75705-2c2b-4bb7-ba26-2b92ef427c88
Ancestors: ToolBuilder-Kernel-cwp.53
These methods ask the user for something. (As in, that's their primary purpose.) As such they belong in the same package as UIManager, ToolBuilder-Kernel.
(I don't see the value of these 'convenience' methods, but I suppose others do.)
=============== Diff against ToolBuilder-Kernel-cwp.53 ===============
Item was added:
+ ----- Method: Object>>confirm: (in category '*ToolBuilder-Kernel-error handling') -----
+ confirm: queryString
+ "Put up a yes/no menu with caption queryString. Answer true if the
+ response is yes, false if no. This is a modal question--the user must
+ respond yes or no."
+
+ "nil confirm: 'Are you hungry?'"
+
+ ^ UIManager default confirm: queryString!
Item was added:
+ ----- Method: Object>>confirm:orCancel: (in category '*ToolBuilder-Kernel-error handling') -----
+ confirm: aString orCancel: cancelBlock
+ "Put up a yes/no/cancel menu with caption aString. Answer true if
+ the response is yes, false if no. If cancel is chosen, evaluate
+ cancelBlock. This is a modal question--the user must respond yes or no."
+
+ ^ UIManager default confirm: aString orCancel: cancelBlock!
Item was added:
+ ----- Method: Object>>inform: (in category '*ToolBuilder-Kernel-user interface') -----
+ inform: aString
+ "Display a message for the user to read and then dismiss. 6/9/96 sw"
+
+ aString isEmptyOrNil ifFalse: [UIManager default inform: aString]!
Frank Shearar uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-fbs.768.mcz
==================== Summary ====================
Name: Kernel-fbs.768
Author: fbs
Time: 3 June 2013, 10:46:25.818 pm
UUID: b90884d6-3fbb-42ed-a13c-f04ed880c02e
Ancestors: Kernel-fbs.767
These methods ask the user for something. (As in, that's their primary purpose.) As such they belong in the same package as UIManager, ToolBuilder-Kernel.
(I don't see the value of these 'convenience' methods, but I suppose others do.)
=============== Diff against Kernel-fbs.767 ===============
Item was removed:
- ----- Method: Object>>confirm: (in category 'error handling') -----
- confirm: queryString
- "Put up a yes/no menu with caption queryString. Answer true if the
- response is yes, false if no. This is a modal question--the user must
- respond yes or no."
-
- "nil confirm: 'Are you hungry?'"
-
- ^ UIManager default confirm: queryString!
Item was removed:
- ----- Method: Object>>confirm:orCancel: (in category 'error handling') -----
- confirm: aString orCancel: cancelBlock
- "Put up a yes/no/cancel menu with caption aString. Answer true if
- the response is yes, false if no. If cancel is chosen, evaluate
- cancelBlock. This is a modal question--the user must respond yes or no."
-
- ^ UIManager default confirm: aString orCancel: cancelBlock!
Item was removed:
- ----- Method: Object>>inform: (in category 'user interface') -----
- inform: aString
- "Display a message for the user to read and then dismiss. 6/9/96 sw"
-
- aString isEmptyOrNil ifFalse: [UIManager default inform: aString]!
On 2013-06-01, at 22:20, commits(a)source.squeak.org wrote:
> Frank Shearar uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-fbs.655.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-fbs.655
> Author: fbs
> Time: 1 June 2013, 11:19:58.083 pm
> UUID: b2ebeb75-74c9-4909-b81c-8eb82350599a
> Ancestors: Morphic-fbs.654
>
> Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support.
>
> =============== Diff against Morphic-fbs.653 ===============
>
> Item was added:
> + ----- Method: MailComposition>>addAttachment (in category '*Morphic-Support') -----
> + addAttachment
> + | file fileResult fileName |
> + textEditor
> + ifNotNil: [self hasUnacceptedEdits ifTrue: [textEditor accept]].
> +
> + (fileResult := StandardFileMenu oldFile)
> + ifNotNil:
> + [fileName := fileResult directory fullNameFor: fileResult name.
> + file := FileStream readOnlyFileNamed: fileName.
> + file ifNotNil:
> + [file binary.
> + self messageText:
> + ((MailMessage from: self messageText asString)
> + addAttachmentFrom: file withName: fileResult name; text).
> + file close]] !
Is that a good enough reason to make this an extension method? Just because the only current sender is an outside package doesn't necessarily mean it belongs to that package, does it? It seems innocuous to me, but it's quite possible I'm overlooking something.
- Bert -
On Sun, 2 Jun 2013, commits(a)source.squeak.org wrote:
> Frank Shearar uploaded a new version of Graphics to project The Trunk:
> http://source.squeak.org/trunk/Graphics-fbs.211.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-fbs.211
> Author: fbs
> Time: 2 June 2013, 7:05:25.648 pm
> UUID: 65a2ecea-af2e-42cd-b61e-aece057c0e7b
> Ancestors: Graphics-fbs.210
>
> Form >> #stencil and Pen >> #putDotOfDiameter:at: are only called from EToys code, so they belong in EToys.
I don't see what Form >> #stencil has to do with EToys. It's a general
purpose method to create a stencil from a form. :)
Levente
>
> =============== Diff against Graphics-fbs.210 ===============
>
> Item was removed:
> - ----- Method: Form>>stencil (in category 'image manipulation') -----
> - stencil
> - "return a 1-bit deep, black-and-white stencil of myself"
> -
> - | canvas |
> - canvas := FormCanvas extent: self extent depth: 1.
> - canvas fillColor: (Color white).
> -
> - canvas stencil: self at: 0@0
> - sourceRect: (Rectangle origin: 0@0 corner: self extent) color: Color black.
> -
> - ^ canvas form
> - !
>
> Item was removed:
> - ----- Method: Pen>>putDotOfDiameter:at: (in category 'operations') -----
> - putDotOfDiameter: aDiameter at: aPoint
> - "Put a dot of the given size at the given point, using my colot"
> -
> - (FormCanvas on: destForm)
> - fillOval: (Rectangle center: aPoint extent: (aDiameter @ aDiameter))
> - color: self color!
>
>
>