Squeak-dev November 2015

squeak-dev@lists.squeakfoundation.org

40 participants
251 discussions

The Trunk: Tools-kfr.656.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

Karl Ramberg uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-kfr.656.mcz ==================== Summary ==================== Name: Tools-kfr.656 Author: kfr Time: 23 November 2015, 11:34:24.394 pm UUID: 0ece22f7-03af-4926-b071-bbb3dec38d64 Ancestors: Tools-kfr.655 Might as well get the comment right on this one.... =============== Diff against Tools-kfr.655 =============== Item was changed: ----- Method: Browser>>browseAllCommentsForClass (in category 'message functions') ----- browseAllCommentsForClass + "Opens a HelpBrowser on the class" - "Inspect all instances of the selected class. 1/26/96 sw" | myClass | ((myClass := self selectedClassOrMetaClass) isNil or: [myClass isTrait]) ifFalse: [HelpBrowser openOn: myClass theNonMetaClass] !

1 0

The Trunk: Tools-kfr.655.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

Karl Ramberg uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-kfr.655.mcz ==================== Summary ==================== Name: Tools-kfr.655 Author: kfr Time: 23 November 2015, 11:28:19.779 pm UUID: 80343420-2d7b-43dc-aea0-11e528a51ed0 Ancestors: Tools-mt.654 Adds menu item for class pane to open a HeloBrowser for selected class. =============== Diff against Tools-mt.654 =============== Item was added: + ----- Method: Browser>>browseAllCommentsForClass (in category 'message functions') ----- + browseAllCommentsForClass + "Inspect all instances of the selected class. 1/26/96 sw" + + | myClass | + ((myClass := self selectedClassOrMetaClass) isNil or: [myClass isTrait]) + ifFalse: [HelpBrowser openOn: myClass theNonMetaClass] + ! Item was changed: ----- Method: Browser>>classListMenu: (in category 'class functions') ----- classListMenu: aMenu "Conveniently fit for backward compatibility with old browers stored in image segments" <classListMenuShifted: false> aMenu addList: #( - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' spawnHierarchy) ('browse protocol (p)' browseFullProtocol) - ('printOut' printOutClass) ('fileOut' fileOutClass) - ('show hierarchy' hierarchy) ('show definition' editClass) ('show comment' editComment) + ('show all comments' browseAllCommentsForClass) - ('references... (r)' browseVariableReferences) ('assignments... (a)' browseVariableAssignments) ('class refs (N)' browseClassRefs) - ('rename class ...' renameClass) ('copy class' copyClass) ('remove class (x)' removeClass) - ('find method...' findMethod)). ^ aMenu !

1 0

Re: [squeak-dev] The Inbox: Traits-pre.307.mcz
by karl ramberg 23 Nov '15

23 Nov '15

On Mon, Nov 23, 2015 at 10:07 PM, tim Rowledge <tim(a)rowledge.org> wrote: > Doing anything big is a pain, even if you’re being paid to do it, have > assigned colleagues that you can direct, and know what you’re doing. Most > companies fail miserably at it. > > In an open source project you add an entire galaxy of extra pain. Herding > cats doesn’t even begin to cover it; if you have a decent group of fans of > your idea(s) you still face the problems of lack of time, other interests, > arguments and on and on. It is a perfect example why the fantasy of ‘the > free market will solve everything!’ is so fatuous. > > Traits; I liked the idea, as I said. But I’ve never felt the lack of them, > nor worked on anything where I thought “hhmm, a trait would be useful here” > and with no support in any tools nor easily accessible documentation that > might lead me to a fuller appreciation etc... forget it. The only response > we’ve had to offer any idea why we ought to care was Marcel saying he > found them a bit useful for documenting something. That isn’t exactly a > ringing endorsement. > > There is a modestly informative page on the swiki at > http://wiki.squeak.org/squeak/538 but it dates back to 2006! The > commentary in-image is dismal (as is pretty standard, to our disgrace) and > offers nothing I can spot that could encourage me to use them, let alone > any pointers on how. There’s nothing I can see to indicate Traits actually > being used in-image so there’s nothing that makes me think it worth digging > further. The only Trait stuff I can find is in fact in the > 311Deprecated-Traits category. 3.11 was quite a while ago. Oh, wait, there > is a set of tests that might explain something *if they were damn well > documented* > Never used traits either. > > Islands; I can’t find anything about them. The swiki has a few pages of > approximately 0 information content. In fact it doesn’t seem like they’re > even in the image, so I have no idea. > Not used this. > > Environments: I like the idea of namespaces that help avoid > class/ivar/message name clashes. I don’t see any info to help me make use > of them, or when it might be useful, or how to find them. I see very few > comments in code, virtually none for classes, nothing in the tests. Haven’t > been able to spot any swiki info either. > I have looked at the code, but not really understood it. > > Universes; I can’t even see enough info to gain an idea of what they’re > for! The only bit I spotted points to stuff on a server that no longer > exists and probably hasn’t since ’06. > Universes was a SquakMap kind of tool, but since there is no server running, it's pretty useless. > > The software world in general seems to be useless at this; we’re nothing > special. There are people out there that think running some parser over a > tree of text files and extracting function comments is an adequate way to > create a manual! There are others that will claim that the ‘code is self > documenting’ which really ought to be a capital crime. > You can always doIt HelpBrowser openOn: aClass which will bring up all class and method comments for that class. By the way, that should be added to the browser class pane menu... Best, Karl > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Useful Latin Phrases:- Nullo metro compositum est = It doesn't rhyme. > > > >

1 0

The Inbox: MorphicExtras-tpr.166.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

tim Rowledge uploaded a new version of MorphicExtras to project The Inbox: http://source.squeak.org/inbox/MorphicExtras-tpr.166.mcz ==================== Summary ==================== Name: MorphicExtras-tpr.166 Author: tpr Time: 23 November 2015, 11:34:44.792 am UUID: ec623673-dea1-40f9-a046-7bb0791cdb06 Ancestors: MorphicExtras-cmm.164, MorphicExtras-kfr.165 Handle the SoundRecorder Warning exception in EventRecordingmorph and RecordingControlsMorph to notify the user. Note that BaseSoundSystem>>#randomBitsFromSoundInput: is not altered - the best I can think of is to let the debugger warning get raised here since it isn't a UI item. It may be better to handel the exceptio to either do nothing (so there will be bad random numbers) or delgate to some other randomiser. =============== Diff against MorphicExtras-cmm.164 =============== Item was changed: ----- Method: EventRecorderMorph>>resumeRecordIn: (in category 'pause/resume') ----- resumeRecordIn: aWorld recHand := aWorld activeHand ifNil: [aWorld primaryHand]. recHand newKeyboardFocus: aWorld. recHand addEventListener: self. lastEvent := nil. state := #record. voiceRecorder ifNotNil: [voiceRecorder clearRecordedSound. + [voiceRecorder resumeRecording] on: Warning do:[:ex| + self inform: ex tag "NB - it may be better to simply ignore this; all that would happen is nothing gets recorded"]. - voiceRecorder resumeRecording. startSoundEvent := MorphicUnknownEvent new setType: #startSound argument: nil hand: nil stamp: Time millisecondClockValue. tapeStream nextPut: startSoundEvent]. self synchronize. ! Item was changed: ----- Method: RecordingControlsMorph>>record (in category 'button commands') ----- record recorder clearRecordedSound. + [recorder resumeRecording] on: Warning do:[:ex| + self inform: ex tag] - recorder resumeRecording. ! Item was removed: - ----- Method: ReferenceMorph>>handlesMouseMove: (in category 'event handling') ----- - handlesMouseMove: anEvent - ^true! Item was changed: BookMorph subclass: #StoryboardBookMorph instanceVariableNames: 'alansSliders panAndTiltFactor zoomFactor zoomController' classVariableNames: '' poolDictionaries: '' category: 'MorphicExtras-Books'! + !StoryboardBookMorph commentStamp: 'kfr 5/17/2015 23:37' prior: 0! + A BookMorph variant whose pages are instances of ZoomAndScrollMorph. + I have a control area where the user may pan, tilt and zoom over the image shown in the page. - !StoryboardBookMorph commentStamp: '<historical>' prior: 0! - A BookMorph variant whose pages are instances of ZoomAndScrollMorph. I have a control area where the user may pan, tilt and zoom over the image shown in the page. + StoryboardBookMorph new openInWorld + + Drop an picture at the book. + + Mouse + - drag up and down to tilt - - drag up and down to zoom in and out - drag left and right to pan + - shift-drag up and down to zoom in and out + + Keyboard + Arrow keys pan and tilts the image + X and Z zoom in and out + + From top left in control panel you pull out stills from diffrent zoom, tilt and pan posititons. + Drop these after eachother to make an animation script. + The numbers between the stills are playback speed, that can be edited. + Save script from the scripts halo menu. + + Playback script from controll panels halo menu. + + ! - - shift-drag up and down to tilt.! Item was changed: ----- Method: StoryboardBookMorph>>initialize (in category 'initialization') ----- initialize + newPagePrototype := ZoomAndScrollMorph new extent: 300@300. - newPagePrototype := ZoomAndScrollMorph new extent: Display extent // 3. zoomController := ZoomAndScrollControllerMorph new + setBalloonText: 'Drag in here to zoom, tilt and pan the page above'; + extent: 246@147. - setBalloonText: 'Drag in here to zoom, tilt and pan the page above'. super initialize. + zoomController openInWorld. + + "tool := RectangleMorph new extent: 250@170; layoutPolicy: TableLayout new. + tool addMorph: zoomController. - self addMorphBack: zoomController. - alansSliders := { {#changeTiltFactor: . #getTiltFactor . 'Pan and tilt sensitivity'}. {#changeZoomFactor: . #getZoomFactor . 'Zoom sensitivity'}. } collect: [ :sData | { SimpleSliderMorph new extent: 150@10; color: Color orange; sliderColor: Color gray; target: self; actionSelector: sData first; setBalloonText: sData third; adjustToValue: (self perform: sData second). sData second } ]. + alansSliders do: [ :each | tool addMorphBack: each first]. + tool openInWorld" - alansSliders do: [ :each | self addMorphBack: each first] ! Item was changed: ----- Method: ZoomAndScrollControllerMorph>>changeKeys (in category 'as yet unclassified') ----- changeKeys upDownCodes := Dictionary new. + changeKeysState := #(up down left right in out). - changeKeysState := #(up down in out). self changed.! Item was changed: ----- Method: ZoomAndScrollControllerMorph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" | displayer dataMorph | super initialize. "" hasFocus := true. currentKeyDown := Set new. upDownCodes := Dictionary new. + upDownCodes at: 31 put: #up; "arrow keys" + at: 30 put: #down; + at: 29 put: #left; + at: 28 put: #right; + at: 88 put:#in; "x" + at: 90 put:#out. "y" + - upDownCodes at: 126 put: #up; - at: 125 put: #down; - at: 123 put: #out; - at: 124 put: #in. - "arrow keys on the mac" self extent: 40 @ 40; vResizing: #rigid; hResizing: #spaceFill; setBalloonText: 'Drag in here to zoom, tilt and pan the page above'. dataMorph := AlignmentMorph newColumn. dataMorph color: Color yellow; hResizing: #shrinkWrap; vResizing: #shrinkWrap. dataMorph on: #mouseDown send: #grabCameraPositionEvent:morph: to: self. displayer := UpdatingStringMorph new getSelector: #cameraPointRounded; target: self; growable: true; putSelector: nil. dataMorph addMorph: displayer lock. displayer := UpdatingStringMorph new getSelector: #cameraScale; target: self; growable: true; floatPrecision: 0.001; putSelector: nil. dataMorph addMorph: displayer lock. self addMorph: dataMorph! Item was changed: ----- Method: ZoomAndScrollControllerMorph>>step (in category 'stepping and presenter') ----- step + | delta halfDW shift | + shift := false. - | delta halfDW | - (self valueOfProperty: #currentCameraVersion ifAbsent: [0]) = self currentCameraVersion ifFalse: [ self patchOldVersion1. self setProperty: #currentCameraVersion toValue: self currentCameraVersion. ]. super step. self doProgrammedMoves. + (currentKeyDown ifNil: [#()]) do: [ :each | | action | + action := upDownCodes at: each ifAbsent: [shift := true]. - (currentKeyDown ifNil: [#()]) do: [ :each | | action | - action := upDownCodes at: each ifAbsent: [#fugeddaboutit]. action == #in ifTrue: [ target scaleImageBy: -10. ]. action == #out ifTrue: [ target scaleImageBy: 10. ]. action == #up ifTrue: [ + target panImageBy: 0@ -20. - target tiltImageBy: -20. ]. action == #down ifTrue: [ + target panImageBy: 0@20. - target tiltImageBy: 20. ]. + action == #left ifTrue: [ + target panImageBy: -20@0. + ]. + action == #right ifTrue: [ + target panImageBy: 20@0. + ]. ]. mouseMovePoint ifNil: [^self]. mouseDownPoint ifNil: [^self]. target ifNil: [^self]. halfDW := self deadZoneWidth // 2. + halfDW := self deadZoneWidth // 2. delta := mouseMovePoint - mouseDownPoint. delta x abs <= halfDW ifTrue: [delta := 0@delta y]. delta y abs <= halfDW ifTrue: [delta := delta x@0]. + shift ifTrue:[^target scaleImageBy: delta x]. + target panImageBy: delta x @ delta y - - target panImageBy: delta x. ! Item was changed: ----- Method: ZoomAndScrollMorph>>panImageBy: (in category 'as yet unclassified') ----- panImageBy: pixels + self changeOffsetBy: (pixels x* self getTiltFactor * 0.1) @ (pixels y* self getTiltFactor * 0.1) - self changeOffsetBy: (pixels * self getTiltFactor * 0.1) @ 0. "steps := (pixels abs / 6) exp rounded * pixels sign." "==Alan's preferred factors pan = 0.0425531914893617 zoom = 0.099290780141844 ===" ! Item was removed: - ----- Method: ZoomAndScrollMorph>>tiltImageBy: (in category 'as yet unclassified') ----- - tiltImageBy: pixels - - self changeOffsetBy: 0 @ (pixels * self getTiltFactor * 0.1) - - " steps := (pixels abs / 6) exp rounded * pixels sign. - " - "==Alan's preferred factors - pan = 0.0425531914893617 - zoom = 0.099290780141844 - ===" - !

1 0

The Inbox: Nebraska-tpr.42.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

tim Rowledge uploaded a new version of Nebraska to project The Inbox: http://source.squeak.org/inbox/Nebraska-tpr.42.mcz ==================== Summary ==================== Name: Nebraska-tpr.42 Author: tpr Time: 23 November 2015, 11:28:38.815 am UUID: fa28a253-e88a-4641-a22d-3569a99e0262 Ancestors: Nebraska-kfr.41 An accompanying change to the Sound-tpr.45 changes; catch the Warning exception in ChatNotes to inform the user =============== Diff against Nebraska-kfr.41 =============== Item was changed: ----- Method: ChatNotes>>record (in category 'button commands') ----- record self isRecording: true. notesIndex = 0 ifFalse: [self notesListIndex: 0]. sound := nil. recorder clearRecordedSound. + [recorder resumeRecording] on: Warning do:[:ex| + self inform: ex tag]! - recorder resumeRecording.!

1 0

Key Decode Table
by marcel.taeumel 23 Nov '15

23 Nov '15

Hi, there is a filter for keyDown events for CTRL combinations in InputSensor class >> #installDuplicateKeyEntryFor: c | key | key := c asInteger. "first do control->alt key" KeyDecodeTable at: { key bitAnd: 16r9F . 2 } put: { key . 8 }. "then alt->alt key" KeyDecodeTable at: { key . 8 } put: { key . 8 } That "bitAnd: 16r9F" is the reason why there are still keyDowns for, e.g., CTRL+1. Should we get rid of that #bitAnd: and remove all #controlKeyPressed calls from the base system? That mixture is really confusing at the moment... Opinions? Ideas? For the sake of cross-platform compatibility, there are onyl the following keyboard shortcuts: CMD+<something> CMD+SHIFT+<something> SHIFT+<something> I know that there are modern Mac keyboard that have 8 modifiers (left/right ctrl, left/right shift, left/right alt, left/right command). However, many shortcuts get eaten by the operating system. That's why key duplication makes sense: Hit Ctrl+Q to complete the symbol in a text field because CMD+Q will close the VM. In Squeak, CMD+Q is assigned to this feature. Best, Marcel -- View this message in context: http://forum.world.st/Key-Decode-Table-tp4862698.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

ctrl-J and type in
by Eliot Miranda 23 Nov '15

23 Nov '15

Hi Marcel, I like the new Ctrl-J. But there's one feature that was lost. It used to be that one could type over some string and then hit Ctrl-J to repeat the dir on the next occurrence of the string. For examplee, consider the following: [JumpZero] -> [opcode caseOf: { [CmpRR] -> [branch setOpcode: BrEqRR andOperandsFrom: self. branch operands at: 3 put: (operands at: 1). opcode := Label]. }]. [JumpNonZero]-> [opcode caseOf: { [CmpRR] -> [branch setOpcode: BrNeRR andOperandsFrom: self. branch operands at: 3 put: (operands at: 1). opcode := Label]. }]. [JumpLongZero]-> [opcode caseOf: { [CmpRR] -> [branch setOpcode: BrNeRR andOperandsFrom: self. "skip the following long branch" branch operands at: 3 put: self jumpLongByteSize. opcode := JumpLong]. }]. [JumpLongNonZero]-> [opcode caseOf: { [CmpRR] -> [branch setOpcode: BrEqRR andOperandsFrom: self. "skip the following long branch" branch operands at: 3 put: self jumpLongByteSize. opcode := JumpLong]. opcode := Label]. }]. where it turns out branch operands at: 3 should read branch operands at: 2. So it used to be that one could select the first "at: 3", type "at: 2", and then hit Ctrl-J to edit the next, Ctrl-J to edit the one after that and so on. I think it's just making sure that the selection that is replaced by Ctrl-J becomes the new search string for copy/replace. _,,,^..^,,,_ best, Eliot

3 4

The Trunk: Help-Squeak-Project-cmm.34.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

Chris Muller uploaded a new version of Help-Squeak-Project to project The Trunk: http://source.squeak.org/trunk/Help-Squeak-Project-cmm.34.mcz ==================== Summary ==================== Name: Help-Squeak-Project-cmm.34 Author: cmm Time: 22 November 2015, 10:38:43.067 pm UUID: 0187686e-7a36-466f-8c00-aae97ddb6ce3 Ancestors: Help-Squeak-Project-mt.33 - Document recently added Redo function. - Clarify and correct the toggle enclosure function. =============== Diff against Help-Squeak-Project-mt.33 =============== Item was changed: ----- Method: SqueakTutorialsCommandKey class>>commandKeyMappings (in category 'as yet unclassified') ----- commandKeyMappings "This method was automatically generated. Edit it using:" "SqueakTutorialsCommandKey edit: #commandKeyMappings" ^HelpTopic title: 'Command Key Mappings' contents: 'Lower-case command keys (use with Cmd key on Mac and Alt key on other platforms) a Select all b Browse it (selection is a class name or cursor is over a class-list or message-list) c Copy selection d Do it (selection is a valid expression) e Exchange selection with prior selection f Find text with a dialog g Find the current selection again j Repeat the last selection replacement i Inspect it k Set font l Cancel text edit m Implementors of it n Senders of it o Spawn current method p Print it (selection is a valid expression) q Query symbol (toggle all possible completion for a given prefix) s Save (i.e. accept) t Finds a Transcript (when cursor is over the desktop) u Toggle alignment v Paste w Select/Delete preceding word (over text); Close-window (over morphic desktop) x Cut selection y Swap characters z Undo Note: for Do it, Senders of it, etc., a null selection will be expanded to a word or to the current line in an attempt to do what you want. Also note that Senders/Implementors of it will find the outermost keyword selector in a large selection, as when you have selected a bracketed expression or an entire line. Finally note that the same cmd-m and cmd-n (and cmd-v for versions) work in the message pane of most browsers. Upper-case command keys (use with Shift-Cmd, or Ctrl on Mac or Shift-Alt on other platforms; sometimes Ctrl works too) A Advance argument B Browse it in this same browser (in System browsers only) C Compare the selected text to the clipboard contents D Debug-It E Method strings containing it F Insert ''ifFalse:'' G fileIn from it (a file name) H cursor TopHome: I Inspect via Object Explorer J Again many (apply the previous text command repeatedly until the end of the text) K Set style L Outdent (move selection one tab-stop left) M Select current type-in N References to it (selection is a class name, or cursor is over a class-list or message-list) O Open single-message browser (in message lists) P Make project link R Indent (move selection one tab-stap right) S Search T Insert ''ifTrue:'' U Convert linefeeds to carriage returns in selection V Paste author''s initials W Selectors containing it (in text); show-world-menu (when issued with cursor over desktop) X Force selection to lowercase Y Force selection to uppercase + Z Redo Other special keys Backspace Backward delete character Shift-Bksp Backward select or delete word Del Forward delete character Shift-Del Forward delete word Esc Pop up the context menu Shift+Esc Pop up the World Menu Cmd+Esc Close the active window Ctrl+Esc Present a list of open windows \ Send the active window to the back Cursor keys left, right, up, down Move cursor left, right, up or down Ctrl-left Move cursor left one word Ctrl-right Move cursor right one word Home Move cursor to begin of line or begin of text End Move cursor to end of line or end of text PgUp, Ctrl-up Move cursor up one page PgDown, Ctrl-Dn Move cursor down one page Note all these keys can be used together with Shift to define or enlarge the selection. You cannot however shrink that selection again, as in some other systems. Other Cmd-key combinations (not available on all platforms) Return Insert return followed by as many tabs as the previous line (with a further adjustment for additional brackets in that line) Space Select the current word as with double clicking Enclose the selection in a kind of bracket. Each is a toggle. (not available on all platforms) Ctrl-( Toggle enclosure within parentheses + Cmd-[ Toggle enclosure within brackets + Crtl-{ Toggle enclosure within curly braces - Ctrl-[ Toggle enclosure within brackets - Crtl-{ Toggle enclosre within curly braces - Ctrl-< Toggle enclosre within less-than / greater-than (HTML) Ctrl-'' Toggle enclosure within double-quotes + Cmd-'' Toggle enclosure within single-quotes - Ctrl-'' Toggle encllosure within single-quotes + Note also that you can double-click just inside any of the above delimiters, or at the beginning or end of a line, to select the text enclosed. - Note also that you can double-click just inside any of the above delimiters, - or at the beginning or end of a line, to select the text enclosed. Text Emphasis (not available on all platforms) Cmd-1 type the first method argument Cmd-2 type the second method argument Cmd-3 type the third method argument Cmd-4 type the fourth method argument Cmd-5 for future use Cmd-6 color, action-on-click, link to class comment, link to method, url Brings up a menu. To remove these properties, select more than the active part and then use command-0. Cmd-7 bold Cmd-8 italic Cmd-9 narrow (same as negative kern) Cmd-0 plain text (resets all emphasis) Cmd-- underlined (toggles it) Cmd-= struck out (toggles it) Shift-Cmd-- (aka :=) negative kern (letters 1 pixel closer) Shift-Cmd-+ positive kern (letters 1 pixel larger spread) Docking Bar Ctrl-<n> opens the n-th (where n is between 0 and 7) menu if such exists, otherwise it moves the keyboard focus to the Search Bar. Currently this means: + Ctrl-0 Activates Search Bar or Scratch Pad - Ctrl-0 Activates Search Bar Ctrl-1 Squeak menu Ctrl-2 Projects menu Ctrl-3 Tools menu Ctrl-4 Apps menu Ctrl-5 Extras menu Ctrl-6 Windows menu Ctrl-7 Help menu !!' readStream nextChunkText!

1 0

Re: [squeak-dev] The Inbox: Sound-tpr.45.mcz
by tim Rowledge 23 Nov '15

23 Nov '15

> On 22-11-2015, at 11:08 PM, commits(a)source.squeak.org wrote: > > tim Rowledge uploaded a new version of Sound to project The Inbox: > http://source.squeak.org/inbox/Sound-tpr.45.mcz > > ==================== Summary ==================== > > Name: Sound-tpr.45 > Author: tpr > Time: 22 November 2015, 3:08:45.33 pm > UUID: 47fd8f98-1a2b-4724-95cc-6f1b34b9ff19 > Ancestors: Sound-tpr.44 > > Attempting to start the SoundRecorder on hardwarewith no sound input (ie a RaspberryPi) fails and there is no attempt to handle it. Tacky. > > Remove the prim failure from primStartRecording... and raise a Warning instead from startRecording. The main recorder process is perfectly happy to run and do nothing. In the Scratchg code I can catch the exception and inform the users rather more politely than by opening a debugger. A couple of points about this a) dammit, the save dialogue DID NOT SHOW computeSustainValueAtMSecs, sustainEnd, midiCmd:channel:byte: , midiCmd:channel:byte:byte: as being changed. They should not have been included. b) This is in the inbox because someone may have a better idea than using a generic Warning. I don’t mind as long as I know so I can do the right thing in the Scratch code. c) I can’t test the results of this change on Windows, nor on a linux box that *does* have sound input hardware to connect to - nor a Mac that doesn’t. d) assuming it satisfies everyone we would want to patch the generic RecordingControlsMorph in a similar manner to the Scratch recorder morph. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Oxymorons: New classic

1 0

The Inbox: Sound-tpr.45.mcz
by commits＠source.squeak.org 23 Nov '15

23 Nov '15

tim Rowledge uploaded a new version of Sound to project The Inbox: http://source.squeak.org/inbox/Sound-tpr.45.mcz ==================== Summary ==================== Name: Sound-tpr.45 Author: tpr Time: 22 November 2015, 3:08:45.33 pm UUID: 47fd8f98-1a2b-4724-95cc-6f1b34b9ff19 Ancestors: Sound-tpr.44 Attempting to start the SoundRecorder on hardwarewith no sound input (ie a RaspberryPi) fails and there is no attempt to handle it. Tacky. Remove the prim failure from primStartRecording... and raise a Warning instead from startRecording. The main recorder process is perfectly happy to run and do nothing. In the Scratchg code I can catch the exception and inform the users rather more politely than by opening a debugger. =============== Diff against Sound-topa.43 =============== Item was added: + ----- Method: Envelope>>computeSustainValueAtMSecs: (in category 'applying') ----- + computeSustainValueAtMSecs: mSecs + "Return the value of this envelope at the given number of milliseconds from its onset. Return zero for times outside the time range of this envelope." + "Note: Unlike the private method incrementalComputeValueAtMSecs:, this method does is not increment. Thus it is slower, but it doesn't depend on being called sequentially at fixed time intervals. + Note: this is the same as computeValueAtMSecs: apart from removing the first section that requires loopEndMSecs t obe nil; this appears to cause a problem when a sound in playing and is stopped whilst the #computeSlopeAtMSecs: method is run inside the SoundPlayer loop" + + | t i | + mSecs < 0 ifTrue: [^ 0.0]. + + " prevent this bit running so that we don't have to fudge loopEndMSecs to nil in #sustainEnd: + ((loopEndMSecs ~~ nil) and: [mSecs >= loopEndMSecs]) ifTrue: [ ""decay phase"" + t := (points at: loopEndIndex) x + (mSecs - loopEndMSecs). + i := self indexOfPointAfterMSecs: t startingAt: loopEndIndex. + i == nil ifTrue: [^ 0.0]. ""past end"" + ^ (self interpolate: t between: (points at: i - 1) and: (points at: i)) * decayScale]. + " + mSecs < loopStartMSecs ifTrue: [ "attack phase" + i := self indexOfPointAfterMSecs: mSecs startingAt: 1. + i = 1 ifTrue: [^ (points at: 1) y * scale]. + ^ self interpolate: mSecs between: (points at: i - 1) and: (points at: i)]. + + "sustain phase" + loopMSecs = 0 ifTrue: [^ (points at: loopEndIndex) y * scale]. "looping on a single point" + t := loopStartMSecs + ((mSecs - loopStartMSecs) \\ loopMSecs). + i := self indexOfPointAfterMSecs: t startingAt: loopStartIndex. + + ^ self interpolate: t between: (points at: i - 1) and: (points at: i) + ! Item was changed: ----- Method: Envelope>>sustainEnd: (in category 'applying') ----- sustainEnd: mSecs "Set the ending time of the sustain phase of this envelope; the decay phase will start this point. Typically derived from a note's duration." "Details: to avoid a sharp transient, the decay phase is scaled so that the beginning of the decay matches the envelope's instantaneous value when the decay phase starts." | vIfSustaining firstVOfDecay | + loopEndMSecs := mSecs. "no longer set to nil in order to pretend to be sustaining" - loopEndMSecs := nil. "pretend to be sustaining" decayScale := 1.0. nextRecomputeTime := 0. + vIfSustaining := self computeSustainValueAtMSecs: mSecs. "get value at end of sustain phase" + "loopEndMSecs := mSecs. not required any more" - vIfSustaining := self computeValueAtMSecs: mSecs. "get value at end of sustain phase" - loopEndMSecs := mSecs. firstVOfDecay := (points at: loopEndIndex) y * scale. firstVOfDecay = 0.0 ifTrue: [decayScale := 1.0] ifFalse: [decayScale := vIfSustaining / firstVOfDecay]. ! Item was changed: ----- Method: SimpleMIDIPort>>midiCmd:channel:byte: (in category 'output') ----- midiCmd: cmd channel: channel byte: dataByte "Immediately output the given MIDI command with the given channel and argument byte to this MIDI port. Assume that the port is open." accessSema critical: [ + self primMIDIWriteNoErrorPort: portNumber - self primMIDIWritePort: portNumber from: (ByteArray with: (cmd bitOr: channel) with: dataByte) at: 0]. ! Item was changed: ----- Method: SimpleMIDIPort>>midiCmd:channel:byte:byte: (in category 'output') ----- midiCmd: cmd channel: channel byte: dataByte1 byte: dataByte2 "Immediately output the given MIDI command with the given channel and argument bytes to this MIDI port. Assume that the port is open." accessSema critical: [ + self primMIDIWriteNoErrorPort: portNumber - self primMIDIWritePort: portNumber from: (ByteArray with: (cmd bitOr: channel) with: dataByte1 with: dataByte2) at: 0]. ! Item was changed: ----- Method: SoundRecorder>>primStartRecordingDesiredSampleRate:stereo:semaIndex: (in category 'primitives') ----- primStartRecordingDesiredSampleRate: samplesPerSec stereo: stereoFlag semaIndex: anInteger + "Start sound recording with the given stereo setting. Use a sampling rate as close to the desired rate as the underlying platform will support. If the given semaphore index is > 0, it is taken to be the index of a Semaphore in the external objects array to be signalled every time a recording buffer is filled. + We do *not* raise a primitiveFailed error here since this prim is called insdied a critical blcok and that often makes things painful. The only really likely case where this prim fails is a linux machine with no sound input hardware (a Raspberry Pi for example). See the startRecording method for how the failure is handled" - "Start sound recording with the given stereo setting. Use a sampling rate as close to the desired rate as the underlying platform will support. If the given semaphore index is > 0, it is taken to be the index of a Semaphore in the external objects array to be signalled every time a recording buffer is filled." <primitive: 'primitiveSoundStartRecording' module: 'SoundPlugin'> + "self primitiveFailed" - self primitiveFailed ! Item was changed: ----- Method: SoundRecorder>>startRecording (in category 'recording controls') ----- startRecording + "Turn on the sound input driver and start the recording process. Initially, recording is paused. + If the primStartRecordingDesiredSampleRate:... fails it almost certainly means we have no usable + sound input device. Rather than having the prim raise a failure error we let it quietly do nothing + (since I hate trying to debug errors inside a critical block) and check the actual sampling rate later. + If the sampling rate is 0 we know the startup failed and raise an application level Signal to let any + user code know about the problem. + You might think we should also use the stopRecording message to close things down cleanly but + that simply results in astorm of attempts to start recording so it is simpler to let it be deluded. An + attempts to start recording will repeat the test and thereby handle any plug-in hardware etc." - "Turn of the sound input driver and start the recording process. Initially, recording is paused." recordLevel ifNil: [recordLevel := 0.5]. "lazy initialization" CanRecordWhilePlaying ifFalse: [SoundPlayer shutDown]. recordProcess ifNotNil: [self stopRecording]. paused := true. meteringBuffer := SoundBuffer newMonoSampleCount: 1024. meterLevel := 0. self allocateBuffer. Smalltalk newExternalSemaphoreDo: [ :semaphore :index | bufferAvailableSema := semaphore. self primStartRecordingDesiredSampleRate: samplingRate asInteger stereo: stereo semaIndex: index ]. RecorderActive := true. samplingRate := self primGetActualRecordingSampleRate. + samplingRate = 0 ifTrue: [ Warning signal: 'SoundRecorder: unable to connect to sound input device']. self primSetRecordLevel: (1000.0 * recordLevel) asInteger. recordProcess := [self recordLoop] newProcess. recordProcess priority: Processor userInterruptPriority. recordProcess resume!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
26
Older →

Jump to page: