Squeak-dev November 2015

squeak-dev@lists.squeakfoundation.org

40 participants
251 discussions

Daily Commit Log
by commits＠source.squeak.org 22 Nov '15

22 Nov '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-November/009188.h… Name: Compiler-eem.317 Ancestors: Compiler-nice.316 Small improvement to compiler performance. There is no need to scan for an assignment to the limit in a to:[by:]do: when the to: argument is known to be an argument, because arguments are not written to. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-November/009189.h… Name: Morphic-mt.1053 Ancestors: Morphic-cmm.1052 Fixes undo for autoEnclose again. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-November/009190.h… Name: HelpSystem-Tests-kfr.17 Ancestors: HelpSystem-Tests-mt.16 Fixed a couple of broken tests =============================================

1 0

The Trunk: HelpSystem-Tests-kfr.17.mcz
by commits＠source.squeak.org 22 Nov '15

22 Nov '15

Karl Ramberg uploaded a new version of HelpSystem-Tests to project The Trunk: http://source.squeak.org/trunk/HelpSystem-Tests-kfr.17.mcz ==================== Summary ==================== Name: HelpSystem-Tests-kfr.17 Author: kfr Time: 22 November 2015, 7:30:41.491 pm UUID: 682515b0-b94a-4681-9a8a-6269e7a9f09b Ancestors: HelpSystem-Tests-mt.16 Fixed a couple of broken tests =============== Diff against HelpSystem-Tests-mt.16 =============== Item was added: + ----- Method: AdvancedHelpBrowserDummy>>model (in category 'testing') ----- + model + ^self! Item was added: + ----- Method: AdvancedHelpBrowserDummy>>showFirstTopic (in category 'testing') ----- + showFirstTopic + ^rootTopic!

1 0

The Trunk: Morphic-mt.1053.mcz
by commits＠source.squeak.org 22 Nov '15

22 Nov '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1053.mcz ==================== Summary ==================== Name: Morphic-mt.1053 Author: mt Time: 22 November 2015, 2:45:14.467 pm UUID: a55f6a5e-b5c9-4e64-9ffa-9cac6cbc8e54 Ancestors: Morphic-cmm.1052 Fixes undo for autoEnclose again. =============== Diff against Morphic-cmm.1052 =============== Item was changed: ----- Method: TextEditor>>autoEncloseFor: (in category 'typing support') ----- autoEncloseFor: typedChar "Answer whether typeChar was handled by auto-enclosure. Caller should call normalCharacter if not." | openers closers | openers := '([{'. closers := ')]}'. (closers includes: typedChar) ifTrue: [ | pos | self blinkPrevParen: typedChar. ((pos := self indexOfNextNonwhitespaceCharacter) notNil and: [ (paragraph string at: pos) = typedChar ]) ifTrue: [ self moveCursor: [ : position | position + pos - pointBlock stringIndex + 1 ] forward: true select: false. ^ true ] ifFalse: [ ^ false ] ]. + (openers includes: typedChar) ifTrue: - (self class autoEnclose and: [ openers includes: typedChar ]) ifTrue: [ self + openTypeIn; + addString: typedChar asString; + addString: (closers at: (openers indexOf: typedChar)) asString; + insertAndCloseTypeIn; - addString: (closers at: (openers indexOf: typedChar)) asString ; - insertTypeAhead ; moveCursor: [ : position | position - 1 ] forward: false select: false. + ^ true ]. - ^ false ]. ^ false! Item was changed: ----- Method: TextEditor>>dispatchOnKeyboardEvent: (in category 'typing support') ----- dispatchOnKeyboardEvent: aKeyboardEvent "Carry out the action associated with this character, if any. Type-ahead is passed so some routines can flush or use it." | honorCommandKeys typedChar | typedChar := aKeyboardEvent keyCharacter. "Create a new command for separating characters. Do not create separate commands for consecutive separators." ((Character separators includes: typedChar) and: [(Character separators includes: previousKeyCharacter) not]) ifTrue: [self closeTypeIn]. previousKeyCharacter := typedChar. "Handle one-line input fields." (typedChar == Character cr and: [morph acceptOnCR]) ifTrue: [^ true]. "Clear highlight for last opened parenthesis." self clearParens. "Handle line breaks and auto indent." typedChar == Character cr ifTrue: [ aKeyboardEvent controlKeyPressed ifTrue: [^ self normalCharacter: aKeyboardEvent]. aKeyboardEvent shiftPressed ifTrue: [^ self lf: aKeyboardEvent]. aKeyboardEvent commandKeyPressed ifTrue: [^ self crlf: aKeyboardEvent]. ^ self crWithIndent: aKeyboardEvent]. "Handle indent/outdent with selected text block." typedChar == Character tab ifTrue: [ aKeyboardEvent shiftPressed ifTrue: [self outdent: aKeyboardEvent. ^ true] ifFalse: [self hasMultipleLinesSelected ifTrue: [self indent: aKeyboardEvent. ^ true]]]. honorCommandKeys := Preferences cmdKeysInText. (honorCommandKeys and: [typedChar == Character enter]) ifTrue: [^ self dispatchOnEnterWith: aKeyboardEvent]. "Special keys overwrite crtl+key combinations - at least on Windows. To resolve this conflict, assume that keys other than cursor keys aren't used together with Crtl." ((self class specialShiftCmdKeys includes: aKeyboardEvent keyValue) and: [aKeyboardEvent keyValue < 27]) ifTrue: [^ aKeyboardEvent controlKeyPressed ifTrue: [self perform: (self class shiftCmdActions at: aKeyboardEvent keyValue + 1) with: aKeyboardEvent] ifFalse: [self perform: (self class cmdActions at: aKeyboardEvent keyValue + 1) with: aKeyboardEvent]]. "backspace, and escape keys (ascii 8 and 27) are command keys" ((honorCommandKeys and: [aKeyboardEvent commandKeyPressed]) or: [self class specialShiftCmdKeys includes: aKeyboardEvent keyValue]) ifTrue: [ ^ aKeyboardEvent shiftPressed ifTrue: [self perform: (self class shiftCmdActions at: aKeyboardEvent keyValue + 1) with: aKeyboardEvent] ifFalse: [self perform: (self class cmdActions at: aKeyboardEvent keyValue + 1) with: aKeyboardEvent]]. "the control key can be used to invoke shift-cmd shortcuts" (honorCommandKeys and: [ aKeyboardEvent controlKeyPressed ]) ifTrue: [^ self perform: (self class shiftCmdActions at: aKeyboardEvent keyValue + 1) with: aKeyboardEvent]. + "Automatically enclose paired characters such as brackets." + (self class autoEnclose and: [self autoEncloseFor: typedChar]) + ifTrue: [^ true]. + + self normalCharacter: aKeyboardEvent. - self class autoEnclose - ifTrue: - [ (self autoEncloseFor: typedChar) ifFalse: [ self normalCharacter: aKeyboardEvent ] ] - ifFalse: [ self normalCharacter: aKeyboardEvent ]. - ^ false!

1 0

Re: The Trunk: Morphic-cmm.1052.mcz
by marcel.taeumel 22 Nov '15

22 Nov '15

-1 1. This breaks the undo for #autoEnclose, which I had fixed on purpose. 2. This removes a very convenient feature to put brackets around the current selection. Please revert that commit or give a rationale. ;-) Or both. What is that use case "replace expression with new expression"? Just from reading the words, it just worked fine. Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-Morphic-cmm-1052-mcz-tp4862408p4862409.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

3 3

The Trunk: Compiler-eem.317.mcz
by commits＠source.squeak.org 22 Nov '15

22 Nov '15

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.317.mcz ==================== Summary ==================== Name: Compiler-eem.317 Author: eem Time: 21 November 2015, 3:20:26.817 pm UUID: 956bcba6-bf0a-463c-aaef-90903732fb85 Ancestors: Compiler-nice.316 Small improvement to compiler performance. There is no need to scan for an assignment to the limit in a to:[by:]do: when the to: argument is known to be an argument, because arguments are not written to. =============== Diff against Compiler-nice.316 =============== Item was changed: ----- Method: MessageNode>>transformToDo: (in category 'macro transformations') ----- transformToDo: encoder " var := rcvr. L1: [var <= arg1] Bfp(L2) [block body. var := var + inc] Jmp(L1) L2: " + | limit increment block initStmt test incStmt limitInit blockVar myRange blockRange | - | limit increment block initStmt test incStmt limitInit blockVar myRange blockRange limitIsAssignedTo | block := arguments last. "First check for valid arguments" (block notNil and: [block isBlockNode and: [block numberOfArguments = 1 and: [block firstArgument isVariableReference "As with debugger remote vars"]]]) ifFalse: [^false]. arguments size = 3 ifTrue: [increment := arguments at: 2. (increment isConstantNumber and: [increment literalValue ~= 0]) ifFalse: [^false]] ifFalse: [increment := encoder encodeLiteral: 1]. (limit := arguments at: 1) isVariableReference ifTrue: + [| shouldScanForAssignment | + shouldScanForAssignment := limit isArg not + or: [limit isBlockArg and: [Scanner allowBlockArgumentAssignment]]. + shouldScanForAssignment ifTrue: + [block nodesDo: + [:node| + (node isAssignmentNode and: [node variable = limit]) ifTrue: + [^false]]]]. - [limitIsAssignedTo := false. - block nodesDo: - [:node| - (node isAssignmentNode and: [node variable = limit]) ifTrue: - [limitIsAssignedTo := true]]. - limitIsAssignedTo ifTrue: - [^false]]. arguments size < 3 ifTrue: "transform to full form" [selector := SelectorNode new key: #to:by:do: code: #macro]. "Now generate auxiliary structures" myRange := encoder rawSourceRanges at: self ifAbsent: [1 to: 0]. blockRange := encoder rawSourceRanges at: block ifAbsent: [1 to: 0]. blockVar := block firstArgument. initStmt := AssignmentNode new variable: blockVar value: receiver. + (limit isVariableReference or: [limit isConstantNumber]) - limit isVariableReference | limit isConstantNumber ifTrue: [limitInit := nil] ifFalse: "Need to store limit in a var" [limit := encoder bindBlockArg: blockVar key, 'LimiT' within: block. limit scope: -2. "Already done parsing block; flag so it won't print" block addArgument: limit. limitInit := AssignmentNode new variable: limit value: arguments first]. test := MessageNode new receiver: blockVar selector: (increment key > 0 ifTrue: [#<=] ifFalse: [#>=]) arguments: {limit} precedence: precedence from: encoder sourceRange: (myRange first to: blockRange first). incStmt := AssignmentNode new variable: blockVar value: (MessageNode new receiver: blockVar selector: #+ arguments: {increment} precedence: precedence from: encoder sourceRange: (myRange last to: (myRange last max: blockRange last))) from: encoder sourceRange: (myRange last to: (myRange last max: blockRange last)). arguments := {limit. increment. block. initStmt. test. incStmt. limitInit}. block noteOptimizedIn: self. ^true!

1 0

Daily Commit Log
by commits＠source.squeak.org 21 Nov '15

21 Nov '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-November/009184.h… Name: WebClient-HTTP-cmm.4 Ancestors: WebClient-HTTP-cmm.3 Support the 'args' variable in HTTPSocket class>>#httpGet:args:user:passwd:. This fixes the in-image 'mc history' and origin functions for methods and classes. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-November/009185.h… Name: Morphic-cmm.1052 Ancestors: Morphic-mt.1051 - Restore the use-case "Replace Expression With A New Expression" (e.g., fix autoEnclose). "Connect Existing Expression To A New Expression" is already present via the Command key. We need to support both of those use cases. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-November/009186.h… Name: Environments-kfr.59 Ancestors: Environments-eem.58 Colin's suggested workaround for Bindings http://lists.squeakfoundation.org/pipermail/squeak-dev/2014-September/18001… ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-November/009187.h… Name: MorphicExtras-kfr.168 Ancestors: MorphicExtras-kfr.167 Moved from MorphicExtras-Obsolete to Morphic-Extras-Widgets =============================================

1 0

Re: The Trunk: Morphic-kfr.1048.mcz
by marcel.taeumel 21 Nov '15

21 Nov '15

Why obsolete? Any application that may need a progress bar can use it. Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-Morphic-kfr-1048-mcz-tp4862058p4862149.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

3 7

The Trunk: MorphicExtras-kfr.168.mcz
by commits＠source.squeak.org 21 Nov '15

21 Nov '15

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.168.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.168 Author: kfr Time: 21 November 2015, 10:36:27.418 pm UUID: 99d2fb92-d0ff-4175-9ca5-73d90053a5a1 Ancestors: MorphicExtras-kfr.167 Moved from MorphicExtras-Obsolete to Morphic-Extras-Widgets =============== Diff against MorphicExtras-kfr.167 =============== Item was changed: BorderedMorph subclass: #ProgressBarMorph instanceVariableNames: 'value progressColor lastValue' classVariableNames: '' poolDictionaries: '' + category: 'MorphicExtras-Widgets'! - category: 'MorphicExtras-Obsolete'! Item was changed: RectangleMorph subclass: #ProgressMorph instanceVariableNames: 'labelMorph subLabelMorph progress' classVariableNames: '' poolDictionaries: '' + category: 'MorphicExtras-Widgets'! - category: 'MorphicExtras-Obsolete'!

1 0

The Trunk: Environments-kfr.59.mcz
by commits＠source.squeak.org 21 Nov '15

21 Nov '15

Karl Ramberg uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-kfr.59.mcz ==================== Summary ==================== Name: Environments-kfr.59 Author: kfr Time: 21 November 2015, 10:33:48.689 pm UUID: 28f20424-19f0-4333-90c3-7fe53fbd51b5 Ancestors: Environments-eem.58 Colin's suggested workaround for Bindings http://lists.squeakfoundation.org/pipermail/squeak-dev/2014-September/18001… =============== Diff against Environments-eem.58 =============== Item was changed: ----- Method: Binding>>objectForDataStream: (in category 'as yet unclassified') ----- + objectForDataStream: refStrm + | dp | + "I am about to be written on an object file. If I am a known global, write a proxy that will hook up with the same resource in the destination system." + self flag: #environments. + + ^ (Smalltalk globals associationAt: key ifAbsent: [nil]) == self + ifTrue: [dp := DiskProxy global: #Smalltalk selector: #associationOrUndeclaredAt: + args: (Array with: key). + refStrm replace: self with: dp. + dp] + ifFalse: [self]! - objectForDataStream: refStream - "It's not yet clear how serialization should work in the presence of environments" - - self shouldBeImplemented.!

1 0

Fixing tab behaviour and browser hierarchy appearance
by Eliot Miranda 21 Nov '15

21 Nov '15

Hi Marcel, I'm having a go at fixing the tabbing indent behavior. I can't live with selecting interior text (text that is past some sequence of whitespace at the beginning of a line), typing tab to replace the selection with tabs, and have the line indent instead. If people want the indent all they have to do is select within whitespace at the beginning of the line. However, when I opened up the browser to inspect the Editor, TextEditor, SmalltalkEditor hierarchy I was misled into thinking that SmalltalkEditor was a sibling of TextEditor rather than its subclass because SmalltalkEditor is indented so little w.r.t. TextEditor. To reproduce, open up a browser and navigate to Morphic-Text Support, then look at TextEditor and SmalltalkEditor. I think you'll agree that the indent needs to be larger. I'll fix tab indenting if you fix browser indenting ;-) _,,,^..^,,,_ best, Eliot

7 27

← Newer
1
...
4
5
6
7
8
9
10
...
26
Older →

Jump to page: