Squeak-dev March 2018

squeak-dev@lists.squeakfoundation.org

53 participants
146 discussions

Why is testSemaInCriticalWait failing?
by David T. Lewis 24 Mar '18

24 Mar '18

SemaphoreTest>>testSemaInCriticalWait passes in Squeak 4.6 but fails in my trunk image. Has anyone looked into this? Thanks, Dave

1 0

The Trunk: Monticello-ul.679.mcz
by commits＠source.squeak.org 23 Mar '18

23 Mar '18

Levente Uzonyi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ul.679.mcz ==================== Summary ==================== Name: Monticello-ul.679 Author: ul Time: 22 March 2018, 7:32:51.372118 pm UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5 Ancestors: Monticello-ul.678 - enable #useSharedWebClientInstance by default when WebClient is present =============== Diff against Monticello-ul.678 =============== Item was changed: ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- useSharedWebClientInstance <preference: 'Use shared WebClient instance' category: 'Monticello' description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' type: #Boolean> + ^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]! - ^UseSharedWebClientInstance ifNil: [ false ]!

4 4

FileList and friends and the insane things they do
by tim Rowledge 23 Mar '18

23 Mar '18

In my seemingly never ending quest to clean out nasty misuse of FileList and descendants and StandardFileMenu etc I keep coming across place where it is clear some serious problems have occurred during the life of the code. Apparently the approach of CASE NIGHTMARE APRICOT has lead to trans-dimensional leakage of deviant bytes from the realms of the Soul Eater. Let's look at an example or two - FileList2 class>>#projectOnlySelectionMethod: This has nothing much to do with actual FileLists; it is a messy way to find files with certain filename extensions. It gets used in contexts completely unrelated to a File List. FileDirectory>entriesForProjectFiles would probably be a little less obnoxious? SugarNavigatorBar>>#publishSexp is rather fun, too. I *think* al that messing with the FileList2 instance near the bottom is to remove a button, though since there is also an interaction with the Project>>#storeOnServerInnards code and the interesting usage of #saveLocalOnlyHit and the Preference. Then there is SugarNavigatorBar class>>#findAnythingMorph. The only findable use relates to putting a non-functional example instance into the 'objects' morph. And QuickGuideGenerator>>#makeInputDirList. Comments on any known history of why, or what is supposed to happen etc welcomed. They're yet more excellent examples of why some hint of documentation is nice. Sure, code tells you what actually happens, assuming you can actually make any sense of it, but not about what is *meant* to happen, or what is not yet included, or why. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Utinam barbari spatium proprium tuum invadant! = May barbarians invade your personal space!

1 1

Crazy idea for a programming editor in Squeak *for C*
by tim Rowledge 23 Mar '18

23 Mar '18

So thinking about things related to Subbu's questions it suddenly came to me that we might be able to make a much nicer C editor than most seem to be. Caution - I use TextWrangler on my iMac when I have to mess with C. This may well bias my opinion. Seems to me that most so called IDEs that let you handle C code are pretty pathetic. You load a file and scroll up and down it. If you're lucky it scans the file and makes sort of bookmark of function locations etc. You might get a half decent comparison tool to compare different versions. Now, we have a useful but in need of improvement tool for reading source code files without actually loading them in the FileContentsBrowser. A variant of that could read C source, split it up, parse the bits and bobs and maybe provide a decent structured view of the code. Yes, I remember ObjectWorks C++ and the debacle of C++ programmers not wanting anything more advanced than vi. There's also a possible value for this in the Python world where they at least pretend to have a clue about objects. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Law of Logical Argument: Anything is possible if you don't know what you are talking about.

8 11

The Trunk: ToolBuilder-Morphic-tpr.208.mcz
by commits＠source.squeak.org 23 Mar '18

23 Mar '18

tim Rowledge uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-tpr.208.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-tpr.208 Author: tpr Time: 22 March 2018, 5:11:45.931652 pm UUID: f88f9d36-8005-46ef-96e8-1dadd3301370 Ancestors: ToolBuilder-Morphic-tpr.207 Correct a couple of FileChooserDialog example comments to actually work =============== Diff against ToolBuilder-Morphic-tpr.207 =============== Item was changed: ----- Method: FileChooserDialog class>>openOn:suffixList:label: (in category 'instance creation') ----- openOn: aDirectory suffixList: patternList label: labelString "Open a modal dialog to choose a file. Start the dialog with aDirectory selected and files matching the file name suffixes in patternList. Set the user message to labelString." + "FileChooserDialog openOn: FileDirectory default suffixList: { 'changes' . 'image' } label: 'Do something with the selected files' " - "FileChooserDialog openOn: FileDirectory default suffixList: { '*.changes' . '*image' } label: 'Do something with the selected files' " ^self new directory: aDirectory; suffixList: patternList; message: labelString; getUserResponse! Item was changed: ----- Method: FileChooserDialog class>>openOnSuffixList:label: (in category 'instance creation') ----- openOnSuffixList: patternList label: labelString "Open a modal dialog to choose a file. Start the dialog with a default directory selected and with files matching the file name suffixes in patternList. Set the user message to labelString." + "FileChooserDialog openOnSuffixList: { 'changes' . 'image' } label: 'Do something with the selected files' " - "FileChooserDialog openOnSuffixList: { '*.changes' . '*image' } label: 'Do something with the selected files' " ^self openOn: nil suffixList: patternList label: labelString !

1 0

The Trunk: EToys-tpr.322.mcz
by commits＠source.squeak.org 23 Mar '18

23 Mar '18

tim Rowledge uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-tpr.322.mcz ==================== Summary ==================== Name: EToys-tpr.322 Author: tpr Time: 22 March 2018, 5:06:55.965192 pm UUID: b4b7d324-3922-4202-bf26-bb9e9bb17879 Ancestors: EToys-tpr.321, EToys-topa.321 Change CrosticPanel & FileInput to use the new file dialogues instead of the nasty old StandardFileMenu. Moved to trunk since no complaints of problems were made wrt the inbox version =============== Diff against EToys-topa.321 =============== Item was changed: ----- Method: CrosticPanel>>openFile (in category 'menu') ----- openFile + | fileName crostic file | + + fileName := FileChooserDialog openOn: FileDirectory default suffixList: { 'crostic' } label: 'Select a Crostic file...' translated. + fileName ifNil: [^nil]. + + file := FileStream readOnlyFileNamed: fileName. - | stdFileMenuResult crostic file | - stdFileMenuResult := (StandardFileMenu new pattern: '*.crostic'; - oldFileFrom: FileDirectory default) startUpWithCaption: 'Select a Crostic File...' translated. - stdFileMenuResult - ifNil: [^ nil]. - file := stdFileMenuResult directory readOnlyFileNamed: stdFileMenuResult name. crostic := CrosticPanel newFromFile: file. file close. (self isClean or: [self confirm: 'Is it OK to discard this crostic?' translated]) ifTrue: [self world addMorphFront: (crostic position: self position). self delete] ifFalse: [self world addMorphFront: crostic]! Item was changed: ----- Method: FileInput>>browse (in category 'accessing') ----- browse + | fileName | + fileName := (FileChooserDialog openOn: self directory) ifNil: [^nil]. - | file | - file := (StandardFileMenu oldFileFrom: self directory) ifNil: [^nil]. - file directory isNil ifTrue: [^ nil]. + textMorph setText: fileName; - textMorph setText: (file directory pathName, FileDirectory slash, file name); hasUnacceptedEdits: true; accept! Item was changed: ----- Method: StackMorph>>addCardsFromAFile (in category 'background') ----- addCardsFromAFile "Using the current background, create new cards by reading in data from a fileThe data are in each record are expected to be tab-delimited, and to occur in the same order as the instance variables of the current-background's cards " + | fileName | + fileName := FileChooserDialog openOn: FileDirectory default. + fileName ifNil:[^Beeper beep]. + FileStream oldFileNamed: fileName do:[:fs| + self addCardsFromFile: fs].! - | aFileStream | - (aFileStream := FileList2 modalFileSelector) ifNil: [^ Beeper beep]. - self addCardsFromString: aFileStream contentsOfEntireFile. - aFileStream close! Item was changed: ----- Method: SugarNavigatorBar>>loadASexp (in category 'button actions') ----- loadASexp + | fileName siss sexp | + fileName := FileChooserDialog openOnSuffixList: {'sexp'} label: nil. + fileName ifNil: [^ self]. + FileStream + oldFileNamed: fileName + do: [:file | + file binary. + siss := file contents. + sexp := [(DataStream on: (file reset; yourself)) next] + on: Error + do: [:e | (Smalltalk at: #MSExpParser) + parse: siss + with: #ksexp]]. + sexp sissReadObjectsAsEtoysProject submorphs do: #openInWorld! - | file siss sexp | - file := FileList2 modalFileSelectorForSuffixes: #('sexp'). - file ifNil: [^ self]. - file binary. - siss := file contents. - sexp := [(DataStream on: (file reset; yourself)) next] on: Error do: [:e | - (Smalltalk at: #MSExpParser) parse: siss with: #ksexp]. - sexp sissReadObjectsAsEtoysProject submorphs do: #openInWorld. - !

1 0

Showing control keys on display
by K K Subbu 22 Mar '18

22 Mar '18

Is there a facility in Morphic to display and fade out (e.g. "CTRL+C") when command/control keys are pressed? This is to facilitate screen captures and lecture demonstrations. Thanks .. Subbu

2 1

The Trunk: Monticello-ul.678.mcz
by commits＠source.squeak.org 22 Mar '18

22 Mar '18

Levente Uzonyi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ul.678.mcz ==================== Summary ==================== Name: Monticello-ul.678 Author: ul Time: 19 March 2018, 1:03:18.137853 am UUID: 4d47635e-aa48-43cc-99bb-b8d2f1a5a51f Ancestors: Monticello-cmm.677 Store and reuse a shared WebClient instance for each MCHttpRepository. This makes it possible to speed up downloads by reusing TCP connections. Disabled by default. Enable it by evaluating [MCHttpRepository useSharedWebClientInstance: true] =============== Diff against Monticello-cmm.677 =============== Item was changed: MCFileBasedRepository subclass: #MCHttpRepository + instanceVariableNames: 'location user password readerCache indexed webClient' + classVariableNames: 'UseSharedWebClientInstance' - instanceVariableNames: 'location user password readerCache indexed' - classVariableNames: '' poolDictionaries: '' category: 'Monticello-Repositories'! Item was added: + ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- + useSharedWebClientInstance + + <preference: 'Use shared WebClient instance' + category: 'Monticello' + description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' + type: #Boolean> + ^UseSharedWebClientInstance ifNil: [ false ]! Item was added: + ----- Method: MCHttpRepository class>>useSharedWebClientInstance: (in category 'preferences') ----- + useSharedWebClientInstance: aBoolean + + UseSharedWebClientInstance := aBoolean! Item was changed: ----- Method: MCHttpRepository>>allFileNames (in category 'overriding') ----- allFileNames + | index | + index := self displayProgress: 'Updating ', self description during: [ + self httpGet: self locationWithTrailingSlash, '?C=M;O=D' arguments: nil ]. + ^index ifNotNil: [ self parseFileNamesFromStream: index ]! - self displayProgress: 'Updating ', self description during:[ - index := HTTPSocket httpGet: self locationWithTrailingSlash, '?C=M;O=D' args: nil user: self user passwd: self password. - ]. - index isString ifTrue: [NetworkError signal: 'Could not access ', location]. - ^ self parseFileNamesFromStream: index ! Item was added: + ----- Method: MCHttpRepository>>httpGet:arguments: (in category 'private') ----- + httpGet: url arguments: arguments + + | progress urlString client response result | + self class useSharedWebClientInstance ifFalse: [ + ^HTTPSocket httpGet: url args: arguments user: self user passwd: self password ]. + progress := [ :total :amount | + HTTPProgress new + total: total; + amount: amount; + signal: 'Downloading...' ]. + urlString := arguments + ifNil: [ url ] + ifNotNil: [ + | queryString | + queryString := (Smalltalk classNamed: #WebUtils) encodeUrlEncodedForm: arguments. + (url includes: $?) + ifTrue: [ url, '&', queryString ] + ifFalse: [ url, '?', queryString ] ]. + "Acquire webClient by atomically storing it in the client variable and setting its value to nil." + client := webClient. + webClient := nil. + client ifNil: [ client := (Smalltalk classNamed: #WebClient) new ]. + response := client + username: self user; + password: self password; + httpGet: urlString do: [ :request | + request + headerAt: 'Authorization' put: 'Basic ', (self user, ':', self password) base64Encoded; + headerAt: 'Connection' put: 'Keep-Alive'; + headerAt: 'Accept' put: '*/*' ]. + result := (response code between: 200 and: 299) + ifFalse: [ + response content. "Make sure content is read." + nil ] + ifTrue: [ (RWBinaryOrTextStream with: (response contentWithProgress: progress)) reset ]. + "Save the WebClient instance for reuse, but only if there is no client cached." + webClient + ifNil: [ webClient := client ] + ifNotNil: [ client close ]. + ^result ifNil: [ + NetworkError signal: 'Could not access ', location. + nil ]! Item was changed: ----- Method: MCHttpRepository>>readStreamForFileNamed:do: (in category 'private') ----- readStreamForFileNamed: aString do: aBlock + | contents | + contents := self displayProgress: 'Downloading ', aString during: [ + self httpGet: (self urlForFileNamed: aString) arguments: nil ]. + ^contents ifNotNil: [ aBlock value: contents ]! - self displayProgress: 'Downloading ', aString during:[ - contents := HTTPSocket httpGet: (self urlForFileNamed: aString) args: nil user: self user passwd: self password. - ]. - ^ contents isString ifFalse: [aBlock value: contents]!

1 0

The Inbox: KernelTests-cbc.336.mcz
by commits＠source.squeak.org 22 Mar '18

22 Mar '18

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-cbc.336.mcz ==================== Summary ==================== Name: KernelTests-cbc.336 Author: cbc Time: 21 March 2018, 9:41:20.439568 pm UUID: 0ad1f79d-ea7e-0243-9c7e-ccfcc72aa1ef Ancestors: KernelTests-eem.335, KernelTests-fn.333 updated for Kernel-cbc.1163 =============== Diff against KernelTests-eem.335 =============== Item was changed: ----- Method: FalseTest>>testXor (in category 'tests') ----- testXor self assert: (false xor: true) = true. self assert: (false xor: false) = false. + self assert: (false xor: [true]) = true. + self assert: (false xor: [false]) = false.! - - self - should: [(false xor: [false]) - ifTrue: ["This should never be true, do not signal an Error and let the test fail"] - ifFalse: [self error: 'OK, this should be false, raise an Error']] - raise: Error - description: 'a Block argument is not allowed. If it were, answer would be false'.! Item was removed: - TestCase subclass: #LiteralRefLocatorTest - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'KernelTests-Methods'! Item was removed: - ----- Method: LiteralRefLocatorTest>>testFindLiteralsInBytecode (in category 'tests') ----- - testFindLiteralsInBytecode - "Create a method referencing integers, characters, special selectors and nil, true & false. - Compile it and check that the objects are found." - | source primary secondary binarySpecials integers characters | - binarySpecials := Smalltalk specialSelectors select: [:s| s isSymbol and: [s isBinary]]. - "-65536 to 65535 in powers of two" - integers := ((16 to: 1 by: -1) collect: [:power| (2 raisedTo: power) negated]), - ((0 to: 16) collect: [:power| (2 raisedTo: power) - 1]). - "some printable characters; alas none have code > 255" - characters := (0 to: 65535) - select: [:n| (n between: 132 and: 160) not "these have no glyph in typical fonts" - and: [(Character value: n) shouldBePrintedAsLiteral]] - thenCollect: [:n| Character value: n]. - [characters size > 32] whileTrue: - [characters := (1 to: characters size by: 2) collect: [:i| characters at: i]]. - - #(('' '') ('^[' ']')) do: "And the locators should work whether in a block or not" - [:pFixes| - source := ByteString streamContents: - [:s| | binaries | - binaries := binarySpecials readStream. - s nextPutAll: 'exampleMethod'; crtab; nextPutAll: pFixes first. - integers - do: [:n| s print: n] - separatedBy: - [binaries atEnd ifTrue: [binaries reset]. - s space; nextPutAll: binaries next; space]. - s nextPut: $.; crtab. - s nextPut: ${; space. - characters - do: [:c| s print: c] - separatedBy: [s nextPut: $.; space]. - s space; nextPut: $}; nextPut: $.; crtab. - s nextPutAll: 'true ifTrue: [^nil] ifFalse: [^false]'; nextPutAll: pFixes last]. - primary := CompiledCode classPool at: #PrimaryBytecodeSetEncoderClass. - secondary := CompiledCode classPool at: #SecondaryBytecodeSetEncoderClass. - { primary. secondary } do: - [:encoderClass| | method | - method := (Parser new - encoderClass: encoderClass; - parse: source class: self class) - generate: CompiledMethodTrailer empty. - binarySpecials, integers, characters, #(nil false true) do: - [:literal| - self assert: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: false). - (encoderClass scanBlockOrNilForLiteral: literal) - ifNil: [self assert: (method hasLiteral: literal)] - ifNotNil: [:scanBlock| - self assert: ((method scanFor: scanBlock) - or: [method literals anySatisfy: [:l| l isCompiledCode and: [l scanFor: scanBlock]]])]]. - - "Now test for false positives..." - integers, characters, #(nil false true) do: - [:literal| | simpleSource simpleMethod | - simpleSource := ByteString streamContents: - [:s| s nextPutAll: 'exampleMethod'; crtab; nextPutAll: pFixes first; print: literal; nextPutAll: ' class'; nextPutAll: pFixes last]. - simpleMethod := (Parser new - encoderClass: encoderClass; - parse: simpleSource class: self class) - generate: CompiledMethodTrailer empty. - binarySpecials, integers, characters, #(nil false true) do: - [:anyLiteral| - anyLiteral == literal - ifTrue: - [self assert: (simpleMethod - refersTo: anyLiteral - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: anyLiteral) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: anyLiteral) - thorough: false). - (encoderClass scanBlockOrNilForLiteral: anyLiteral) - ifNil: [self assert: (simpleMethod hasLiteral: anyLiteral)] - ifNotNil: [:scanBlock| - self assert: ((simpleMethod scanFor: scanBlock) - or: [simpleMethod literals anySatisfy: [:l| l isCompiledCode and: [l scanFor: scanBlock]]])]] - ifFalse: - [self deny: (simpleMethod - refersTo: anyLiteral - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: anyLiteral) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: anyLiteral) - thorough: false). - (encoderClass scanBlockOrNilForLiteral: anyLiteral) - ifNil: [self deny: (simpleMethod hasLiteral: anyLiteral)] - ifNotNil: [:scanBlock| - self deny: ((simpleMethod scanFor: scanBlock) - or: [simpleMethod literals anySatisfy: [:l| l isCompiledCode and: [l scanFor: scanBlock]]])]]]]]]! Item was removed: - ----- Method: LiteralRefLocatorTest>>testThoroughFindLiteralsInBytecode (in category 'tests') ----- - testThoroughFindLiteralsInBytecode - "Create a method referencing integers, characters, special selectors and nil, true & false. - Compile it and check that the objects are found." - | literals problem primary secondary | - literals := #(-1 0 1 $0 $1 1.0 #[1 2 3 4] 'one' #one nil true false NaN). - problem := Float bindingOf: #NaN. - primary := CompiledCode classPool at: #PrimaryBytecodeSetEncoderClass. - secondary := CompiledCode classPool at: #SecondaryBytecodeSetEncoderClass. - { primary. secondary } do: - [:encoderClass| | method | - #(('' '') ('^[' ']')) do: "And the locators should work whether in a block or not" - [:pFixes| - "NaN's binding should still be found even though (Float bindingOf: #NaN) ~= (Float bindingOf: #NaN)" - method := (Parser new - encoderClass: encoderClass; - parse: 'foo ', pFixes first, '^NaN', pFixes last class: Float) - generate: CompiledMethodTrailer empty. - [:literal| - self assert: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: false). - self assert: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: true)] value: problem. - - "All the literals should be found in a thorough search, but not otherwise" - method := (Parser new - encoderClass: encoderClass; - parse: 'foo ', pFixes first, '^', literals storeString, pFixes last class: Float) - generate: CompiledMethodTrailer empty. - literals, {problem. problem key} do: - [:literal| - self deny: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: false). - self assert: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: true)]]. - - "Likewise if in a pragma" - method := (Parser new - encoderClass: encoderClass; - parse: 'foo <pragma: ', literals storeString, ' with: ', problem key storeString, '>' class: Float) - generate: CompiledMethodTrailer empty. - literals, {problem. problem key} do: - [:literal| - self deny: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: false). - self assert: (method - refersTo: literal - primaryBytecodeScanner: (primary scanBlockOrNilForLiteral: literal) - secondaryBytecodeScanner: (secondary scanBlockOrNilForLiteral: literal) - thorough: true)]]! Item was changed: ----- Method: PromiseTest>>testTimeout (in category 'testing') ----- testTimeout | promise | promise := Promise new. self shouldnt: [promise waitTimeoutMSecs: 1]. self shouldnt: [promise isResolved]. - self shouldnt: [promise isRejected]. promise resolveWith: 45. self should: [promise waitTimeoutMSecs: 1]. self should: [promise isResolved]. + ! - self shouldnt: [promise isRejected].! Item was removed: - ----- Method: PromiseTest>>testTimeoutRejected (in category 'testing') ----- - testTimeoutRejected - | promise | - promise := Promise new. - self shouldnt: [promise waitTimeoutMSecs: 1]. - self shouldnt: [promise isResolved]. - self shouldnt: [promise isRejected]. - promise rejectWith: 45. - self shouldnt: [promise waitTimeoutMSecs: 1]. - self shouldnt: [promise isResolved]. - self should: [promise isRejected].! Item was changed: ----- Method: TrueTest>>testXor (in category 'testing') ----- testXor self assert: (true xor: true) = false. self assert: (true xor: false) = true. + self assert: (true xor: [true]) = false. + self assert: (true xor: [false]) = true.! - - self - should: [(true xor: [true]) - ifTrue: ["This should never be true, do not signal an Error and let the test fail"] - ifFalse: [self error: 'OK, this should be false, raise an Error']] - raise: Error - description: 'a Block argument is not allowed. If it were, answer would be false'.!

2 1

The Inbox: Kernel-cbc.1163.mcz
by commits＠source.squeak.org 22 Mar '18

22 Mar '18

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-cbc.1163.mcz ==================== Summary ==================== Name: Kernel-cbc.1163 Author: cbc Time: 21 March 2018, 9:09:20.773568 pm UUID: 45d9dad8-7c81-034e-b578-b9ccd291cab6 Ancestors: Kernel-dtl.1162, Kernel-fn.1152 Update #xor: to work with argument being a block as well. =============== Diff against Kernel-dtl.1162 =============== Item was added: + ----- Method: Boolean>>xor: (in category 'logical operations') ----- + xor: aBoolean + "Exclusive OR. Answer true if the receiver is not equivalent to aBoolean." + + ^(self == aBoolean) not! Item was changed: ----- Method: False>>xor: (in category 'logical operations') ----- xor: aBoolean + "aBoolean is either a boolean, or an object who's #value returns a boolean (usually a block)." + ^aBoolean value ifTrue: [ true ] ifFalse: [ false ]! - "Posted by Eliot Miranda to squeak-dev on 3/24/2009" - - ^aBoolean! Item was changed: ----- Method: True>>xor: (in category 'logical operations') ----- xor: aBoolean + "aBoolean is either a boolean, or an object who's #value returns a boolean (usually a block)." + ^aBoolean value ifTrue: [ false ] ifFalse: [ true ]! - "Posted by Eliot Miranda to squeak-dev on 3/24/2009" - - ^aBoolean not!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
15
Older →

Jump to page: