Squeak-dev March 2018

squeak-dev@lists.squeakfoundation.org

53 participants
146 discussions

The Trunk: Morphic-mt.1401.mcz
by commits＠source.squeak.org 27 Mar '18

27 Mar '18

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1401.mcz ==================== Summary ==================== Name: Morphic-mt.1401 Author: mt Time: 27 March 2018, 4:50:25.366732 pm UUID: 7db07362-382c-c94c-b78b-0c4181f5e2e6 Ancestors: Morphic-eem.1400 Fixes two regressions regarding Morphic halo invocation and event handling: 1) do not make halo-invoked morphs come to front, 2) support regular event dispatch while a halo is visible. Note that I realized that we needed another kind of event dispatch for focused morphs. I called it "all-over dispatch" in addition to "full dispatch". If the full event dispatch around the focused morph was not successful, try regular dispatch to give, for example, sibling morphs a chance. The focused morph, however, will be locked during that attempt to not (unsuccessfully) handle the event again. Now, the global halo morph is an example for the use of this all-over dispatch. Maybe you can think of a better name for it. Let me know. =============== Diff against Morphic-eem.1400 =============== Item was added: + ----- Method: MorphicEventDispatcher>>dispatchFocusEventAllOver:with: (in category 'focus events') ----- + dispatchFocusEventAllOver: evt with: focusMorph + "Like a full event dispatch BUT adds regular dispatch if the focus morph did nothing with the event. This is useful for letting the focusMorph's siblings handle the events instead. Take halo invocation as an example. See senders of me." + + | result hand mouseFocus | + result := self dispatchFocusEventFully: evt with: focusMorph. + + result == #rejected ifTrue: [^ result]. + result wasIgnored ifTrue: [^ result]. + result wasHandled ifTrue: [^ result]. + + hand := evt hand. + mouseFocus := hand mouseFocus. + + [ + "Avoid re-dispatching the event to the focus morph. See Morph >> #rejectsEvent:." + focusMorph lock. + + "Handle side effect for mouse-enter and mouse-leave events." + self flag: #hacky. "mt: Maybe we find a better way to synthesize enter/leave events in the future." + hand newMouseFocus: nil. + hand mouseOverHandler processMouseOver: hand lastEvent. + + "Give the morph's world a chance to normally dispatch the event." + ^ focusMorph world processEvent: evt using: self + ] ensure: [ + focusMorph unlock. + evt hand newMouseFocus: mouseFocus].! Item was changed: ----- Method: PasteUpMorph>>tryInvokeHalo: (in category 'events-processing') ----- tryInvokeHalo: anEvent | innerMost target | anEvent hand halo ifNotNil: [^ self "No invocation needed. Halo will handle transfer itself."]. Preferences noviceMode ifTrue: [^ self "No halo in novice mode."]. Preferences cmdGesturesEnabled ifFalse: [^ self]. innerMost := (self morphsAt: anEvent position unlocked: true) first. "1) Try to use innermost morph but skip all the ones that do not want to show a halo along the owner chain." target := innerMost. [target isNil or: [target wantsHaloFromClick]] whileFalse: [target := target owner]. target ifNil: [^ self]. "2) Without a modifier, which is normal, find the outermost container for that inner morph." (innerMost == self or: [anEvent shiftPressed]) ifFalse: [ | previousTargets | previousTargets := OrderedCollection new. [target notNil and: [target owner ~~ self]] whileTrue: [ previousTargets add: target. target := target owner]. target ifNil: [^ self]. [previousTargets isEmpty or: [target wantsHaloFromClick]] whileFalse: [ target := previousTargets removeLast]. target wantsHaloFromClick ifFalse: [^ self]]. + + "3) Now that we have the target, show the halo. Abort event dispatching, too, to avoid confusion." - - "3) Show the container of that nested structure, which is usually my direct submorph." - target withAllOwnersDo: [:ea | ea owner == self ifTrue: [ea comeToFront]]. - - "4) Now that we have the target, show the halo. Abort event dispatching, too, to avoid confusion." anEvent hand newMouseFocus: target event: anEvent. target invokeHaloOrMove: anEvent. anEvent ignore.! Item was changed: ----- Method: SimpleHaloMorph>>processFocusEvent:using: (in category 'events') ----- processFocusEvent: evt using: dispatcher + ^ dispatcher dispatchFocusEventAllOver: evt with: self! - ^ dispatcher dispatchFocusEventFully: evt with: self!

1 0

The Trunk: Kernel-cbc.1163.mcz
by commits＠source.squeak.org 27 Mar '18

27 Mar '18

Chris Cunningham uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cbc.1163.mcz ==================== Summary ==================== Name: Kernel-cbc.1163 Author: cbc Time: 21 March 2018, 9:09:20.773568 pm UUID: 45d9dad8-7c81-034e-b578-b9ccd291cab6 Ancestors: Kernel-dtl.1162, Kernel-fn.1152 Update #xor: to work with argument being a block as well. =============== Diff against Kernel-dtl.1162 =============== Item was added: + ----- Method: Boolean>>xor: (in category 'logical operations') ----- + xor: aBoolean + "Exclusive OR. Answer true if the receiver is not equivalent to aBoolean." + + ^(self == aBoolean) not! Item was changed: ----- Method: False>>xor: (in category 'logical operations') ----- xor: aBoolean + "aBoolean is either a boolean, or an object who's #value returns a boolean (usually a block)." + ^aBoolean value ifTrue: [ true ] ifFalse: [ false ]! - "Posted by Eliot Miranda to squeak-dev on 3/24/2009" - - ^aBoolean! Item was changed: ----- Method: True>>xor: (in category 'logical operations') ----- xor: aBoolean + "aBoolean is either a boolean, or an object who's #value returns a boolean (usually a block)." + ^aBoolean value ifTrue: [ false ] ifFalse: [ true ]! - "Posted by Eliot Miranda to squeak-dev on 3/24/2009" - - ^aBoolean not!

5 9

read-only literals
by Eliot Miranda 27 Mar '18

27 Mar '18

Hi All, the VM now has support for read only objects, and the first logical application is for literals, making boxed floats, strings, symbols, arrays and byte arrays read-only. Doing so is trivial; only two methods need to be modified (see attached). AFAIA little or no core code is broken by making literals read-only. However, when I ran the test suite with read-only literals in place, several tests were broken. These are things like creating null-terminated strings for testing OSProcess, by replacing spaces in string literals with zeros, etc. When we added read-only literals to VisualWorks in something like vw7.0 the balance of opinion was that we should not break user code. Hence we implemented a preference scheme with three states: - By default, an attempt to modify a read-only literal would silently make the literal mutable temporarily,update it and then reenable read-onlyness. - A second state would issue a warning to the transcript, while doing what the default did. - The third state would raise an error Remember that all one needs to do to fix code that modifies literals is to send copy to the literal before modifying the copy, since copies of read-only literals are mutable. I was on the side of only raising an error, but was overruled :-). I wonder what this community thinks. If there are strong views that user code should continue to function unchanged (even though it is modifying literals, which is so so wrong :-) ) I'm happy to implement a scheme similar to that for VisualWorks. But I'd rather not have to and simply have people fix their code within a system that raises an error whenever an attempt is made to modify a literal, and is as simple as possible, but no simpler ;-) Thoughts, opinions? _,,,^..^,,,_ best, Eliot

9 18

The Trunk: KernelTests-cbc.336.mcz
by commits＠source.squeak.org 26 Mar '18

26 Mar '18

Chris Cunningham uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-cbc.336.mcz ==================== Summary ==================== Name: KernelTests-cbc.336 Author: cbc Time: 25 March 2018, 1:51:33.345291 pm UUID: 6e6b91ac-d706-8f4d-bd60-1057109994cb Ancestors: KernelTests-eem.335 Test that new xor: takes blocks - but only those that result in booleans. Others raise errors. =============== Diff against KernelTests-eem.335 =============== Item was changed: ----- Method: FalseTest>>testXor (in category 'tests') ----- testXor self assert: (false xor: true) = true. self assert: (false xor: false) = false. + self assert: (false xor: [true]) = true. + self assert: (false xor: [false]) = false. + self should: [false xor: [1]] raise: NonBooleanReceiver.! - - self - should: [(false xor: [false]) - ifTrue: ["This should never be true, do not signal an Error and let the test fail"] - ifFalse: [self error: 'OK, this should be false, raise an Error']] - raise: Error - description: 'a Block argument is not allowed. If it were, answer would be false'.! Item was changed: ----- Method: TrueTest>>testXor (in category 'testing') ----- testXor self assert: (true xor: true) = false. self assert: (true xor: false) = true. + self assert: (true xor: [true]) = false. + self assert: (true xor: [false]) = true. + self should: [true xor: [1]] raise: NonBooleanReceiver.! - - self - should: [(true xor: [true]) - ifTrue: ["This should never be true, do not signal an Error and let the test fail"] - ifFalse: [self error: 'OK, this should be false, raise an Error']] - raise: Error - description: 'a Block argument is not allowed. If it were, answer would be false'.!

3 4

The Trunk: KernelTests-cbc.337.mcz
by commits＠source.squeak.org 26 Mar '18

26 Mar '18

Chris Cunningham uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-cbc.337.mcz ==================== Summary ==================== Name: KernelTests-cbc.337 Author: cbc Time: 26 March 2018, 11:16:17.932291 am UUID: 412bf5e8-a7c6-334f-9353-153edac45fd9 Ancestors: KernelTests-cbc.336 Correct expected xor: failure to be any type of error, not a specific one. =============== Diff against KernelTests-cbc.336 =============== Item was changed: ----- Method: FalseTest>>testXor (in category 'tests') ----- testXor self assert: (false xor: true) = true. self assert: (false xor: false) = false. self assert: (false xor: [true]) = true. self assert: (false xor: [false]) = false. + "Verify that boolean with non-boolean raise errors." + self should: [false xor: [1]] raise: Error. + self should: [false xor: 1] raise: Error.! - self should: [false xor: [1]] raise: NonBooleanReceiver.! Item was changed: ----- Method: TrueTest>>testXor (in category 'testing') ----- testXor self assert: (true xor: true) = false. self assert: (true xor: false) = true. self assert: (true xor: [true]) = false. self assert: (true xor: [false]) = true. + "Verify that boolean with non-boolean raise errors." + self should: [true xor: [1]] raise: Error. + self should: [true xor: 1] raise: Error.! - self should: [true xor: [1]] raise: NonBooleanReceiver.!

1 0

The Trunk: Monticello-mt.680.mcz
by commits＠source.squeak.org 26 Mar '18

26 Mar '18

Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.680.mcz ==================== Summary ==================== Name: Monticello-mt.680 Author: mt Time: 26 March 2018, 8:40:04.07367 am UUID: f25dda73-849e-4343-83df-398625815819 Ancestors: Monticello-ul.679 Minor improvement of security/privacy in Monticello's HTTP repositories. =============== Diff against Monticello-ul.679 =============== Item was changed: SystemOrganization addCategory: #'Monticello-Base'! SystemOrganization addCategory: #'Monticello-Chunk Format'! + SystemOrganization addCategory: #'Monticello-Environments'! SystemOrganization addCategory: #'Monticello-Loading'! SystemOrganization addCategory: #'Monticello-Merging'! SystemOrganization addCategory: #'Monticello-Modeling'! SystemOrganization addCategory: #'Monticello-Patching'! SystemOrganization addCategory: #'Monticello-Repositories'! SystemOrganization addCategory: #'Monticello-Storing'! SystemOrganization addCategory: #'Monticello-UI'! SystemOrganization addCategory: #'Monticello-Versioning'! - SystemOrganization addCategory: #'Monticello-Environments'! Item was added: + ----- Method: MCHttpRepository>>creationTemplate (in category 'accessing') ----- + creationTemplate + ^ self asCreationTemplate! Item was added: + ----- Method: MCHttpRepository>>creationTemplate: (in category 'accessing') ----- + creationTemplate: aString + creationTemplate := nil.! Item was changed: + (PackageInfo named: 'Monticello') postscript: 'MCHttpRepository allSubInstancesDo: [:ea | ea creationTemplate: nil].'! - (PackageInfo named: 'Monticello') postscript: '"Woops somehow missed renaming the #browseMcMethodHistory service." - MCHttpRepository initialize.'!

1 0

The Trunk: Environments-dtl.72.mcz
by commits＠source.squeak.org 25 Mar '18

25 Mar '18

David T. Lewis uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-dtl.72.mcz ==================== Summary ==================== Name: Environments-dtl.72 Author: dtl Time: 17 March 2018, 3:09:49.564301 pm UUID: e9aed004-8798-41c0-83f9-a04f5963dd55 Ancestors: Environments-jr.71, Environments-fbs.27 Merge Environments-fbs.27 =============== Diff against Environments-jr.71 =============== Item was added: + ----- Method: Environment>>rootClasses (in category 'accessing') ----- + rootClasses + "return a collection of classes which have a nil superclass" + ^ (self select: [:each | each isBehavior and: [each superclass isNil]]) asOrderedCollection.!

5 17

The Trunk: Kernel-fn.1152.mcz
by commits＠source.squeak.org 25 Mar '18

25 Mar '18

Chris Cunningham uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fn.1152.mcz ==================== Summary ==================== Name: Kernel-fn.1152 Author: fn Time: 10 February 2018, 5:39:43.015522 pm UUID: 3f388945-f981-4f1e-830e-a296f4d45a2a Ancestors: Kernel-fn.1151 Move to "logical operations". =============== Diff against Kernel-fn.1151 =============== Item was added: + ----- Method: Boolean>>xor: (in category 'logical operations') ----- + xor: aBoolean + "Exclusive OR. Answer true if the receiver is not equivalent to aBoolean." + + ^(self == aBoolean) not!

1 0

The Trunk: Kernel-fn.1151.mcz
by commits＠source.squeak.org 25 Mar '18

25 Mar '18

Chris Cunningham uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fn.1151.mcz ==================== Summary ==================== Name: Kernel-fn.1151 Author: fn Time: 9 February 2018, 12:32:25.516883 pm UUID: 9fb7df4b-6bf4-4af8-9c75-7496c2f0b517 Ancestors: Kernel-tonyg.1150 For consistency: allow blocks to be passed into #xor: (see #or: and #and:). =============== Diff against Kernel-tonyg.1150 =============== Item was changed: ----- Method: False>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value! - ^aBoolean! Item was changed: ----- Method: True>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value not! - ^aBoolean not!

1 0

Bug in FileChooser
by Javier Diaz-Reinoso 25 Mar '18

25 Mar '18

Create file aaa(2).gcode, then DoIt: 'FileChooser example1', then open aaa(2).gcode, there is an error: 'aaa.gcode does not exist' because now FileChooser try to open aaa.gcode, the problem is in FileList>>fileNameFromFormattedItem: who remove the (2) from the name, why? I really don't understand this. Tested in full updated Squeak6.0alpha #17826.

2 1

← Newer
1
2
3
4
5
6
7
8
9
...
15
Older →

Jump to page: