Squeak-dev August 2019

squeak-dev@lists.squeakfoundation.org

35 participants
288 discussions

The Trunk: Tools-mt.860.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.860.mcz ==================== Summary ==================== Name: Tools-mt.860 Author: mt Time: 4 August 2019, 11:47:29.338314 am UUID: 4c9375a7-9e2f-994f-b08e-7ccb3a620b9e Ancestors: Tools-mt.859 Merges Tools-ct.855, which I moved to treated inbox due to ancestry issues. "Addition to last commit: Style content in ContextVariablesInspector completely according to doItReceiver (highlight instvars correctly)" =============== Diff against Tools-mt.859 =============== Item was changed: ----- Method: ContextVariablesInspector>>aboutToStyle:forMorph: (in category 'styling') ----- aboutToStyle: aStyler forMorph: aMorph + (super aboutToStyle: aStyler forMorph: aMorph) + ifFalse: [^ false]. + aStyler + classOrMetaClass: self doItReceiver class; + context: self doItContext. + ^ true! - aStyler context: self object. - ^ super aboutToStyle: aStyler forMorph: aMorph!

1 0

The Trunk: Tools-ct.852.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.852.mcz ==================== Summary ==================== Name: Tools-ct.852 Author: ct Time: 30 June 2019, 1:53:09.36343 pm UUID: 24bcf5d5-2d7f-2c47-a3c3-f80b0bd5241e Ancestors: Tools-ct.851 Activate code styling for inspector panes in Debugger =============== Diff against Tools-ct.851 =============== Item was changed: ----- Method: Debugger>>buildFullWith: (in category 'toolbuilder') ----- buildFullWith: builder | windowSpec listSpec textSpec | windowSpec := builder pluggableWindowSpec new model: self; label: 'Debugger'; children: OrderedCollection new. listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #toggleContextStackIndex:; menu: #contextStackMenu:shifted:; icon: #messageIconAt:; helpItem: #messageHelpAt:; keyPress: #contextStackKey:from:; frame: (0@0 corner: 1(a)0.22). windowSpec children add: listSpec. textSpec := self buildCodePaneWith: builder. textSpec frame: (0(a)0.22corner: 1(a)0.8). windowSpec children add: textSpec. listSpec := builder pluggableListSpec new. listSpec model: self receiverInspector; list: #fieldList; getIndex: #selectionIndex; setIndex: #toggleIndex:; menu: #fieldListMenu:; keyPress: #inspectorKey:from:; frame: (0(a)0.8 corner: 0.2@1); help: 'Receiver''s\Instance\Variables' withCRs. windowSpec children add: listSpec. + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self receiverInspector; getText: #contents; setText: #accept:; help: '<- Select receiver''s field' translated; selection: #contentsSelection; menu: #codePaneMenu:shifted:; frame: (0.2(a)0.8 corner: 0.5@1). windowSpec children add: textSpec. listSpec := builder pluggableListSpec new. listSpec model: self contextVariablesInspector; list: #fieldList; getIndex: #selectionIndex; setIndex: #toggleIndex:; menu: #fieldListMenu:; keyPress: #inspectorKey:from:; frame: (0.5(a)0.8 corner: 0.7@1); help: 'Other\Context\Bindings' withCRs. windowSpec children add: listSpec. + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self contextVariablesInspector; getText: #contents; setText: #accept:; help: '<- Select context''s field' translated; selection: #contentsSelection; menu: #codePaneMenu:shifted:; frame: (0.7(a)0.8 corner: 1@1). windowSpec children add: textSpec. ^builder build: windowSpec!

1 0

The Trunk: Tools-ct.853.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.853.mcz ==================== Summary ==================== Name: Tools-ct.853 Author: ct Time: 7 July 2019, 7:58:37.726178 pm UUID: a11f70d4-3f36-894a-89e7-78011f6ab2e2 Ancestors: Tools-ct.852 Refine styling in Inspector & Debugger This commit is based on ToolBuilder-Morphic-ct.228 (#aboutToStyle:forMorph:). - Introduce a state for Inspector (shouldStyleValuePane) that indicates whether to style the value pane - Name the value pane to identify it - Allow styling in every inspector window - Refactor the debugger toolbuilding and refer to inspector's building methods (they shared many common properties) Also see the following thread: http://forum.world.st/The-Inbox-Tools-ct-852-mcz-td5100784.html =============== Diff against Tools-ct.851 =============== Item was changed: ----- Method: Debugger>>buildFullWith: (in category 'toolbuilder') ----- buildFullWith: builder | windowSpec listSpec textSpec | windowSpec := builder pluggableWindowSpec new model: self; label: 'Debugger'; children: OrderedCollection new. listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #toggleContextStackIndex:; menu: #contextStackMenu:shifted:; icon: #messageIconAt:; helpItem: #messageHelpAt:; keyPress: #contextStackKey:from:; frame: (0@0 corner: 1(a)0.22). windowSpec children add: listSpec. textSpec := self buildCodePaneWith: builder. textSpec frame: (0(a)0.22corner: 1(a)0.8). windowSpec children add: textSpec. + listSpec := self receiverInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self receiverInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0(a)0.8 corner: 0.2@1); help: 'Receiver''s\Instance\Variables' withCRs. windowSpec children add: listSpec. + textSpec := self receiverInspector buildValuePaneWith: builder. - textSpec := builder pluggableTextSpec new. textSpec - model: self receiverInspector; - getText: #contents; - setText: #accept:; help: '<- Select receiver''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.2(a)0.8 corner: 0.5@1). windowSpec children add: textSpec. + listSpec := self contextVariablesInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self contextVariablesInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0.5(a)0.8 corner: 0.7@1); help: 'Other\Context\Bindings' withCRs. windowSpec children add: listSpec. + textSpec := self contextVariablesInspector buildValuePaneWith: builder. - textSpec := builder pluggableTextSpec new. textSpec - model: self contextVariablesInspector; - getText: #contents; - setText: #accept:; help: '<- Select context''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.7(a)0.8 corner: 1@1). windowSpec children add: textSpec. ^builder build: windowSpec! Item was changed: StringHolder subclass: #Inspector + instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression shouldStyleValuePane' - instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression' classVariableNames: '' poolDictionaries: '' category: 'Tools-Inspector'! !Inspector commentStamp: '<historical>' prior: 0! I represent a query path into the internal representation of an object. As a StringHolder, the string I represent is the value of the currently selected variable of the observed object.! Item was removed: - ----- Method: Inspector>>aboutToStyle: (in category 'styling') ----- - aboutToStyle: aStyler - - aStyler - classOrMetaClass: object class; - parseAMethod: false. - ^true! Item was added: + ----- Method: Inspector>>aboutToStyle:forMorph: (in category 'styling') ----- + aboutToStyle: aStyler forMorph: aMorph + + (aMorph knownName = #valuePane and: [shouldStyleValuePane not]) + ifTrue: [^ false]. + + aStyler + classOrMetaClass: object class; + parseAMethod: false. + ^true! Item was changed: ----- Method: Inspector>>buildValuePaneWith: (in category 'toolbuilder') ----- buildValuePaneWith: builder | textSpec | + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self; + name: #valuePane; getText: #contents; setText: #accept:; + editText: #typeValue:; help: 'Selection details.'; selection: #contentsSelection; menu: #codePaneMenu:shifted:. ^textSpec! Item was changed: ----- Method: Inspector>>initialize (in category 'initialize-release') ----- initialize selectionIndex := 0. + shouldStyleValuePane := true. super initialize! Item was changed: ----- Method: Inspector>>toggleIndex: (in category 'selecting') ----- toggleIndex: anInteger "The receiver has a list of variables of its inspected object. One of these is selected. If anInteger is the index of this variable, then deselect it. Otherwise, make the variable whose index is anInteger be the selected item." selectionUpdateTime := 0. selectionIndex = anInteger ifTrue: ["same index, turn off selection" selectionIndex := 0. contents := ''] ifFalse: ["different index, new selection" + shouldStyleValuePane := false. selectionIndex := anInteger. self contentsIsString ifTrue: [contents := self selection] ifFalse: [contents := self selectionPrintString]]. self changed: #selection. self changed: #contents. self changed: #selectionIndex.! Item was added: + ----- Method: Inspector>>typeValue: (in category 'selecting') ----- + typeValue: aTextOrString + + shouldStyleValuePane := true. + self changed: #style!

1 0

The Trunk: Tools-mt.859.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.859.mcz ==================== Summary ==================== Name: Tools-mt.859 Author: mt Time: 4 August 2019, 11:44:43.754314 am UUID: 3150edde-eaec-1840-ac4c-fe5db691d640 Ancestors: Tools-mt.858, Tools-ct.853 Merges Tools-ct.853 and ct.854. The latter was moved to treated inbox due to strange ancestry. Adds style-on-type for all value panes in inspector and debugger. =============== Diff against Tools-mt.858 =============== Item was added: + ----- Method: ContextVariablesInspector>>aboutToStyle:forMorph: (in category 'styling') ----- + aboutToStyle: aStyler forMorph: aMorph + + aStyler context: self object. + ^ super aboutToStyle: aStyler forMorph: aMorph! Item was changed: ----- Method: Debugger>>buildFullWith: (in category 'toolbuilder') ----- buildFullWith: builder | windowSpec listSpec textSpec | windowSpec := builder pluggableWindowSpec new model: self; label: 'Debugger'; children: OrderedCollection new. listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #toggleContextStackIndex:; menu: #contextStackMenu:shifted:; icon: #messageIconAt:; helpItem: #messageHelpAt:; keyPress: #contextStackKey:from:; frame: (0@0 corner: 1(a)0.22). windowSpec children add: listSpec. textSpec := self buildCodePaneWith: builder. textSpec frame: (0(a)0.22corner: 1(a)0.8). windowSpec children add: textSpec. + listSpec := self receiverInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self receiverInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0(a)0.8 corner: 0.2@1); help: 'Receiver''s\Instance\Variables' withCRs. windowSpec children add: listSpec. + textSpec := self receiverInspector buildValuePaneWith: builder. - textSpec := builder pluggableTextSpec new. textSpec - model: self receiverInspector; - getText: #contents; - setText: #accept:; help: '<- Select receiver''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.2(a)0.8 corner: 0.5@1). windowSpec children add: textSpec. + listSpec := self contextVariablesInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self contextVariablesInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0.5(a)0.8 corner: 0.7@1); help: 'Other\Context\Bindings' withCRs. windowSpec children add: listSpec. + textSpec := self contextVariablesInspector buildValuePaneWith: builder. - textSpec := builder pluggableTextSpec new. textSpec - model: self contextVariablesInspector; - getText: #contents; - setText: #accept:; help: '<- Select context''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.7(a)0.8 corner: 1@1). windowSpec children add: textSpec. ^builder build: windowSpec! Item was changed: StringHolder subclass: #Inspector + instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression shouldStyleValuePane' - instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression' classVariableNames: '' poolDictionaries: '' category: 'Tools-Inspector'! !Inspector commentStamp: '<historical>' prior: 0! I represent a query path into the internal representation of an object. As a StringHolder, the string I represent is the value of the currently selected variable of the observed object.! Item was removed: - ----- Method: Inspector>>aboutToStyle: (in category 'styling') ----- - aboutToStyle: aStyler - - aStyler - classOrMetaClass: object class; - parseAMethod: false. - ^true! Item was added: + ----- Method: Inspector>>aboutToStyle:forMorph: (in category 'styling') ----- + aboutToStyle: aStyler forMorph: aMorph + + (aMorph knownName = #valuePane and: [shouldStyleValuePane not]) + ifTrue: [^ false]. + + aStyler + classOrMetaClass: object class; + parseAMethod: false. + ^true! Item was changed: ----- Method: Inspector>>buildValuePaneWith: (in category 'toolbuilder') ----- buildValuePaneWith: builder | textSpec | + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self; + name: #valuePane; getText: #contents; setText: #accept:; + editText: #typeValue:; help: 'Selection details.'; selection: #contentsSelection; menu: #codePaneMenu:shifted:. ^textSpec! Item was changed: ----- Method: Inspector>>initialize (in category 'initialize-release') ----- initialize selectionIndex := 0. + shouldStyleValuePane := true. super initialize! Item was changed: ----- Method: Inspector>>toggleIndex: (in category 'selecting') ----- toggleIndex: anInteger "The receiver has a list of variables of its inspected object. One of these is selected. If anInteger is the index of this variable, then deselect it. Otherwise, make the variable whose index is anInteger be the selected item." selectionUpdateTime := 0. selectionIndex = anInteger ifTrue: ["same index, turn off selection" selectionIndex := 0. contents := ''] ifFalse: ["different index, new selection" + shouldStyleValuePane := false. selectionIndex := anInteger. self contentsIsString ifTrue: [contents := self selection] ifFalse: [contents := self selectionPrintString]]. self changed: #selection. self changed: #contents. self changed: #selectionIndex.! Item was added: + ----- Method: Inspector>>typeValue: (in category 'selecting') ----- + typeValue: aTextOrString + + shouldStyleValuePane := true. + self changed: #style!

1 0

The Inbox: Protocols-jr.63.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

A new version of Protocols was added to project The Inbox: http://source.squeak.org/inbox/Protocols-jr.63.mcz ==================== Summary ==================== Name: Protocols-jr.63 Author: jr Time: 4 August 2019, 11:40:18.213513 am UUID: 7921d09f-b335-5e4e-bb85-ace62a287eb7 Ancestors: Protocols-pre.62 Implement spontaneous overriding of methods from Lexicon. Use a new instance variable to temporarily hold which class is the target of the current accept operation. Make sure to update the message list in case the current selector's class has now changed. Assumption: setClassAndSelectorIn: must provide the data of the currently selected method and it will not pretend to view a different class. Also add browseFullProtocol to ClassDescription to make it easier to open a Lexicon from a Workspace or the search box. Depends on Tools-jr.859. =============== Diff against Protocols-pre.62 =============== Item was added: + ----- Method: ClassDescription>>browseFullProtocol (in category '*Protocols-Tools') ----- + browseFullProtocol + Lexicon new openOnClass: self showingSelector: nil.! Item was changed: ProtocolBrowser subclass: #Lexicon + instanceVariableNames: 'currentVocabulary categoryList categoryListIndex targetClass limitClass currentQuery currentQueryParameter selectorsVisited compileTargetClass' - instanceVariableNames: 'currentVocabulary categoryList categoryListIndex targetClass limitClass currentQuery currentQueryParameter selectorsVisited' classVariableNames: '' poolDictionaries: '' category: 'Protocols-Tools'! + !Lexicon commentStamp: 'jr 8/4/2019 11:36' prior: 0! - !Lexicon commentStamp: 'fbs 5/2/2013 08:29' prior: 0! An instance of Lexicon shows the list of all the method categories known to an object or any of its superclasses, as a "flattened" list, and, within any selected category, shows all methods understood by the class's instances which are associated with that category, again as a "flattened" list. A variant with a search pane rather than a category list is also implemented. categoryList the list of categories categoryListIndex index of currently-selected category targetObject optional -- an instance being viewed targetClass the class being viewed lastSearchString the last string searched for lastSendersSearchSelector the last senders search selector limitClass optional -- the limit class to search for selectorsVisited list of selectors visited selectorsActive not presently in use, subsumed by selectorsVisited currentVocabulary the vocabulary currently installed currentQuery what the query category relates to: + #senders #selectorName #currentChangeSet + compileTargetClass transient -- behavior in which the current contents is + accepted/compiled! - #senders #selectorName #currentChangeSet! Item was added: + ----- Method: Lexicon>>contents:notifying: (in category 'private') ----- + contents: aString notifying: aController + "Make sure a possible choice of the compileTargetClass is not remembered." + [^ super contents: aString notifying: aController] + ensure: [compileTargetClass := nil]! Item was added: + ----- Method: Lexicon>>contents:oldSelector:in:classified:notifying: (in category 'private') ----- + contents: aString oldSelector: oldSelector in: aClass classified: category notifying: aController + "Update messageList if a method is compiled because the selector might be in a + different class now." + ^ (super contents: aString oldSelector: oldSelector in: aClass classified: category notifying: aController) + ifTrue: [ self reformulateList. ^ true] + ifFalse: [false]! Item was changed: ----- Method: Lexicon>>okayToAccept (in category 'model glue') ----- okayToAccept "Answer whether it is okay to accept the receiver's input" + | ok reply | - | ok aClass reply | (ok := super okayToAccept) ifTrue: + [((compileTargetClass := self selectedClassOrMetaClass) ~~ targetClass) ifTrue: - [((aClass := self selectedClassOrMetaClass) ~~ targetClass) ifTrue: [reply := UIManager default chooseFrom: + {'okay, no problem'. + 'cancel - let me reconsider'. + 'compile into ', targetClass name, ' instead'. + 'compile into a new uniclass'} title: - {'okay, no problem'. - 'cancel - let me reconsider'. - 'compile into ', targetClass name, ' instead'. - 'compile into a new uniclass'} title: 'Caution!! This would be + accepted into class ', compileTargetClass name, '. + Is that okay?'. + reply caseOf: + {[1] -> [^ true]. + [2] -> [^ false]. + [3] -> [compileTargetClass := targetClass. ^ true]} + otherwise: [self notYetImplemented]]]. - accepted into class ', aClass name, '. - Is that okay?' . - reply = 1 ifTrue: [^ true]. - reply ~= 2 ifTrue: - [self notYetImplemented]. - ^ false]]. ^ ok! Item was removed: - ----- Method: Lexicon>>setClassAndSelectorIn: (in category 'selection') ----- - setClassAndSelectorIn: csBlock - "Decode strings of the form <selectorName> (<className> [class])" - - - self selection ifNil: [^ csBlock value: targetClass value: nil]. - ^ super setClassAndSelectorIn: csBlock! Item was added: + ----- Method: Lexicon>>targetForContents: (in category 'private') ----- + targetForContents: aString + ^ compileTargetClass!

1 0

The Trunk: ToolBuilder-Morphic-ct.228.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.228.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.228 Author: ct Time: 7 July 2019, 7:57:32.634178 pm UUID: fa6c1281-afb6-d34d-aeb4-ca2428d2c2d8 Ancestors: ToolBuilder-Morphic-pre.227 Add optional parameter for the #aboutToStyle: call You can now, optionally, implement #aboutToStyle:forMorph: instead of #aboutToStyle:. =============== Diff against ToolBuilder-Morphic-pre.227 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>okToStyle (in category 'testing') ----- okToStyle ^ styler ifNil:[false] + ifNotNil: [:s | (model class canUnderstand: #aboutToStyle:forMorph:) + ifTrue: [model aboutToStyle: s forMorph: self] + ifFalse: [model aboutToStyle: s]]! - ifNotNil: [:s | model aboutToStyle: s]!

1 0

The Trunk: ToolBuilder-Morphic-mt.233.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.233.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.233 Author: mt Time: 4 August 2019, 11:29:50.851314 am UUID: d615205a-b262-fa40-80c5-a5054d962a23 Ancestors: ToolBuilder-Morphic-mt.232, ToolBuilder-Morphic-ct.228 Complements Kernel-mt.1253. Merges ct.228 from inbox. =============== Diff against ToolBuilder-Morphic-mt.232 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>okToStyle (in category 'testing') ----- okToStyle ^ styler + ifNil: [false] + ifNotNil: [:s | model aboutToStyle: s forMorph: self]! - ifNil:[false] - ifNotNil: [:s | model aboutToStyle: s]!

1 0

The Trunk: PreferenceBrowser-mt.87.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-mt.87.mcz ==================== Summary ==================== Name: PreferenceBrowser-mt.87 Author: mt Time: 4 August 2019, 11:28:59.837314 am UUID: f2ce8c78-a60f-7744-928a-324a751c68f5 Ancestors: PreferenceBrowser-mt.86 Complements Kernel-mt.1253. =============== Diff against PreferenceBrowser-mt.86 =============== Item was added: + ----- Method: PBClassPreferenceView>>aboutToStyle:forMorph: (in category 'styling') ----- + aboutToStyle: styler forMorph: morph + "For Shout styling support." + ^ true!

1 0

The Trunk: Kernel-mt.1253.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1253.mcz ==================== Summary ==================== Name: Kernel-mt.1253 Author: mt Time: 4 August 2019, 11:28:20.673314 am UUID: 38317323-3403-404c-88d2-20ce552e20ec Ancestors: Kernel-mt.1252 Let models configure the styler based on the particular view (or morph or widget). This is related to merging ToolBuilder-Morphic-ct.228. =============== Diff against Kernel-mt.1252 =============== Item was added: + ----- Method: Model>>aboutToStyle:forMorph: (in category 'morphic ui') ----- + aboutToStyle: aStyler forMorph: aMorph + "View-specific extension for styling. Overwrite this method to configure the styler with morph-specific information." + + ^ self aboutToStyle: aStyler!

1 0

The Inbox: Tools-jr.859.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.859.mcz ==================== Summary ==================== Name: Tools-jr.859 Author: jr Time: 4 August 2019, 11:23:31.139513 am UUID: da4ec759-c2aa-6040-9151-53c2942b3e88 Ancestors: Tools-mt.858 Refactor accept in MessageSet such that subclasses can override in which class the contents will be compiled. This will allow Lexicon (package Protocols) to create an override from an inherited method without switching the tool. Assumption: setClassAndSelectorIn: must provide the data of the currently selected method and it will not pretend to view a different class. Also split the contents:notifying: method since it did several things at once and was quite long. =============== Diff against Tools-mt.858 =============== Item was changed: ----- Method: MessageSet>>contents:notifying: (in category 'private') ----- contents: aString notifying: aController "Compile the code in aString. Notify aController of any syntax errors. Answer false if the compilation fails. Otherwise, if the compilation created a new method, deselect the current selection. Then answer true." + | category class oldSelector | - | category selector class oldSelector | self okayToAccept ifFalse: [^ false]. + class := self targetForContents: aString. - self setClassAndSelectorIn: [:c :os | class := c. oldSelector := os]. class ifNil: [^ false]. + self setClassAndSelectorIn: [:c :os | oldSelector := os]. + (self contents: aString specialSelector: oldSelector in: class notifying: aController) + ifTrue: [^ false]. - (oldSelector ~~ nil and: [oldSelector first isUppercase]) ifTrue: - [oldSelector = #Comment ifTrue: - [class comment: aString stamp: Utilities changeStamp. - self changed: #annotation. - self clearUserEditFlag. - ^ false]. - oldSelector = #Definition ifTrue: - ["self defineClass: aString notifying: aController." - class subclassDefinerClass - evaluate: aString - notifying: aController - logged: true. - self clearUserEditFlag. - ^ false]. - oldSelector = #Hierarchy ifTrue: - [self inform: 'To change the hierarchy, edit the class definitions'. - ^ false]]. "Normal method accept" + category := self selectedMessageCategoryName. + ^ self contents: aString + oldSelector: oldSelector + in: class + classified: category + notifying: aController! - category := class organization categoryOfElement: oldSelector. - selector := class compile: aString - classified: category - notifying: aController. - selector == nil ifTrue: [^ false]. - self noteAcceptanceOfCodeFor: selector. - selector == oldSelector ifFalse: - [self reformulateListNoting: selector]. - contents := aString copy. - self changed: #annotation. - ^ true! Item was added: + ----- Method: MessageSet>>contents:oldSelector:in:classified:notifying: (in category 'private') ----- + contents: aString oldSelector: oldSelector in: aClass classified: category notifying: aController + "Compile the code in aString. Notify aController of any syntax errors. + Answer false if the compilation fails. Otherwise, if the compilation + created a new method, deselect the current selection. Then answer true." + | selector | + selector := aClass compile: aString + classified: category + notifying: aController. + selector == nil ifTrue: [^ false]. + self noteAcceptanceOfCodeFor: selector. + selector == oldSelector ifFalse: + [self reformulateListNoting: selector]. + contents := aString copy. + self changed: #annotation. + ^ true! Item was added: + ----- Method: MessageSet>>contents:specialSelector:in:notifying: (in category 'private') ----- + contents: aString specialSelector: oldSelector in: aClass notifying: aController + "If the selector is a fake to denote a different definition than that of a method, + try to change that different object. Answer whether a special selector was found and + handled." + (oldSelector ~~ nil and: [oldSelector first isUppercase]) ifFalse: [^ false]. + oldSelector = #Comment ifTrue: + [aClass comment: aString stamp: Utilities changeStamp. + self changed: #annotation. + self clearUserEditFlag. + ^ true]. + oldSelector = #Definition ifTrue: + ["self defineClass: aString notifying: aController." + aClass subclassDefinerClass + evaluate: aString + notifying: aController + logged: true. + self clearUserEditFlag. + ^ true]. + oldSelector = #Hierarchy ifTrue: + [self inform: 'To change the hierarchy, edit the class definitions'. + ^ true]. + ^ false! Item was added: + ----- Method: MessageSet>>targetForContents: (in category 'private') ----- + targetForContents: aString + "Answer the behavior into which the contents will be accepted." + self setClassAndSelectorIn: [:c :os | ^ c]. + ^ nil "fail safe for overriding implementations of setClassAndSelectorIn:"!

1 0

Jump to page: