Squeak-dev August 2019

squeak-dev@lists.squeakfoundation.org

35 participants
288 discussions

The Trunk: Tools-mt.857.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.857.mcz ==================== Summary ==================== Name: Tools-mt.857 Author: mt Time: 4 August 2019, 10:10:22.694314 am UUID: 939fa67c-333f-3241-83c4-2983e2b01e15 Ancestors: Tools-mt.855, Tools-ct.850 Merges Tools-cmm.849 and Tools-ct.850. =============== Diff against Tools-mt.855 =============== Item was changed: ----- Method: ChangeSorter>>setContents (in category 'code pane') ----- setContents "return the source code that shows in the bottom pane" | sel class strm changeType | self clearUserEditFlag. + myChangeSet ifNil: [^ contents := String empty]. "should not happen but can" + currentClassName ifNil: [^ contents := myChangeSet preambleString ifNil: [String empty]]. - currentClassName ifNil: [^ contents := myChangeSet preambleString ifNil: ['']]. class := self selectedClassOrMetaClass. (sel := self selectedMessageName) == nil ifFalse: [changeType := (myChangeSet atSelector: (sel := sel asSymbol) class: class). changeType == #remove ifTrue: [^ contents := 'Method has been removed (see versions)']. changeType == #addedThenRemoved ifTrue: [^ contents := 'Added then removed (see versions)']. class ifNil: [^ contents := 'Method was added, but cannot be found!!']. (class includesSelector: sel) ifFalse: [^ contents := 'Method was added, but cannot be found!!']. contents := class sourceCodeAt: sel. (#(prettyPrint prettyDiffs) includes: contentsSymbol) ifTrue: [contents := class prettyPrinterClass format: contents in: class notifying: nil]. self showingAnyKindOfDiffs ifTrue: [contents := self diffFromPriorSourceFor: contents]. ^ contents := contents asText makeSelectorBoldIn: class] ifTrue: [strm := WriteStream on: (String new: 100). (myChangeSet classChangeAt: (self withoutItemAnnotation: currentClassName)) do: [:each | each = #remove ifTrue: [strm nextPutAll: 'Entire class was removed.'; cr]. each = #addedThenRemoved ifTrue: [strm nextPutAll: 'Class was added then removed.']. each = #rename ifTrue: [strm nextPutAll: 'Class name was changed.'; cr]. each = #add ifTrue: [strm nextPutAll: 'Class definition was added.'; cr]. each = #change ifTrue: [strm nextPutAll: 'Class definition was changed.'; cr]. each = #reorganize ifTrue: [strm nextPutAll: 'Class organization was changed.'; cr]. each = #comment ifTrue: [strm nextPutAll: 'New class comment.'; cr. ]]. ^ contents := strm contents].! Item was changed: ----- Method: MessageSet>>filterMessageList (in category 'filtering') ----- filterMessageList "Allow the user to refine the list of messages." | builder menuSpec | builder := ToolBuilder default. menuSpec := builder pluggableMenuSpec new model: self; yourself. menuSpec addList: #( ('unsent messages' filterToUnsentMessages 'filter to show only messages that have no senders') - ('messages that send...' filterToSendersOf 'filter to show only messages that send a selector I specify') ('messages that do not send...' filterToNotSendersOf 'filter to show only messages that do not send a selector I specify') - ('messages whose selector is...' filterToImplementorsOf 'filter to show only messages with a given selector I specify') ('messages whose selector is NOT...' filterToNotImplementorsOf 'filter to show only messages whose selector is NOT a seletor I specify') - ('messages in current change set' filterToCurrentChangeSet 'filter to show only messages that are in the current change set') ('messages not in current change set' filterToNotCurrentChangeSet 'filter to show only messages that are not in the current change set') - ('messages in any change set' filterToAnyChangeSet 'filter to show only messages that occur in at least one change set') ('messages not in any change set' filterToNotAnyChangeSet 'filter to show only messages that do not occur in any change set in the system') - ('messages authored by me' filterToCurrentAuthor 'filter to show only messages whose authoring stamp has my initials') ('messages not authored by me' filterToNotCurrentAuthor 'filter to show only messages whose authoring stamp does not have my initials') - ('messages logged in .changes file' filterToMessagesInChangesFile 'filter to show only messages whose latest source code is logged in the .changes file') ('messages only in .sources file' filterToMessagesInSourcesFile 'filter to show only messages whose latest source code is logged in the .sources file') - ('messages with prior versions' filterToMessagesWithPriorVersions 'filter to show only messages that have at least one prior version') ('messages without prior versions' filterToMessagesWithoutPriorVersions 'filter to show only messages that have no prior versions') - ('uncommented messages' filterToUncommentedMethods 'filter to show only messages that do not have comments at the beginning') ('commented messages' filterToCommentedMethods 'filter to show only messages that have comments at the beginning') - ('messages in hardened classes' filterToMessagesWithHardenedClasses 'filter to show only messages of established classes (as opposed to Uniclasses such as Player23)') - ('methods in classes with matching names' filterToMatchingClassesNames 'filter to show only methods of classes with names that match the given criteria (wildcards are allowed)') ('methods in package...' filterToPackage 'filter to show only methods of a given package') + ('methods not in package...' filterToNotPackage 'filter to show only methods not of a given package') - ('messages that...' filterToMessagesThat 'let me type in a block taking a class and a selector, which will specify yea or nay concerning which elements should remain in the list')). builder runModal: (builder open: menuSpec).! Item was added: + ----- Method: MessageSet>>filterToNotPackage (in category 'filtering') ----- + filterToNotPackage + self requestPackageSelection ifNotNil: + [ : selectedPackage | self filterFrom: + [ : aClass : aSelector | (selectedPackage + includesMethod: aSelector + ofClass: aClass) not ] ]! Item was changed: ----- Method: MessageSet>>filterToPackage (in category 'filtering') ----- filterToPackage + self requestPackageSelection ifNotNil: + [ : selectedPackage | self filterFrom: + [ : aClass : aSelector | selectedPackage + includesMethod: aSelector + ofClass: aClass ] ]! - - | packages selectedIndex selectedPackage | - - packages := (PackageOrganizer default packages sort: [ :a :b | - a packageName <= b packageName ]). - - selectedIndex := UIManager default chooseFrom: (packages collect:[:each | each packageName]) lines: #() title: 'Select a package...'. - selectedIndex isZero ifTrue:[^ self]. - - selectedPackage := packages at: selectedIndex. - self filterFrom: [:aClass :aSelector | selectedPackage includesMethod: aSelector ofClass: aClass ] - ! Item was added: + ----- Method: MessageSet>>requestPackageSelection (in category 'private') ----- + requestPackageSelection + | packages selectedIndex | + packages := PackageOrganizer default packages sort: + [ : a : b | a packageName <= b packageName ]. + selectedIndex := UIManager default + chooseFrom: (packages collect: [ : each | each packageName ]) + lines: Array empty + title: 'Select a package...'. + ^ packages at: selectedIndex ifAbsent: [ nil ]! Item was added: + ----- Method: SearchBar>>spawn: (in category '*Tools') ----- + spawn: contentsString + + UIManager default edit: contentsString label: 'Workspace'!

1 0

The Trunk: ShoutCore-ct.66.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-ct.66.mcz ==================== Summary ==================== Name: ShoutCore-ct.66 Author: ct Time: 21 July 2019, 1:20:54.761477 pm UUID: d881aecc-1ceb-4b4d-a3f6-02ac4e71cbbf Ancestors: ShoutCore-ul.65 Allow context-dependent styling We will be able to use this in ContextVariableInspector =============== Diff against ShoutCore-ul.65 =============== Item was changed: Object subclass: #SHParserST80 + instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition blockDepth bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors parseAMethod context' - instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition blockDepth bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors parseAMethod' classVariableNames: '' poolDictionaries: '' category: 'ShoutCore-Parsing'! !SHParserST80 commentStamp: 'tween 8/16/2004 15:44' prior: 0! I am a Smalltalk method / expression parser. Rather than creating an Abstract Syntax Tree, I create a sequence of SHRanges (in my 'ranges' instance variable), which represent the tokens within the String I am parsing. I am used by a SHTextStylerST80 to parse method source strings. I am able to parse incomplete / incorrect methods, and so can be used to parse methods that are being edited. My 'source' instance variable should be set to the string to be parsed. My 'classOrMetaClass' instance var must be set to the class or metaClass for the method source so that I can correctly resolve identifiers within the source. If this is nil , I parse the source as an expression (i.e. a doIt expression). My 'workspace' instance variable can be set to a Workspace, so that I can resolve workspace variables. My 'environment' instance variable is the global namespace (this is initialized to Smalltalk, but can be set to a different environment). Example 1. ranges := SHParserST80 new classOrMetaClass: Object; source: 'testMethod ^self'; parse; ranges ! Item was changed: ----- Method: SHParserST80>>parse: (in category 'parse') ----- parse: isAMethod "Parse the receiver's text. If isAMethod is true then treat text as a method, if false as an expression with no message pattern" self initializeInstanceVariables. allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. sourcePosition := 1. arguments := Dictionary new. temporaries := Dictionary new. blockDepth := bracketDepth := 0. ranges ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] ifNotNil: [ ranges reset ]. + context ifNotNil: [ + (context tempNames copyFrom: 1 to: context numArgs) + do: [:arg | self pushArgument: arg]. + (context tempNames allButFirst: context numArgs) + do: [:temp | self pushTemporary: temp]]. errorBlock := [^false]. self scanNext. isAMethod ifTrue: [ self parseMessagePattern; parsePragmaSequence ]. self parseMethodTemporaries. isAMethod ifTrue: [ self parsePragmaSequence ]. self parseStatementList. currentToken ifNotNil: [ self error ]. ^true! Item was changed: ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment: (in category 'parse') ----- rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil + ^ self rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: nil! - anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. - self - workspace: aWorkspace; - classOrMetaClass: aBehaviour; - source: sourceString. - self parse. - ^ranges! Item was added: + ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment:context: (in category 'parse') ----- + rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: aContextOrNil + anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. + aContextOrNil ifNotNil: [context := aContextOrNil]. + self + workspace: aWorkspace; + classOrMetaClass: aBehaviour; + source: sourceString. + self parse. + ^ranges! Item was changed: SHTextStyler subclass: #SHTextStylerST80 + instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod context' - instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod' classVariableNames: 'SyntaxHighlightingAsYouType SyntaxHighlightingAsYouTypeAnsiAssignment SyntaxHighlightingAsYouTypeLeftArrowAssignment TextAttributesByPixelHeight' poolDictionaries: '' category: 'ShoutCore-Styling'! !SHTextStylerST80 commentStamp: 'tween 8/27/2004 10:55' prior: 0! I style Smalltalk methods and expressions. My 'styleTable' class instance var holds an array ofArrays which control how each token is styled/coloured. See my defaultStyleTable class method for its structure. My styleTable can be changed by either modifying the defaultStyleTable class method and then executing SHTextStylerST80 initialize ; or by giving me a new styleTable through my #styleTable: class method. My 'textAttributesByPixelSize' class instance var contains a dictionary of dictionaries. The key is a pixelSize and the value a Dictionary from token type Symbol to TextAttribute array. It is created/maintained automatically. I also install these 3 preferences when my class initialize method is executed.... #syntaxHighlightingAsYouType - controls whether methods are styled in browsers #syntaxHighlightingAsYouTypeAnsiAssignment - controls whether assignments are formatted to be := #syntaxHighlightingAsYouTypeLeftArrowAssignment - controls whether assignments are formatted to be _ I reimplement #unstyledTextFrom: so that TextActions are preserved in the unstyled text ! Item was added: + ----- Method: SHTextStylerST80>>context: (in category 'accessing') ----- + context: aContext + context := aContext! Item was changed: ----- Method: SHTextStylerST80>>rangesIn:setWorkspace: (in category 'private') ----- rangesIn: aText setWorkspace: aBoolean "Answer a collection of SHRanges by parsing aText. When formatting it is not necessary to set the workspace, and this can make the parse take less time, so aBoolean specifies whether the parser should be given the workspace" | shoutParserClass | "Switch parsers if we have to" shoutParserClass := (classOrMetaClass ifNil:[Object]) shoutParserClass. parser class == shoutParserClass ifFalse:[parser := shoutParserClass new]. parser parseAMethod: parseAMethod. ^parser rangesIn: aText asString classOrMetaClass: classOrMetaClass workspace: (aBoolean ifTrue:[workspace]) environment: environment + context: context! - !

1 0

The Trunk: ShoutCore-ul.68.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-ul.68.mcz ==================== Summary ==================== Name: ShoutCore-ul.68 Author: ul Time: 30 July 2019, 4:54:51.155525 pm UUID: c4f9bfa4-c725-48d5-beb1-4805e5e0efd2 Ancestors: ShoutCore-ul.67, ShoutCore-ct.66 - merged with ShoutCore-ct.66 - extracted most instance variable initialization before parsing to SHParserST80 >> #initializeInstanceVariables - improved #parseString - implemented #= and #hash for SHRange =============== Diff against ShoutCore-ul.67 =============== Item was changed: Object subclass: #SHParserST80 + instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors allowBlockArgumentAssignment parseAMethod currentTokenType context' - instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors allowBlockArgumentAssignment parseAMethod currentTokenType' classVariableNames: '' poolDictionaries: '' category: 'ShoutCore-Parsing'! + !SHParserST80 commentStamp: 'ul 7/30/2019 00:31' prior: 0! - !SHParserST80 commentStamp: 'ul 7/18/2019 21:12' prior: 0! I am a Smalltalk method / expression parser. Rather than creating an Abstract Syntax Tree, I create a sequence of SHRanges (in my 'ranges' instance variable), which represent the tokens within the String I am parsing. I am used by a SHTextStylerST80 to parse method source strings. I am able to parse incomplete / incorrect methods, and so can be used to parse methods that are being edited. Instance Variables allowBlockArgumentAssignment: <Boolean> allowUnderscoreAssignments: <Boolean> allowUnderscoreSelectors: <Boolean> arguments: <OrderedCollection<OrderedCollection<String>|nil> bracketDepth: <Integer> classOrMetaClass: <Class|nil> currentToken: <String|nil> currentTokenFirst: <Character> currentTokenSourcePosition: <Integer|nil> currentTokenType: <Symbol|nil> environment: <Environment> errorBlock: <Block> instanceVariables: <Array> parseAMethod: <Boolean> ranges: <OrderedCollection<SHRange>> source: <String> sourcePosition: <Integer> temporaries: <OrderedCollection<OrderedCollection<String>|nil> workspace: <Workspace|nil> + context: <Context|nil> allowBlockArgumentAssignment The value cached at the beginning of parsing of Scanner allowBlockArgumentAssignment. allowUnderscoreAssignments The value cached at the beginning of parsing of Scanner allowUnderscoreAsAssignment. allowUnderscoreSelectors The value cached at the beginning of parsing of Scanner prefAllowUnderscoreSelectors. arguments This OrderedCollection has an element for each scope encapsulating the current scope. The current scope's arguments are stored in the last element. The first element holds the outermost scope's arguments. Each element is nil when the corresponding scope doesn't have any arguments, and the element is an OrderedCollection with the names of the arguments declared at the given scope when there's at least one. The size of this variable is the same as the size of temporaries. bracketDepth Stores the number of unclosed brackets "(" and parentheses "[" before the current sourcePosition. classOrMetaClass The Class or MetaClass instance, class and pool variables should be looked up during parsing or nil when not parsing code in the context of a class (e.g. when parsing code written in a Workspace). Having this set doesn't mean a method is being parsed. currentToken The token being analyzed for which the next range should be created for. currentTokenFirst The first character of currentToken cached for quick access or a space character when there are no more tokens to parse. Being always a Character helps avoiding extra checks. currentTokenSourcePosition The position of source the current token starts at or nil when there are no more tokens to process. currentTokenType The type of the current token calculated lazily by #currentTokenType. When it has been calculated, Its value is one of #keyword, #assignment, #ansiAssignment, #binary, #name, #other and occasionally #invalid. environment The Environment globals and classes should be looked up at during parsing when classOrMetaClass is nil. Its value is Smalltalk globals by default. errorBlock A block used to quickly stop parsing in case of an unrecoverable parse error. instanceVariables An Array with the instance variable names of classOrMetaClass or an empty Array when classOrMetaClass is nil. parseAMethod A way to tell the parser to parse source as a code snippet instead of a method. Mainly used by inspectors. ranges The SHRanges parsed by the parser. source The source code as a String to be parsed. sourcePosition souce is treated as a stream by the parser. This variable stores the stream position. temporaries This OrderedCollection has an element for each scope encapsulating the current scope. The current scope's temporaries are stored in the last element. The first element holds the outermost scope's temporaries. Each element is nil when the corresponding scope doesn't have any temporary variables, and the element is an OrderedCollection with the names of the temporaries declared at the given scope when there's at least one. The size of this variable is the same as the size of arguments. workspace The Workspace in whose context variables should be looked up during parsing or nil when not parsing code in a workspace. + context + The Context in which variables should be looked up during parsing or nil when not parsing within a context. Example (explore it): ranges := SHParserST80 new classOrMetaClass: Object; source: 'testMethod ^self'; parse; ranges Benchmark (print it): SHParserST80 benchmark! Item was changed: ----- Method: SHParserST80>>initializeInstanceVariables (in category 'parse support') ----- initializeInstanceVariables instanceVariables := classOrMetaClass ifNil: [ #() ] + ifNotNil: [ classOrMetaClass allInstVarNames asArray ]. + allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. + allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. + allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. + sourcePosition := 1. + arguments + ifNil: [ arguments := OrderedCollection with: nil ] + ifNotNil: [ arguments reset; addLast: nil ]. + temporaries + ifNil: [ temporaries := OrderedCollection with: nil ] + ifNotNil: [ temporaries reset; addLast: nil ]. + context ifNotNil: [ + | contextArgumentCount contextVariableNames | + contextArgumentCount := context numArgs. + contextVariableNames := context tempNames asOrderedCollection. + contextArgumentCount > 0 ifTrue: [ + arguments at: 1 put: (contextVariableNames first: contextArgumentCount) ]. + contextArgumentCount < contextVariableNames size ifTrue: [ + temporaries at: 1 put: (contextVariableNames allButFirst: contextArgumentCount) ] ]. + bracketDepth := 0. + ranges + ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] + ifNotNil: [ ranges reset ]! - ifNotNil: [ classOrMetaClass allInstVarNames asArray ]! Item was changed: ----- Method: SHParserST80>>parse: (in category 'parse') ----- parse: isAMethod + "Parse the receiver's text. If isAMethod is true then treat text as a method, if false as an expression with no message pattern" - "Parse the receiver's text. If isAMethod is true - then treat text as a method, if false as an - expression with no message pattern" self initializeInstanceVariables. + errorBlock := [^false]. "This must be defined in this method, as the goal is to return from this method in case of an error." - allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. - allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. - allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. - sourcePosition := 1. - arguments - ifNil: [ arguments := OrderedCollection with: nil ] - ifNotNil: [ arguments reset; addLast: nil ]. - temporaries - ifNil: [ temporaries := OrderedCollection with: nil ] - ifNotNil: [ temporaries reset; addLast: nil ]. - bracketDepth := 0. - ranges - ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] - ifNotNil: [ ranges reset ]. - errorBlock := [^false]. self scanNext. isAMethod ifTrue: [ self parseMessagePattern; parsePragmaSequence ]. self parseTemporaries. isAMethod ifTrue: [ self parsePragmaSequence ]. self parseStatementList. currentToken ifNotNil: [ self fail ]. ^true! Item was changed: ----- Method: SHParserST80>>parseString (in category 'parse') ----- parseString - | first c last | - first := sourcePosition. + | stringStart | + stringStart := sourcePosition - 1. + [ + (sourcePosition := source indexOf: $' startingAt: sourcePosition) = 0 ifTrue: [ - [(c := self currentChar) - ifNil: [ self + addRangeType: #unfinishedString start: stringStart end: source size; - addRangeType: #unfinishedString start: first - 1 end: source size; fail ": 'unfinished string'"]. + self peekChar == $' - c ~~ $' or: [ - self peekChar == $' ifTrue: [ sourcePosition := sourcePosition + 1. + true ] + ifFalse: [ false ] ] + whileTrue: [ sourcePosition := sourcePosition + 1 ]. + sourcePosition := sourcePosition + 1. + self scanPast: #string start: stringStart end: sourcePosition - 1! - true] - ifFalse: [false]] - ] whileTrue: [sourcePosition := sourcePosition + 1]. - last := sourcePosition. - self - nextChar; - scanPast: #string start: first - 1 end: last! Item was changed: ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment: (in category 'parse') ----- rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil + ^ self rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: nil! - anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. - self - workspace: aWorkspace; - classOrMetaClass: aBehaviour; - source: sourceString. - self parse. - ^ranges! Item was added: + ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment:context: (in category 'parse') ----- + rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: aContextOrNil + anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. + aContextOrNil ifNotNil: [context := aContextOrNil]. + self + workspace: aWorkspace; + classOrMetaClass: aBehaviour; + source: sourceString. + self parse. + ^ranges! Item was added: + ----- Method: SHRange>>= (in category 'comparing') ----- + = anObject + + anObject class == SHRange ifFalse: [ ^false ]. + type = anObject type ifFalse: [ ^false ]. + start = anObject start ifFalse: [ ^false ]. + end = anObject end ifFalse: [ ^false ]. + ^true! Item was added: + ----- Method: SHRange>>hash (in category 'comparing') ----- + hash + + ^(((self class hash + type hash) hashMultiply + start) hashMultiply + end) hashMultiply! Item was changed: SHTextStyler subclass: #SHTextStylerST80 + instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod context' - instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod' classVariableNames: 'SyntaxHighlightingAsYouType SyntaxHighlightingAsYouTypeAnsiAssignment SyntaxHighlightingAsYouTypeLeftArrowAssignment TextAttributesByPixelHeight' poolDictionaries: '' category: 'ShoutCore-Styling'! !SHTextStylerST80 commentStamp: 'tween 8/27/2004 10:55' prior: 0! I style Smalltalk methods and expressions. My 'styleTable' class instance var holds an array ofArrays which control how each token is styled/coloured. See my defaultStyleTable class method for its structure. My styleTable can be changed by either modifying the defaultStyleTable class method and then executing SHTextStylerST80 initialize ; or by giving me a new styleTable through my #styleTable: class method. My 'textAttributesByPixelSize' class instance var contains a dictionary of dictionaries. The key is a pixelSize and the value a Dictionary from token type Symbol to TextAttribute array. It is created/maintained automatically. I also install these 3 preferences when my class initialize method is executed.... #syntaxHighlightingAsYouType - controls whether methods are styled in browsers #syntaxHighlightingAsYouTypeAnsiAssignment - controls whether assignments are formatted to be := #syntaxHighlightingAsYouTypeLeftArrowAssignment - controls whether assignments are formatted to be _ I reimplement #unstyledTextFrom: so that TextActions are preserved in the unstyled text ! Item was added: + ----- Method: SHTextStylerST80>>context: (in category 'accessing') ----- + context: aContext + context := aContext! Item was changed: ----- Method: SHTextStylerST80>>rangesIn:setWorkspace: (in category 'private') ----- rangesIn: aText setWorkspace: aBoolean "Answer a collection of SHRanges by parsing aText. When formatting it is not necessary to set the workspace, and this can make the parse take less time, so aBoolean specifies whether the parser should be given the workspace" | shoutParserClass | "Switch parsers if we have to" shoutParserClass := (classOrMetaClass ifNil:[Object]) shoutParserClass. parser class == shoutParserClass ifFalse:[parser := shoutParserClass new]. parser parseAMethod: parseAMethod. ^parser rangesIn: aText asString classOrMetaClass: classOrMetaClass workspace: (aBoolean ifTrue:[workspace]) environment: environment + context: context! - !

1 0

The Trunk: 51Deprecated-mt.53.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of 51Deprecated to project The Trunk: http://source.squeak.org/trunk/51Deprecated-mt.53.mcz ==================== Summary ==================== Name: 51Deprecated-mt.53 Author: mt Time: 4 August 2019, 9:37:27.289314 am UUID: 9267700e-7002-bb4d-be66-86284fa6449f Ancestors: 51Deprecated-dtl.52 Updates DateAndTime protocol for backwards compatibility to match the recent refactorings in Chronology. =============== Diff against 51Deprecated-dtl.52 =============== Item was changed: ----- Method: DateAndTime class>>nowWithOffset: (in category '*51deprecated') ----- nowWithOffset: aDuration + "Answer time now as reported by #primitiveUtcWithOffset. If the primitive is not + available, answer the Posix epoch with time zone offset aDuration." + | timeArray | + self deprecated: 'This is just for backwards compatibility. Use DateAndTime class >> #now, which already contains correct offset information.'. + timeArray := Time posixMicrosecondClockWithOffset. + ^ self utcMicroseconds: timeArray first offset: aDuration asSeconds + ! - | clockValue nanos | - self deprecated: 'use (... now offset: ...) instead'. - clockValue := Time utcMicrosecondClock. - "Ensure that consecutive sends of this method return increasing values, by adding small values to the nanosecond part of the created object. The next few lines are assumed to be executed atomically - having no suspension points." - ((LastClockValue ifNil: [ 0 ]) digitCompare: clockValue) = 0 - ifTrue: [ NanoOffset := NanoOffset + 1 ] - ifFalse: [ NanoOffset := 0 ]. - LastClockValue := clockValue. - nanos := clockValue \\ 1000000 * 1000 + NanoOffset. - clockValue := clockValue // 1000000. - ^self basicNew - setJdn: clockValue // SecondsInDay + SqueakEpoch - seconds: clockValue \\ SecondsInDay - nano: nanos - offset: aDuration!

1 0

The Trunk: Chronology-Core-mt.49.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-mt.49.mcz ==================== Summary ==================== Name: Chronology-Core-mt.49 Author: mt Time: 4 August 2019, 9:36:34.375314 am UUID: 118bc15d-e640-1344-9342-a9b653675df8 Ancestors: Chronology-Core-dtl.48 Moves compatibility protocol back to 51Deprecated. I think it was moved here by accident. =============== Diff against Chronology-Core-dtl.48 =============== Item was removed: - ----- Method: DateAndTime class>>nowWithOffset: (in category 'squeak protocol') ----- - nowWithOffset: aDuration - "Answer time now as reported by #primitiveUtcWithOffset. If the primitive is not - available, answer the Posix epoch with time zone offset aDuration." - - | timeArray | - timeArray := Time posixMicrosecondClockWithOffset. - ^ self utcMicroseconds: timeArray first offset: aDuration asSeconds - !

1 0

The Inbox: Tools-ct.857.mcz
by commits＠source.squeak.org 03 Aug '19

03 Aug '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.857.mcz ==================== Summary ==================== Name: Tools-ct.857 Author: ct Time: 2 August 2019, 4:35:42.962625 pm UUID: 4f55f36d-167e-944c-b2e8-731f025398e9 Ancestors: Tools-ct.855, Tools-mt.856, Tools-cmm.816 Fix & refactor ChangeList>>#compareToCurrentVersion Deduplicate the code with overridden version in ClassCommentVersionBrowser, and fix a bug: As the feature is named "compare TO current version", I expect a comparison FROM the selected item to the current version, not the opposite (same as "compare to version ..."). =============== Diff against Tools-ct.855 =============== Item was added: + ----- Method: ChangeList>>compareToCurrentSource: (in category 'menu actions') ----- + compareToCurrentSource: currentSource + "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + + | change selectedSource | + change := changeList at: listIndex ifAbsent: [^ self]. + selectedSource := change string. + currentSource = selectedSource + ifTrue: [^ self inform: 'Exact Match']. + (StringHolder new + textContents: (TextDiffBuilder + buildDisplayPatchFrom: selectedSource + to: currentSource + inClass: change methodClass + prettyDiffs: self showingPrettyDiffs)) + openLabel: 'Comparison to Current Version'.! Item was changed: ----- Method: ChangeList>>compareToCurrentVersion (in category 'menu actions') ----- compareToCurrentVersion "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + | change class | + change := changeList at: listIndex ifAbsent: [^ self]. + class := change methodClass. + (class notNil and: [(class includesSelector: change methodSelector)]) + ifFalse: [^ self flash]. + ^ self compareToCurrentSource: (class sourceCodeAt: change methodSelector) asString! - | change class s1 s2 | - listIndex = 0 - ifTrue: [^ self]. - change := changeList at: listIndex. - ((class := change methodClass) notNil - and: [class includesSelector: change methodSelector]) - ifTrue: [s1 := (class sourceCodeAt: change methodSelector) asString. - s2 := change string. - s1 = s2 - ifTrue: [^ self inform: 'Exact Match']. - (StringHolder new - textContents: (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2 inClass: class prettyDiffs: self showingPrettyDiffs)) - openLabel: 'Comparison to Current Version'] - ifFalse: [self flash]! Item was changed: ----- Method: ClassCommentVersionsBrowser>>compareToCurrentVersion (in category 'menu') ----- compareToCurrentVersion "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + ^ self compareToCurrentSource: classOfMethod organization classComment! - | change s1 s2 | - listIndex = 0 - ifTrue: [^ self]. - change := changeList at: listIndex. - s1 := classOfMethod organization classComment. - s2 := change string. - s1 = s2 - ifTrue: [^ self inform: 'Exact Match']. - (StringHolder new - textContents: (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2 inClass: classOfMethod prettyDiffs: self showingPrettyDiffs)) - openLabel: 'Comparison to Current Version'!

2 1

The Inbox: Tools-ct.858.mcz
by commits＠source.squeak.org 02 Aug '19

02 Aug '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.858.mcz ==================== Summary ==================== Name: Tools-ct.858 Author: ct Time: 2 August 2019, 7:23:35.594625 pm UUID: 3ece1c71-070b-0e48-a0aa-1e259555dbee Ancestors: Tools-ct.857 Inspector: Try to keep field selection when changing object Instead of unselecting the field viewed latest when another object is assigned, keep the selection unless it is no more valid (got a phantom) Example where this is useful: debug World allMorphs, select owner in the receiver view and watch the selection while stepping a few times into #allMorphsDo:. =============== Diff against Tools-ct.857 =============== Item was changed: ----- Method: Inspector>>object: (in category 'accessing') ----- object: anObject "Set anObject to be the object being inspected by the receiver." + | oldSelection oldFields newFields commonFieldRange | - | oldIndex | anObject == object ifTrue: [self update] ifFalse: + [oldSelection := selectionIndex. + oldFields := self fieldList. - [oldIndex := selectionIndex <= 2 ifTrue: [selectionIndex] ifFalse: [0]. self inspect: anObject. + newFields := self fieldList. + commonFieldRange := ((1 to: (oldFields size min: newFields size)) + select: [:i | (oldFields at: i) = (newFields at: i)]) + ifNotEmpty: #last + ifEmpty: [0]. - oldIndex := oldIndex min: self fieldList size. self changed: #inspectObject. + self toggleIndex: (oldSelection <= commonFieldRange + ifTrue: [oldSelection] + ifFalse: [0]). - oldIndex > 0 - ifTrue: [self toggleIndex: oldIndex]. self changed: #fieldList. self changed: #contents. self changed: #helpText]!

1 0

The Trunk: System-mt.1078.mcz
by commits＠source.squeak.org 02 Aug '19

02 Aug '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1078.mcz ==================== Summary ==================== Name: System-mt.1078 Author: mt Time: 2 August 2019, 2:36:47.057946 pm UUID: 7e1a1567-d617-dd42-aa20-a69264d0fea4 Ancestors: System-mt.1077 Adds missing returns of (constructed) tool windows to system navigation's browse*-calls. Many were already there. Note that there is the non-browse-interface in system navigation to just execute and return queries such as #allCallsOn: vs. #browseAllCallsOn:. =============== Diff against System-mt.1077 =============== Item was changed: ----- Method: SystemNavigation>>browseAllCallsOn: (in category 'browse') ----- browseAllCallsOn: aLiteral "Create and schedule a message browser on each method that refers to aLiteral." "self default browseAllCallsOn: #open:label:." + ^ self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | - self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | self browseMessageList: [ self allCallsOn: aLiteral ] name: label autoSelect: autoSelect]! Item was changed: ----- Method: SystemNavigation>>browseAllCallsOn:and:localToPackage: (in category 'browse') ----- browseAllCallsOn: literal1 and: literal2 localToPackage: packageNameOrInfo "Create and schedule a message browser on each method in the given package that refers to both literal1 and literal2." "self default browseAllCallsOn: #open:label: localToPackage: 'Tools'." + ^ self headingAndAutoselectForLiteral: literal1 do: [ :label :autoSelect | - self headingAndAutoselectForLiteral: literal1 do: [ :label :autoSelect | self browseMessageList: [ self allCallsOn: literal1 and: literal2 localToPackage: packageNameOrInfo ] name: label, ' local to package ', (self packageInfoFor: packageNameOrInfo) name autoSelect: autoSelect ]! Item was changed: ----- Method: SystemNavigation>>browseAllCallsOn:localTo: (in category 'browse') ----- browseAllCallsOn: aLiteral localTo: aBehavior "Create and schedule a message browser on each method in or below the given class that refers to aLiteral." "self default browseAllCallsOn: #open:label: localTo: CodeHolder" aBehavior ifNil: [ ^self inform: 'No behavior selected.' ]. + ^ self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | - self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | self browseMessageList: [ self allCallsOn: aLiteral from: aBehavior ] name: label, ' local to ', aBehavior name autoSelect: autoSelect ]! Item was changed: ----- Method: SystemNavigation>>browseAllCallsOn:localToPackage: (in category 'browse') ----- browseAllCallsOn: aLiteral localToPackage: packageNameOrInfo "Create and schedule a message browser on each method in the given package that refers to aLiteral." "self default browseAllCallsOn: #open:label: localToPackage: 'Tools'." + ^ self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | - self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect | self browseMessageList: [ self allCallsOn: aLiteral localToPackage: packageNameOrInfo ] name: label, ' local to package ', (self packageInfoFor: packageNameOrInfo) name autoSelect: autoSelect ]! Item was changed: ----- Method: SystemNavigation>>browseAllCallsOnClass: (in category 'browse') ----- browseAllCallsOnClass: aBehaviorOrBinding "Create and schedule a message browser on each method that refers to aBehavior." "self default browseAllCallsOnClass: Array" | behaviorName | behaviorName := aBehaviorOrBinding isBehavior ifTrue: [aBehaviorOrBinding theNonMetaClass name] ifFalse: [aBehaviorOrBinding key]. + ^ self - self browseMessageList: [ self allCallsOnClass: aBehaviorOrBinding ] name: 'Users of ', behaviorName autoSelect: behaviorName! Item was changed: ----- Method: SystemNavigation>>browseAllImplementorsOf:localToPackage: (in category 'browse') ----- browseAllImplementorsOf: selector localToPackage: packageNameOrInfo "Create and schedule a message browser on each method in the given package that implements the message whose selector is the argument, selector. For example, SystemNavigation new browseAllImplementorsOf: #at:put: localToPackage: 'Collections'." + ^ self browseMessageList: (self - self browseMessageList: (self allImplementorsOf: selector localToPackage: packageNameOrInfo) name: 'Implementors of ' , selector, ' local to package ', (self packageInfoFor: packageNameOrInfo) name! Item was changed: ----- Method: SystemNavigation>>browseAllImplementorsOfList: (in category 'browse') ----- browseAllImplementorsOfList: selectorList "Create and schedule a message browser on each method that implements the message whose selector is in the argument selectorList. For example, Smalltalk browseAllImplementorsOf: #(at:put: size). 1/16/96 sw: defer to the titled version" + ^ self browseAllImplementorsOfList: selectorList title: 'Implementors of all'! - self browseAllImplementorsOfList: selectorList title: 'Implementors of all'! Item was changed: ----- Method: SystemNavigation>>browseAllObjectReferencesTo:except:ifNone: (in category 'browse') ----- browseAllObjectReferencesTo: anObject except: objectsToExclude ifNone: aBlock "Bring up a list inspector on the objects that point to anObject. If there are none, then evaluate aBlock on anObject. " | aList shortName | aList := Utilities pointersTo: anObject except: objectsToExclude. aList size > 0 ifFalse: [^aBlock value: anObject]. shortName := (anObject name ifNil: [anObject printString]) contractTo: 20. + ^ aList inspectWithLabel: 'Objects pointing to ' , shortName! - aList inspectWithLabel: 'Objects pointing to ' , shortName! Item was changed: ----- Method: SystemNavigation>>browseAllReferencesToPool:from: (in category 'browse') ----- browseAllReferencesToPool: poolOrName from: aClass "Open a message list on all messages referencing the given pool" | pool list | (poolOrName isString) ifTrue:[pool := Smalltalk at: poolOrName asSymbol] ifFalse:[pool := poolOrName]. list := self allReferencesToPool: pool from: aClass. + ^ self - self browseMessageList: list + name: 'users of ', poolOrName name! - name: 'users of ', poolOrName name. - ^list! Item was changed: ----- Method: SystemNavigation>>browseAllUnSentMessages (in category 'browse') ----- browseAllUnSentMessages "Create and schedule a message browser on each method whose message is not sent in any method in the system." "self new browseAllUnSentMessages" + ^ self browseAllImplementorsOfList: self allUnSentMessages title: 'Messages implemented but not sent'! - self browseAllImplementorsOfList: self allUnSentMessages title: 'Messages implemented but not sent' - ! Item was changed: ----- Method: SystemNavigation>>browseAllUnimplementedCalls (in category 'browse') ----- browseAllUnimplementedCalls "Create and schedule a message browser on each method that includes a message that is not implemented in any object in the system." + ^self browseMessageList: self allUnimplementedCalls name: 'Unimplemented calls'! - ^self browseMessageList: self allUnimplementedCalls name: 'Unimplemented calls'! Item was changed: ----- Method: SystemNavigation>>browseClass: (in category 'browse') ----- browseClass: aBehavior | targetClass | targetClass := aBehavior isMeta ifTrue: [aBehavior theNonMetaClass] ifFalse: [aBehavior ]. + ^ ToolSet browse: targetClass selector: nil! - ToolSet browse: targetClass selector: nil! Item was changed: ----- Method: SystemNavigation>>browseClassesWithNamesContaining:caseSensitive: (in category 'browse') ----- browseClassesWithNamesContaining: aString caseSensitive: caseSensitive "SystemNavigation default browseClassesWithNamesContaining: 'eMorph' caseSensitive: true " "Launch a class-list list browser on all classes whose names containg aString as a substring." | suffix aList | suffix := caseSensitive ifTrue: [' (case-sensitive)'] ifFalse: [' (use shift for case-sensitive)']. aList := OrderedCollection new. Cursor wait showWhile: [Smalltalk allClassesDo: [:class | (class name includesSubstring: aString caseSensitive: caseSensitive) ifTrue: [aList add: class name]]]. + ^ ToolSet openClassListBrowser: aList asSet sorted title: 'Classes whose names contain ' , aString , suffix! - aList size > 0 - ifTrue: [ToolSet openClassListBrowser: aList asSet sorted title: 'Classes whose names contain ' , aString , suffix]! Item was changed: ----- Method: SystemNavigation>>browseHierarchy: (in category 'browse') ----- browseHierarchy: aBehavior | targetClass | targetClass := aBehavior isMeta ifTrue: [aBehavior theNonMetaClass] ifFalse: [aBehavior ]. + ^ ToolSet browseHierarchy: targetClass selector: nil! - ToolSet browseHierarchy: targetClass selector: nil.! Item was changed: ----- Method: SystemNavigation>>browseMethodsWhoseNamesContain: (in category 'browse') ----- browseMethodsWhoseNamesContain: aString "Launch a tool which shows all methods whose names contain the given string; case-insensitive. · 1/16/1996 sw, at the dawn of Squeak: this was the classic implementation that provided the underpinning for the 'method names containing it' (cmd-shift-W) feature that has always been in Squeak -- the feature that later inspired the MethodFinder (aka SelectorBrowser). · sw 7/27/2001: Switched to showing a MessageNames tool rather than a message-list browser, if in Morphic." + ^ Smalltalk isMorphic + ifTrue: [ToolSet browseMessageNames: aString] + ifFalse: [ + self + browseAllImplementorsOfList: (Symbol selectorsContaining: aString) + title: 'Methods whose names contain ''', aString, '''']! - | aList | - Smalltalk isMorphic - ifFalse: - [aList := Symbol selectorsContaining: aString. - aList size > 0 ifTrue: - [self browseAllImplementorsOfList: aList title: 'Methods whose names contain ''', aString, '''']] - - ifTrue: - [ToolSet browseMessageNames: aString] - ! Item was changed: ----- Method: SystemNavigation>>browseMethodsWithLiteral: (in category 'browse') ----- browseMethodsWithLiteral: aString "Launch a browser on all methods that contain string literals with aString as a substring. Make the search case-sensitive or insensitive as dictated by the caseSensitive boolean parameter" + ^ self browseAllSelect: - self browseAllSelect: [:method | method hasLiteralSuchThat: [:lit | (lit isString and: [lit isSymbol not]) and: [lit = aString]]] name: 'Methods with string ', aString printString + autoSelect: aString! - autoSelect: aString. - ! Item was changed: ----- Method: SystemNavigation>>browseMethodsWithString:matchCase: (in category 'browse') ----- browseMethodsWithString: aString matchCase: caseSensitive "Launch a browser on all methods that contain string literals with aString as a substring. Make the search case-sensitive or insensitive as dictated by the caseSensitive boolean parameter" + ^ self - self browseMessageList: (self allMethodsWithString: aString matchCase: caseSensitive) name: 'Methods with string ', aString printString, (caseSensitive ifTrue: [' (case-sensitive)'] ifFalse: [' (case-insensitive)']) autoSelect: aString! Item was changed: ----- Method: SystemNavigation>>browseMyChanges (in category 'browse') ----- browseMyChanges "Browse only the changes (in the changes file) by the current author." "SystemNavigation default browseMyChanges" + ^ self browseAllSelect: [ :method | - self browseAllSelect: [ :method | method fileIndex > 1 "only look at changes file" and: [ method timeStamp beginsWith: Utilities authorInitials ]]! Item was changed: ----- Method: SystemNavigation>>browseObsoleteMethodReferences (in category 'browse') ----- browseObsoleteMethodReferences "Open a browser on all referenced behaviors that are obsolete" "SystemNavigation default browseObsoleteMethodReferences" | list | list := self obsoleteMethodReferences. + ^ self - self browseMessageList: list name: 'Method referencing obsoletes' autoSelect: nil! Item was changed: ----- Method: SystemNavigation>>browseObsoleteReferences (in category 'browse') ----- browseObsoleteReferences "self new browseObsoleteReferences" | references | references := OrderedCollection new. (LookupKey allSubInstances select: [:x | ((x value isKindOf: Behavior) and: ['AnOb*' match: x value name]) or: ['AnOb*' match: x value class name]]) do: [:x | references addAll: (self allCallsOn: x)]. + ^ self - self browseMessageList: references name: 'References to Obsolete Classes'! Item was changed: ----- Method: SystemNavigation>>browseUncommentedMethodsWithInitials: (in category 'browse') ----- browseUncommentedMethodsWithInitials: targetInitials "Browse uncommented methods whose initials (in the time-stamp, as logged to disk) match the given initials. Present them in chronological order. CAUTION: It will take several seconds for this to complete." "Time millisecondsToRun: [SystemNavigation default browseUncommentedMethodsWithInitials: 'jm']" + ^ self - self browseMessageList: [ self allUncommentedMethodsWithInitials: targetInitials ] name: 'Uncommented methods with initials ', targetInitials autoSelect: nil!

1 0

Recent test failures
by Fabio Niephaus 02 Aug '19

02 Aug '19

Hi all, Today, I upgraded from 18618 to 18692 and noticed the following new test failures: *New failures:* PackageDependencyTest>>testShoutCore SystemNavigationTest>>testAllSentMessagesWithout SystemNavigationTest>>testAllUnusedClassesWithout *Now opens a dialog:* TraitTest>>testTraitFromPattern If you recently pushed to trunk and have a feeling that your code could've caused some of the above issues, it'd be great if you could have a look at this. Thanks, Fabio

2 2

The Trunk: TraitsTests-mt.19.mcz
by commits＠source.squeak.org 02 Aug '19

02 Aug '19

Marcel Taeumel uploaded a new version of TraitsTests to project The Trunk: http://source.squeak.org/trunk/TraitsTests-mt.19.mcz ==================== Summary ==================== Name: TraitsTests-mt.19 Author: mt Time: 2 August 2019, 9:45:17.294366 am UUID: fc22c531-8d69-cc46-8eda-18453d18da85 Ancestors: TraitsTests-ul.18 Fixes #testTraitFromPattern to not show a dialog window anymore. =============== Diff against TraitsTests-ul.18 =============== Item was changed: ----- Method: TraitTest>>testTraitFromPattern (in category 'testing') ----- testTraitFromPattern | newTrait | newTrait := self createTraitNamed: #TTraitTestBaseTrait uses: {}. + self assert: newTrait equals: (SystemNavigation default allClassesAndTraitsMatching: 'TTraitTestBaseT') first.! - self assert: (UIManager default classFromPattern: 'TTraitTestBaseT' withCaption: '') = newTrait.!

1 0

Jump to page: