Squeak-dev January 2021

squeak-dev@lists.squeakfoundation.org

38 participants
171 discussions

The Trunk: ToolBuilder-MVC-mt.63.mcz
by commits＠source.squeak.org 06 Jan '21

06 Jan '21

Marcel Taeumel uploaded a new version of ToolBuilder-MVC to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-MVC-mt.63.mcz ==================== Summary ==================== Name: ToolBuilder-MVC-mt.63 Author: mt Time: 6 January 2021, 10:54:51.611417 am UUID: 3d989178-1d1f-9343-b240-39472ac722dd Ancestors: ToolBuilder-MVC-mt.62, ToolBuilder-MVC-ct.60 Merges ToolBuilder-MVC-ct.60, which got shadowed by ToolBuilder-MVC-TheresaHMartenK.60 last June. =============== Diff against ToolBuilder-MVC-mt.62 =============== Item was changed: ----- Method: MVCToolBuilder>>open: (in category 'opening') ----- open: anObject "Build and open the object. Answer the widget opened." | window | + window := (anObject isKindOf: View orOf: PopUpMenu) - window := (anObject isKindOf: View) ifTrue: [anObject] ifFalse: [self build: anObject]. (window isKindOf: PopUpMenu) ifTrue: [window invokeOn: nil]. (window isKindOf: View) ifTrue: [window controller open]. ^window!

1 0

The Trunk: ST80-mt.263.mcz
by commits＠source.squeak.org 06 Jan '21

06 Jan '21

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.263.mcz ==================== Summary ==================== Name: ST80-mt.263 Author: mt Time: 6 January 2021, 10:33:34.521417 am UUID: 06e12acc-4e20-0c4c-9e25-ca0838ccf765 Ancestors: ST80-mt.262 Fixes auto-indent bug in MVC text editors by supporting type-aheads with size > 1 outside the context of copy-paste (and similar) in #zapSelectionWithCompositionWith:. Note that dynamic character composition is not supported in Morphic's TextEditor, I suppose. We might want to add that, too. Yoshiki added this feature in 2007 only to ST80/MVC. =============== Diff against ST80-mt.262 =============== Item was changed: ----- Method: ParagraphEditor>>zapSelectionWithCompositionWith: (in category 'accessing-selection') ----- zapSelectionWithCompositionWith: aString "Deselect, and replace the selection text by aString. Remember the resulting selectionInterval in UndoInterval and otherInterval. Do not set up for undo." | stream newString aText beforeChar | wasComposition := false. ((aString isEmpty or: [(beforeChar := self charBefore) isNil]) or: [ + aString size >= 1 and: [(Unicode isComposition: aString first) not]]) ifTrue: [ - aString size = 1 and: [(Unicode isComposition: aString first) not]]) ifTrue: [ ^ self zapSelectionWith: (Text string: aString emphasis: emphasisHere)]. stream := UnicodeCompositionStream on: (String new: 16). stream nextPut: beforeChar. stream nextPutAll: aString. newString := stream contents. aText := Text string: newString emphasis: emphasisHere. self markBlock < self pointBlock ifTrue: [self setMark: self markBlock stringIndex - 1] ifFalse: [self setPoint: self pointBlock stringIndex - 1]. wasComposition := true. self zapSelectionWith: aText. !

1 0

Two new curious Context/primitive questions :-)
by Thiede, Christoph 06 Jan '21

06 Jan '21

Hi all, hi Eliot, new year, new simulation fun, and I have collected two new questions about the Context implementation which I'd love to get answered here: First, I was confused by the following: (BlockClosure >> #numArgs) primitive. "266" (Context >> #pc) primitive. "0" What makes Context so special that it cannot be compiled with quick accessor methods? Second, Context >> #isPrimFailToken: attracted my attention multiple times when looking at different #timeProfile results of simulation sessions. In the expression [100000 factorial] it takes up more than 44% of the whole execution time! I have no idea why it could be so slow, but this message is sent really often, which is at least 2 times per simulation of a special message send. Would there be an easy change to resolve this bottleneck and speed up the simulation by 40% or more? Would it be possible to provide a primitive for this method? Or do you see any other way to optimize it? Best, Christoph

5 8

The Inbox: KernelTests-ct.382.mcz
by commits＠source.squeak.org 06 Jan '21

06 Jan '21

Christoph Thiede uploaded a new version of KernelTests to project The Inbox: http://source.squeak.org/inbox/KernelTests-ct.382.mcz ==================== Summary ==================== Name: KernelTests-ct.382 Author: ct Time: 1 January 2021, 7:59:13.17819 pm UUID: 812293dd-db7d-4c03-a33d-8b6f4354d1fa Ancestors: KernelTests-ct.375, KernelTests-tonyg.381 Tests simulation of #perform:... primitives 83, 84, and 100. Complements Kernel-ct.1367. Depends indeed not only on KernelTests-tonyg.381 but also on KernelTests-ct.375, it would be nice if we could get the latter merged soon, this has already been causing too many merge conflicts in the past. :-) =============== Diff against KernelTests-ct.375 =============== Item was added: + ----- Method: ContextTest>>testPrimitive100 (in category 'tests') ----- + testPrimitive100 + + { + {#isNil. {}. Object}. "valid 0-arg message" + {#=. {true}. UndefinedObject}. "valid unary message" + {#ifNil:ifNotNil:. {[2]. [:x | x]}. Object}. "valid binary message" + {}. "missing selector" + {#isNil}. "missing arguments" + {#isNil. 'not an array'}. "invalid arguments" + {#isNil. {}}. "missing lookupClass" + {#isNil. {'excess arg'}. Object}. "too many arguments" + {#=. {}. UndefinedObject}. "missing argument" + {#isNil. {}. Boolean}. "lookupClass not in inheritance chain" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 100 withArgs: args]) + equals: (nil tryPrimitive: 100 withArgs: args)].! Item was added: + ----- Method: ContextTest>>testPrimitive83 (in category 'tests') ----- + testPrimitive83 + + { + {#isNil}. "valid 0-arg message" + {#=. true}. "valid unary message" + {#ifNil:ifNotNil:. [2]. [:x | x]}. "valid binary message" + {}. "missing selector" + {#isNil. 'excess arg'}. "too many arguments" + {#=}. "missing argument" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 83 withArgs: args]) + equals: (nil tryPrimitive: 83 withArgs: args)].! Item was added: + ----- Method: ContextTest>>testPrimitive84 (in category 'tests') ----- + testPrimitive84 + + { + {#isNil. {}}. "valid 0-arg message" + {#=. {true}}. "valid unary message" + {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" + {}. "missing selector" + {#isNil}. "missing arguments" + {#isNil. 'not an array'}. "invalid arguments" + {#isNil. {'excess arg'}}. "too many arguments" + {#=. {}}. "missing argument" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 84 withArgs: args]) + equals: (nil tryPrimitive: 84 withArgs: args)].!

4 4

The Trunk: Monticello-mt.735.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

Nicolas Cellier uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.735.mcz ==================== Summary ==================== Name: Monticello-mt.735 Author: mt Time: 5 January 2021, 1:23:12.398865 pm UUID: b2a82046-9f24-4838-896b-6f669aa8a65d Ancestors: Monticello-mt.734 Consider version infos being working copies "in disguise" :-) =============== Diff against Monticello-mt.734 =============== Item was changed: ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') ----- isWorkingAncestry + + ^ self name = self nameForWorkingCopy! - ^ false! Item was added: + ----- Method: MCAncestry>>nameForWorkingCopy (in category 'ancestry') ----- + nameForWorkingCopy + + ^ '<working copy>'! Item was changed: ----- Method: MCVersionInfo>>name (in category 'accessing') ----- name + ^ name ifNil: [self nameForWorkingCopy]! - ^ name ifNil: ['<working copy>']! Item was changed: ----- Method: MCWorkingAncestry>>name (in category 'testing') ----- name + ^ self nameForWorkingCopy! - ^ '<working copy>'!

1 0

The Trunk: Monticello-mt.734.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

Nicolas Cellier uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.734.mcz ==================== Summary ==================== Name: Monticello-mt.734 Author: mt Time: 5 January 2021, 1:09:08.981865 pm UUID: 93fdf435-68a1-4ace-a7a9-d9d86fb3118f Ancestors: Monticello-mt.733 Alternative fix for the problem addressed in Monticello-nice.734 =============== Diff against Monticello-mt.733 =============== Item was added: + ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ false! Item was added: + ----- Method: MCVersionHistoryBrowser>>package (in category 'accessing') ----- + package + ^ package! Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot + ^ self selectedInfo isWorkingAncestry + ifTrue: [self package snapshot] + ifFalse: [self snapshotForInfo: self selectedInfo]! - ^ self snapshotForInfo: self selectedInfo! Item was added: + ----- Method: MCWorkingAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ true!

1 0

The Inbox: System-dtl.1209.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

David T. Lewis uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-dtl.1209.mcz ==================== Summary ==================== Name: System-dtl.1209 Author: dtl Time: 28 December 2020, 10:50:06.875257 am UUID: 25efba24-561f-4c53-97d9-95438edfce90 Ancestors: System-eem.1207 Provide vmParameterAt:default: to handle primitive failure on reading VM parameters. Supply default parameter values to mock possibly missing elements in the parameters array. Remove two unnecessary isRunningCog checks and an ifNotNil: Remove inappropriate halt in sendMouseWheelEvents: Let supportsMultipleBytecodeSets and supportsReadOnlyObjects work on any VM. =============== Diff against System-eem.1207 =============== Item was changed: ----- Method: SmalltalkImage>>isRunningCog (in category 'system attributes') ----- isRunningCog "Answers if we're running on a Cog VM (JIT or StackInterpreter)" + ^(self vmParameterAt: 42 default: nil) - ^(self vmParameterAt: 42) ifNil: [false] ifNotNil: [:numStackPages| numStackPages > 0]! Item was changed: ----- Method: SmalltalkImage>>isRunningCogit (in category 'system attributes') ----- isRunningCogit "Answers if we're running on the Cog JIT" + ^(self vmParameterAt: 46 default: nil) - ^(self vmParameterAt: 46) ifNil: [false] ifNotNil: [:machineCodeZoneSize| machineCodeZoneSize > 0]! Item was changed: ----- Method: SmalltalkImage>>lowSpaceThreshold (in category 'memory space') ----- lowSpaceThreshold "Answer the low space threshold. When the amount of free memory (after garbage collection) falls below this limit, the system is in serious danger of completely exhausting memory and crashing. This limit should be made high enough to allow the user open a debugger to diagnose a problem or to save the image. In a stack-based VM such as Cog contexts for activations in the stack zone will have to be created as the debugger opens, requiring additional headroom." | slotsForDebugger slotsForContextsOnStackPages | slotsForDebugger := 65536. "Arbitrary guess" slotsForContextsOnStackPages := + (self vmParameterAt: 42 default: nil) - (self vmParameterAt: 42) ifNil: [0] ifNotNil: [:numStackPages| | headerSize numActivationsPerPage maxContextSize | numActivationsPerPage := 40. "Design goal of the Cog & Stack VMs" headerSize := 8 / self wordSize. "64-bits for Spur" maxContextSize := thisContext class instSize + CompiledMethod fullFrameSize + headerSize. numStackPages * numActivationsPerPage * maxContextSize]. ^slotsForDebugger + slotsForContextsOnStackPages * self wordSize! Item was changed: ----- Method: SmalltalkImage>>maxExternalSemaphores (in category 'vm parameters') ----- maxExternalSemaphores + "The size of table where external semaphores are registered. Only in Cog, + other VMs are expected to answer nil if present in the parameters array." + ^self vmParameterAt: 49 default: nil! - "The size of table where external semaphores are registered. Only in Cog" - self isRunningCog ifFalse: [^nil]. - ^self vmParameterAt: 49! Item was changed: ----- Method: SmalltalkImage>>maxExternalSemaphores: (in category 'vm parameters') ----- maxExternalSemaphores: aSize "Changes the size of table where external semaphores are registered. The size can only grow, and will always be the next power of two larger than the parameter. Setting this at any time other than start-up can potentially lose requests. i.e. during the realloc new storage is allocated, the old contents are copied and then pointers are switched. Requests occurring during copying won't be seen if they occur to indices already copied. The intended use is to set the table to some adequate maximum at start-up" - self isRunningCog ifFalse: [^0]. "The vm-header field is a short, maximum 64k entries. Well, on most platforms anyways " (aSize < 0 or: [aSize > 16rFFFF]) ifTrue: [^self error: 'maxExternalSemaphores: is limited to 16rFFFF']. + ^[self vmParameterAt: 49 put: aSize] on: Error do: [0].! - ^self vmParameterAt: 49 put: aSize! Item was changed: ----- Method: SmalltalkImage>>processPreemptionYields (in category 'system attributes') ----- processPreemptionYields "Answer whether the VM causes a process to yield on process preemption, i.e. to put a preempted process at the back of its run queue. If the parameter is unavailable (non-Cog VMs) or bit 2 (4) is 0 then preemption yields." + ^((self vmParameterAt: 48 default: [^true]) allMask: 4) not + ! - ^(([self vmParameterAt: 48] - on: Error - do: [:ex| ^true]) allMask: 4) not! Item was changed: ----- Method: SmalltalkImage>>sendMouseWheelEvents (in category 'system attributes') ----- sendMouseWheelEvents "The Cog VM can be instructed to deliver mouse wheel events as mouse wheel events. By default mouse wheel events are mapped to arrow events. This flag persists across snapshots, stored in the image header." + ^(self vmParameterAt: 48 default: 0) anyMask: 32! - ^(self vmParameterAt: 48) anyMask: 32! Item was changed: ----- Method: SmalltalkImage>>supportsMultipleBytecodeSets (in category 'system attributes') ----- supportsMultipleBytecodeSets "Answer whether the VM supports multiple bytecodeSets." "SmalltalkImage current supportsMultipleBytecodeSets" + ^(self vmParameterAt: 65 default: nil) - ^(self vmParameterAt: 65) ifNil: [false] ifNotNil: [:param| "In older VMs this is a boolean answering the vm-internal MULTIPLE_BYTECODE_SETS define" param isInteger "In newer VMs it is a set of integer flags, bit 0 of which is the vm-internal MULTIPLE_BYTECODE_SETS define" ifTrue: [param anyMask: 1] ifFalse: [param]]! Item was changed: ----- Method: SmalltalkImage>>supportsQueueingFinalization (in category 'system attributes') ----- supportsQueueingFinalization "Answer whether the VM queues individual weak arrays for finalization, instead of signalling the finalization semaphore once for all arrays and having the WeakRegistry mechanism finalize all weak arrays, whether they need to or not." "SmalltalkImage current supportsQueueingFinalization" + ^(self vmParameterAt: 48 default: 0) anyMask: 16! - ^(self vmParameterAt: 48) anyMask: 16! Item was changed: ----- Method: SmalltalkImage>>supportsReadOnlyObjects (in category 'system attributes') ----- supportsReadOnlyObjects "Answer whether the VM observes the per-object read-only flag and consequently aborts writes to inst vars of, and fails primitives that attempt to modify, read-only objects." "SmalltalkImage current supportsReadOnlyObjects" + ^(self vmParameterAt: 65 default: nil) - ^(self vmParameterAt: 65) ifNil: [false] ifNotNil: [:param| "In older VMs this is a boolean answering the vm-internal MULTIPLE_BYTECODE_SETS define" param isInteger "In newer VMs it is a set of integer flags, bit 1 of which is the vm-internal IMMUTABILITY define" ifTrue: [param anyMask: 2] ifFalse: [false]]! Item was added: + ----- Method: SmalltalkImage>>vmParameterAt:default: (in category 'vm parameters') ----- + vmParameterAt: parameterIndex default: defaultValueOrBlock + "Answer a VM parameter or defaultValueOrBlock value if out of range." + <primitive: 254> + ^defaultValueOrBlock value! Item was changed: ----- Method: SmalltalkImage>>wordSize (in category 'image') ----- wordSize "Answer the size in bytes of an object pointer or word in the object memory. The value does not change for a given image, but may be modified by a SystemTracer when converting the image to another format. The value is cached in WordSize to avoid the performance overhead of repeatedly consulting the VM." "Smalltalk wordSize" + ^ WordSize ifNil: [WordSize := self vmParameterAt: 40 default: 4]! - ^ WordSize ifNil: [WordSize := [self vmParameterAt: 40] on: Error do: [4]]!

5 5

Re: [squeak-dev] [Vm-dev] some stupid failures
by Marcel Taeumel 05 Jan '21

05 Jan '21

Hi Nicolas. > Do we really want to keep this kind of test? Such benchmarks (and benchmark-like tests) should at least average over several runs and only fail as a test if something actually got slower on average. Or something like that. A single misbehaving run should not be the reason for such a test failure. Maybe we can tweak #should:notTakeMoreThan: to evaluate the block several times? But then it cannot fail early on as it is doing now ... Hmmm... Best, Marcel Am 05.01.2021 09:08:46 schrieb Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: Hi all, sometimes, some build fail for just 1 test... Here https://travis-ci.com/github/OpenSmalltalk/opensmalltalk-vm/jobs/468407844 a squeak.stack.v3 RenderBugz ✗ #testSetForward (7ms) TestFailure: Block evaluation took more than the expected 0:00:00:00.004 RenderBugz(TestCase)>>assert:description: RenderBugz(TestCase)>>should:notTakeMoreThan: RenderBugz(TestCase)>>should:notTakeMoreThanMilliseconds: RenderBugz>>shouldntTakeLong: RenderBugz>>testSetForward ...shouldntTakeLong: [ t forwardDirection: 180.0 . self assert: ( t forwardDirection = 0.0 ) ] RenderBugz(TestCase)>>performTest 4ms, really? On C.I. infrastructure, anything can happen... Do we really want to keep this kind of test? We eventually could once startup performance is known (see isLowerPerformance discussion on squeak-dev), but in the interim, I suggest we neutralize this specific test in Smalltalk-CI.

2 1

The Trunk: System-codefrau.1205.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

Vanessa Freudenberg uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-codefrau.1205.mcz ==================== Summary ==================== Name: System-codefrau.1205 Author: codefrau Time: 20 December 2020, 10:23:10.790782 pm UUID: f94486f3-3743-4300-a495-c2a89089e122 Ancestors: System-dtl.1204 Update platformName for SqueakJS 1.0 =============== Diff against System-dtl.1204 =============== Item was changed: ----- Method: SmalltalkImage>>isLowerPerformance (in category 'system attributes') ----- isLowerPerformance "Some operations - TestCases for example - need an idea of the typical performance of the system on which they are being performed. For now we will simply assert that running on an ARM cpu or as a SqueakJS instance is enough of a discriminator. Options for the future might also involve whether the vm is a full Cog or Sisata system, even actually measuring the performance at some point to be sure" ^ (self platformSubtype beginsWith: 'arm') "Raspberry PI for example" + or: [self platformName = 'JS'] "SqueakJS"! - or: [self platformName = 'Web'] "SqueakJS"!

8 24

multitasking now available in Squeak6.0?
by gettimothy 05 Jan '21

05 Jan '21

Hi folks, I just updated my Squeak6.0 and on a whim I am running all the tests to see what happens. Interestingly, while the tests are running (and no information/progress bar popup is in place) I clicked on the World and the World menu popped up. Is squeak now able to multi-task? cheers, t

3 8

Jump to page: