Squeak-dev January 2021

squeak-dev@lists.squeakfoundation.org

38 participants
171 discussions

The Trunk: Kernel-eem.1365.mcz
by commits＠source.squeak.org 04 Jan '21

04 Jan '21

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1365.mcz ==================== Summary ==================== Name: Kernel-eem.1365 Author: eem Time: 3 January 2021, 6:13:25.987938 pm UUID: 1e125cb0-86f1-451b-b288-d89c06b9f267 Ancestors: Kernel-mt.1364 Context>>#doPrimitive:method:receiver:args: shoukld not send effectiveProcess to Processor activeProcess. The send is done inside Processor>>#activeProcess. Make sure CompiledBlock understands anyAndAllMessages so that implementors/senders doesn't crash inside the debugger with a block selected. =============== Diff against Kernel-mt.1364 =============== Item was added: + ----- Method: CompiledBlock>>anyAndAllMessages (in category 'literals') ----- + anyAndAllMessages + ^self homeMethod anyAndAllMessages! Item was changed: ----- Method: Context>>doPrimitive:method:receiver:args: (in category 'private') ----- doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and arguments are given as arguments to this message. If successful, push result and return resuming context, else ^ {errCode, PrimitiveFailToken}. Any primitive which provokes execution needs to be intercepted and simulated to avoid execution running away." | value | "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. Hence use primitive 19 with care :-)" "SystemNavigation new browseAllSelect: [:m| m primitive = 19]" + primitiveIndex = 19 ifTrue: + [Processor activeProcess - primitiveIndex = 19 ifTrue: [ - Processor activeProcess debug: self title:'Code simulation error' full: false]. ((primitiveIndex between: 201 and: 222) and: [(self objectClass: receiver) includesBehavior: BlockClosure]) ifTrue: [(primitiveIndex = 206 or: [primitiveIndex = 208]) ifTrue: "[Full]BlockClosure>>valueWithArguments:" [^receiver simulateValueWithArguments: arguments first caller: self]. ((primitiveIndex between: 201 and: 209) "[Full]BlockClosure>>value[:value:...]" or: [primitiveIndex between: 221 and: 222]) ifTrue: "[Full]BlockClosure>>valueNoContextSwitch[:]" [^receiver simulateValueWithArguments: arguments caller: self]]. primitiveIndex = 83 ifTrue: "afr 9/11/1998 19:50" "Object>>perform:[with:...]" [^self send: arguments first to: receiver with: arguments allButFirst]. primitiveIndex = 84 ifTrue: "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:" [^self send: arguments first to: receiver with: (arguments at: 2) lookupIn: (self objectClass: receiver)]. primitiveIndex = 100 ifTrue: "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:" [^self send: arguments first to: receiver with: (arguments at: 2) lookupIn: (arguments at: 3)]. "Mutex>>primitiveEnterCriticalSection Mutex>>primitiveTestAndSetOwnershipOfCriticalSection" (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue: + ["Transcript + cr; + nextPutAll: 'Processor activeProcess '; + nextPutAll: (Processor activeProcess == receiver owningProcess ifTrue: [#==] ifFalse: [#~~]); + nextPutAll: ' owner'; + flush." + value := primitiveIndex = 186 + ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: Processor activeProcess] + ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: Processor activeProcess]. - [| effective | - effective := Processor activeProcess effectiveProcess. - "active == effective" - value := primitiveIndex = 186 - ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective] - ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]]. primitiveIndex = 188 ifTrue: "Object>>withArgs:executeMethod: CompiledMethod class>>receiver:withArguments:executeMethod: VMMirror>>ifFail:object:with:executeMethod: et al" [| n args methodArg thisReceiver | ((n := arguments size) between: 2 and: 4) ifFalse: [^self class primitiveFailTokenFor: #'unsupported operation']. ((self objectClass: (args := arguments at: n - 1)) == Array and: [(self objectClass: (methodArg := arguments at: n)) includesBehavior: CompiledMethod]) ifFalse: [^self class primitiveFailTokenFor: #'bad argument']. methodArg numArgs = args size ifFalse: [^self class primitiveFailTokenFor: #'bad number of arguments']. thisReceiver := arguments at: n - 2 ifAbsent: [receiver]. methodArg primitive > 0 ifTrue: [methodArg isQuick ifTrue: [^self push: (methodArg valueWithReceiver: thisReceiver arguments: args)]. ^self doPrimitive: methodArg primitive method: meth receiver: thisReceiver args: args]. ^Context sender: self receiver: thisReceiver method: methodArg arguments: args]. primitiveIndex = 118 ifTrue: "[receiver:]tryPrimitive:withArgs:; avoid recursing in the VM" [(arguments size = 3 and: [(self objectClass: arguments second) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifTrue: [^self doPrimitive: arguments second method: meth receiver: arguments first args: arguments last]. (arguments size = 2 and: [(self objectClass: arguments first) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifFalse: [^self class primitiveFailTokenFor: nil]. ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last]. value := primitiveIndex = 120 "FFI method" ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments] ifFalse: [primitiveIndex = 117 "named primitives" ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments] ifFalse: "should use self receiver: receiver tryPrimitive: primitiveIndex withArgs: arguments but this is only in later VMs (and appears to be broken)" [receiver tryPrimitive: primitiveIndex withArgs: arguments]]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]!

1 0

The Trunk: Tools-eem.1022.mcz
by commits＠source.squeak.org 04 Jan '21

04 Jan '21

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.1022.mcz ==================== Summary ==================== Name: Tools-eem.1022 Author: eem Time: 3 January 2021, 11:56:05.837731 am UUID: 67d66d1d-d650-45f4-8a72-1dd88c6d8ba4 Ancestors: Tools-ct.1021 Less verbosity in ObjectExplorer>>#world =============== Diff against Tools-ct.1021 =============== Item was changed: ----- Method: ObjectExplorer>>world (in category 'monitoring') ----- world - | project | + ^(project := Project current) isMorphic ifTrue: [project world]! - project := Project current. - project isMorphic ifFalse: [^ nil]. - ^ project world!

3 2

The Trunk: Tools-ct.1021.mcz
by commits＠source.squeak.org 03 Jan '21

03 Jan '21

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1021.mcz ==================== Summary ==================== Name: Tools-ct.1021 Author: ct Time: 3 January 2021, 8:44:07.705149 pm UUID: de36bf14-60b2-d745-9ade-df88c56b645c Ancestors: Tools-mt.1019 Hotfix for fatal error in MVC projects when switching from an explorer to an inspector. Regression since Tools-mt.998 (elimination of 'Active' variables): [Project current world] now consistently answers a ControlManager instance in an MVC project rather than nil. Unfortunately, ControlManager does not implement the stepping protocol like Morphic does ... For now, let ObjectExplorer >> #world only answer actually steppable, i.e. morphic worlds, so stepping is disabled safely in MVC. Note that, however, at a later point we might want to talk about stepping support for MVC again ... maybe? The Process Browser already supports it. :-) =============== Diff against Tools-mt.1019 =============== Item was changed: ----- Method: ObjectExplorer>>release (in category 'monitoring') ----- release + self world ifNotNil: [ :world | world stopStepping: self selector: #step ]. - self world ifNotNil: [ self world stopStepping: self selector: #step ]. super release.! Item was changed: ----- Method: ObjectExplorer>>stopMonitoring (in category 'monitoring') ----- stopMonitoring monitorList := nil. + self world ifNotNil: [ :world | world stopStepping: self selector: #step].! - self world stopStepping: self selector: #step! Item was changed: ----- Method: ObjectExplorer>>world (in category 'monitoring') ----- world + | project | + project := Project current. + project isMorphic ifFalse: [^ nil]. + ^ project world! - ^ Project current world!

1 0

The Inbox: Tools-ct.1021.mcz
by commits＠source.squeak.org 03 Jan '21

03 Jan '21

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1021.mcz ==================== Summary ==================== Name: Tools-ct.1021 Author: ct Time: 3 January 2021, 8:44:07.705149 pm UUID: de36bf14-60b2-d745-9ade-df88c56b645c Ancestors: Tools-mt.1019 Hotfix for fatal error in MVC projects when switching from an explorer to an inspector. Regression since Tools-mt.998 (elimination of 'Active' variables): [Project current world] now consistently answers a ControlManager instance in an MVC project rather than nil. Unfortunately, ControlManager does not implement the stepping protocol like Morphic does ... For now, let ObjectExplorer >> #world only answer actually steppable, i.e. morphic worlds, so stepping is disabled safely in MVC. Note that, however, at a later point we might want to talk about stepping support for MVC again ... maybe? The Process Browser already supports it. :-) =============== Diff against Tools-mt.1019 =============== Item was changed: ----- Method: ObjectExplorer>>release (in category 'monitoring') ----- release + self world ifNotNil: [ :world | world stopStepping: self selector: #step ]. - self world ifNotNil: [ self world stopStepping: self selector: #step ]. super release.! Item was changed: ----- Method: ObjectExplorer>>stopMonitoring (in category 'monitoring') ----- stopMonitoring monitorList := nil. + self world ifNotNil: [ :world | world stopStepping: self selector: #step].! - self world stopStepping: self selector: #step! Item was changed: ----- Method: ObjectExplorer>>world (in category 'monitoring') ----- world + | project | + project := Project current. + project isMorphic ifFalse: [^ nil]. + ^ project world! - ^ Project current world!

1 0

The Inbox: ST80-ct.264.mcz
by commits＠source.squeak.org 03 Jan '21

03 Jan '21

A new version of ST80 was added to project The Inbox: http://source.squeak.org/inbox/ST80-ct.264.mcz ==================== Summary ==================== Name: ST80-ct.264 Author: ct Time: 3 January 2021, 8:34:46.789366 pm UUID: 69dbd2d8-5dbf-f043-8ff4-893f45185436 Ancestors: ST80-mt.262 Proposal: Add inspect item to ST80 window blue-button menu. =============== Diff against ST80-mt.262 =============== Item was changed: ----- Method: StandardSystemController class>>initialize (in category 'class initialization') ----- initialize "StandardSystemController initialize" ScheduledBlueButtonMenu := SelectionMenu labels: 'edit label choose color... two-tone/full color move frame full screen collapse + inspect controller close' lines: #(3 7) + selections: #(label chooseColor toggleTwoTone move reframe fullScreen collapse inspect close). - selections: #(label chooseColor toggleTwoTone move reframe fullScreen collapse close). VBorderCursor := Cursor extent: 16@16 fromArray: #( 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010010000100000 2r1010110000110000 2r1011111111111000 2r1010110000110000 2r1010010000100000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000) offset: 0@0. HBorderCursor := Cursor extent: 16@16 fromArray: #( 2r1111111111111111 2r0000000000000000 2r1111111111111111 2r0000000100000000 2r0000001110000000 2r0000011111000000 2r0000000100000000 2r0000000100000000 2r0000000100000000 2r0000000100000000 2r0000011111000000 2r0000001110000000 2r0000000100000000 2r0000000000000000 2r0000000000000000 2r0000000000000000) offset: 0@0.!

1 0

Re: [squeak-dev] FullBlockClosures and ignoreOuterContext?
by Eliot Miranda 02 Jan '21

02 Jan '21

Hi Stefan, > On Jan 2, 2021, at 6:18 AM, Stefan Marr via Squeak-dev <squeak-dev(a)lists.squeakfoundation.org> wrote: > > Hi Fabio: > >> On 2 Jan 2021, at 12:49, Fabio Niephaus <lists(a)fniephaus.com> wrote: >> - In terms of performance, Sista makes almost no difference in TruffleSqueak. > > I would expect a benefit in terms of cold-code/interpreter performance. > Do you see any benefits here? There are two things here, one going on, the other not going on. Sista, the adaptive optimizer architecture, includes Scorch, the image-level speculative compiler. Scorch is not (yet) in use. Clément is at Google and I don’t have the cycles to work on it. But Sista and Scorch require the SistaV1 bytecode set, which is a set capable of expressing normal Smalltalk and optimizations, and a set that lifts limits on maximum method size, supports separate method objects for closures, etc. In Squeak we’ve moved to using the SistaV1 bytecode set but are of the order of six months to a year of engineering effort away from putting Sista the architecture into production. Doing so depends on a more productive development architecture, using the vm simulator and mirrors to allow Scorch to live alongside the simulator and optimize the image being simulated, not the current image, hence insulating the current image from bugs in Scorch. This could be a really interesting PhD and I’d love to collaborate. But if the community simply waits for me to do the work it’ll be years before its complete. I have a very full plate. Of course nothing will happen from Potsdam; they get their funding from Oracle, from Mario as I understand of, and right now that prevents competent people such as Fabio from working on Scorch itself and has them merely spectating, waiting to take advantage of something no one is putting resource into. It’s a frustrating and tragic situation. [I say tragic because my understanding of Shakespeare’s tragedies is that they are all driven by character] Some creativity on behalf of us all seems necessary if this work isn’t going to go to waste. I’m extremely frustrated with this situation. If people can’t find a way of collaborating with me and only find ways of finding what are effectively disruptive efforts then the project will eventually wither and die. I’m working for 3dIcc.com and we’re teetering on the brink. If we can get customers we can survive and I can become self-funding and may, in the remaining eight years to my seventieth birthday, have time to complete Sista; I certainly want to. But if the community could somehow find one or two people of Clément’s abilities to join me directly in the work, rather than simply spectating a body in a coma, then there is a good chance that Sista could be in production within a year or two. Yes I’m angry and frustrated. You would be too. > >> which could greatly improve warmup. > > Less run-time work for optimizers is one possible benefit, but I would expect the interpreter itself to also shows some performance difference. > For instance, I’d assume there’s less needed for run-time specialization in the Truffle interpreter, and the Truffle interpreter code being less polymorphic. > Is that the case/measurable? > > Best regards > Stefan > > > -- > Stefan Marr > School of Computing, University of Kent > https://stefan-marr.de/research/ HNY!! Eliot _,,,^..^,,,_ (phone)

1 0

FullBlockClosures and ignoreOuterContext?
by Fabio Niephaus 02 Jan '21

02 Jan '21

Hi all, While digging through the implementation of FullBlockClosure with Hernan, we were wondering about full closures that ignore their outerContext. We noticed that the following method has two senders: EncoderForSistaV1>>#genPushFullClosure:numCopied:receiverOnStack:ignoreOuterContext: One of them seems to be the only one in use, and it's passing in false as defaults for both receiverOnstack and ignoreOuterContext. The other sender (BytecodeEncoder>>#sizePushFullClosure:numCopied:receiverOnStack:ignoreOuterContext:), in turn, doesn't seem to have any further senders. Unless we missed something, it looks like the outerContext will never be ignored at the moment. Similarly, the receiver is never on the stack. Is this something only Scorch can do or is this just "not yet implemented"? When can the outerContext be ignored? When does it make sense to pop the receiver from the stack? And where can we find the latest version of Scorch. Is it still the one at [1]? Cheers, Fabio [1] https://github.com/clementbera/Scorch

3 5

The Trunk: KernelTests-eem.392.mcz
by commits＠source.squeak.org 01 Jan '21

01 Jan '21

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.392.mcz ==================== Summary ==================== Name: KernelTests-eem.392 Author: eem Time: 1 January 2021, 12:17:42.043127 pm UUID: c803a1d3-a439-4bac-8fc6-de85912285d9 Ancestors: KernelTests-eem.391 Add a FloatTest to compare all literal float contants in methods with those from a fresh compile, failing if any differ. Add a utility method to answer teh set of methods that cause the test to fail (FloatTest>>methodsMaybeContainingBrokenCompiledConstants). =============== Diff against KernelTests-eem.391 =============== Item was added: + ----- Method: FloatTest>>floatLiteralsIn: (in category 'private') ----- + floatLiteralsIn: method + | floatLiterals | + floatLiterals := OrderedCollection new. + method allLiteralsDo: + [:lit| lit isFloat ifTrue: [floatLiterals addLast: lit]]. + ^floatLiterals! Item was added: + ----- Method: FloatTest>>methodContainsFloatLiteral: (in category 'private') ----- + methodContainsFloatLiteral: method + method isQuick ifFalse: + [method allLiteralsDo: + [:lit| lit isFloat ifTrue: [^true]]]. + ^false! Item was added: + ----- Method: FloatTest>>methodsMaybeContainingBrokenCompiledConstants (in category 'private') ----- + methodsMaybeContainingBrokenCompiledConstants + "Answer a set of all methods in the system which contain float constants that differ from those obtaiuned by + recompiling. These may indicate an old compiler issue, or indeed an issue with the current compiler. This is a + variant of testCompiledConstants used for collecting the set of methods rather than testing that none exist." + | identifiedPatients | + identifiedPatients := IdentitySet new. + CurrentReadOnlySourceFiles cacheDuring: + [self systemNavigation allSelectorsAndMethodsDo: + [:class :selector :method| + (self methodContainsFloatLiteral: method) ifTrue: + [| newMethodAndNode newLiterals oldLiterals | + newMethodAndNode := class compile: method getSource asString notifying: nil trailer: CompiledMethodTrailer empty ifFail: nil. + newLiterals := self floatLiteralsIn: newMethodAndNode method. + oldLiterals := self floatLiteralsIn: method. + "Convenience doit for recompiling broken methods:..." + "class recompile: selector" + newLiterals size = oldLiterals size + ifFalse: [identifiedPatients add: method] + ifTrue: + [newLiterals with: oldLiterals do: + [:new :old| + (new asIEEE64BitWord = old asIEEE64BitWord + or: [new isNaN and: old isNaN]) ifFalse: + [identifiedPatients add: method]]]]]]. + ^identifiedPatients! Item was added: + ----- Method: FloatTest>>testCompiledConstants (in category 'tests') ----- + testCompiledConstants + "Test that any methods containing a floating point literal have been correctly compiled." + CurrentReadOnlySourceFiles cacheDuring: + [self systemNavigation allSelectorsAndMethodsDo: + [:class :selector :method| + (self methodContainsFloatLiteral: method) ifTrue: + [| newMethodAndNode newLiterals oldLiterals | + newMethodAndNode := class compile: method getSource asString notifying: nil trailer: CompiledMethodTrailer empty ifFail: nil. + newLiterals := self floatLiteralsIn: newMethodAndNode method. + oldLiterals := self floatLiteralsIn: method. + "Convenience doit for recompiling broken methods:..." + "class recompile: selector" + self assert: newLiterals size = oldLiterals size. + newLiterals with: oldLiterals do: + [:new :old| + self assert: (new asIEEE64BitWord = old asIEEE64BitWord + or: [new isNaN and: old isNaN])]]]]!

1 0

The Trunk: KernelTests-eem.391.mcz
by commits＠source.squeak.org 01 Jan '21

01 Jan '21

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.391.mcz ==================== Summary ==================== Name: KernelTests-eem.391 Author: eem Time: 1 January 2021, 11:29:37.785901 am UUID: 26cca588-616d-452b-9894-287b0f7e677e Ancestors: KernelTests-eem.390 Oops. remember to include the meta part of the test. =============== Diff against KernelTests-eem.390 =============== Item was changed: ----- Method: FloatTest>>testClassConstants (in category 'tests - characterization') ----- testClassConstants "Test all the class constants that are floats to check that they are valid. Sometimes compiler bugs mean that the initialization method is incorrect, etc" | expectedVariables unexpectedVariables "these two are for determining if this test is correct, not its results" finiteVariables infiniteVariables nanVariables | finiteVariables := #(Pi Halfpi Twopi ThreePi RadiansPerDegree Ln2 Ln10 Sqrt2 E Epsilon MaxVal MaxValLn NegativeZero). infiniteVariables := #(Infinity NegativeInfinity). nanVariables := #(NaN). expectedVariables := Set new. unexpectedVariables := Set new. Float classPool keysAndValuesDo: [:name :value| value isFloat ifTrue: [(finiteVariables includes: name) ifTrue: [expectedVariables add: name. self assert: value isFinite. self deny: value isInfinite. self deny: value isNaN]. (infiniteVariables includes: name) ifTrue: [expectedVariables add: name. self deny: value isFinite. self assert: value isInfinite. self deny: value isNaN]. (nanVariables includes: name) ifTrue: [expectedVariables add: name. self deny: value isFinite. self deny: value isInfinite. self assert: value isNaN]. (expectedVariables includes: name) ifFalse: [unexpectedVariables add: name]] ifFalse: + [self deny: ((finiteVariables includes: name) or: [(infiniteVariables includes: name) or: [nanVariables includes: name]])]]. + "Now check that test itself is working as intended..." + self assert: unexpectedVariables isEmpty. + self assert: expectedVariables = (finiteVariables, infiniteVariables, nanVariables) asSet! - [self deny: ((finiteVariables includes: name) or: [(infiniteVariables includes: name) or: [nanVariables includes: name]])]]!

1 0

The Trunk: KernelTests-eem.390.mcz
by commits＠source.squeak.org 01 Jan '21

01 Jan '21

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.390.mcz ==================== Summary ==================== Name: KernelTests-eem.390 Author: eem Time: 1 January 2021, 11:24:53.814816 am UUID: 82abce52-6291-4621-8946-3575c4f4f9c3 Ancestors: KernelTests-ct.389 Add a test to check Float's constants. Add a utility (e.g for package prologs) to answer whether the test passes. At least in my image Float fmax had become NaN. =============== Diff against KernelTests-ct.389 =============== Item was added: + ----- Method: FloatTest class>>testClassConstantsPasses (in category 'utilities') ----- + testClassConstantsPasses + "Answer if testClassConstants passes. This can be used in e.g. the Kernel Package prolog + to test if Float initialize needs to be run." + [self new testClassConstants] + on: TestResult failure + do: [:ex| ^false]. + ^true! Item was added: + ----- Method: FloatTest>>testClassConstants (in category 'tests - characterization') ----- + testClassConstants + + "Test all the class constants that are floats to check that they are valid. + Sometimes compiler bugs mean that the initialization method is incorrect, etc" + | expectedVariables unexpectedVariables "these two are for determining if this test is correct, not its results" + finiteVariables infiniteVariables nanVariables | + finiteVariables := #(Pi Halfpi Twopi ThreePi RadiansPerDegree Ln2 Ln10 Sqrt2 E Epsilon MaxVal MaxValLn NegativeZero). + infiniteVariables := #(Infinity NegativeInfinity). + nanVariables := #(NaN). + expectedVariables := Set new. + unexpectedVariables := Set new. + Float classPool keysAndValuesDo: + [:name :value| + value isFloat + ifTrue: + [(finiteVariables includes: name) ifTrue: + [expectedVariables add: name. + self assert: value isFinite. + self deny: value isInfinite. + self deny: value isNaN]. + (infiniteVariables includes: name) ifTrue: + [expectedVariables add: name. + self deny: value isFinite. + self assert: value isInfinite. + self deny: value isNaN]. + (nanVariables includes: name) ifTrue: + [expectedVariables add: name. + self deny: value isFinite. + self deny: value isInfinite. + self assert: value isNaN]. + (expectedVariables includes: name) ifFalse: + [unexpectedVariables add: name]] + ifFalse: + [self deny: ((finiteVariables includes: name) or: [(infiniteVariables includes: name) or: [nanVariables includes: name]])]]!

1 0

Jump to page: