Squeak-dev December 2021

squeak-dev@lists.squeakfoundation.org

30 participants
391 discussions

The Trunk: Kernel-ct.1438.mcz
by commits＠source.squeak.org 02 Jan '22

02 Jan '22

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1438.mcz ==================== Summary ==================== Name: Kernel-ct.1438 Author: ct Time: 28 December 2021, 9:13:10.136249 pm UUID: 0477e714-e01d-d34d-b6aa-0939494a4abc Ancestors: Kernel-mt.1437, Kernel-ct.1403 Merges Kernel-ct.1403 (fixes simulation of dynamic-forwarding objects as methods). =============== Diff against Kernel-mt.1437 =============== Item was changed: ----- Method: Context>>send:to:with:lookupIn: (in category 'controlling') ----- send: selector to: rcvr with: arguments lookupIn: lookupClass "Simulate the action of sending a message with selector and arguments to rcvr. The argument, lookupClass, is the class in which to lookup the message. This is the receiver's class for normal messages, but for super messages it will be some specific class related to the source method." + | meth methClass primIndex val ctxt | - | meth primIndex val ctxt | (meth := lookupClass lookupSelector: selector) ifNil: [selector == #doesNotUnderstand: ifTrue: [self error: 'Recursive message not understood!!' translated]. ^self send: #doesNotUnderstand: to: rcvr with: {(Message selector: selector arguments: arguments) lookupClass: lookupClass} lookupIn: lookupClass]. + ((methClass := self objectClass: meth) == CompiledMethod or: [methClass == CompiledBlock]) ifFalse: - meth isCompiledMethod ifFalse: ["Object as Methods (OaM) protocol: 'The contract is that, when the VM encounters an ordinary object (rather than a compiled method) in the method dictionary during lookup, it sends it the special selector #run:with:in: providing the original selector, arguments, and receiver.'. DOI: 10.1145/2991041.2991062." ^self send: #run:with:in: to: meth with: {selector. arguments. rcvr}]. meth numArgs = arguments size ifFalse: [^ self error: ('Wrong number of arguments in simulated message {1}' translated format: {selector})]. (primIndex := meth primitive) > 0 ifTrue: [val := self doPrimitive: primIndex method: meth receiver: rcvr args: arguments. (self isPrimFailToken: val) ifFalse: [^val]]. ctxt := self activateMethod: meth withArgs: arguments receiver: rcvr. (primIndex isInteger and: [primIndex > 0]) ifTrue: [ctxt failPrimitiveWith: val]. ^ctxt!

4 3

ChangeSorter preamble eating seems to break broken
by tim Rowledge 31 Dec '21

31 Dec '21

In a ChangeSorter it is now quite tricky to add and edit a preamble. It's a bit difficult to be sure but so far as I can establish you have to make sure that no class in the class list is selected in order to be able to see any preamble text. In 5.3 it seems that selecting a changeset is enough to clear any class selection so that we see the preamble; this is how my muscle memory recalls it. In a 20892 image this does not work the same at all. It appears to be a change in selecting a default - ie the the first class in the list of classes - that makes the difference. This manages to clash quite badly with the menu option to add or edit the preamble, making it seem like the preamble stuff is completely broken. It isn't - it's just not very well. I *think* it must be ChangeSorter>>#showChangeSet: that has changed here; Marcel, what was your intent for that change? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Borrow money from pessimists--they don't expect it back.

2 5

a transitive law broken by Fraction since 5.3
by Chris Muller 31 Dec '21

31 Dec '21

__________ *“If a is equal to b and b is equal to c, then a is equal to c.”* __________ | a b c | a := Fraction numerator: 5 denominator: 1. b := 5.0. c := 5. self assert: a=b; assert: b=c. "Pass" self assert: a=c. "Fail" __________ I understand this is not a normal way to create Fractions, but serializers must often construct objects in other-than-normal ways. This constructor on Fraction is actually a valid API, but leaves an inconsistent comparison contract with other Numbers. I fixed it by reverting Fraction>>#= to the (nice 3/28/2006 23:41) edition. Comments?

3 4

The Inbox: SUnit-ct.133.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

A new version of SUnit was added to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.133.mcz ==================== Summary ==================== Name: SUnit-ct.133 Author: ct Time: 29 December 2021, 6:38:28.060638 pm UUID: 83af50fb-86e6-d843-8e9e-9abe8e8e379a Ancestors: SUnit-mt.125 Updates debugging logic of TestCase. Instead of abusing #halt, open a debugger directly on the entrypoint to run the case. Deprecates #openDebuggerOnFailingTestMethod. Also slightly refactors internal behavior to avoid some duplication, and to get rid of unnecessary semaphores which do not add any value compared to #ensure: unless some really low-level things are broken. Supersedes SUnit-ct.125. Based on my own experiences from >1.5 years, I have revised #debugAsFailure to always halt right before sending #setUp. This improves a) the explorability of any custom set-up/tear-down logic of the test case and b) the immediacy of opening a debugger if you have a very heavy #setUp implementation. From the user perspective, effectively, you still have to click "Over-into-over-into" to navigate into the actual test method. Please report back whether you find this behavior acceptable. :-) =============== Diff against SUnit-mt.125 =============== Item was added: + ----- Method: TestCase>>assureResourcesDuring: (in category 'private') ----- + assureResourcesDuring: aBlock + + | resources | + resources := self resources. + resources do: [:resource | + resource isAvailable ifFalse: [ + ^ resource signalInitializationError]]. + ^ aBlock ensure: [ + resources do: [:resource | + resource reset]].! Item was changed: ----- Method: TestCase>>debug (in category 'running') ----- debug + "Run the receiver and open a debugger on the first failure or error." + + ^ self assureResourcesDuring: [self runCaseWithoutTimeout]! - self resources do: - [ : res | res isAvailable ifFalse: [ ^ res signalInitializationError ] ]. - [ self runCase ] ensure: - [ self resources do: - [ : each | each reset ] ]! Item was changed: ----- Method: TestCase>>debugAsFailure (in category 'running') ----- debugAsFailure + "Spawn a debugger that is ready to debug the receiver." + + (Process + forBlock: [self debug] + runUntil: [:context | context isClosureContext "navigate the process directly to the point where it is about to send #setUp" + and: [context selector = #runCaseWithoutTimeout]]) + debug.! - | semaphore | - semaphore := Semaphore new. - self resources do: [:res | - res isAvailable ifFalse: [^res signalInitializationError]]. - [semaphore wait. self resources do: [:each | each reset]] fork. - (self class selector: testSelector) runCaseAsFailure: semaphore.! Item was changed: ----- Method: TestCase>>openDebuggerOnFailingTestMethod (in category 'running') ----- openDebuggerOnFailingTestMethod + + self deprecated: 'ct: Use #debugAsFailure'. + "SUnit has halted one step in front of the failing test method. Step over the 'self halt' and send into 'self perform: testSelector' to see the failure from the beginning" - self halt; performTest! Item was changed: ----- Method: TestCase>>runCaseAsFailure: (in category 'running') ----- runCaseAsFailure: aSemaphore + + self deprecated: 'ct: Use #runCaseWithoutTimeout and #ensure:'. + ^ [self runCaseWithoutTimeout] + ensure: [aSemaphore signal]! - [self setUp. - self openDebuggerOnFailingTestMethod] ensure: [ - self tearDown. - aSemaphore signal]! Item was added: + ----- Method: TestCase>>runCaseWithoutTimeout (in category 'running') ----- + runCaseWithoutTimeout + + [self setUp. + self performTest] + ensure: [self tearDown].!

2 1

The Trunk: System-mt.1276.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1276.mcz ==================== Summary ==================== Name: System-mt.1276 Author: mt Time: 31 December 2021, 3:06:43.907879 pm UUID: 1a8c32b0-87e9-7748-b3a3-d6566d8c1d66 Ancestors: System-mt.1275 Quickfix for loading older pref dicts from file. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217817… =============== Diff against System-mt.1275 =============== Item was changed: ----- Method: Preferences class>>loadPreferencesFrom: (in category 'initialization - save/load') ----- loadPreferencesFrom: aFile | stream params dict desktopColor patternsToIgnore | patternsToIgnore := #('*updateMapName' '*defaultUpdateURL'). stream := ReferenceStream fileNamed: aFile. params := stream next. self assert: (params isKindOf: IdentityDictionary). params removeKey: #PersonalDictionaryOfPreferences. dict := stream next. self assert: (dict isKindOf: IdentityDictionary). desktopColor := stream next. stream close. + dict rehash. "See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217817…" dict keys reject: [:key | patternsToIgnore anySatisfy: [:pattern | pattern match: key]] thenDo: [:key | | value | value := dict at: key. (self preferenceAt: key ifAbsent: [nil]) ifNotNil: [:pref | [pref preferenceValue: value preferenceValue] on: Deprecation do: [ : err | "Ignore preferences which may not be supported anymore."]]]. params keysAndValuesDo: [ :key :value | self setParameter: key to: value ]. Smalltalk isMorphic ifTrue: [ Project current world fillStyle: desktopColor ] ifFalse: [ self desktopColor: desktopColor. ScheduledControllers updateGray ]!

1 0

The Trunk: PreferenceBrowser-mt.125.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-mt.125.mcz ==================== Summary ==================== Name: PreferenceBrowser-mt.125 Author: mt Time: 31 December 2021, 2:47:02.385589 pm UUID: 29599ad7-e40a-8049-bf8f-d35555f8b0a4 Ancestors: PreferenceBrowser-mt.124 I forgot to update the balloon texts. Note that this method needs clean up but I am exhausted right now. At least that messy style is confined in PreferenceWizardMorph. =============== Diff against PreferenceBrowser-mt.124 =============== Item was changed: ----- Method: PreferenceWizardMorph>>updateFromChangedScaleFactor (in category 'display scale') ----- updateFromChangedScaleFactor previewWorld delete. previewWorld := nil. DisplayScreen displayIsFullScreen ifFalse: [ DisplayScreen setNewScreenSize: (self defaultExtent * RealEstateAgent scaleFactor) rounded]. checkmark := nil. radiomark := nil. self layoutInset: (self defaultFont widthOf: $x) * 2; cellGap: (self defaultFont widthOf: $x). titleMorph font: (UserInterfaceTheme current get: #wizardTitleFont); margins: (self cellGap @ 0 corner: self cellGap @ self cellGap). titleMorph layoutFrame bottomOffset: titleMorph height. self updateLowPerformanceLabel: lowPerformanceMorph contents. "buttons" {startButton. skipButton. previousButton. nextButton. doneButton}, (pages gather: [:page | page allMorphs select: [:ea | ea isButton]]) do: [:button | ((button owner hasProperty: #isRadioButton) or: [button owner hasProperty: #isCheckbox]) ifTrue: [ button "layoutInset: 0;" extent: (TextStyle defaultFont height * 1.75) asPoint; update: button getLabelSelector. + button owner cellGap: (TextStyle defaultFont widthOf: $x). + button owner balloonText ifNotNil: [:text | + text addAttribute: (TextFontReference toFont: (UserInterfaceTheme current get: #wizardHelpFont))]] - button owner cellGap: (TextStyle defaultFont widthOf: $x)] ifFalse: [ button layoutInset: self defaultButtonMargins]. button borderWidth: (2 * RealEstateAgent scaleFactor) truncated; font: (UserInterfaceTheme current get: #wizardButtonFont); updateMinimumExtent "Font might not change but PPI did."]. self fullBounds. (startButton minimumWidth max: skipButton minimumWidth) in: [:w | startButton hResizing: #rigid; width: w. skipButton hResizing: #rigid; width: w. startButton layoutFrame leftOffset: 2*w negated. skipButton layoutFrame rightOffset: 2*w]. (previousButton minimumWidth max: nextButton minimumWidth) in: [:w | previousButton hResizing: #rigid; width: w. nextButton hResizing: #rigid; width: w]. pagesLabel margins: (self layoutInset@0 corner: self layoutInset@0); font: (UserInterfaceTheme current get: #wizardStandardFont). buttonRowMorph cellGap: self cellGap; layoutInset: (0@self layoutInset corner: 0@0). buttonRowMorph layoutFrame topOffset: buttonRowMorph fullBounds height negated. "labels" {controlMorph firstSubmorph}, (pages gather: [:page | page allMorphs select: [:ea | ea isTextMorph]]) do: [:label | label font: (UserInterfaceTheme current get: #wizardStandardFont); margins: self defaultTextMargins "No need for #releaseParagraph because window resizing will happen anyway."]. "controlMorph" controlMorph layoutInset: (0@0 corner: self cellGap@0). controlMorph layoutFrame topOffset: titleMorph height; bottomOffset: buttonRowMorph height negated. "scroll panes in pages" pages do: [:page | | scrollPane | page layoutInset: (self layoutInset asPoint corner: self cellGap@0); cellGap: self cellGap. scrollPane := page submorphs second. scrollPane scrollBarThickness: self layoutInset. scrollPane scroller firstSubmorph cellGap: self cellGap; layoutInset: (0@0 corner: self cellGap@0). (scrollPane vScrollBar instVarNamed: #slider) borderWidth: (2 * RealEstateAgent scaleFactor) truncated]. "previewWorld" self initializePreviewWorld. self addMorph: previewWorld. self step. " previewWorld borderWidth: (2 * RealEstateAgent scaleFactor) truncated. previewWorld layoutFrame topOffset: titleMorph height; bottomOffset: buttonRowMorph height negated. " !

1 0

The Trunk: 60Deprecated-mt.101.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-mt.101.mcz ==================== Summary ==================== Name: 60Deprecated-mt.101 Author: mt Time: 31 December 2021, 2:10:27.09979 pm UUID: 00cc3301-aabc-b74d-aeda-4b1514dbcc07 Ancestors: 60Deprecated-mt.100 Adds missing deprecations in wizard to make the CI finish again. =============== Diff against 60Deprecated-mt.100 =============== Item was added: + ----- Method: PreferenceWizardMorph>>stateUseBiggerFonts (in category '*60Deprecated-actions buttons') ----- + stateUseBiggerFonts + + self flag: #deprecated. "mt: Soft deprecation for the CI." + ^ false! Item was added: + ----- Method: PreferenceWizardMorph>>toggleUseBiggerFonts (in category '*60Deprecated-actions buttons') ----- + toggleUseBiggerFonts + + self flag: #deprecated. "mt: Soft deprecation for the CI." + !

1 0

The Trunk: ReleaseBuilder-mt.225.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.225.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.225 Author: mt Time: 31 December 2021, 12:51:13.044496 pm UUID: 1c2edec1-adeb-dd47-aa0c-f09861f8e5df Ancestors: ReleaseBuilder-mt.224 Fixes regression in ReleaseBuilder. =============== Diff against ReleaseBuilder-mt.224 =============== Item was changed: ----- Method: ReleaseBuilder class>>clearCaches (in category 'scripts') ----- clearCaches "Clear caches, discard unused references, free space." "1) Explicit clean-up of FONT-related stuff." + Display platformScaleFactor: nil; uiScaleFactor: 1.0. self cleanUpBitstreamVeraSans. StrikeFont initialize. "2) FIRST PHASE of explicit clean-up of CODE-related stuff." self discardUserObjects. MCFileBasedRepository flushAllCaches. "3) Now clean-up all STATE-related stuff." Preferences chooseInitialSettings. + Smalltalk cleanUp: true. - Smalltalk cleanUp: true. "4) SECOND PHASE of explicit clean-up of CODE-related stuff. As late as possible to get rid of all references before running this." Smalltalk garbageCollect. Environment allInstancesDo: [:environment | environment purgeUndeclared ]. Undeclared removeUnreferencedKeys. ! Item was changed: ----- Method: ReleaseBuilder class>>configureDesktop (in category 'scripts') ----- configureDesktop "Open tools, multimedia content, etc." self setDisplayExtent: 1024 @ 768. self setProjectBackground: Color darkGray. + (UserInterfaceTheme named: 'Squeak') applyScaled. - (UserInterfaceTheme named: 'Squeak') apply. self deleteAllWindows. self deleteAllOtherMorphs. "Avoid strange drawing issues." Project current world allMorphsDo: [:m | m removeProperty: #errorOnDraw]. "Replace docking bar instance in case its code has changed." Project current removeMainDockingBar. TheWorldMainDockingBar updateInstances.! Item was changed: ----- Method: ReleaseBuilder class>>prepareEnvironment (in category 'preparing') ----- prepareEnvironment "Prepare everything that should be done for a new image build. Clear caches, passwords, etc." | balloon | self clearCaches; configureProjects; configureTools; setPreferences; configureDesktop. balloon := self getBalloonForm. "Get now because later the file might be missing." DeferredTask := [ self openWelcomeWorkspacesWith: balloon. PreferenceWizardMorph open]. "If you save-and-quit the image after calling #prepareEnvironment, ensure that the next image startup will be fast." + Project current world doOneCycle. + Display platformScaleFactor: 1.0.! - Project current world doOneCycle.!

1 0

The Trunk: Graphics-mt.456.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.456.mcz ==================== Summary ==================== Name: Graphics-mt.456 Author: mt Time: 31 December 2021, 12:49:55.337496 pm UUID: ca084a4c-d28b-b54b-af9b-ae8d9cbfcd80 Ancestors: Graphics-mt.455 Quickfix for re-initialization of pre-rendered DejaVu Sans. =============== Diff against Graphics-mt.455 =============== Item was changed: ----- Method: StrikeFont class>>createDejaVu: (in category 'font creation') ----- createDejaVu: pointSize "Warning: Uses the methods in 'dejaVu font data' category, that will be removed soon (or are already removed) to save space." + | base bold oblique boldOblique point actualPointSize | - | base bold oblique boldOblique point | point := pointSize asString. + actualPointSize := self fixDejaVuPointSIze: pointSize. base := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBook', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBook', point, 'Data') asSymbol) name: 'Bitmap DejaVu Sans ', point) + pointSize: actualPointSize. - pointSize: pointSize. bold := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBold', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBold', point, 'Data') asSymbol) name: 'Bitmap DejaVu Sans ', point, 'B') emphasis: 1; + pointSize: actualPointSize. - pointSize: pointSize. oblique := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansOblique', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansOblique', point, 'Data') asSymbol) name: 'Bitmap DejaVu Sans ', point, 'I') emphasis: 2; + pointSize: actualPointSize. - pointSize: pointSize. boldOblique := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBoldOblique', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBoldOblique', point, 'Data') asSymbol) name: 'Bitmap DejaVu Sans ', point, 'BI') emphasis: 3; + pointSize: actualPointSize. - pointSize: pointSize. base derivativeFont: bold at: 1. base derivativeFont: oblique at: 2. base derivativeFont: boldOblique at: 3. ^base! Item was changed: ----- Method: StrikeFont class>>createDejaVuDark: (in category 'font creation') ----- createDejaVuDark: pointSize + | base bold oblique boldOblique point actualPointSize | - | base bold oblique boldOblique point | point := pointSize asString. + actualPointSize := self fixDejaVuPointSIze: pointSize. base := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBookDark', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBookDark', point, 'Data') asSymbol) name: 'Darkmap DejaVu Sans', point) + pointSize: actualPointSize. - pointSize: pointSize. bold := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBoldDark', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBoldDark', point, 'Data') asSymbol) name: 'Darkmap DejaVu Sans', point, 'B') emphasis: 1; + pointSize: actualPointSize. - pointSize: pointSize. oblique := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansObliqueDark', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansObliqueDark', point, 'Data') asSymbol) name: 'Darkmap DejaVu Sans', point, 'I') emphasis: 2; + pointSize: actualPointSize. - pointSize: pointSize. boldOblique := (StrikeFont new buildFromForm: (self perform: ('dejaVuSansBoldObliqueDark', point, 'Form') asSymbol) data: (self perform: ('dejaVuSansBoldObliqueDark', point, 'Data') asSymbol) name: 'Darkmap DejaVu Sans', point, 'BI') emphasis: 3; + pointSize: actualPointSize. - pointSize: pointSize. base derivativeFont: bold at: 1. base derivativeFont: oblique at: 2. base derivativeFont: boldOblique at: 3. ^base! Item was added: + ----- Method: StrikeFont class>>fixDejaVuPointSIze: (in category 'font creation') ----- + fixDejaVuPointSIze: pointSize + "Maps the given pointSize to 96 ppi." + + ^ (Dictionary newFrom: { + 7 -> 7.5. + 9 -> 10.5. + 12 -> 14.5. + 14 -> 16.5. + 17 -> 19.5. + 20 -> 23.5}) at: pointSize + !

1 0

The Trunk: Morphic-mt.1839.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1839.mcz ==================== Summary ==================== Name: Morphic-mt.1839 Author: mt Time: 31 December 2021, 12:22:28.156545 pm UUID: 195e1996-bbf5-2a44-a88d-b4161321c930 Ancestors: Morphic-mt.1838 Fixes regression in FontChooserTool. =============== Diff against Morphic-mt.1838 =============== Item was changed: ----- Method: FontChooserTool>>selectedTextStyle (in category 'font list') ----- selectedTextStyle + ^TextStyle named: (self selectedFontFamily ifNil:[^TextStyle default]).! - ^TextStyle named: (self selectedFontFamily ifNil: [TextStyle default])!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
40
Older →

Jump to page: