Squeak-dev May 2023

squeak-dev@lists.squeakfoundation.org

16 participants
109 discussions

Review Request: allTimeZones.4.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 18 Jun '23

18 Jun '23

=============== Summary =============== Change Set: allTimeZones Date: 18 May 2023 Author: Christoph Thiede Adds convenient accessors to TimeZone class side for browsing and finding timezones. Also adds tests. =============== Diff =============== TimeZone class>>allForOffset: {accessing} · ct 5/15/2023 19:23 + allForOffset: aDuration + + ^ self allTimeZones select: [:ea | ea offset = aDuration] TimeZone class>>allTimeZones {accessing} · ct 5/14/2023 21:19 + allTimeZones + + ^ self timeZones , self timeZonesDST TimeZoneTest + ClassTestCase subclass: #TimeZoneTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Chronology-Tests' + + TimeZoneTest class + instanceVariableNames: '' + + "" TimeZoneTest>>testAllForOffset {tests} · ct 5/17/2023 20:29 + testAllForOffset + + self assert: ((self classToBeTested allForOffset: 0 hours) collect: #abbreviation) = #('UTC' 'GMT'). + self assert: (self classToBeTested allForOffset: -14 hours) isEmpty. TimeZoneTest>>testAllTimeZones {tests} · ct 5/17/2023 20:26 + testAllTimeZones + + self assert: self classToBeTested allTimeZones notEmpty. + self assert: (self classToBeTested allTimeZones anySatisfy: [:ea | ea offset = 2 hours]). --- Sent from Squeak Inbox Talk ["allTimeZones.4.cs"]

4 6

#lines and #findString: on Text
by christoph.thiede＠student.hpi.uni-potsdam.de 05 Jun '23

05 Jun '23

Hi all, quick question: Would you like/mind to see #lines and #findString: and their variants on Text? I have some usecases for that, but I don't know whether this would clutter the interface too much. (Could be a nice application for traits ... :-)) Best, Christoph

2 6

Review Request: UIManagerInformTitle.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

=============== Summary =============== Change Set: UIManagerInformTitle Date: 17 May 2023 Author: Christoph Thiede Adds UIManager>>#inform:title:, analogously to existing #confirm:title. Project uiManager inform: 'Squeak is great!' title: 'Important Note' =============== Diff =============== DummyUIManager>>inform:title: {ui requests} · ct 5/14/2023 21:27 + inform: aString title: titleString + "Nothing to be done here" + self askForProvidedAnswerTo: aString ifSupplied: [:answer | + ^ answer]. MVCUIManager>>inform:title: {ui requests} · ct 5/14/2023 21:27 + inform: aString title: titleString + "Display a message for the user to read and then dismiss" + self askForProvidedAnswerTo: aString ifSupplied: [:answer | + ^ answer]. + + ^ PopUpMenu inform: (self dialogStringFromQuery: aString withTitle: titleString) MorphicUIManager>>inform:title: {ui requests} · ct 5/14/2023 21:26 + inform: aString title: titleString + "Display a message for the user to read and then dismiss" + self askForProvidedAnswerTo: aString ifSupplied: [:answer | + ^ answer]. + + ^ UserDialogBoxMorph inform: aString title: titleString UIManager>>inform:title: {ui requests} · ct 5/14/2023 21:27 + inform: aString title: titleString + "Display a message for the user to read and then dismiss" + ^self subclassResponsibility --- Sent from Squeak Inbox Talk ["UIManagerInformTitle.1.cs"]

4 16

Review Request: base32.4.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

=============== Summary =============== Change Set: base32 Date: 18 May 2023 Author: Christoph Thiede Adds support for base32 encoding and decoding. Adds Base32MimeConverter class and subsumes it with existing Base64MimeConverter class under new abstract RFC4648MimeConverter class. Adds #base32Encoded and #base32Decoded on String and String+ByteArray, resp. Adds convenient MimeConverter class>>#mimeDecode:. Tests new converter in new Base32MimeConverterTest and subsumes it with existing Base64MimeConverterTest under new abstract RFC4648MimeConverterTest. =============== Diff =============== Base32MimeConverter + nil subclass: #Base32MimeConverter + instanceVariableNames: '' + classVariableNames: 'FromCharTable ToCharTable' + poolDictionaries: '' + category: 'Collections-Streams' + + Base32MimeConverter class + instanceVariableNames: '' + + "I encode and decode data in base32 format. I translate a whole stream at once, taking a Stream as input and giving one as output, and answer a whole stream for the sender to use. 0 A 8 I 16 Q 24 Y 1 B 9 J 17 R 25 Z 2 C 10 K 18 S 26 2 3 D 11 L 19 T 27 3 4 E 12 M 20 U 28 4 5 F 13 N 21 V 29 5 6 G 14 O 22 W 30 6 7 H 15 P 23 X 31 7 (pad) = Outbound: bytes are broken into 5 bit chunks, and the 0-31 value is converted to a character. 5 data bytes go into 8 characters. Inbound: Characters are translated in to 0-31 values and shifted into 8 bit bytes." Base32MimeConverter class>>initialize {class initialization} · ct 5/18/2023 16:07 + initialize + + FromCharTable := Array new: 256. "nils" + ToCharTable := ($A to: $Z) , ($2 to: $7) , '='. + ToCharTable keysAndValuesDo: [:ind :char | + FromCharTable at: char asciiValue + 1 put: ind - 1]. Base32MimeConverter>>fromCharTable {private} · ct 5/18/2023 19:47 + fromCharTable + + ^ FromCharTable Base32MimeConverter>>mimeDecode {conversion} · ct 5/18/2023 19:49 + mimeDecode + "Convert the stream in base 32 with only A-Z,2-7 to a full byte stream of characters. Answer a whole stream for the user to read." + + | nibA nibB nibC nibD nibE nibF nibG nibH | + [mimeStream atEnd] whileFalse: [ + (nibA := self nextValue) ifNil: [^ dataStream]. + (nibB := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibA bitShift: 3) + (nibB bitShift: -2)) asCharacter. + nibB := nibB bitAnd: 16r3. + (nibC := self nextValue) ifNil: [^ dataStream]. + (nibD := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibB bitShift: 6) + (nibC bitShift: 1) + (nibD bitShift: -4)) asCharacter. + nibD := nibD bitAnd: 16rF. + (nibE := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibD bitShift: 4) + (nibE bitShift: -1)) asCharacter. + nibE := nibE bitAnd: 16r1. + (nibF := self nextValue) ifNil: [^ dataStream]. + (nibG := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibE bitShift: 7) + (nibF bitShift: 2) + (nibG bitShift: -3)) asCharacter. + nibG := nibG bitAnd: 16r7. + (nibH := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibG bitShift: 5) + nibH) asCharacter. + ]. + ^ dataStream Base32MimeConverter>>mimeDecodeToByteArray {conversion} · ct 5/18/2023 19:49 + mimeDecodeToByteArray + "Convert the stream in base 32 with only A-Z,2-7 to a full ByteArray of 0-255 values. Answer a whole stream for the user to read." + + | nibA nibB nibC nibD nibE nibF nibG nibH | + [mimeStream atEnd] whileFalse: [ + (nibA := self nextValue) ifNil: [^ dataStream]. + (nibB := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibA bitShift: 3) + (nibB bitShift: -2)). + nibB := nibB bitAnd: 16r3. + (nibC := self nextValue) ifNil: [^ dataStream]. + (nibD := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibB bitShift: 6) + (nibC bitShift: 1) + (nibD bitShift: -4)). + nibD := nibD bitAnd: 16rF. + (nibE := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibD bitShift: 4) + (nibE bitShift: -1)). + nibE := nibE bitAnd: 16r1. + (nibF := self nextValue) ifNil: [^ dataStream]. + (nibG := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibE bitShift: 7) + (nibF bitShift: 2) + (nibG bitShift: -3)). + nibG := nibG bitAnd: 16r7. + (nibH := self nextValue) ifNil: [^ dataStream]. + dataStream nextPut: ((nibG bitShift: 5) + nibH). + ]. + ^ dataStream Base32MimeConverter>>mimeEncode {conversion} · ct 5/18/2023 19:12 + mimeEncode + "Convert from data to 5 bit characters." + + | padding raw nib lineLength | + padding := nil. + lineLength := 0. + [dataStream atEnd] whileFalse: [ + (multiLine and:[lineLength >= 70]) ifTrue: [ mimeStream cr. lineLength := 0. ]. + data := raw := dataStream next asInteger. + nib := (data bitAnd: 16rF8) bitShift: -3. "1111 1000" + mimeStream nextPut: (ToCharTable at: nib+1). + (raw := dataStream next) ifNil: [raw := 0. padding := -6]. + data := ((data bitAnd: 7) bitShift: 8) + raw asInteger. "0000 0111" + nib := (data bitAnd: 16r7C0) bitShift: -6. "0000 0111 1100 0000" + mimeStream nextPut: (ToCharTable at: nib+1). + nib := (data bitAnd: 16r3E) bitShift: -1. "0011 1110" + mimeStream nextPut: (ToCharTable at: nib+1). + (raw := dataStream next) ifNil: [raw := 0. padding ifNil: [padding := -4]]. + data := ((data bitAnd: 1) bitShift: 8) + (raw asInteger). "0000 0001" + nib := (data bitAnd: 16r1F0) bitShift: -4. "0000 0001 1111 0000" + mimeStream nextPut: (ToCharTable at: nib+1). + (raw := dataStream next) ifNil: [raw := 0. padding ifNil: [padding := -3]]. + data := ((data bitAnd: 16rF) bitShift: 8) + (raw asInteger). "0000 1111" + nib := (data bitAnd: 16rF80) bitShift: -7. "0000 1111 1000 0000" + mimeStream nextPut: (ToCharTable at: nib+1). + nib := (data bitAnd: 16r7C) bitShift: -2. "0111 1100" + mimeStream nextPut: (ToCharTable at: nib+1). + (raw := dataStream next) ifNil: [raw := 0. padding ifNil: [padding := -1]]. + data := ((data bitAnd: 3) bitShift: 8) + (raw asInteger). "0000 0011" + nib := (data bitAnd: 16r3E0) bitShift: -5. "0000 0011 1110 0000" + mimeStream nextPut: (ToCharTable at: nib+1). + nib := (data bitAnd: 16r1F). "0001 1111" + mimeStream nextPut: (ToCharTable at: nib+1). + + lineLength := lineLength + 8.]. + + padding ifNotNil: [ + mimeStream skip: padding. + padding to: -1 do: [:i | mimeStream nextPut: $=]. + ^ mimeStream]. Base32MimeConverterTest + nil subclass: #Base32MimeConverterTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Streams' + + Base32MimeConverterTest class + instanceVariableNames: '' + + "" Base32MimeConverterTest>>testBase32Encoded {tests} · ct 5/18/2023 20:08 + testBase32Encoded + + | encoded | + encoded := (self classToBeTested mimeEncode: message) contents. + self assert: string base32Encoded equals: encoded. Base32MimeConverterTest>>testMimeEncodeDecode {tests} · ct 5/18/2023 20:10 + testMimeEncodeDecode + + | encoded | + encoded := self classToBeTested mimeEncode: message. + self assert: 'JBUSAVDIMVZGKII=' equals: encoded contents. + self assert: message contents equals: (self classToBeTested mimeDecodeToChars: encoded) contents. + + "Encoding should start from the beginning of the stream." + message reset. + message skip: 2. + encoded := self classToBeTested mimeEncode: message. + self assert: 'JBUSAVDIMVZGKII=' equals: encoded contents. + + "Encoding should start from the current position of the stream." + message reset. + message skip: 2. + encoded := self classToBeTested mimeEncodeContinue: message. + self assert: 'EBKGQZLSMUQQ====' equals: encoded contents. Base32MimeConverterTest>>testMimeEncodeDecodeMultiLine {tests} · ct 5/18/2023 20:07 + testMimeEncodeDecodeMultiLine + + | encoded | + encoded := (self classToBeTested mimeEncode: (String new: 100 withAll: $a) readStream) contents. + self assert: encoded = + 'MFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLB + MFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLB + MFQWCYLBMFQWCYLB'. + + encoded := (self classToBeTested mimeEncode: (String new: 100 withAll: $a) readStream multiLine: false) contents. + self assert: encoded = + 'MFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLBMFQWCYLB'. Base32MimeConverterTest>>testOnByteArray {tests} · ct 5/18/2023 20:07 + testOnByteArray + + self assert: string base32Encoded = string asByteArray base32Encoded. Base64MimeConverter (changed) - MimeConverter subclass: #Base64MimeConverter - instanceVariableNames: 'data multiLine' + nil subclass: #Base64MimeConverter + instanceVariableNames: '' classVariableNames: 'FromCharTable ToCharTable' poolDictionaries: '' category: 'Collections-Streams' Base64MimeConverter class instanceVariableNames: '' "This class encodes and decodes data in Base64 format. This is MIME encoding. We translate a whole stream at once, taking a Stream as input and giving one as output. Returns a whole stream for the caller to use. 0 A 17 R 34 i 51 z 1 B 18 S 35 j 52 0 2 C 19 T 36 k 53 1 3 D 20 U 37 l 54 2 4 E 21 V 38 m 55 3 5 F 22 W 39 n 56 4 6 G 23 X 40 o 57 5 7 H 24 Y 41 p 58 6 8 I 25 Z 42 q 59 7 9 J 26 a 43 r 60 8 10 K 27 b 44 s 61 9 11 L 28 c 45 t 62 + 12 M 29 d 46 u 63 / 13 N 30 e 47 v 14 O 31 f 48 w (pad) = 15 P 32 g 49 x 16 Q 33 h 50 y Outbound: bytes are broken into 6 bit chunks, and the 0-63 value is converted to a character. 3 data bytes go into 4 characters. Inbound: Characters are translated in to 0-63 values and shifted into 8 bit bytes. (See: N. Borenstein, Bellcore, N. Freed, Innosoft, Network Working Group, Request for Comments: RFC 1521, September 1993, MIME (Multipurpose Internet Mail Extensions) Part One: Mechanisms for Specifying and Describing the Format of Internet Message Bodies. Sec 6.2) By Ted Kaehler, based on Tim Olson's Base64Filter." Base64MimeConverter class>>decodeInteger: {convenience} · tk 2/19/2000 15:53 (removed) - decodeInteger: mimeString - | bytes sum | - "Decode the MIME string into an integer of any length" - - bytes := (Base64MimeConverter mimeDecodeToBytes: - (ReadStream on: mimeString)) contents. - sum := 0. - bytes reverseDo: [:by | sum := sum * 256 + by]. - ^ sum Base64MimeConverter class>>encodeInteger: {convenience} · nice 7/26/2014 23:00 (removed) - encodeInteger: int - | strm | - "Encode an integer of any length and return the MIME string" - - strm := WriteStream on: (ByteArray new: int digitLength). - 1 to: int digitLength do: [:ii | strm nextPut: (int digitAt: ii)]. - ^ ((self mimeEncode: strm readStream) contents) copyUpTo: $= "remove padding" Base64MimeConverter class>>mimeDecodeToBytes: {convenience} · nice 7/26/2014 23:03 (removed) - mimeDecodeToBytes: aStream - "Return a ReadStream of the original ByteArray. aStream has only 65 innocuous character values. aStream is not binary. (See class comment). 4 bytes in aStream goes to 3 bytes in output." - - | me | - aStream position: 0. - me := self new mimeStream: aStream. - me dataStream: (WriteStream on: (ByteArray new: aStream size * 3 // 4)). - me mimeDecodeToByteArray. - ^ me dataStream readStream Base64MimeConverter class>>mimeDecodeToChars: {convenience} · nice 7/26/2014 23:01 (removed) - mimeDecodeToChars: aStream - "Return a ReadWriteStream of the original String. aStream has only 65 innocuous character values. It is not binary. (See class comment). 4 bytes in aStream goes to 3 bytes in output." - - | me | - aStream position: 0. - me := self new mimeStream: aStream. - me dataStream: (WriteStream on: (String new: aStream size * 3 // 4)). - me mimeDecode. - ^ me dataStream readStream Base64MimeConverter class>>mimeEncode: {convenience} · ar 3/9/2010 22:17 (removed) - mimeEncode: aStream - "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." - ^self mimeEncode: aStream multiLine: true atStart: true Base64MimeConverter class>>mimeEncode:multiLine: {convenience} · ar 3/9/2010 22:17 (removed) - mimeEncode: aStream multiLine: aBool - "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." - - ^self mimeEncode: aStream multiLine: aBool atStart: true Base64MimeConverter class>>mimeEncode:multiLine:atStart: {private - convenience} · nice 7/26/2014 22:59 (removed) - mimeEncode: aStream multiLine: aBool atStart: resetInput - "Return a ReadStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." - - | me | - resetInput ifTrue:[aStream position: 0]. - me := self new dataStream: aStream. - me multiLine: aBool. - me mimeStream: (WriteStream on: (String new: aStream size + 20 * 4 // 3)). - me mimeEncode. - ^ me mimeStream readStream Base64MimeConverter class>>mimeEncodeContinue: {private - convenience} · ar 3/9/2010 22:17 (removed) - mimeEncodeContinue: aStream - "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." - ^self mimeEncode: aStream multiLine: true atStart: false Base64MimeConverter>>fromCharTable {private} · ct 5/18/2023 19:47 + fromCharTable + + ^ FromCharTable Base64MimeConverter>>mimeDecode {conversion} · ct 5/18/2023 19:49 (changed) mimeDecode - "Convert a stream in base 64 with only a-z,A-Z,0-9,+,/ to a full byte stream of characters. Return a whole stream for the user to read." + "Convert the stream in base 64 with only a-z,A-Z,0-9,+,/ to a full byte stream of characters. Answer a whole stream for the user to read." | nibA nibB nibC nibD | [mimeStream atEnd] whileFalse: [ (nibA := self nextValue) ifNil: [^ dataStream]. (nibB := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibA bitShift: 2) + (nibB bitShift: -4)) asCharacter. nibB := nibB bitAnd: 16rF. (nibC := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibB bitShift: 4) + (nibC bitShift: -2)) asCharacter. nibC := nibC bitAnd: 16r3. (nibD := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibC bitShift: 6) + nibD) asCharacter. ]. ^ dataStream Base64MimeConverter>>mimeDecodeToByteArray {conversion} · ct 5/18/2023 19:50 (changed) mimeDecodeToByteArray - "Convert a stream in base 64 with only a-z,A-Z,0-9,+,/ to a full ByteArray of 0-255 values. Return a whole stream for the user to read." + "Convert the stream in base 64 with only a-z,A-Z,0-9,+,/ to a full ByteArray of 0-255 values. Answer a whole stream for the user to read." | nibA nibB nibC nibD | [mimeStream atEnd] whileFalse: [ (nibA := self nextValue) ifNil: [^ dataStream]. (nibB := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibA bitShift: 2) + (nibB bitShift: -4)). nibB := nibB bitAnd: 16rF. (nibC := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibB bitShift: 4) + (nibC bitShift: -2)). nibC := nibC bitAnd: 16r3. (nibD := self nextValue) ifNil: [^ dataStream]. dataStream nextPut: ((nibC bitShift: 6) + nibD). ]. ^ dataStream Base64MimeConverterTest (changed) - TestCase subclass: #Base64MimeConverterTest - instanceVariableNames: 'message' + nil subclass: #Base64MimeConverterTest + instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'CollectionsTests-Streams' Base64MimeConverterTest class instanceVariableNames: '' "This is the unit test for the class Base64MimeConverter. Unit tests are a good way to exercise the functionality of your system in a repeatable and automatic manner. They are therefore recommended if you plan to release anything. For more information, see: - http://www.c2.com/cgi/wiki?UnitTest - http://minnow.cc.gatech.edu/squeak/1547 - the sunit class category" Base64MimeConverterTest>>testBase64Encoded {tests} · ct 5/18/2023 20:09 (changed) testBase64Encoded + | encoded | - encoded := (Base64MimeConverter mimeEncode: message) contents. - self assert: encoded = 'Hi There!' base64Encoded. - + encoded := (self classToBeTested mimeEncode: message) contents. + self assert: string base64Encoded equals: encoded. Base64MimeConverterTest>>testMimeEncodeDecode {tests} · ct 5/18/2023 20:10 (changed) testMimeEncodeDecode | encoded | - encoded := Base64MimeConverter mimeEncode: message. - self assert: (encoded contents = 'SGkgVGhlcmUh'). - self assert: ((Base64MimeConverter mimeDecodeToChars: encoded) contents = message contents). - + encoded := self classToBeTested mimeEncode: message. + self assert: 'SGkgVGhlcmUh' equals: encoded contents. + self assert: message contents equals: (self classToBeTested mimeDecodeToChars: encoded) contents. + "Encoding should start from the beginning of the stream." message reset. message skip: 2. - encoded := Base64MimeConverter mimeEncode: message. - self assert: (encoded contents = 'SGkgVGhlcmUh'). + encoded := self classToBeTested mimeEncode: message. + self assert: 'SGkgVGhlcmUh' equals: encoded contents. "Encoding should start from the current position of the stream." message reset. message skip: 2. - encoded := Base64MimeConverter mimeEncodeContinue: message. - self assert: (encoded contents = 'IFRoZXJlIQ=='). + encoded := self classToBeTested mimeEncodeContinue: message. + self assert: 'IFRoZXJlIQ==' equals: encoded contents. Base64MimeConverterTest>>testMimeEncodeDecodeMultiLine {tests} · ct 5/18/2023 20:11 (changed) testMimeEncodeDecodeMultiLine | encoded | - encoded := (Base64MimeConverter mimeEncode: (String new: 100 withAll: $a) readStream) contents. + encoded := (self classToBeTested mimeEncode: (String new: 100 withAll: $a) readStream) contents. self assert: encoded = 'YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYQ=='. - - encoded := (Base64MimeConverter mimeEncode: (String new: 100 withAll: $a) readStream multiLine: false) contents. + + encoded := (self classToBeTested mimeEncode: (String new: 100 withAll: $a) readStream multiLine: false) contents. self assert: encoded = - 'YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYQ=='. + 'YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYQ=='. Base64MimeConverterTest>>testOnByteArray {tests} · ct 5/18/2023 20:11 (changed) testOnByteArray - self assert: ('Hi There!' base64Encoded = 'Hi There!' asByteArray base64Encoded) + + self assert: string base64Encoded = string asByteArray base64Encoded. ByteArray>>base32Encoded {converting} · ct 5/18/2023 17:46 + base32Encoded + "Encode the receiver as base32" + "'Hello World' asByteArray base32Encoded" + ^(Base32MimeConverter mimeEncode: self readStream) contents MimeConverter class>>mimeDecode: {convenience} · ct 5/18/2023 20:21 + mimeDecode: aCollectionOrStream + + ^ String streamContents: [:out | + self mimeDecode: aCollectionOrStream to: out] RFC4648MimeConverter + MimeConverter subclass: #RFC4648MimeConverter + instanceVariableNames: 'data multiLine' + classVariableNames: '' + poolDictionaries: '' + category: 'Collections-Streams' + + RFC4648MimeConverter class + instanceVariableNames: '' + + "I am the abstract superclass for power-of-two-base mime converters according to RFC4648. We translate a whole stream at once, taking a Stream as input and giving one as output, and answer a whole stream for the sender to use." RFC4648MimeConverter class>>decodeInteger: {convenience} · ct 5/18/2023 19:50 + decodeInteger: mimeString + "Decode the MIME string into an integer of any length" + + | bytes sum | + bytes := (self mimeDecodeToBytes: + (ReadStream on: mimeString)) contents. + sum := 0. + bytes reverseDo: [:by | sum := sum * 256 + by]. + ^ sum RFC4648MimeConverter class>>encodeInteger: {convenience} · ct 5/18/2023 19:51 + encodeInteger: anInteger + "Encode anInteger of any length and return the MIME string" + + | stream | + stream := WriteStream on: (ByteArray new: anInteger digitLength). + 1 to: anInteger digitLength do: [:ii | stream nextPut: (anInteger digitAt: ii)]. + ^ ((self mimeEncode: stream readStream) contents) copyUpTo: $= "remove padding" RFC4648MimeConverter class>>mimeDecodeToBytes: {convenience} · ct 5/18/2023 19:53 + mimeDecodeToBytes: aStream + "Return a ReadStream of the original ByteArray. aStream has only 33/65/... innocuous character values. aStream is not binary. (See class comment). 8/4/... bytes in aStream goes to 5/3/... bytes in output." + + | me | + aStream position: 0. + me := self new mimeStream: aStream. + me dataStream: (WriteStream on: (ByteArray new: aStream size * 3 // 4)). + me mimeDecodeToByteArray. + ^ me dataStream readStream RFC4648MimeConverter class>>mimeDecodeToChars: {convenience} · ct 5/18/2023 19:54 + mimeDecodeToChars: aStream + "Return a ReadWriteStream of the original String. aStream has only 33/65/... innocuous character values. It is not binary. (See class comment). 8/4/... bytes in aStream goes to 5/3/... bytes in output." + + | me | + aStream position: 0. + me := self new mimeStream: aStream. + me dataStream: (WriteStream on: (String new: aStream size * 3 // 4)). + me mimeDecode. + ^ me dataStream readStream RFC4648MimeConverter class>>mimeEncode: {convenience} · ct 5/18/2023 19:54 + mimeEncode: aStream + "Return a ReadWriteStream of characters. The data of aStream is encoded as 33/65/... innocuous characters. (See class comment). 5/3/... bytes in aStream goes to 8/4/... bytes in output." + self flag: #suspicious. "ct: All other classes answer a String, just this one answers a ReadStream. Unfortunately, expectations of senders are inconsistent as well ..." + ^self mimeEncode: aStream multiLine: true atStart: true RFC4648MimeConverter class>>mimeEncode:multiLine: {convenience} · ct 5/18/2023 19:55 + mimeEncode: aStream multiLine: aBool + "Return a ReadWriteStream of characters. The data of aStream is encoded as 33/65/... innocuous characters. (See class comment). 5/3/... bytes in aStream goes to 8/4/... bytes in output." + + ^self mimeEncode: aStream multiLine: aBool atStart: true RFC4648MimeConverter class>>mimeEncode:multiLine:atStart: {private - convenience} · ct 5/18/2023 19:55 + mimeEncode: aStream multiLine: aBool atStart: resetInput + "Return a ReadStream of characters. The data of aStream is encoded as 33/65/... innocuous characters. (See class comment). 5/3/... bytes in aStream goes to 8/4/... bytes in output." + + | me | + resetInput ifTrue:[aStream position: 0]. + me := self new dataStream: aStream. + me multiLine: aBool. + me mimeStream: (WriteStream on: (String new: aStream size + 20 * 4 // 3)). + me mimeEncode. + ^ me mimeStream readStream RFC4648MimeConverter class>>mimeEncodeContinue: {private - convenience} · ct 5/18/2023 19:55 + mimeEncodeContinue: aStream + "Return a ReadWriteStream of characters. The data of aStream is encoded as 33/65/... innocuous characters. (See class comment). 5/3/... bytes in aStream goes to 8/4/... bytes in output." + ^self mimeEncode: aStream multiLine: true atStart: false RFC4648MimeConverter>>fromCharTable {private} · ct 5/18/2023 19:46 + fromCharTable + + ^ self subclassResponsibility RFC4648MimeConverter>>mimeDecode {conversion} · ct 5/18/2023 19:48 + mimeDecode + "Convert the stream in the respective base to a full byte stream of characters. Answer a whole stream for the user to read." + + ^ self subclassResponsibility RFC4648MimeConverter>>mimeDecodeToByteArray {conversion} · ct 5/18/2023 19:49 + mimeDecodeToByteArray + "Convert the stream in the respective base to a full ByteArray of 0-255 values. Answer a whole stream for the user to read." + + ^ self subclassResponsibility RFC4648MimeConverter>>mimeEncode {conversion} · ct 5/18/2023 19:45 + mimeEncode + "Convert from data to n bit characters." + + ^ self subclassResponsibility RFC4648MimeConverter>>multiLine {accessing} · ar 4/15/2008 17:58 + multiLine + "Determines whether we allow multi-line encodings (the default) or force everything into a single line (for use with URLs etc. where the continuation marker and the line break cause problems)" + ^multiLine RFC4648MimeConverter>>multiLine: {accessing} · ar 4/15/2008 17:58 + multiLine: aBool + "Determines whether we allow multi-line encodings (the default) or force everything into a single line (for use with URLs etc. where the continuation marker and the line break cause problems)" + multiLine := aBool RFC4648MimeConverter>>nextValue {conversion} · ct 5/18/2023 19:46 + nextValue + "The next n bits of data char from the mimeStream, or nil. Skip all other chars" + | raw num | + [raw := mimeStream next. + raw ifNil: [^ nil]. "end of stream" + raw == $= ifTrue: [^ nil]. + num := self fromCharTable at: raw asciiValue + 1. + num ifNotNil: [^ num]. + "else ignore space, return, tab, ..." + ] repeat RFC4648MimeConverterTest + ClassTestCase subclass: #RFC4648MimeConverterTest + instanceVariableNames: 'string message' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Streams' + + RFC4648MimeConverterTest class + instanceVariableNames: '' + + "" RFC4648MimeConverterTest class>>isAbstract {testing} · ct 5/18/2023 20:08 + isAbstract + + ^ self name = #RFC4648MimeConverterTest RFC4648MimeConverterTest>>setUp {running} · ct 5/18/2023 20:04 + setUp + string := 'Hi There!'. + message := string readStream. String>>base32Decoded {converting} · ct 5/18/2023 19:38 + base32Decoded + "Decode the receiver from base 32" + "'JBSWY3DPEBLW64TMMQ======' base32Decoded" + ^ Base32MimeConverter mimeDecode: self as: self class String>>base32Encoded {converting} · ct 5/18/2023 19:15 + base32Encoded + "Encode the receiver as base32" + "'Hello World' base32Encoded" + + ^(Base32MimeConverter + mimeEncode: (ReadStream on: self) + multiLine: false) contents StringTest>>testBase32 {tests - converting} · ct 5/18/2023 20:15 + testBase32 + + self + assert: 'JBSWY3DPEBLW64TMMQ======' base32Decoded = 'Hello World'; + assert: 'Hello World' base32Encoded = 'JBSWY3DPEBLW64TMMQ======'; + assert: (String new: 100 withAll: $x) base32Encoded = 'PB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DYPB4HQ6DY'. --- Sent from Squeak Inbox Talk ["base32.4.cs"]

3 3

Review Request: mcAddAnythingToChangeSet.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

=============== Summary =============== Change Set: mcAddAnythingToChangeSet Date: 18 May 2023 Author: Christoph Thiede Makes 'add (all) to current change set' in Monticello code tools capable of class and script definitions. =============== Diff =============== ChangeSet>>noteRemovalOf: {class changes} · ct 5/18/2023 22:25 (changed) noteRemovalOf: class "The class is about to be removed from the system. Adjust the receiver to reflect that fact." - class wantsChangeSetLogging ifFalse: [^ self]. + | c ccname | + class isString + ifTrue: [c := self environment classNamed: class. ccname := class , ' class'] + ifFalse: [c := class. ccname := class class name]. + (c notNil and: [c wantsChangeSetLogging not]) ifTrue: [^ self]. (self changeRecorderFor: class) - noteChangeType: #remove fromClass: class. - changeRecords removeKey: class class name ifAbsent: []. + noteChangeType: #remove fromClass: c. + changeRecords removeKey: ccname ifAbsent: []. MCAddition>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet MCClassDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 22:21 + addRemovalToChangeSet: aChangeSet + + aChangeSet noteRemovalOf: self className. MCClassDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:45 + addToChangeSet: aChangeSet + + aChangeSet addClass: self actualClass. MCDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:34 + addRemovalToChangeSet: aChangeSet + + ^ self subclassResponsibility MCDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility MCMethodDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:44 + addRemovalToChangeSet: aChangeSet + + aChangeSet removeSelector: self selector class: self actualClass priorMethod: nil lastMethodInfo: nil. MCMethodDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:42 + addToChangeSet: aChangeSet + + aChangeSet adoptSelector: self selector forClass: self actualClass. MCModification>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet MCOperationsBrowser>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:06 (changed) adoptMessageInCurrentChangeset - selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - - items select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (selection ifNotNil: [{selection}] ifNil: [items]) + do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations. MCOperationsBrowser>>methodListMenu: {menus} · ct 5/18/2023 22:15 (changed) methodListMenu: aMenu selection ifNil: [items ifNotEmpty: [ aMenu addList: #( ('add all to current change set' adoptMessageInCurrentChangeset))]] ifNotNil: [aMenu addList: #( ('install' installSelection) ('revert (x)' revertSelection) ('browse origin' browseSelectionOrigin) -)]. self unchangedMethods ifNotEmpty: [aMenu addList: #( ('revert unchanged methods...' revertUnchangedMethods) ('filter out unchanged methods...' filterOutUnchangedMethods) -)]. super methodListMenu: aMenu. + self selectedMessageName ifNil: + [aMenu addList: #( + ('add to current change set' adoptMessageInCurrentChangeset))]. ^ aMenu MCPatchOperation>>addToChangeSet: {applying} · ct 5/18/2023 21:32 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility MCPatchOperation>>applyTo: {applying} · ct 5/18/2023 21:30 + applyTo: anObject + + ^ self subclassResponsibility MCPostscriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:05 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('\"{1}"\{2}.' withCRs format: {self packageName. self script}). MCPreambleDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:07 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePreambleExists; + preamble: aChangeSet preamble , ('\\"{1}"\{2}.' withCRs format: {self packageName. self script}). MCRemoval>>addToChangeSet: {applying} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self definition addRemovalToChangeSet: aChangeSet MCRemoval>>applyTo: {applying} · ab 5/24/2003 16:11 (changed and recategorized) applyTo: anObject anObject removeDefinition: definition MCSaveVersionDialog>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:00 (changed) adoptMessageInCurrentChangeset selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - (items copyWithoutAll: ignore) select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (items copyWithoutAll: ignore) do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations. MCScriptDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:58 + addRemovalToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: '' MCScriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:58 + addToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: self script MCScriptDefinition>>addToChangeSet:script: {installing} · ct 5/18/2023 22:04 + addToChangeSet: aChangeSet script: aString + + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('<n><n>(PackageInfo named: <1p>) <2s>: <3p>.' expandMacrosWithArguments: {self packageName. self scriptSelector. aString}). --- Sent from Squeak Inbox Talk ["mcAddAnythingToChangeSet.1.cs"]

2 3

Review Request: Color-fromString-css-function.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

What do you think about that? Alternatively, I could parse these expressions from HtmlReadWriter, but I imagined they could be useful for other senders of Color fromString: as well. :-) Best, Christoph =============== Summary =============== Change Set: Color-fromString-css-function Date: 20 May 2023 Author: Christoph Thiede Adds support for basic CSS color functions to Color fromString:. This may be especially helpful for parsing HTML. While there are other color functions in CSS such as hsv(), lch(), oklab(), et al. for color models that we don't support, and CSS colors may be complex expressions, simple rgb() and argb() expressions are especially common. =============== Diff =============== Color class>>fromRGBAString: {other} · ct 5/19/2023 23:49 + fromRGBAString: rgba + "Do not call this method directly, call Color>>#fromString: instead as it is more generic" + + | alpha | + alpha := (Float readFrom:(rgba at: 4)) min: 1 max: 0. + ^ (self fromRGBString: rgba) + alpha: alpha Color class>>fromString: {instance creation} · ct 5/20/2023 18:40 (changed) fromString: aString "for HTML color spec: #FFCCAA or white/black/red/other name, or an r,g,b triplet string" "Color fromString: '#FFCCAA'. Color fromString: 'white'. Color fromString: 'orange' Color fromString: '126,42,33' " | aColorHex rgb| aString isEmptyOrNil ifTrue: [ ^self white ]. aString first = $# ifTrue: [ aColorHex := aString allButFirst ] ifFalse: [ aColorHex := aString ]. "is the string a 6 digit hex number?" ((aColorHex size = 6 or: [aColorHex size = 8]) and: [ aColorHex allSatisfy: [ :each | '0123456789ABCDEFabcdef' includes: each ] ]) ifTrue: [^ self fromHTMLString: aColorHex ]. + "is the string a CSS function?" + aString last = $) ifTrue: [ + "While there are other color functions in CSS such as hsv(), lch(), oklab(), et al. for color models that we don't support, and CSS colors may be complex expressions, simple rgb() and argb() expressions are especially common." + (aString beginsWith: 'rgb(') ifTrue: [ + rgb := ((aString allButLast allButFirst: 4) findTokens: $,) collect: #withBlanksTrimmed. + ^ self fromRGBString: rgb]. + (aString beginsWith: 'rgba(') ifTrue: [ + | rgba | + rgba := ((aString allButLast allButFirst: 5) findTokens: $,) collect: #withBlanksTrimmed. + ^ self fromRGBAString: rgba]. + self flag: #forLater. "support hsl and hsla" + ^ self white]. + "is the string in the form a,b,c ?" rgb := aColorHex findTokens: $, . rgb size = 3 ifTrue: [^ self fromRGBString: rgb]. "try to match aColorHex with known named colors, case insensitive" ^self perform: (ColorNames detect: [:colorSymbol | aColorHex sameAs: colorSymbol] ifNone: [ #white ]) ColorTest>>testFromString {tests} · ct 5/19/2023 23:48 (changed) testFromString self assert: ((Color fromString: '#FF8800') asHTMLColor sameAs: '#ff8800'); assert: ((Color fromString: 'FF8800') asHTMLColor sameAs: '#ff8800'); assert: ((Color fromString: '126,42,33') asHTMLColor sameAs: '#7E2A21'); assert: ((Color fromString: '00000000') asHTMLColor sameAs: '#00000000'); "html with alpha channel" assert: ((Color fromString: '#8C500BAE') asHTMLColor sameAs: '#8C500BAE'); assert: ((Color fromString: 'white') asHTMLColor sameAs: '#ffffff'); assert: ((Color fromString: 'black') asHTMLColor sameAs: '#000000'); assert: ((Color fromString: nil) asHTMLColor sameAs: '#ffffff'); assert: ((Color fromString: 'inexistent color') asHTMLColor sameAs: '#ffffff'); "should return white" assert: ((Color fromString: 'XXXXXX') asHTMLColor sameAs: '#ffffff') description: 'Color string should be alphanumeric'; assert: ((Color fromString: '000000000') asHTMLColor sameAs: '#ffffff') description: 'number string too long'. self assert: (Color fromString: 'DARKGRAY') = Color darkGray description: 'Color can be specified with a case insensitive color name'; - assert: (Color fromString: '#blue') = Color blue description: 'Color can be specified with a leading literal sharp'. + assert: (Color fromString: '#blue') = Color blue description: 'Color can be specified with a leading literal sharp'. + + self + assert: (Color fromString: 'rgb(12,34,56)') = (Color r: 12 g: 34 b: 56 range: 255); + assert: (Color fromString: 'rgba(12,34,56,0.78)') = ((Color r: 12 g: 34 b: 56 range: 255) alpha: 0.78). ["Color-fromString-css-function.1.cs"] --- Sent from Squeak Inbox Talk ["Color-fromString-css-function.1.cs"]

2 2

Deprecating PluggableFileList
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

Hi all, to my knowledge, PluggableFileList should be deprecated and removed (see PluggableFileList>>#open). At the moment, it is only referenced from MVCProject>>#findAFolderForProject:label:. If I try to run that in MVC, I get an #errorEmptyCollection from MVCToolBuilder>>setLayout:in:. Could we just migrate MVCProject>>#findAFolderForProject:label: to use DirectoryChooserDialog? Because MVC does not support tree widgets, users could only enter a path string there, but the current way is broken anyway, and to be honest I don't know whether anyone wants to save an MVC project ... Best, Christoph --- Sent from Squeak Inbox Talk

2 2

#timeToRun | Mysterious 500 :-)
by Marcel Taeumel 01 Jun '23

01 Jun '23

Hi Eliot, hi Nicolas, hi all -- What's the meaning of that magic number 500 when calculating #timeToRun of a block? In 2016, we changed from using primitive 135 to 240 to get some UTC-based microsecond value with millisecond precision. In Time class >> #millisecondsToRun:, we see that a magic 500 offset was added (by eem). And it is added, not removed. So, it is not the offset to call the primitive itself it seems... More interestingly, we can see that 500 being added in Time class >> #microsecondsToRun: to a nanosecond value! So, what does it mean: microsOrNanos + 500 // 1000 Best, Marcel

2 6

The Trunk: Tools-mt.1207.mcz
by commits＠source.squeak.org 31 May '23

31 May '23

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1207.mcz ==================== Summary ==================== Name: Tools-mt.1207 Author: mt Time: 31 May 2023, 3:42:47.717502 pm UUID: bf03c261-761b-0144-aca8-63a3a4b98371 Ancestors: Tools-mt.1206 In TreeBrowser, fixes some bugs regarding multi-window support. Thanks to Eliot (eem) for reporting those! =============== Diff against Tools-mt.1206 =============== Item was changed: ----- Method: Browser>>restoreToCategory:className:protocol:selector:mode:meta: (in category 'multi-window support') ----- restoreToCategory: category className: className protocol: protocol selector: selector mode: editMode meta: metaBool + selectedSystemCategory := nil. "forces UI updates in selectSystemCategory:" - selectedSystemCategory := nil. "forces recomputation in selectSystemCategory:" self selectSystemCategory: category. self selectClassNamed: className. self metaClassIndicated: metaBool. self selectMessageCategoryNamed: protocol. self selectMessageNamed: selector. editSelection := editMode. self contentsChanged; decorateButtons! Item was changed: ----- Method: TreeBrowser>>buildAndOpenCategoryBrowserLabel: (in category 'toolbuilder') ----- buildAndOpenCategoryBrowserLabel: aLabel "Overwrite to replay certain interactive features that only work if the browser is already open." super buildAndOpenCategoryBrowserLabel: aLabel. self expandClassTree. self changed: #classChild. + + self expandMessageCategoryTree. + self changed: #messageCategoryChild. ! Item was changed: ----- Method: TreeBrowser>>buildAndOpenFullBrowser (in category 'toolbuilder') ----- buildAndOpenFullBrowser "Overwrite to replay certain interactive features that only work if the browser is already open." super buildAndOpenFullBrowser. self expandClassTree. self changed: #classChild. + self expandMessageCategoryTree. + self changed: #messageCategoryChild.! - ! Item was added: + ----- Method: TreeBrowser>>classList (in category 'class list') ----- + classList + "Overwritten to not compute hierarchical list by accident. Receiver looks up hierarchy differently. See 'class tree' category." + + ^ self defaultClassList! Item was added: + ----- Method: TreeBrowser>>defaultClassList (in category 'class list') ----- + defaultClassList + "Overwritten for multi-window support together with hierarchyMode. See #findClass." + + ^ self isHierarchy + ifTrue: [lastClassList collect: [:ea | ea name]] + ifFalse: [super defaultClassList]! Item was added: + ----- Method: TreeBrowser>>findClass (in category 'system category functions') ----- + findClass + "Overwritten for multi-window support. Switching between hierarchyMode via #findClass needs a refresh of the visible system categories. See #initHierarchyFor:." + + super findClass. + + self multiWindowState ifNotNil: [ | foundClass | + foundClass := self selectedClass. + self updateSystemCategoryTree. + self isHierarchy + ifTrue: [self selectSystemCategory: self class hierarchyCategory] + ifFalse: [self selectCategoryForClass: foundClass]. + self selectClass: foundClass].! Item was changed: ----- Method: TreeBrowser>>restoreToCategory:className:protocol:selector:mode:meta: (in category 'extras - multi-window support') ----- restoreToCategory: category className: className protocol: protocol selector: selector mode: editMode meta: metaBool lastSystemCategoryList := #(). lastClassList := #(). lastMessageCategoryList := #(). + self isHierarchy + ifTrue: [self initHierarchyFor: classForHierarchy] + ifFalse: [self updateTreesIfNeeded]. - self updateTreesIfNeeded. super restoreToCategory: category className: className protocol: protocol selector: selector mode: editMode meta: metaBool.! Item was changed: ----- Method: TreeBrowser>>updateMessageCategoryTree: (in category 'updating') ----- updateMessageCategoryTree: newList lastMessageCategoryList := newList. self changed: #messageCategoryRoots. + self expandMessageCategoryTree. + + self changed: #messageCategoryChild.! - self expandMessageCategoryTree.!

1 0

The Trunk: Kernel-mt.1516.mcz
by commits＠source.squeak.org 31 May '23

31 May '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1516.mcz ==================== Summary ==================== Name: Kernel-mt.1516 Author: mt Time: 31 May 2023, 9:39:49.731172 am UUID: 3dfb942b-0523-4240-a424-49485b35ff66 Ancestors: Kernel-mt.1515 For #tinyBenchmarks, adds Pi4 numbers. =============== Diff against Kernel-mt.1515 =============== Item was changed: ----- Method: Integer>>tinyBenchmarks (in category 'benchmarks') ----- tinyBenchmarks "Report the results of running the two tiny Squeak benchmarks. ar 9/10/1999: Adjusted to run at least 1 sec to get more stable results" "0 tinyBenchmarks" | t1 t2 r n1 n2 pref | pref := Time useHighResClockForTiming. Time useHighResClockForTiming: false. n1 := 1. [t1 := Time millisecondsToRun: [n1 benchmark]. t1 < 1000] whileTrue:[n1 := n1 * 2]. "Note: #benchmark's runtime is about O(n)" n2 := 28. [t2 := Time millisecondsToRun: [r := n2 benchFib]. t2 < 1000] whileTrue:[n2 := n2 + 1]. "Note: #benchFib's runtime is about O(k^n), where k is the golden number = (1 + 5 sqrt) / 2 = 1.618...." Time useHighResClockForTiming: pref. ^ ((n1 * 500000 * 1000) // t1 significantDigits: 2) asStringWithCommas, ' bytecodes/sec; ', ((r * 1000) // t2 significantDigits: 2) asStringWithCommas, ' sends/sec' " Known benchmark results: On a 292 MHz G3 Mac: 23,000,000 bytecodes/sec; 980,000 sends/sec On a 400 MHz PII/Win98: 18,000,000 bytecodes/sec; 1,100,000 sends/sec On a 2800 MHz i7: 1,200,000,000 bytecodes/sec; 25,000,000 sends/sec On a 2800 MHz i7 (CogVM): 1,700,000,000 bytecodes/sec; 260,000,000 sends/sec On a RaspberryPi 3B+ ARMv6 (CogVM, April 2018): 330,000,000 bytecodes/sec; 19,000,000 sends/sec + On a RaspberryPi 4 ARMv8 (CogVM, May 2023): 750,000,000 bytecodes/sec; 53,000,000 sends/sec On an Apple M1 (macMini 2020, CogVM 202112201228): 4,400,000,000 bytecodes/sec; 330,000,000 sends/sec On an Apple M1 x64/Rosetta (macMini 2020, CogVM 202112201228): 3,500,000,000 bytecodes/sec; 270,000,000 sends/sec On a Core i7-1185G7 (Surface Pro 8, CogVM 202206021410): 3,800,000,000 bytecodes/sec; 290,000,000 sends/sec "!

1 0

← Newer
1
2
3
4
5
6
7
...
11
Older →