Squeak-dev June 2023

squeak-dev@lists.squeakfoundation.org

23 participants
127 discussions

The Trunk: Graphics-ct.541.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-ct.541.mcz ==================== Summary ==================== Name: Graphics-ct.541 Author: ct Time: 1 June 2023, 9:07:27.980127 pm UUID: ee2eb548-c686-9a4f-b85c-3dd027cf9d8f Ancestors: Graphics-nice.540 Merges Color-fromString-css-function-1.cs: Adds support for basic CSS color functions to Color fromString:. This may be especially helpful for parsing HTML. While there are other color functions in CSS such as hsv(), lch(), oklab(), et al. for color models that we don't support, and CSS colors may be complex expressions, simple rgb() and argb() expressions are especially common. Revision: Moved private constructors into private category. Fixed plenk. =============== Diff against Graphics-nice.540 =============== Item was changed: + ----- Method: Color class>>fromHTMLString: (in category 'instance creation - private') ----- - ----- Method: Color class>>fromHTMLString: (in category 'other') ----- fromHTMLString: aColorHex "Do not call this method directly, call Color>>#fromString: instead as it is more generic" | green red blue resultColor | red := (Integer readFrom: (aColorHex first: 2) base: 16). green := (Integer readFrom: (aColorHex copyFrom: 3 to: 4) base: 16). blue := (Integer readFrom: (aColorHex copyFrom: 5 to: 6) base: 16). resultColor := self r: red g: green b: blue range: 255. ^ (aColorHex size = 8) ifTrue: [resultColor alpha: ((Integer readFrom: (aColorHex last: 2) base: 16) / 255)] ifFalse: [resultColor]! Item was added: + ----- Method: Color class>>fromRGBAString: (in category 'instance creation - private') ----- + fromRGBAString: rgba + "Do not call this method directly, call Color>>#fromString: instead as it is more generic" + + | alpha | + alpha := (Float readFrom: (rgba at: 4)) min: 1 max: 0. + ^ (self fromRGBString: rgba) + alpha: alpha! Item was changed: + ----- Method: Color class>>fromRGBString: (in category 'instance creation - private') ----- - ----- Method: Color class>>fromRGBString: (in category 'other') ----- fromRGBString: rgb "Do not call this method directly, call Color>>#fromString: instead as it is more generic" | green red blue | red := (Integer readFrom:(rgb at: 1)) min: 255 max: 0. green := (Integer readFrom:(rgb at: 2)) min: 255 max: 0. blue := (Integer readFrom:(rgb at: 3)) min: 255 max: 0. ^self r: red g: green b: blue range: 255! Item was changed: ----- Method: Color class>>fromString: (in category 'instance creation') ----- fromString: aString "for HTML color spec: #FFCCAA or white/black/red/other name, or an r,g,b triplet string" "Color fromString: '#FFCCAA'. Color fromString: 'white'. Color fromString: 'orange' Color fromString: '126,42,33' " | aColorHex rgb| aString isEmptyOrNil ifTrue: [ ^self white ]. aString first = $# ifTrue: [ aColorHex := aString allButFirst ] ifFalse: [ aColorHex := aString ]. "is the string a 6 digit hex number?" ((aColorHex size = 6 or: [aColorHex size = 8]) and: [ aColorHex allSatisfy: [ :each | '0123456789ABCDEFabcdef' includes: each ] ]) ifTrue: [^ self fromHTMLString: aColorHex ]. + "is the string a CSS function?" + aString last = $) ifTrue: [ + "While there are other color functions in CSS such as hsv(), lch(), oklab(), et al. for color models that we don't support, and CSS colors may be complex expressions, simple rgb() and argb() expressions are especially common." + (aString beginsWith: 'rgb(') ifTrue: [ + rgb := ((aString allButLast allButFirst: 4) findTokens: $,) collect: #withBlanksTrimmed. + ^ self fromRGBString: rgb]. + (aString beginsWith: 'rgba(') ifTrue: [ + | rgba | + rgba := ((aString allButLast allButFirst: 5) findTokens: $,) collect: #withBlanksTrimmed. + ^ self fromRGBAString: rgba]. + self flag: #forLater. "support hsl and hsla" + ^ self white]. + "is the string in the form a,b,c ?" rgb := aColorHex findTokens: $, . rgb size = 3 ifTrue: [^ self fromRGBString: rgb]. "try to match aColorHex with known named colors, case insensitive" ^self perform: (ColorNames detect: [:colorSymbol | aColorHex sameAs: colorSymbol] ifNone: [ #white ])! Item was changed: + ----- Method: Color class>>shutDown (in category 'class initialization') ----- - ----- Method: Color class>>shutDown (in category 'other') ----- shutDown "Color shutDown" ColorChart := nil. "Palette of colors for the user to pick from" CachedColormaps := nil. "Maps to translate between color depths" MaskingMap := nil. "Maps all colors except transparent to black for creating a mask" !

1 0

The Trunk: GraphicsTests-ct.63.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-ct.63.mcz ==================== Summary ==================== Name: GraphicsTests-ct.63 Author: ct Time: 1 June 2023, 9:07:23.607127 pm UUID: 2e7945d7-a0ba-f04a-8f49-1c19ed81fd4c Ancestors: GraphicsTests-nice.62 Complements Graphics-ct.541 (merges Color-fromString-css-function-1.cs). =============== Diff against GraphicsTests-nice.62 =============== Item was changed: ----- Method: ColorTest>>testFromString (in category 'tests') ----- testFromString self assert: ((Color fromString: '#FF8800') asHTMLColor sameAs: '#ff8800'); assert: ((Color fromString: 'FF8800') asHTMLColor sameAs: '#ff8800'); assert: ((Color fromString: '126,42,33') asHTMLColor sameAs: '#7E2A21'); assert: ((Color fromString: '00000000') asHTMLColor sameAs: '#00000000'); "html with alpha channel" assert: ((Color fromString: '#8C500BAE') asHTMLColor sameAs: '#8C500BAE'); assert: ((Color fromString: 'white') asHTMLColor sameAs: '#ffffff'); assert: ((Color fromString: 'black') asHTMLColor sameAs: '#000000'); assert: ((Color fromString: nil) asHTMLColor sameAs: '#ffffff'); assert: ((Color fromString: 'inexistent color') asHTMLColor sameAs: '#ffffff'); "should return white" assert: ((Color fromString: 'XXXXXX') asHTMLColor sameAs: '#ffffff') description: 'Color string should be alphanumeric'; assert: ((Color fromString: '000000000') asHTMLColor sameAs: '#ffffff') description: 'number string too long'. self assert: (Color fromString: 'DARKGRAY') = Color darkGray description: 'Color can be specified with a case insensitive color name'; + assert: (Color fromString: '#blue') = Color blue description: 'Color can be specified with a leading literal sharp'. + + self + assert: (Color fromString: 'rgb(12,34,56)') = (Color r: 12 g: 34 b: 56 range: 255); + assert: (Color fromString: 'rgba(12,34,56,0.78)') = ((Color r: 12 g: 34 b: 56 range: 255) alpha: 0.78).! - assert: (Color fromString: '#blue') = Color blue description: 'Color can be specified with a leading literal sharp'.!

1 0

The Inbox: Tools-ct.1212.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1212.mcz ==================== Summary ==================== Name: Tools-ct.1212 Author: ct Time: 1 June 2023, 8:36:02.460263 pm UUID: 6565c5ce-dfe0-c847-bc8d-3a30e720ab6c Ancestors: Tools-ct.1210 Fixes an issue with updating the UI theme after closing a debugger. The issue is sporadic and leaks the GC behavior. =============== Diff against Tools-ct.1210 =============== Item was changed: ----- Method: Debugger>>aboutToStyle: (in category 'code pane') ----- aboutToStyle: aStyler "This is a notification that aStyler is about to re-style its text. Set the classOrMetaClass in aStyler, so that identifiers will be resolved correctly. Answer true to allow styling to proceed, or false to veto the styling" + contextStack ifNil: [ + "already released and then updated via global UserInterfaceTheme update." + ^ false]. self isModeStyleable ifFalse: [^false]. aStyler classOrMetaClass: self selectedClassOrMetaClass; sourceMap: self debuggerMap. ^true!

2 1

The Trunk: XML-Explorer-eem.3.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Eliot Miranda uploaded a new version of XML-Explorer to project The Trunk: http://source.squeak.org/trunk/XML-Explorer-eem.3.mcz ==================== Summary ==================== Name: XML-Explorer-eem.3 Author: eem Time: 1 June 2023, 10:51:10.968993 am UUID: 3f0dea52-960d-4518-a674-e3c6b7841fac Ancestors: XML-Explorer-ct.2 Use LimitedWriteStream to control how much data is printed for each node in the explorer label. Arbitrarily set at 1000. Gives a huge improvement in responsiveness for very large XML documents (tested on an 18Mb XML document). =============== Diff against XML-Explorer-ct.2 =============== Item was changed: ----- Method: XMLElement>>asExplorerString (in category '*XML-Explorer') ----- asExplorerString + | sizeLimit stream | + sizeLimit := 1000. + stream := LimitedWriteStream on: (String new: 100). + stream + setLimit: sizeLimit + limitBlock: [stream setLimit: stream position + 4 limitBlock: nil. + stream nextPutAll: ' ...'. + ^ stream contents]. + self elementsAndContentsDo: + [:node | + node isText + ifTrue: + [stream nextPutAll: node asExplorerString] + ifFalse: + [node printXMLOn: (XMLWriter on: stream)]]. + ^stream contents! - - ^ String streamContents: [:stream | - self elementsAndContentsDo: [:node | - node isText - ifTrue: - [stream nextPutAll: node asExplorerString] - ifFalse: - [ | writer | - writer := XMLWriter on: stream. - node printXMLOn: writer]]]! Item was changed: ----- Method: XMLStringNode>>asExplorerString (in category '*XML-Explorer') ----- asExplorerString + ^ self string size > 1000 + ifTrue: [(string copyFrom: 1 to: 1000), ' ...'] + ifFalse: [self string]! - ^ self string!

1 0

The Trunk: Tools-ct.1210.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1210.mcz ==================== Summary ==================== Name: Tools-ct.1210 Author: ct Time: 1 June 2023, 7:20:32.797571 pm UUID: 9ecd5608-fe57-1743-af79-ff1f8a29efab Ancestors: Tools-ct.1209 Replaces hardcoded class names with self. =============== Diff against Tools-ct.1209 =============== Item was changed: ----- Method: PluggableFileList class>>checkExistingFileValidateBlock (in category 'validateBlocks') ----- checkExistingFileValidateBlock ^[:theDirectory :theFileName :theNewFiles | (theNewFiles includes: theFileName) or: + [(self okToOverwrite: theFileName)]].! - [(PluggableFileList okToOverwrite: theFileName)]].! Item was changed: ----- Method: PluggableFileList class>>existingFileValidateBlock (in category 'validateBlocks') ----- existingFileValidateBlock ^[:theDirectory :theFileName :theNewFiles | (theNewFiles includes: theFileName) or: + [(self okToOverwrite: theFileName)]].! - [(PluggableFileList okToOverwrite: theFileName)]].! Item was changed: ----- Method: PluggableFileList class>>getFilePathNameDialog (in category 'instance creation') ----- getFilePathNameDialog ^(self new) + validateBlock: self alwaysValidateBlock; - validateBlock: PluggableFileList alwaysValidateBlock; yourself! Item was changed: ----- Method: PluggableFileList class>>getFilePathNameDialogWithExistenceCheck (in category 'instance creation') ----- getFilePathNameDialogWithExistenceCheck ^(self new) prompt: 'Select New File:'; + validateBlock: self checkExistingFileValidateBlock; - validateBlock: PluggableFileList checkExistingFileValidateBlock; yourself! Item was changed: ----- Method: PluggableFileList class>>getFolderDialog (in category 'instance creation') ----- getFolderDialog ^(self new) prompt: 'Select a Folder'; + fileFilterBlock: self allFoldersFileFilter; + canAcceptBlock: self alwaysAcceptBlock; + resultBlock: self directoryResultBlock; + validateBlock: self alwaysValidateBlock; - fileFilterBlock: PluggableFileList allFoldersFileFilter; - canAcceptBlock: PluggableFileList alwaysAcceptBlock; - resultBlock: PluggableFileList directoryResultBlock; - validateBlock: PluggableFileList alwaysValidateBlock; yourself! Item was changed: ----- Method: PluggableFileList>>initialize (in category 'initialize-release') ----- initialize super initialize. prompt := 'Select File'. directory := FileDirectory default. newFiles := OrderedCollection new. + fileFilterBlock := self class allFilesAndFoldersFileFilter. + canAcceptBlock := self class fileNameSelectedAcceptBlock. + resultBlock := self class pathNameResultBlock. + validateBlock := self class checkExistingFileValidateBlock. - fileFilterBlock := PluggableFileList allFilesAndFoldersFileFilter. - canAcceptBlock := PluggableFileList fileNameSelectedAcceptBlock. - resultBlock := PluggableFileList pathNameResultBlock. - validateBlock := PluggableFileList checkExistingFileValidateBlock. !

1 0

The Trunk: ST80-ct.294.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-ct.294.mcz ==================== Summary ==================== Name: ST80-ct.294 Author: ct Time: 1 June 2023, 7:17:43.354571 pm UUID: 6a1255f6-9b94-6344-b2fc-ab9f69be7c5f Ancestors: ST80-mt.293 Adds support for <cmd>D to "debug it" in MVC. The context menu already suggested the existence of this shortcut, which we also have in Morphic. =============== Diff against ST80-mt.293 =============== Item was changed: ----- Method: ParagraphEditor class>>initializeShiftCmdKeyShortcuts (in category 'keyboard shortcut tables') ----- initializeShiftCmdKeyShortcuts "Initialize the shift-command-key (or control-key) shortcut table." "NOTE: if you don't know what your keyboard generates, use Sensor kbdTest" "wod 11/3/1998: Fix setting of cmdMap for shifted keys to actually use the capitalized versions of the letters. TPR 2/18/99: add the plain ascii values back in for those VMs that don't return the shifted values." | cmdMap | "shift-command and control shortcuts" cmdMap := Array new: 256 withAll: #noop:. "use temp in case of a crash" cmdMap at: ( 1 + 1) put: #cursorHome:. "home key" cmdMap at: ( 4 + 1) put: #cursorEnd:. "end key" cmdMap at: ( 8 + 1) put: #forwardDelete:. "ctrl-H or delete key" cmdMap at: (11 + 1) put: #cursorPageUp:. "page up key" cmdMap at: (12 + 1) put: #cursorPageDown:. "page down key" cmdMap at: (13 + 1) put: #crWithIndent:. "ctrl-Return" cmdMap at: (27 + 1) put: #offerMenuFromEsc:. "escape key" cmdMap at: (28 + 1) put: #cursorLeft:. "left arrow key" cmdMap at: (29 + 1) put: #cursorRight:. "right arrow key" cmdMap at: (30 + 1) put: #cursorUp:. "up arrow key" cmdMap at: (31 + 1) put: #cursorDown:. "down arrow key" cmdMap at: (32 + 1) put: #selectWord:. "space bar key" cmdMap at: (45 + 1) put: #changeEmphasis:. "cmd-sh-minus" cmdMap at: (61 + 1) put: #changeEmphasis:. "cmd-sh-plus" cmdMap at: (127 + 1) put: #forwardDelete:. "del key" "triplet = {character. comment selector. novice appropiated}" #( ($a argAdvance: false) ($b browseItHere: false) ($c compareToClipboard: false) + ($d debugIt: false) ($e methodStringsContainingIt: false) ($f displayIfFalse: false) ($g fileItIn: false) ($h cursorTopHome: true) ($i exploreIt: false) ($j doAgainMany: true) ($k changeStyle: true) ($m selectCurrentTypeIn: true) ($n referencesToIt: false) ($p makeProjectLink: true) ($s search: true) ($t displayIfTrue: false) ($u changeLfToCr: false) ($v pasteInitials: false) ($w methodNamesContainingIt: false) ($x makeLowercase: true) ($y makeUppercase: true) ($z makeCapitalized: true) ) select:[:triplet | Preferences noviceMode not or:[triplet third]] thenDo:[:triplet | cmdMap at: (triplet first asciiValue + 1) put: triplet second. "plain keys" cmdMap at: (triplet first asciiValue - 32 + 1) put: triplet second. "shifted keys" cmdMap at: (triplet first asciiValue - 96 + 1) put: triplet second. "ctrl keys" ]. ShiftCmdActions := cmdMap!

1 0

The Trunk: Tools-ct.1209.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1209.mcz ==================== Summary ==================== Name: Tools-ct.1209 Author: ct Time: 1 June 2023, 6:28:28.483263 pm UUID: eeae5d94-3e79-334c-af43-277dfd9ae0ed Ancestors: Tools-mt.1208 Fixes "Project findAFolder..." in MVC by adding missing override (cf. #open). We still need to discuss how we want to move on with PluggableFileList. See: https://lists.squeakfoundation.org/archives/list/squeak-dev@lists.squeakfou… =============== Diff against Tools-mt.1208 =============== Item was added: + ----- Method: PluggableFileList>>openLabel: (in category 'initialize-release') ----- + openLabel: aString + self deprecated: 'PluggableFileList is being deprecated'. "This can go away soon" + + ^ Project uiManager openPluggableFileList: self label: aString in: self currentWorld!

1 0

Deprecating PluggableFileList
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Jun '23

01 Jun '23

Hi all, to my knowledge, PluggableFileList should be deprecated and removed (see PluggableFileList>>#open). At the moment, it is only referenced from MVCProject>>#findAFolderForProject:label:. If I try to run that in MVC, I get an #errorEmptyCollection from MVCToolBuilder>>setLayout:in:. Could we just migrate MVCProject>>#findAFolderForProject:label: to use DirectoryChooserDialog? Because MVC does not support tree widgets, users could only enter a path string there, but the current way is broken anyway, and to be honest I don't know whether anyone wants to save an MVC project ... Best, Christoph --- Sent from Squeak Inbox Talk

2 2

The Trunk: Network-pre.277.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Patrick Rein uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-pre.277.mcz ==================== Summary ==================== Name: Network-pre.277 Author: pre Time: 1 June 2023, 2:10:16.680896 pm UUID: f0681b24-25cb-8c4d-aded-38c32566757a Ancestors: Network-mt.276 Implements case-insensitive comparison of MIMETypes and case-insensitive access to parameters. =============== Diff against Network-mt.276 =============== Item was changed: Object subclass: #MIMEType instanceVariableNames: 'main sub parameters' classVariableNames: 'DefaultSuffixes StandardMIMEMappings' poolDictionaries: '' category: 'Network-MIME'! + + !MIMEType commentStamp: 'pre 6/1/2023 14:05' prior: 0! + A MIMEType instances represent a specific MIME type including parameters. + + It adheres to https://datatracker.ietf.org/doc/html/rfc2045. + + ------ + + Design decisions: + - the comparison currently normalizes the main and sub-type ad hoc to preserve the original case + - parameter names are normalized to simplify the lookup logic! Item was changed: ----- Method: MIMEType class>>fromMIMEString: (in category 'instance creation') ----- fromMIMEString: mimeString "Examples: MIMEType fromMIMEString: 'text/plain' MIMEType fromMIMEString: 'text/plain;charset=utf8' MIMEType fromMIMEString: 'Message/Partial; number=2; total=3; id=""oc=jpbe0M2Yt4s(a)thumper.bellcore.com""'" | idx main sub parameters | + parameters := OrderedDictionary new. idx := mimeString indexOf: $/. idx = 0 ifTrue: [self error: 'Illegal mime type string "' , mimeString , '".']. main := mimeString copyFrom: 1 to: idx-1. idx := mimeString indexOf: $; startingAt: idx+1. idx = 0 ifTrue: [ sub := mimeString copyFrom: main size + 2 to: mimeString size] ifFalse: [ | pos key val | sub := mimeString copyFrom: main size + 2 to: idx-1. - parameters := OrderedDictionary new. pos := idx. [pos < mimeString size] whileTrue: [ idx := idx + 1. "Skip $;" [(mimeString at: idx) isSeparator] whileTrue: [idx := idx+1]. pos := mimeString indexOf: $= startingAt: idx. key := mimeString copyFrom: idx to: pos-1. idx := pos+1. (mimeString at: idx) = $" ifFalse: ["token" pos := mimeString indexOf: $; startingAt: idx. pos = 0 ifTrue: [pos := mimeString size + 1]. val := mimeString copyFrom: idx to: pos-1. idx := pos] ifTrue: ["quoted-string" idx := idx+1. pos := mimeString indexOf: $" startingAt: idx. pos = 0 ifTrue: [self error: 'Illegal quoted-string in mime type string "' , mimeString , '".']. val := mimeString copyFrom: idx to: pos-1. idx := pos+1]. parameters at: key put: val]]. ^self main: main sub: sub parameters: parameters ! Item was changed: ----- Method: MIMEType class>>main:sub: (in category 'instance creation') ----- main: mainType sub: subType ^self new main: mainType; sub: subType! Item was changed: ----- Method: MIMEType class>>main:sub:parameters: (in category 'instance creation') ----- main: mainType sub: subType parameters: parameters + + ^(self main: mainType sub: subType) + parameters: parameters; + yourself! - ^self new - main: mainType; - sub: subType; - parameters: parameters! Item was changed: ----- Method: MIMEType>>= (in category 'comparing') ----- = anotherObject anotherObject class == self class ifFalse: [^false]. + ^self main asLowercase = anotherObject main asLowercase + and: [self sub asLowercase = anotherObject sub asLowercase]! - ^self main = anotherObject main - and: [self sub = anotherObject sub]! Item was changed: ----- Method: MIMEType>>hash (in category 'comparing') ----- hash + ^self main asLowercase hash bitXor: self sub asLowercase hash! - ^self main hash bitXor: self sub hash! Item was added: + ----- Method: MIMEType>>initialize (in category 'initialize-release') ----- + initialize + + super initialize. + self + main: ''; + sub: ''; + parameters: OrderedDictionary new.! Item was added: + ----- Method: MIMEType>>parameterAt: (in category 'accessing') ----- + parameterAt: parameterName + + ^ parameters at: parameterName asLowercase! Item was removed: - ----- Method: MIMEType>>parameters (in category 'accessing') ----- - parameters - ^ parameters! Item was changed: ----- Method: MIMEType>>parameters: (in category 'accessing') ----- parameters: params + "We normalize as the access to parameters is case insensitive. --pre" + parameters := Dictionary newFrom: (params keys collect: [:key | + key asLowercase -> (params at: key)]).! - parameters := params!

1 0

The Trunk: NetworkTests-pre.72.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Patrick Rein uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-pre.72.mcz ==================== Summary ==================== Name: NetworkTests-pre.72 Author: pre Time: 1 June 2023, 2:09:33.027896 pm UUID: dc4aface-b8e4-fc48-8c32-2d152687a376 Ancestors: NetworkTests-pre.71 Updates MIMEType tests with new parameterAt: message. =============== Diff against NetworkTests-pre.71 =============== Item was changed: ----- Method: MIMETypeTest>>testFromStringWithParameters (in category 'tests') ----- testFromStringWithParameters #( 'text/plain;charset=utf8' + 'text' 'plain' 'charset' 'utf8' - 'text' 'plain' 1 'charset' 'utf8' 'text/plain; charset=utf8' "extra whitespace" + 'text' 'plain' 'charset' 'utf8' - 'text' 'plain' 1 'charset' 'utf8' 'Message/Partial; number=2; total=3; id="oc=jpbe0M2Yt4s(a)thumper.bellcore.com"' + 'Message' 'Partial' 'id' 'oc=jpbe0M2Yt4s(a)thumper.bellcore.com' + ) groupsDo: [:raw :main :sub :key :value | - 'Message' 'Partial' 3 'id' 'oc=jpbe0M2Yt4s(a)thumper.bellcore.com' - ) groupsDo: [:raw :main :sub :numParams :key :value | | type | type := MIMEType fromMIMEString: raw. self assert: main equals: type main; assert: sub equals: type sub; + assert: value equals: (type parameterAt: key)].! - assert: numParams equals: type parameters size; - assert: value equals: (type parameters at: key)].! Item was changed: ----- Method: MIMETypeTest>>testMIMEParameterAccessIsCaseInsensitive (in category 'tests') ----- testMIMEParameterAccessIsCaseInsensitive #("mimeString parameter" 'text/plain;charset=utf8' 'charset' 'text/plain;charset=utf8' 'Charset' 'text/plain;Charset=utf8' 'charset' 'text/plain;Charset=utf8' 'Charset' 'text/plain;CHARSET=utf8' 'CHARSET') groupsOf: 2 atATimeDo: [:mimeString :parameterName | | type | type := MIMEType fromMIMEString: mimeString. + self assert: 'utf8' equals: (type parameterAt: parameterName).] - self assert: 'utf8' equals: (type parametersAt: parameterName).] !

1 0