Squeak-dev June 2023

squeak-dev@lists.squeakfoundation.org

23 participants
127 discussions

The Trunk: NetworkTests-pre.71.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Patrick Rein uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-pre.71.mcz ==================== Summary ==================== Name: NetworkTests-pre.71 Author: pre Time: 1 June 2023, 2:06:15.662896 pm UUID: 1679aa6d-5412-2a4c-8167-2fc6cfd0153c Ancestors: NetworkTests-mt.70 Tests checking whether MIMEType equality is checked in a case insensitive way. =============== Diff against NetworkTests-mt.70 =============== Item was added: + ----- Method: MIMETypeTest>>testMIMEMainAndSubCompareCaseInsensitive (in category 'tests') ----- + testMIMEMainAndSubCompareCaseInsensitive + + #("main-1 sub-1 main-2 sub-2" + 'text' 'plain' 'Text' 'plain' + 'text' 'plain' 'text' 'Plain' + 'text' 'plain' 'TEXT' 'PLAIN') + groupsOf: 4 atATimeDo: [:main1 :sub1 :main2 :sub2 | |type1 type2| + type1 := MIMEType main: main1 sub: sub1. + type2 := MIMEType main: main2 sub: sub2. + self assert: type1 = type2. + self assert: type1 hash = type2 hash.] + ! Item was added: + ----- Method: MIMETypeTest>>testMIMEParameterAccessIsCaseInsensitive (in category 'tests') ----- + testMIMEParameterAccessIsCaseInsensitive + + #("mimeString parameter" + 'text/plain;charset=utf8' 'charset' + 'text/plain;charset=utf8' 'Charset' + 'text/plain;Charset=utf8' 'charset' + 'text/plain;Charset=utf8' 'Charset' + 'text/plain;CHARSET=utf8' 'CHARSET') + groupsOf: 2 atATimeDo: [:mimeString :parameterName | | type | + type := MIMEType fromMIMEString: mimeString. + self assert: 'utf8' equals: (type parametersAt: parameterName).] + !

1 0

The Trunk: ST80-mt.293.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.293.mcz ==================== Summary ==================== Name: ST80-mt.293 Author: mt Time: 1 June 2023, 10:30:01.900467 am UUID: 338c9d57-8caf-3b48-8366-12102eaec74e Ancestors: ST80-mt.292 Ensure traditional Browser in MVC bc. there is no usable tree widget in MVC/ST80. =============== Diff against ST80-mt.292 =============== Item was changed: Project subclass: #MVCProject + instanceVariableNames: 'originalBrowser' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'ST80-Support'! !MVCProject commentStamp: 'dtl 7/13/2013 15:36' prior: 0! An MVCProject is a project with an MVC user interface. It stores its control manager in the world instance variable, and its UI manager is an MVCUIManager. It uses an MVCToolBuilder to create the views for various tools. ! Item was changed: ----- Method: MVCProject>>finalEnterActions: (in category 'enter') ----- finalEnterActions: leavingProject + ScheduledControllers := world. + + self flag: #todo. "mt: There is no usable tree widget in MVC." + SystemBrowser default name ~= #Browser ifTrue: [ + originalBrowser := SystemBrowser default name. + (self environment classNamed: #Browser) ifNotNil: [:browserClass | + SystemBrowser default: browserClass]].! - ScheduledControllers := world.! Item was changed: ----- Method: MVCProject>>finalExitActions: (in category 'enter') ----- finalExitActions: enteringProject super finalExitActions: enteringProject. + (self environment classNamed: (originalBrowser ifNil: [''])) + ifNotNil: [:browserClass | SystemBrowser default: browserClass]. + self world unCacheWindows. EventSensor default flushEvents. ScheduledControllers := nil.!

2 1

The Trunk: NetworkTests-mt.70.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Marcel Taeumel uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-mt.70.mcz ==================== Summary ==================== Name: NetworkTests-mt.70 Author: mt Time: 1 June 2023, 11:21:01.558467 am UUID: 0e10ad2b-f9d2-3f4a-8c00-60ca3650bbc1 Ancestors: NetworkTests-ct.69 Complements Network-mt.276 =============== Diff against NetworkTests-ct.69 =============== Item was changed: SystemOrganization addCategory: #'NetworkTests-Kernel'! SystemOrganization addCategory: #'NetworkTests-Protocols'! SystemOrganization addCategory: #'NetworkTests-RFC822'! SystemOrganization addCategory: #'NetworkTests-URI'! SystemOrganization addCategory: #'NetworkTests-UUID'! SystemOrganization addCategory: #'NetworkTests-Url'! + SystemOrganization addCategory: #'NetworkTests-MIME'! Item was changed: ClassTestCase subclass: #MIMEDocumentTest instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'NetworkTests-MIME'! - category: 'NetworkTests-Url'! Item was added: + ClassTestCase subclass: #MIMETypeTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'NetworkTests-MIME'! Item was added: + ----- Method: MIMETypeTest>>testFromString (in category 'tests') ----- + testFromString + + #( + 'text/plain' 'text' 'plain' + 'image/png' 'image' 'png' + 'image/*' 'image' '*' + 'application/octet-stream' 'application' 'octet-stream' + 'application/xhtml+xml' 'application' 'xhtml+xml' + ) groupsDo: [:raw :main :sub | + | type | + type := MIMEType fromMIMEString: raw. + self + assert: main equals: type main; + assert: sub equals: type sub].! Item was added: + ----- Method: MIMETypeTest>>testFromStringWithParameters (in category 'tests') ----- + testFromStringWithParameters + + #( + 'text/plain;charset=utf8' + 'text' 'plain' 1 'charset' 'utf8' + 'text/plain; charset=utf8' "extra whitespace" + 'text' 'plain' 1 'charset' 'utf8' + 'Message/Partial; number=2; total=3; id="oc=jpbe0M2Yt4s(a)thumper.bellcore.com"' + 'Message' 'Partial' 3 'id' 'oc=jpbe0M2Yt4s(a)thumper.bellcore.com' + ) groupsDo: [:raw :main :sub :numParams :key :value | + | type | + type := MIMEType fromMIMEString: raw. + self + assert: main equals: type main; + assert: sub equals: type sub; + assert: numParams equals: type parameters size; + assert: value equals: (type parameters at: key)].!

1 0

The Trunk: Network-mt.276.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Marcel Taeumel uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-mt.276.mcz ==================== Summary ==================== Name: Network-mt.276 Author: mt Time: 1 June 2023, 11:20:42.278467 am UUID: 31ecb208-cc84-5e46-bd7c-df7995d34ca9 Ancestors: Network-ct.275 Fixes MIMEType (parameter) parsing from MIME string. MIMEType fromMIMEString: 'text/plain;charset=utf8' MIMEType fromMIMEString: 'Message/Partial; number=2; total=3; id="oc=jpbe0M2Yt4s(a)thumper.bellcore.com"' =============== Diff against Network-ct.275 =============== Item was changed: ----- Method: MIMEType class>>fromMIMEString: (in category 'instance creation') ----- fromMIMEString: mimeString + "Examples: + MIMEType fromMIMEString: 'text/plain' + MIMEType fromMIMEString: 'text/plain;charset=utf8' + MIMEType fromMIMEString: 'Message/Partial; number=2; total=3; id=""oc=jpbe0M2Yt4s(a)thumper.bellcore.com""'" + + | idx main sub parameters | - | idx main rest sub parameters | idx := mimeString indexOf: $/. idx = 0 ifTrue: [self error: 'Illegal mime type string "' , mimeString , '".']. main := mimeString copyFrom: 1 to: idx-1. + idx := mimeString indexOf: $; startingAt: idx+1. - rest := mimeString copyFrom: idx+1 to: mimeString size. - idx := mimeString indexOf: $;. idx = 0 + ifTrue: [ + sub := mimeString copyFrom: main size + 2 to: mimeString size] + ifFalse: [ | pos key val | + sub := mimeString copyFrom: main size + 2 to: idx-1. + parameters := OrderedDictionary new. + pos := idx. + [pos < mimeString size] whileTrue: [ + idx := idx + 1. "Skip $;" + [(mimeString at: idx) isSeparator] whileTrue: [idx := idx+1]. + pos := mimeString indexOf: $= startingAt: idx. + key := mimeString copyFrom: idx to: pos-1. + idx := pos+1. + (mimeString at: idx) = $" + ifFalse: ["token" + pos := mimeString indexOf: $; startingAt: idx. + pos = 0 ifTrue: [pos := mimeString size + 1]. + val := mimeString copyFrom: idx to: pos-1. + idx := pos] + ifTrue: ["quoted-string" + idx := idx+1. + pos := mimeString indexOf: $" startingAt: idx. + pos = 0 ifTrue: [self error: 'Illegal quoted-string in mime type string "' , mimeString , '".']. + val := mimeString copyFrom: idx to: pos-1. + idx := pos+1]. + parameters at: key put: val]]. - ifTrue: [sub := rest] - ifFalse: [ - sub := rest copyFrom: 1 to: idx. - parameters := rest copyFrom: idx+1 to: rest size]. ^self main: main sub: sub parameters: parameters ! Item was added: + ----- Method: MIMEType>>parameters (in category 'accessing') ----- + parameters + ^ parameters! Item was changed: ----- Method: MIMEType>>printOn: (in category 'printing') ----- printOn: stream + stream + nextPutAll: main; nextPut: $/ ; + nextPutAll: sub. + parameters ifNotNil: [ + parameters isString + ifTrue: [ "OLD: broken parameter parsing" + stream nextPutAll: parameters] + ifFalse: [ "NEW: correct key-value parsing" + parameters keysAndValuesDo: [:key :value | + stream + nextPut: $; ; space; + nextPutAll: key; + nextPut: $= . + (value includesAnyOf: ';=/') + ifTrue: [stream nextPut: $"; nextPutAll: value; nextPut: $"] + ifFalse: [stream nextPutAll: value]] ]]! - nextPutAll: main; nextPut: $/ ; nextPutAll: sub!

1 0

The Trunk: Tools-mt.1208.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1208.mcz ==================== Summary ==================== Name: Tools-mt.1208 Author: mt Time: 1 June 2023, 10:32:54.339467 am UUID: c0c05b05-964f-b043-a189-9b41cf9926c5 Ancestors: Tools-mt.1207 Guard Morphic-specific code in TreeBrowser. =============== Diff against Tools-mt.1207 =============== Item was changed: ----- Method: TreeBrowser>>classChild: (in category 'class tree') ----- classChild: aClassNotMeta selectedClassName = aClassNotMeta name ifTrue: [^ self]. self selectClass: aClassNotMeta. + Project current isMorphic + ifTrue: [self currentHand deleteBalloon].! - self currentHand deleteBalloon.! Item was changed: ----- Method: TreeBrowser>>messageCategoryChild: (in category 'message category tree') ----- messageCategoryChild: aSymbol selectedMessageCategoryName = aSymbol ifTrue: [^ self]. self selectMessageCategoryNamed: aSymbol. + Project current isMorphic + ifTrue: [self currentHand deleteBalloon].! - self currentHand deleteBalloon.! Item was changed: ----- Method: TreeBrowser>>systemCategoryChild: (in category 'system category tree') ----- systemCategoryChild: aSymbol aSymbol = selectedSystemCategory ifTrue: [^ self]. self selectSystemCategory: aSymbol. + Project current isMorphic + ifTrue: [self currentHand deleteBalloon].! - self currentHand deleteBalloon.!

1 0

The Trunk: Kernel-mt.1517.mcz
by commits＠source.squeak.org 01 Jun '23

01 Jun '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1517.mcz ==================== Summary ==================== Name: Kernel-mt.1517 Author: mt Time: 1 June 2023, 10:17:09.413467 am UUID: 6972dee4-7908-5d4b-a653-eb05dfff594f Ancestors: Kernel-mt.1516 Adds a little helper to conveniently collect repeated measures. Complements #timesRepeat:. =============== Diff against Kernel-mt.1516 =============== Item was added: + ----- Method: Integer>>timesCollect: (in category 'enumerating') ----- + timesCollect: aBlock + "Evaluate the argument, aBlock, the number of times represented by the + receiver. Collect all results and answer them." + + ^ Array streamContents: [:results | + self timesRepeat: [results nextPut: aBlock value]]!

1 0

#timeToRun | Mysterious 500 :-)
by Marcel Taeumel 01 Jun '23

01 Jun '23

Hi Eliot, hi Nicolas, hi all -- What's the meaning of that magic number 500 when calculating #timeToRun of a block? In 2016, we changed from using primitive 135 to 240 to get some UTC-based microsecond value with millisecond precision. In Time class >> #millisecondsToRun:, we see that a magic 500 offset was added (by eem). And it is added, not removed. So, it is not the offset to call the primitive itself it seems... More interestingly, we can see that 500 being added in Time class >> #microsecondsToRun: to a nanosecond value! So, what does it mean: microsOrNanos + 500 // 1000 Best, Marcel

2 6