On 21 July 2013 10:08, Stefan Marr smalltalk@stefan-marr.de wrote:
Hi Frank:
On 19 Jul 2013, at 19:55, Frank Shearar frank.shearar@gmail.com wrote:
shouldFailWhenPopEmpty | stack | stack := self given: #shouldBeEmpty.
[ stack pop ] should signal: Error withMessageText: 'a Stack() is empty'.!
[ stack pop ] should signal: Error withMessageText: 'this collection is empty'.!If you have a good idea how to handle platform-specific little things like that, I would add it.
I don't for the general case. In _this_ case maybe we can find our way out of the mess by enhancing Phexample:
shouldFailWhenPopEmpty | stack | stack := self given: #shouldBeEmpty. [ stack pop ] should signal: Error withMessageTextMatching: 'a
- is empty'.
Actually, it's easier to fix than that: just relax the test a teeny bit. I've uploaded a fix to http://ss3.gemstone.com/ss/Scratchpad-fbs/Phexample-fbs.64.
Stefan, I'd love to hear if this fixes Phexample for Pharo 1.4.
Niko, how do you handle receiving fixes?
Anyone?
What are you referring to exactly? I just checked it on Squeak 4.4, which was an adventure on its own *sigh*.
I'm curious to know why. Phexample works fine in 4.5, so it ought to work (and does, according to build.squeak.org) on Squeaks 4.3 and 4.4 as well.
Here's how we load Phexample: https://github.com/squeak-smalltalk/squeak-ci/blob/master/package-load-scrip...
frank
The fix got integrated, no? I see:
[ stack pop ] on: Error do: [:e | e messageText should matchRegex: '.* is empty'].
in that method, and it has a timestamp from March, with your name attached.
Works on Squeak 4.4 and Pharo 1.4 with the latest configuration (I tested bleedingEdge).
OK, that's what I wanted to know. I hadn't heard anything, and wanted to know what status the various configurations had. Sounds like we're all good!
frank
Best regards Stefan
-- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525