On 2/26/24 11:53, Tim Rowledge wrote:
On 2024-02-26, at 8:37 AM, Jakob Reschkejakres+squeak@gmail.com wrote:
Renaming unfortunately doesn't help with keeping compatible with existing code out there. So it doesn't free up #assert:equals: to the more common order of arguments.
OK, so a monotonically improving possibility would be to add @assertResultOf:is: and comment that it is a readability-improved version ofassert:equals:. Combined with changing all the plausibly reachable code to use that, it should make things a little clearer.
It might be simpler to fix the existing tests so that the assertions are written correctly. Presumably you would want to do that anyway, and I suspect that if the existing test suites were all written correctly in a consistent style then the perceived readability problem would go away.
I'll confess that my perspective is twisted by exposure to a vast swamp of unit test enhancements in various Java frameworks. There are as many variations on the JUnit frameworks as there are developer opinions, which turns out to be quite a lot. To my eyes, the result is a big mess.
Dave