On Sun, 27 Jun 2010, Rob Withers wrote:
All Crypto except SSL and X509 passes unit tests - green. The X509 tests fail because the example certificates are expired.
Back to the return value of #nextPutAll:, I am surprised that such basic protocol and classes are changing this late in the game. How are we to know that the current implementation is locked down and invariant?
It was a simple protocol cleanup. Stream >> #nextPutAll: returned the argument, but some subclasses didn't. Since Squeak 4.1 you can rely on the return value of #nextPutAll:, since all implementors return the argument.
Levente
just askin', Rob
From: "Rob Withers" reefedjib@yahoo.com Sent: Sunday, June 27, 2010 10:28 AM To: "The general-purpose Squeak developers list" squeak-dev@lists.squeakfoundation.org Subject: Re: [squeak-dev] stream>>#nextPutAll: changed to returncollectioninstead of the stream?
Hey David,
Yeah, I fixed it this way:
writeStream := ByteArray new writeStream nextPutAll: self clientVersion asByteArray; ... nextPutAll: encodedCompressionMethods; yourself.
There is too much noise in the link you gave to find useful Crypto work. I found one package. They should really integrate it into the Monticello HTTP Crypto repository, which is where you will find SSL:
http://www.squeaksource.com/Cryptography
I'll need some time to make sure it is working correctly again.
Cheers, Rob
The Modern Whig Party of Virginia - http://vawhigs.org
From: "C. David Shaffer" cdshaffer@acm.org Sent: Sunday, June 27, 2010 10:16 AM To: "The general-purpose Squeak developers list" squeak-dev@lists.squeakfoundation.org Subject: Re: [squeak-dev] stream>>#nextPutAll: changed to return collectioninstead of the stream?
On 06/27/10 09:01, Rob Withers wrote:
This has completely broken SSL. :-(
I hit this as well. Here's a patch (although you likely already fixed it yourself). BTW, when using SSL you definitely want the improvements to Cryptography found on:
http://croquet-src-01.oit.duke.edu:8886/Contributions
If someone is doing updates of Cryptography/SSL they might want to look into getting this code into SqueakSource as having to search the universe for a working SSL is kind of frustrating :-)
David