Re: [squeak-dev] The Inbox: Tools-ael.394.mcz

25 Jul 2012

      On 23 December 2011 08:42, Aran Lunzer aranlunzer@gmail.com wrote:
...
In a FileList there are some operations (such as 'install into new
change set' and 'fileIn entire file', both on a .st file) that can be
invoked from the file list, but on the contents pane lead to a
walkback.
The problem arises from the setup of the contents-pane menu in
FileList>>fileContentsMenu:shifted:, where menu items are connected to
ServiceEntry instances that have an invalid 'served' object.
The relevant bit of the old code is
            aMenu
                    addServices: services
                    for: self fullName
                    extraLines: extraLines

which looks like it should be
            aMenu
                    addServices: services
                    for: self
                    extraLines: extraLines

...because the served object (the fileList) will be asked its fullName
when the service is invoked.
I just tried, in an updated trunk image, to "install into new change
set", and everything worked just fine. Is this fix still necessary?
frank
...
Aran Lunzer
Viewpoints Research Institute