On 2020-01-18, at 9:49 PM, Frank Shearar frank.shearar@gmail.com wrote:
https://tech.labs.oliverwyman.com/blog/2011/01/04/try-again-with-exceptions/ might help.
It's a decent explanation of the sort of problem we're seeing.
Basically I think the lookup fails and 'giving up' doesn't actually result in giving up because some better error checking needs to be done. And on top of that the file browser assumes that it's a good idea to repeatedly ask a directory to wakeUp, and the ServerDirectory wakeUp method thinks that client isNil is a proper way to decide that we need to open the ftp client and nowhere does any code handle the possibility that the ftp connection is dead, deceased, an ex-connection that has shuffled off to join the finalisation queue invisible.
I think it needs to be possible to flag the ServerDirectory as somnolent in some fashion. After trying to connect and failing (for whatever reason) the sleepy ftp client should probably be kept around so that the file list can deliberately retry the connection if the user asks, or delete it from the list of servers etc.
It's certainly more changes than we should consider at this stage of a hopeful release cycle.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Oxymorons: Resident alien