Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz

20 Apr 2020

      ...
1. Can we automatically use #scaledToHeight: for the badge to avoid the inconsistent row heights?
Oh, definitely. I forgot to call #scaleIconToDisplay. I would rather not make a assumptions about the surrounding text but maybe add support width/height to the <img> tag.
...

TextURL and TextReference seem not to work well together: In my image, only the left half of the banner is actually clickable.

You can open a new discussion for that. :-) And maybe isolate the issue first in a compact example for everybody to try out.
Best,
Marcel
Am 18.04.2020 15:36:05 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
I love this idea! :D
Two comments:
1. Can we automatically use #scaledToHeight: for the badge to avoid the inconsistent row heights?
2. TextURL and TextReference seem not to work well together: In my image, only the left half of the banner is actually clickable.
Best,
Christoph
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von David T. Lewis lewis@mail.msen.com
Gesendet: Freitag, 17. April 2020 20:49 Uhr
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz

That's brilliant :-)
Dave
On Fri, Apr 17, 2020 at 07:04:17PM +0200, karl ramberg wrote:
...
Cool
Best,
Karl
On Fri, Apr 17, 2020 at 5:25 PM Marcel Taeumel marcel.taeumel@hpi.de
wrote:
...
Am 17.04.2020 17:17:37 schrieb commits@source.squeak.org <
commits@source.squeak.org>:
Marcel Taeumel uploaded a new version of MonticelloConfigurations to
project The Trunk:
http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz [http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz]
==================== Summary ====================
Name: MonticelloConfigurations-mt.160
Author: mt
Time: 17 April 2020, 5:17:27.82286 pm
UUID: 6d32501e-f519-3b4a-ae1a-58b52360a937
Ancestors: MonticelloConfigurations-mt.159
Shows the current CI status in the update dialog.
=============== Diff against MonticelloConfigurations-mt.159
Item was changed:
----- Method: MCMcmUpdater>>doUpdate: (in category 'updating') -----
doUpdate: interactive
"Update the image by loading all pending updates from the server. If this
is
the default updater for the system, update the system version when
complete.
If interteractive use a modal notifier, otherwise only update the
transcript.
Flush all caches. If a previous download failed this is often helpful"
| config previousUpdateLevel ensureTranscriptSetting |
previousUpdateLevel := SystemVersion current highestUpdate.
MCFileBasedRepository flushAllCaches.
ensureTranscriptSetting := MCConfiguration ensureOpenTranscript.
[ MCConfiguration ensureOpenTranscript: interactive.
config := self updateFromRepository.
config ifNil: [
interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from
remote repository.' translated ].
Transcript cr; show: '========== Unable to retrieve updates from remote
repository. ==========' translated; cr.
^ self ].
MCMcmUpdater default == self
ifTrue: [
config setSystemVersion.

interactive ifTrue: [
self inform: (self updateMessageFor: previousUpdateLevel)].

interactive ifTrue: [
self inform: ('Update completed.\Version: {1}\Update: {3}{2}\Url:

{4}\Map: ''{5}''{6}' translated withCRs format: {

SystemVersion current version.
SystemVersion current highestUpdate.
previousUpdateLevel = SystemVersion current highestUpdate
ifTrue: ['']
ifFalse: [previousUpdateLevel asString, ' -> '].
self repository.
MCMcmUpdater updateMapName.
SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String

cr, String cr, d]})].
Transcript cr;
show: '========== Update completed: ' translated;
show: previousUpdateLevel;
show: ' -> ' ;
show: SystemVersion current highestUpdate;
show: ' =========='; cr ]
ifFalse: [
interactive
ifTrue: [ self inform: 'Update completed.' ].
Transcript cr; show: '========== Update completed. ==========' translated;
cr ] ]
ensure: [ MCConfiguration ensureOpenTranscript: ensureTranscriptSetting].
!
Item was changed:
----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating') -----
doUpdate: interactive upTo: versionNumber
"Update the image by loading all pending updates from the server. If this
is
the default updater for the system, update the system version when
complete.
If interteractive use a modal notifier, otherwise only update the
transcript.
Flush all caches. If a previous download failed this is often helpful"
| config previousUpdateLevel |
previousUpdateLevel := SystemVersion current highestUpdate.
MCFileBasedRepository flushAllCaches.
config := self updateFromRepositories: { self repository } upTo:
versionNumber.
config ifNil: [
interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from
remote repository.' translated ].
Transcript cr; show: '========== Unable to retrieve updates from remote
repository. ==========' translated; cr.
^ self ].
MCMcmUpdater default == self
ifTrue: [
config setSystemVersion.

interactive ifTrue: [
self inform: (self updateMessageFor: previousUpdateLevel)].

interactive ifTrue: [
self inform: ('Update completed.\Version: {1}\Update: {3}{2}\Url:

{4}\Map: ''{5}''{6}' translated withCRs format: {

SystemVersion current version.
SystemVersion current highestUpdate.
previousUpdateLevel = SystemVersion current highestUpdate
ifTrue: ['']
ifFalse: [previousUpdateLevel asString, ' -> '].
self repository.
MCMcmUpdater updateMapName.
SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String

cr, String cr, d]})].
Transcript cr;
show: '========== Update completed: ' translated;
show: previousUpdateLevel;
show: ' -> ' ;
show: SystemVersion current highestUpdate;
show: ' =========='; cr ]
ifFalse: [
interactive
ifTrue: [ self inform: 'Update completed.' ].
Transcript cr; show: '========== Update completed. ==========' translated;
cr ]
!
Item was added:

----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private')

updateMessageFor: previousUpdateLevel

^ ('Update completed.

Version: {1}
Update: {3}*{2}*
Url: {4}
Map: ''{5}''
TravisCI status: {6}' translated format: {

SystemVersion current version.
SystemVersion current highestUpdate.
previousUpdateLevel = SystemVersion current highestUpdate
ifTrue: ['']
ifFalse: [previousUpdateLevel asString, ' -> '].
self repository.
MCMcmUpdater updateMapName.
SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |
'

', (d copyReplaceAll: String cr with: '
')].

SystemVersion current ciStatusBadgeUrl.
SystemVersion current ciStatusPageUrl.
}) asTextFromHtml!

...