The preference triggers the error because ProjectViewMorph has the SystemWindow as a owner and then it gets hidden when the targetOwner is hidden. I have to look at the other users of this method to understand why the owner should be hidden. Nothing obvious comes to mind.
Best, Karl
On Thu, Dec 6, 2018 at 6:25 AM K K Subbu kksubbu.ml@gmail.com wrote:
There is also a targetMorph show later on in the method that has to be removed.
I doubt whether the preference has anything to do with the bug.
While loading from the server, the system window (or the thumbnail) is hidden and a translucent morph is placed over its bounds. When the loading is complete, the steps are reversed. I suppose this is to indicate that the thumbnail could change when a new version is loaded.
This is holiday season so feedback may be slow in coming. In any case, you could post a fix to the Inbox to trigger discussions.
Regards .. Subbu
On 06/12/18 3:25 AM, karl ramberg wrote:
The problem does not happen when ProjectViewInWindow preference is false.
In ComplexProgressIndicator>>withProgressDo: Comment out targetOwner ifNotNil: [targetOwner hide].
I'm not sure why the owner of the ProjectViewMorph should ever hide here. There could be some edge case I'm not aware of.
If nobody see an issue with this I'll make a change and push to trunk
Cheers, Karl
On Wed, Dec 5, 2018 at 8:47 AM K K Subbu <kksubbu.ml@gmail.com mailto:kksubbu.ml@gmail.com> wrote:
On 28/11/18 1:28 AM, Tim Johnson wrote: > > I did World menu->open->morphic project. (I can enter it and return, or > not enter it at all, and it has no effect on what I'm reporting here.) > > I then menu-clicked inside the project's thumbnail and chose "see
if
> server version is more recent." > > This brings up a chooser dialog and makes the project thumbnail morph > disappear. The project view morph is enclosed in a system window which gets
hidden
while displaying a progress dialog to check on server. If the dialog
is
dismissed, it continues to stay hidden :-(. I suspect this is because ProjectViewMorph>>checkForNewerVersionAndLoad self withProgressDo: [ project loadFromServer ] loadFromServer displays a progress bar when required, so I wonder why withProgressDo: is required again. If I remove this check and change
to
project loadFromServer then the problem gets solved. I don't know enough about project
loading
to confirm if this is indeed the correct solution. Regards .. Subbu