On 27 July 2012 13:36, Sean P. DeNigris sean@clipperadams.com wrote:
Frank Shearar-3 wrote
That's what happens when I'm too slow to commit! I'm making some other changes as well: saving snapshots as a new image, for starters.
One cool thing about git/github is that there's no penalty for committing early and often. Proposed changes can even be discussed right in the pull request. Ordinarily, I would've created an issue on github, and then a branch with the issue name, e.g. issue_14, and committed to the branch to keep master clean, but I was lazy ;-) Although you can see in the pull request that I missed one hard-coded path and made another commit, which appeared in the pull request with the first one.
Sure: github's my bread & butter in my day job. I meant that while I was doing the WORKSPACE changes I got sidetracked into the snapshotting thing, and was going to commit THEN, but you beat me to the punch!
frank
Sean
-- View this message in context: http://forum.world.st/Squeak-release-process-CI-server-tp4640962p4641808.htm... Sent from the Squeak - Dev mailing list archive at Nabble.com.