Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.309.mcz
==================== Summary ====================
Name: EToys-mt.309 Author: mt Time: 12 October 2017, 5:48:05.311645 pm UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b Ancestors: EToys-hjh.279, EToys-hjh.308
For consistency regarding EToys-hjh.279
=============== Diff against EToys-hjh.308 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor + ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [ Color transparent]! - - ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor + ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]! - ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]!
Thank you Marcel for the user interface theme updates.
Could you please elaborate why you go for
+ ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [ Color transparent]!
instead of
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
?
--Hannes
On Thu, 12 Oct 2017 15:49:44 0000, commits@source.squeak.org commits@source.squeak.org wrote:
Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.309.mcz
==================== Summary ====================
Name: EToys-mt.309 Author: mt Time: 12 October 2017, 5:48:05.311645 pm UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b Ancestors: EToys-hjh.279, EToys-hjh.308
For consistency regarding EToys-hjh.279
=============== Diff against EToys-hjh.308 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [
Color transparent]!
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
To make it consistent with the other change in #borderColor.
If you want to use themes, change it back for all calls to the theme. I would rather not mix #get:for: and the normal theme use in the same class.
Best, Marcel Am 12.10.2017 17:59:11 schrieb H. Hirzel hannes.hirzel@gmail.com: Thank you Marcel for the user interface theme updates.
Could you please elaborate why you go for
+ ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [ Color transparent]!
instead of
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
?
--Hannes
On Thu, 12 Oct 2017 15:49:44 0000, commits@source.squeak.org wrote:
Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.309.mcz
==================== Summary ====================
Name: EToys-mt.309 Author: mt Time: 12 October 2017, 5:48:05.311645 pm UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b Ancestors: EToys-hjh.279, EToys-hjh.308
For consistency regarding EToys-hjh.279
=============== Diff against EToys-hjh.308 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [
Color transparent]!
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
I agree not to mix the two different types of calls.
But my question is
what is to be preferred?
--Hannes
On 10/12/17, Marcel Taeumel marcel.taeumel@hpi.de wrote:
To make it consistent with the other change in #borderColor.
If you want to use themes, change it back for all calls to the theme. I would rather not mix #get:for: and the normal theme use in the same class.
Best, Marcel Am 12.10.2017 17:59:11 schrieb H. Hirzel hannes.hirzel@gmail.com: Thank you Marcel for the user interface theme updates.
Could you please elaborate why you go for
- ^ (UserInterfaceTheme current get: #titleColor for:
#MenuMorph) ifNil: [ Color transparent]!
instead of
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
?
--Hannes
On Thu, 12 Oct 2017 15:49:44 0000, commits@source.squeak.org wrote:
Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.309.mcz
==================== Summary ====================
Name: EToys-mt.309 Author: mt Time: 12 October 2017, 5:48:05.311645 pm UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b Ancestors: EToys-hjh.279, EToys-hjh.308
For consistency regarding EToys-hjh.279
=============== Diff against EToys-hjh.308 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil:
[ Color transparent]!
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
The "self userInterfaceTheme color" is the preferred one because it takes advantage of implicit classification for the respective properties. :) Am 12.10.2017 18:07:53 schrieb H. Hirzel hannes.hirzel@gmail.com: I agree not to mix the two different types of calls.
But my question is
what is to be preferred?
--Hannes
On 10/12/17, Marcel Taeumel wrote:
To make it consistent with the other change in #borderColor.
If you want to use themes, change it back for all calls to the theme. I would rather not mix #get:for: and the normal theme use in the same class.
Best, Marcel Am 12.10.2017 17:59:11 schrieb H. Hirzel : Thank you Marcel for the user interface theme updates.
Could you please elaborate why you go for
- ^ (UserInterfaceTheme current get: #titleColor for:
#MenuMorph) ifNil: [ Color transparent]!
instead of
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
?
--Hannes
On Thu, 12 Oct 2017 15:49:44 0000, commits@source.squeak.org wrote:
Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.309.mcz
==================== Summary ====================
Name: EToys-mt.309 Author: mt Time: 12 October 2017, 5:48:05.311645 pm UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b Ancestors: EToys-hjh.279, EToys-hjh.308
For consistency regarding EToys-hjh.279
=============== Diff against EToys-hjh.308 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil:
[ Color transparent]!
- ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
squeak-dev@lists.squeakfoundation.org