A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-hjh.279.mcz
==================== Summary ====================
Name: EToys-hjh.279 Author: hjh Time: 22 February 2017, 11:23:24.984746 am UUID: 3f908905-74c3-4c1c-931c-7b440b143602 Ancestors: EToys-dtl.278
Two steps towards loading an EToys projects dropped on to the desktop.
Change StandardScriptingSystem>>baseColor StandardScriptingSystem>>borderColor
to use UserInterfaceTheme current instead of the old direct access to Preferences.
=============== Diff against EToys-dtl.278 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor + ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [ Color transparent]! - ^ Preferences menuTitleColor!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor + ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]! - ^ Preferences menuBorderColor!
This change has been committed to trunk.
Could somebody please move this to the 'treated' box?
--Hannes
On Wed, 22 Feb 2017 10:23:45 0000, commits@source.squeak.org commits@source.squeak.org wrote:
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-hjh.279.mcz
==================== Summary ====================
Name: EToys-hjh.279 Author: hjh Time: 22 February 2017, 11:23:24.984746 am UUID: 3f908905-74c3-4c1c-931c-7b440b143602 Ancestors: EToys-dtl.278
Two steps towards loading an EToys projects dropped on to the desktop.
Change StandardScriptingSystem>>baseColor StandardScriptingSystem>>borderColor
to use UserInterfaceTheme current instead of the old direct access to Preferences.
=============== Diff against EToys-dtl.278 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil: [
Color transparent]!
- ^ Preferences menuTitleColor!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:
[(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ Preferences menuBorderColor!
Maybe there are better ways of doing it, however it works at the moment and helps Etoys projects to load.
On 10/9/17, H. Hirzel hannes.hirzel@gmail.com wrote:
This change has been committed to trunk.
Could somebody please move this to the 'treated' box?
--Hannes
On Wed, 22 Feb 2017 10:23:45 0000, commits@source.squeak.org commits@source.squeak.org wrote:
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-hjh.279.mcz
==================== Summary ====================
Name: EToys-hjh.279 Author: hjh Time: 22 February 2017, 11:23:24.984746 am UUID: 3f908905-74c3-4c1c-931c-7b440b143602 Ancestors: EToys-dtl.278
Two steps towards loading an EToys projects dropped on to the desktop.
Change StandardScriptingSystem>>baseColor StandardScriptingSystem>>borderColor
to use UserInterfaceTheme current instead of the old direct access to Preferences.
=============== Diff against EToys-dtl.278 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil:
[ Color transparent]!
- ^ Preferences menuTitleColor!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph)
ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ Preferences menuBorderColor!
Hello Marcel
Could you please have a look at this and commit it?
This fix is needed to make Etoys project loading work.
This fix will give one walkback less while doing so.
Thank you
Hannes
On 10/9/17, H. Hirzel hannes.hirzel@gmail.com wrote:
Maybe there are better ways of doing it, however it works at the moment and helps Etoys projects to load.
On 10/9/17, H. Hirzel hannes.hirzel@gmail.com wrote:
This change has been committed to trunk.
Could somebody please move this to the 'treated' box?
--Hannes
On Wed, 22 Feb 2017 10:23:45 0000, commits@source.squeak.org commits@source.squeak.org wrote:
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-hjh.279.mcz
==================== Summary ====================
Name: EToys-hjh.279 Author: hjh Time: 22 February 2017, 11:23:24.984746 am UUID: 3f908905-74c3-4c1c-931c-7b440b143602 Ancestors: EToys-dtl.278
Two steps towards loading an EToys projects dropped on to the desktop.
Change StandardScriptingSystem>>baseColor StandardScriptingSystem>>borderColor
to use UserInterfaceTheme current instead of the old direct access to Preferences.
=============== Diff against EToys-dtl.278 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph)
ifNil: [ Color transparent]!
- ^ Preferences menuTitleColor!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph)
ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ Preferences menuBorderColor!
Hi Hannes,
I think it worked. Still, source.squeak.org went from "slow" to "unresponsive". :(
Best, Marcel Am 12.10.2017 17:29:08 schrieb H. Hirzel hannes.hirzel@gmail.com: Hello Marcel
Could you please have a look at this and commit it?
This fix is needed to make Etoys project loading work.
This fix will give one walkback less while doing so.
Thank you
Hannes
On 10/9/17, H. Hirzel wrote:
Maybe there are better ways of doing it, however it works at the moment and helps Etoys projects to load.
On 10/9/17, H. Hirzel wrote:
This change has been committed to trunk.
Could somebody please move this to the 'treated' box?
--Hannes
On Wed, 22 Feb 2017 10:23:45 0000, commits@source.squeak.org wrote:
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-hjh.279.mcz
==================== Summary ====================
Name: EToys-hjh.279 Author: hjh Time: 22 February 2017, 11:23:24.984746 am UUID: 3f908905-74c3-4c1c-931c-7b440b143602 Ancestors: EToys-dtl.278
Two steps towards loading an EToys projects dropped on to the desktop.
Change StandardScriptingSystem>>baseColor StandardScriptingSystem>>borderColor
to use UserInterfaceTheme current instead of the old direct access to Preferences.
=============== Diff against EToys-dtl.278 ===============
Item was changed: ----- Method: StandardScriptingSystem>>baseColor (in category '*Etoys-Squeakland-tile colors') ----- baseColor
- ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph)
ifNil: [ Color transparent]!
- ^ Preferences menuTitleColor!
Item was changed: ----- Method: StandardScriptingSystem>>borderColor (in category '*Etoys-Squeakland-tile colors') ----- borderColor
- ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph)
ifNil: [(Color r: 0.2 g: 0.3 b: 0.9)]!
- ^ Preferences menuBorderColor!
squeak-dev@lists.squeakfoundation.org
-
commits＠source.squeak.org -
H. Hirzel -
Marcel Taeumel