Great! and thanks for the listing (I keep forgetting to save my workspace code from the videos :-/)
Am I right in thinking this really shouldn't permanently lock things up , even though its an obvious bug in my code?
It would be a common noob mistake and pretty awful to have happen as your first encounter with a Squeak bug.
L
On 4/15/14, 3:19 PM, gettimothy wrote:
First, thanks for an awesome vid. Very informative.
|myMorphs| myMorphs := Array new: 360. 0 to: 359 by:15 do:[:i | myMorphs at: i+1 put:((NCCurveMorph new) extent: 20@20; openInWorld; center: (450@330) + (300 *((i degreesToRadians cos)@(i degreesToRadians sin))); yourself)]. 1 to:(myMorphs size - 1) do:[:i | i+1 to: myMorphs size do:[:j | ((myMorphs at:i ) ~= nil and:(myMorphs at:j ) ~= nil) ifTrue:[NCAAConnectorMorph fromMorph: (myMorphs at:i) toMorph:(myMorphs at:j)]]] "tty Debug Lock" NCAAConnectorMorph allInstances do:[:each | each lock:True]. "This locks it" NCAAConnectorMorph allInstances inspect. "about 285 instances" Transcript clear. NCAAConnectorMorph allInstances do:[:each | Transcript show: (each bounds);cr. ]. "works" NCAAConnectorMorph allInstances do:[:each | Transcript show: (each bounds);cr. each lock:true ]. "works" NCAAConnectorMorph allInstances do:[:each | each lock:true]. "works" True inspect. true inspect. NCAAConnectorMorph allInstances do:[:each | each lock:(True initializedInstance)]. "works"
I was able to recreate the lockup you described. Changing the lock:True to lock:true (all lowercase) does not cause the lock up.
You can work through the reasoingin with the "tty Debug Lock" section in the above code.
If you do the two inspect statements at the bottom, you will see you where passing the "True class" instead of the instance "True".
cordially,
tty
>>Am I right in thinking this really shouldn't permanently lock things up , even though its an obvious bug in my code?
I don't know. I will leave it to the more experienced guys to answer that.
Modifying the Morhp>>lock code to check prevents the freeze, but then you get into UI questions for which I am completely unqualified to answer.
lock: aBoolean "change the receiver's lock property" (aBoolean == true) | (aBoolean == false) ifTrue:[ (extension isNil and: [aBoolean not]) ifTrue: [^ self]. self assureExtension locked: aBoolean]
For example, the above "fix" does not freeze the system, but it also does not lock the morphs and does not inform the user that there was a problem....that sort of judgement is completely outside my experience.
cordially,
tty
squeak-dev@lists.squeakfoundation.org