[Seaside-dev] Re: [Seaside Commits] Seaside 2.9: Seaside-Tools-Web-mls.5.mcz

[Julian Fitzell]

Why not? Isn't that a bug? (I'm only half joking :) )

According to the ANSI spec, though, #allSubclasses need not necessarily
return on OrderedCollection (in fact, why should it be ordered?). Maybe
that's too theoretical an issue to worry about but if you're going to force
a conversion of one of the collections, it's a bit odd not to ensure the
type of the other one.

If this is coming up now, why don't we at least define what kind of
collection #potentialParents should return (I don't think it needs to be
ordered?), write a unit test for it, and make sure it always returns that.
It might be better to do "allSubclasses asSet"?

Julian

On Wed, Jun 17, 2009 at 2:17 PM, <
squeak-dev-noreply at lists.squeakfoundation.org> wrote:

> Michael Lucas-Smith uploaded a new version of Seaside-Tools-Web to project
> Seaside 2.9:
> http://www.squeaksource.com/Seaside29/Seaside-Tools-Web-mls.5.mcz
>
> ==================== Summary ====================
>
> Name: Seaside-Tools-Web-mls.5
> Author: mls
> Time: 17 June 2009, 2:16:56 pm
> UUID: 78a3eb34-4d01-4e6f-808d-c7a472ccf852
> Ancestors: Seaside-Tools-Web-jf.4
>
> - You can't concatenate an OrderedCollection with a Set in VW
>
> =============== Diff against Seaside-Tools-Web-jf.4 ===============
>
> Item was changed:
>  ----- Method: WAUserConfigurationEditor>>potentialParents (in category
> 'rendering-ancestry') -----
>  potentialParents
>        ^ ((WASystemConfiguration allSubclasses collect: [ :each | each
> instance ]),
> +               WASharedConfiguration configurations asOrderedCollection)
> -               WASharedConfiguration configurations)
>                select: [ :each |
>                        (self configuration canAddParent: each)
>                                and: [ (self configuration inheritsFrom:
> each) not ] ]!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20090617/be3a2d50/attachment.htm