Squeak-dev October 2017

squeak-dev@lists.squeakfoundation.org

40 participants
132 discussions

The Trunk: 51Deprecated-tpr.49.mcz
by commits＠source.squeak.org 28 Oct '17

28 Oct '17

tim Rowledge uploaded a new version of 51Deprecated to project The Trunk: http://source.squeak.org/trunk/51Deprecated-tpr.49.mcz ==================== Summary ==================== Name: 51Deprecated-tpr.49 Author: tpr Time: 28 October 2017, 11:03:55.208019 am UUID: 140ed91b-1f30-4f04-bb81-368e58ef4772 Ancestors: 51Deprecated-mt.48 deprecate #labelString in favour of #windowTitle =============== Diff against 51Deprecated-mt.48 =============== Item was added: + ----- Method: StringHolder>>labelString (in category '*51Deprecated') ----- + labelString + ^self windowTitle!

2 1

The Trunk: Morphic-tpr.1355.mcz
by commits＠source.squeak.org 28 Oct '17

28 Oct '17

tim Rowledge uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-tpr.1355.mcz ==================== Summary ==================== Name: Morphic-tpr.1355 Author: tpr Time: 28 October 2017, 11:08:55.911549 am UUID: b132d4a2-6f22-4a89-a13f-dbba9ce7a585 Ancestors: Morphic-eem.1354 Changes as part of promoting #buildWindowWith* to Model =============== Diff against Morphic-eem.1354 =============== Item was removed: - ----- Method: FontChooserTool>>buildWindowWith: (in category 'toolbuilder') ----- - buildWindowWith: builder - | windowSpec | - windowSpec := builder pluggableWindowSpec new. - windowSpec model: self. - windowSpec label: #windowTitle. - windowSpec children: OrderedCollection new. - ^windowSpec! Item was removed: - ----- Method: FontChooserTool>>buildWindowWith:specs: (in category 'toolbuilder') ----- - buildWindowWith: builder specs: specs - | windowSpec | - windowSpec := self buildWindowWith: builder. - specs do:[:assoc| | action widgetSpec rect | - rect := assoc key. - action := assoc value. - widgetSpec := action value. - widgetSpec ifNotNil:[ - widgetSpec frame: rect. - windowSpec children add: widgetSpec]]. - ^windowSpec! Item was changed: ----- Method: FontImporterTool class>>open (in category 'opening') ----- open " + FontImporterTool open. - FontChooserTool open. " ^self new open! Item was removed: - ----- Method: FontImporterTool>>buildWindowWith:specs: (in category 'toolbuilder') ----- - buildWindowWith: builder specs: specs - | windowSpec | - windowSpec := builder pluggableWindowSpec new. - windowSpec - model: self; - label:'Choose a Font to import' translated; - extent: self initialExtent; - children: OrderedCollection new. - - specs do:[:assoc| - | rect action widgetSpec | - rect := assoc key. - action := assoc value. - widgetSpec := action value. - widgetSpec ifNotNil:[ - widgetSpec frame: rect. - windowSpec children add: widgetSpec]]. - ^windowSpec! Item was added: + ----- Method: FontImporterTool>>windowTitle (in category 'toolbuilder') ----- + windowTitle + + ^'Choose a Font to import' translated!

1 0

The Trunk: Kernel-tpr.1115.mcz
by commits＠source.squeak.org 28 Oct '17

28 Oct '17

tim Rowledge uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-tpr.1115.mcz ==================== Summary ==================== Name: Kernel-tpr.1115 Author: tpr Time: 28 October 2017, 11:06:07.532891 am UUID: 5ca44325-d17b-4169-a4bc-801f91348851 Ancestors: Kernel-cmm.1114 Changes as part of promoting #buildWindowWith* to Model =============== Diff against Kernel-cmm.1114 =============== Item was added: + ----- Method: Model>>buildWindowWith: (in category 'toolbuilder') ----- + buildWindowWith: builder + | windowSpec | + windowSpec := builder pluggableWindowSpec new. + windowSpec model: self. + windowSpec label: #windowTitle. + windowSpec children: OrderedCollection new. + ^windowSpec! Item was added: + ----- Method: Model>>buildWindowWith:specs: (in category 'toolbuilder') ----- + buildWindowWith: builder specs: specs + | windowSpec | + windowSpec := self buildWindowWith: builder. + specs do:[:assoc| + | rect action widgetSpec | + rect := assoc key. + action := assoc value. + widgetSpec := action value. + widgetSpec ifNotNil:[ + widgetSpec frame: rect. + windowSpec children add: widgetSpec]]. + ^windowSpec! Item was added: + ----- Method: Model>>windowTitle (in category 'toolbuilder') ----- + windowTitle + ^self class name! Item was removed: - ----- Method: StringHolder>>buildWindowWith: (in category 'toolbuilder') ----- - buildWindowWith: builder - | windowSpec | - windowSpec := builder pluggableWindowSpec new. - windowSpec model: self. - windowSpec label: #labelString. - windowSpec children: OrderedCollection new. - ^windowSpec! Item was removed: - ----- Method: StringHolder>>buildWindowWith:specs: (in category 'toolbuilder') ----- - buildWindowWith: builder specs: specs - | windowSpec | - windowSpec := self buildWindowWith: builder. - specs do:[:assoc| - | rect action widgetSpec | - rect := assoc key. - action := assoc value. - widgetSpec := action value. - widgetSpec ifNotNil:[ - widgetSpec frame: rect. - windowSpec children add: widgetSpec]]. - ^windowSpec! Item was removed: - ----- Method: StringHolder>>labelString (in category 'toolbuilder') ----- - labelString - ^self class name!

1 0

The Trunk: HelpSystem-Core-tpr.100.mcz
by commits＠source.squeak.org 28 Oct '17

28 Oct '17

tim Rowledge uploaded a new version of HelpSystem-Core to project The Trunk: http://source.squeak.org/trunk/HelpSystem-Core-tpr.100.mcz ==================== Summary ==================== Name: HelpSystem-Core-tpr.100 Author: tpr Time: 28 October 2017, 11:05:17.96849 am UUID: 4018391a-689c-42b4-91a3-ad4ec69ce3b0 Ancestors: HelpSystem-Core-ul.99 Changes as part of promoting #buildWindowWith* to Model =============== Diff against HelpSystem-Core-ul.99 =============== Item was removed: - ----- Method: HelpBrowser>>buildWindowWith: (in category 'toolbuilder') ----- - buildWindowWith: builder - - ^ builder pluggableWindowSpec new - model: self; - children: OrderedCollection new; - label: #label; - yourself! Item was removed: - ----- Method: HelpBrowser>>label (in category 'accessing - ui') ----- - label - - ^ self rootTopic - ifNil: ['Help Browser'] - ifNotNil: [:topic | topic title]! Item was changed: ----- Method: HelpBrowser>>rootTopic: (in category 'accessing') ----- rootTopic: aHelpTopic rootTopic := aHelpTopic asHelpTopic. self toplevelTopics: ((self rootTopic ifNil: [#()] ifNotNil: #subtopics) sorted, {self searchTopic}). + self changed: #windowTitle.! - self changed: #label.! Item was added: + ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui') ----- + windowTitle + + ^ self rootTopic + ifNil: ['Help Browser'] + ifNotNil: [:topic | topic title]!

1 0

Changes to Browser building/opening
by tim Rowledge 28 Oct '17

28 Oct '17

I hurt my back a couple of weeks ago and so I found myself forced to sit on my office chair as the least painful place to be. With nothing urgent to do other than avoid boredom, I finally thought to myself that I would attack an annoyance that has been annoying me for years in Squeak. Well as is so often the case, as I dug into what to do I got distracted. In this case I stumbled upon the assorted Browser related methods for building the browsers. So far as I can see waaaay back when we adopted the ToolBuilder idea a whole bunch of methods got hacked about to work with it and then just left to moulder. For example a number of messages that clearly used to actually build windows got turned into code that did no such thing and instead assembled a spec to pass to a toolbuilder. The comments usually didn’t even get updated. Oh, and the ability to spawn browsers with a partially edited bit of code seems to have gone away at that point. And the simple toolbuilder idiom that allows ToolBuilder open: BlahClass didn’t seem to work too well froBrowsers either. Part of that is because the Browser code can build a stack of different UIs instead of the simplistic approach of 'one class one UI’. We could have split Browser up a bit to make that work, and maybe we still should. It has appeal. There was much related ‘fun’ whilst digging into the area, where I discovered that we have SystemNavigation having some code that tries to build assorted browsers (with many comments containing broken examples, sigh), ToolSet and StandardToolSet gathering some Browser building and SystemBrowser doing nothing more complex than deciding between Browser and PackagePaneBrowser. None of this has much in the way of helpful commentary. Oh and let’s not forget UIManager which seems to get tangled in it as well. I found places where a browser was referred to both via ToolSet and Browser. And whilst having pragmas to mark menu related methods is a neat idea it would be a whole lot better if only you could sensibly find the damned things with implementors-of etc. I made a small pile of changes to clean up at least some of this. I’ve made the building more explicit and enabled 'ToolBuilder open: Browser/HierarchyBrowser/ClassListBrowser' etc. I managed to make the spawning-with-partial-text thing work in all the cases I can find. I think I broke something in MVC projects but right now I can’t even get into an mvc project to look - and given that I didn’t (knowingly) touch changesorters I’m not sure it’s my fault. The changes range across several MC packages so I think it is better to share the changes file for an initial look-see. It’s on the swiki at http://wiki.squeak.org/squeak/2736 tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim It said, "Insert disk #3," but only two will fit!

5 19

The Trunk: Tools-tpr.769.mcz
by commits＠source.squeak.org 28 Oct '17

28 Oct '17

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.769.mcz ==================== Summary ==================== Name: Tools-tpr.769 Author: tpr Time: 22 October 2017, 3:53:05.953495 pm UUID: 0879078d-c9fe-4863-814e-dd459c06d9ea Ancestors: Tools-dtl.768 Changes to clean up creation and construction of Browsers. All Browsers can now be made with ToolBuilder open: BrowserClassOfMyChoice except for FileContentsBrowser, which requires setup that doesn't really work as a default thing. =============== Diff against Tools-dtl.768 =============== Item was changed: ----- Method: Browser class>>fullOnClass: (in category 'instance creation') ----- fullOnClass: aClass "Open a new full browser set to class." + "Browser fullOnClass: Browser" + ^ self new - ^ self - openBrowserView: (self new setClass: aClass; + buildAndOpenFullBrowser! - openEditString: nil) - label: nil! Item was changed: ----- Method: Browser class>>fullOnClass:category: (in category 'instance creation') ----- fullOnClass: aClass category: category + "Open a new full browser set to class and message category." + "Browser fullOnClass: Browser category: 'controls' " + ^ self new - ^ self - openBrowserView: (self new setClass: aClass; selectMessageCategoryNamed: category; + buildAndOpenFullBrowser! - openEditString: nil) - label: nil! Item was changed: ----- Method: Browser class>>fullOnClass:selector: (in category 'instance creation') ----- fullOnClass: aClass selector: aSelector + "Open a new full browser set to the class and selector." + "Browser fullOnClass: Browser selector: #defaultWindowColor" - "Open a new full browser set to class." + ^ self new - ^ self - openBrowserView: (self new setClass: aClass selector: aSelector; + buildAndOpenFullBrowser! - openEditString: nil) - label: nil! Item was changed: ----- Method: Browser class>>newOnCategory: (in category 'instance creation') ----- newOnCategory: aCategory + "Open a new browser on this category" - "Browse the system category of the given name. 7/13/96 sw" + "Browser newOnCategory: 'Tools-Browser'" - "Browser newOnCategory: 'Interface-Browser'" + ^self newOnCategory: aCategory label: 'Classes in category ', aCategory - | newBrowser newCat | - newBrowser := self new.. - newCat := aCategory asSymbol. - (newBrowser systemCategoryList includes: newCat) - ifTrue: [ newBrowser selectSystemCategory: newCat ] - ifFalse: [ ^ self inform: 'No such category' ]. - - ^ self - openBrowserView: (newBrowser openSystemCatEditString: nil) - label: 'Classes in category ', aCategory ! Item was added: + ----- Method: Browser class>>newOnCategory:editString:label: (in category 'instance creation') ----- + newOnCategory: aCategory editString: aString label: aLabel + "Open a new browser on this category (testing first for existence) with aString pre-selected in the code pane. + We have to be a bit sneaky to do the string insertion since it cannot be handled until after the actual browser is built and opened" + + "Browser newOnCategory: 'Tools-Browser' editString: 'test string edit setup' label: 'Testing category browser with set edit string'" + + | newBrowser | + newBrowser := self newOnCategory: aCategory label: aLabel. + aString ifNotNil:[newBrowser changed: #editString with: aString]. + ^ newBrowser + + ! Item was added: + ----- Method: Browser class>>newOnCategory:label: (in category 'instance creation') ----- + newOnCategory: aCategory label: aLabel + "Open a new browser on this category (testing first for existence)." + + "Browser newOnCategory: 'Tools-Browser' label: 'Testing category browser'" + + | newBrowser newCat | + newBrowser := self new. + newCat := aCategory asSymbol. + (newBrowser systemCategoryList includes: newCat) + ifTrue: [ newBrowser selectSystemCategory: newCat ] + ifFalse: [ ^ self inform: 'No such category' ]. + + newBrowser buildAndOpenCategoryBrowserLabel: aLabel. + ^ newBrowser + + ! Item was added: + ----- Method: Browser class>>newOnClass:editString:label: (in category 'instance creation') ----- + newOnClass: aClass editString: aString label: aLabel + "Open a new class browser on this class with aString pre-selected in the code pane. + We have to be a bit sneaky to do the string insertion since it cannot be handled until after the actual browser is built and opened" + "Browser newOnClass: Browser editString: 'test string edit setup' label: 'Testing category browser with set edit string'" + | newBrowser| + + newBrowser := self newOnClass: aClass label: aLabel. + newBrowser editSelection: #newMessage. + aString ifNotNil:[newBrowser changed: #editString with: aString]. + ^ newBrowser + ! Item was changed: ----- Method: Browser class>>newOnClass:label: (in category 'instance creation') ----- newOnClass: aClass label: aLabel + "Open a new class browser on this class and set the label." + "Browser newOnClass: Browser label: 'A specific label that I want'" - "Open a new class browser on this class." | newBrowser | newBrowser := self new. newBrowser setClass: aClass. + ^ newBrowser buildAndOpenClassBrowserLabel: aLabel - ^ self - openBrowserView: (newBrowser openOnClassWithEditString: nil) - label: aLabel ! Item was added: + ----- Method: Browser class>>newOnClass:messageCategory: (in category 'instance creation') ----- + newOnClass: aClass messageCategory: aCategory + + ^ self newOnClass: aClass messageCategory: aCategory editString: nil label: 'Message Category Browser (' , aClass name, ')'.! Item was added: + ----- Method: Browser class>>newOnClass:messageCategory:editString:label: (in category 'instance creation') ----- + newOnClass: aClass messageCategory: aCategory editString: aString label: aLabel + "Open a new message protocol browser on this class & protocol with aString pre-selected in the code pane. + We have to be a bit sneaky to do the string insertion since it cannot be handled until after the actual browser is built and opened" + + ^self newOnClass: aClass messageCategory: aCategory selector: nil editString: aString label: aLabel! Item was added: + ----- Method: Browser class>>newOnClass:messageCategory:selector:editString:label: (in category 'instance creation') ----- + newOnClass: aClass messageCategory: aCategory selector: aSelector editString: aString label: aLabel + "Open a new message protocol browser on this class & protocol with aString pre-selected in the code pane. + We have to be a bit sneaky to do the string insertion since it cannot be handled until after the actual browser is built and opened" + "Browser newOnClass: Browser messageCategory: 'controls' selector: #decorateButtons editString: 'test string edit setup' label: 'Testing class browser with set edit string'" + | newBrowser| + + newBrowser := self new. + "setting up a new browser for a specific class, category and selector requires this order of messages + since the #selectMessageCategoryNamed: carefully nils the chosen selector; thus we can't use + the more obvious seeming #setClass:selector: method" + newBrowser setClass: aClass; + selectMessageCategoryNamed: aCategory; + selectMessageNamed: aSelector. + + newBrowser buildAndOpenMessageCategoryBrowserLabel: 'Message Category Browser (' , aClass name, ')'. + aString ifNotNil:[newBrowser changed: #editString with: aString]. + ^newBrowser! Item was changed: ----- Method: Browser class>>newOnClass:selector: (in category 'instance creation') ----- newOnClass: aClass selector: aSymbol "Open a new class browser on this class." + "Browser newOnClass: Browser selector: #decorateButtons" | newBrowser | newBrowser := self new. newBrowser setClass: aClass selector: aSymbol. + ^ newBrowser buildAndOpenClassBrowserLabel: 'Class Browser: ', aClass name - ^ self - openBrowserView: (newBrowser openOnClassWithEditString: nil) - label: 'Class Browser: ', aClass name ! Item was removed: - ----- Method: Browser class>>newOnMessageCategory:inClass: (in category 'instance creation') ----- - newOnMessageCategory: aCategory inClass: aClass - - ^ self - openBrowserView: (self new - setClass: aClass; - selectMessageCategoryNamed: aCategory; - openMessageCatEditString: nil) - label: 'Message Category Browser (' , aClass name, ')'.! Item was changed: ----- Method: Browser class>>openBrowser (in category 'instance creation') ----- openBrowser + "Open a standard system browser with the generic category/class/protocol/message lists" + "Browser openBrowser" - "Create and schedule a BrowserView with default browser label. The - view consists of five subviews, starting with the list view of system - categories of SystemOrganization. The initial text view part is empty." + ^ self new buildAndOpenFullBrowser - | br | - br := self new. - ^ self - openBrowserView: (br openEditString: nil) - label: br defaultBrowserTitle. ! Item was removed: - ----- Method: Browser class>>openBrowserView:label: (in category 'instance creation') ----- - openBrowserView: aBrowserView label: aString - "Schedule aBrowserView, labelling the view aString." - - (aBrowserView isKindOf: ToolBuilderSpec) - ifTrue:[ - (self canUseMultiWindowBrowsers - and: [self useMultiWindowBrowsers]) - ifTrue: [aBrowserView multiWindowStyle: #labelButton]. - aString - ifNil: [ToolBuilder open: aBrowserView] - ifNotNil: [ToolBuilder open: aBrowserView label: aString]] - ifFalse:[ - aBrowserView isMorph - ifTrue: [ - aString ifNotNil: [aBrowserView setLabel: aString]. - aBrowserView openInWorld] - ifFalse: [ - aString ifNotNil: [aBrowserView label: aString]. - aBrowserView minimumSize: 300 @ 200. - aBrowserView subViews do: [:each | each controller]. - aBrowserView controller open]]. - - ^ aBrowserView model - ! Item was changed: ----- Method: Browser class>>prototypicalToolWindow (in category 'instance creation') ----- prototypicalToolWindow "Answer an example of myself seen in a tool window, for the benefit of parts-launching tools" + ^ ToolBuilder default build: self ! - | aWindow | - aWindow := self new openEditString: nil. - ^ ToolBuilder build: aWindow! Item was changed: ----- Method: Browser>>browseAllClasses (in category 'system category functions') ----- browseAllClasses "Create and schedule a new browser on all classes alphabetically." + + ^ClassListBrowser newOnAllClasses! - | newBrowser | - newBrowser := HierarchyBrowser new initAlphabeticListing. - self class openBrowserView: (newBrowser openSystemCatEditString: nil) - label: 'All Classes Alphabetically'! Item was added: + ----- Method: Browser>>buildAndOpenCategoryBrowser (in category 'toolbuilder') ----- + buildAndOpenCategoryBrowser + "assemble the spec for a system category browser, build it and open it - use the default label" + + ^self buildAndOpenCategoryBrowserLabel: nil + ! Item was added: + ----- Method: Browser>>buildAndOpenCategoryBrowserLabel: (in category 'toolbuilder') ----- + buildAndOpenCategoryBrowserLabel: aLabelString + "assemble the spec for a system category browser, build it and open it" + + | builder windowSpec | + builder := ToolBuilder default. + + windowSpec := self buildCategoryBrowserWith: builder. + aLabelString ifNotNil:[:str| windowSpec label: str]. + + builder open: windowSpec. + + ^self + ! Item was added: + ----- Method: Browser>>buildAndOpenClassBrowserLabel: (in category 'toolbuilder') ----- + buildAndOpenClassBrowserLabel: aLabelString + "assemble the spec for a class browser, build it and open it" + + | builder max windowSpec catPaneHeight| + builder := ToolBuilder default. + catPaneHeight := Preferences standardListFont height + 5 "top margin/border" + 5 "bottom margin/border". + max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. + + windowSpec :=self buildWindowWith: builder specs: { + (self topConstantHeightFrame: self buttonHeight fromLeft: 0 width: 0.5) -> [self buildClassListSingletonWith: builder]. + (self frameOffsetFromTop: self buttonHeight fromLeft: 0 width: 0.5 bottomFraction: max) -> [self buildMessageCategoryListWith: builder]. + (self topConstantHeightFrame: self buttonHeight fromLeft: 0.5 width: 0.5) -> [self buildSwitchesWith: builder]. + (self frameOffsetFromTop: self buttonHeight fromLeft: 0.5 width: 0.5 bottomFraction: max) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + windowSpec label: aLabelString. + + builder open: windowSpec. + + ^self + ! Item was added: + ----- Method: Browser>>buildAndOpenFullBrowser (in category 'toolbuilder') ----- + buildAndOpenFullBrowser + "assemble the spec for a full system browser, build it and open it" + + | builder windowSpec | + builder := ToolBuilder default. + + "the build-but-don't-open phase is factored out to support the prototypicalToolWindow facility" + windowSpec := self buildDefaultBrowserWith: builder. + builder open: windowSpec. + + ^self + ! Item was added: + ----- Method: Browser>>buildAndOpenMessageCategoryBrowserLabel: (in category 'toolbuilder') ----- + buildAndOpenMessageCategoryBrowserLabel: aLabelString + "assemble the spec for a messasge category browser, build it and open it" + + | builder max windowSpec| + builder := ToolBuilder default. + max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. + + windowSpec :=self buildWindowWith: builder specs: { + (0@0 corner: 1.0(a)0.08) -> [self buildMessageListCatSingletonWith: builder]. + (0.0(a)0.08 corner: 1.0@max) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + windowSpec label: aLabelString. + + builder open: windowSpec. + + ^self + ! Item was added: + ----- Method: Browser>>buildCategoryBrowserWith: (in category 'toolbuilder') ----- + buildCategoryBrowserWith: builder + "assemble the spec for a system category browser, build it and return it" + + | max windowSpec catPaneHeight| + catPaneHeight := Preferences standardListFont height + 5 "top margin/border" + 5 "bottom margin/border". + max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. + + windowSpec := self buildWindowWith: builder specs: { + (LayoutFrame fractions: (0@0 corner: 1.0@0) offsets: (0@0 corner: 0@catPaneHeight)) -> [self buildSystemCatListSingletonWith: builder]. + ((self classListFrame: max fromTop: 0 fromLeft: 0 width: 0.333) + topOffset: catPaneHeight) -> [self buildClassListWith: builder]. + (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder]. + (LayoutFrame fractions: (0.333@0 corner: 0.666@max) offsets: (0@catPaneHeight corner: 0@0)) -> [self buildMessageCategoryListWith: builder]. + (LayoutFrame fractions: (0.666@0 corner: 1@max) offsets: (0@catPaneHeight corner: 0@0)) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + + ^builder build: windowSpec + ! Item was added: + ----- Method: Browser>>buildDefaultBrowserWith: (in category 'toolbuilder') ----- + buildDefaultBrowserWith: builder + "assemble the spec for a full system browser, build it and return the built but not opened morph" + "this build-but-don't-open phase is factored out to support the prototypicalToolWindow facility" + + | max windowSpec | + max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. + + windowSpec := self buildWindowWith: builder specs: { + (0@0 corner: 0.25@max) -> [self buildSystemCategoryListWith: builder]. + (self classListFrame: max) -> [self buildClassListWith: builder]. + (self switchesFrame: max) -> [self buildSwitchesWith: builder]. + (0.5@0 corner: 0.75@max) -> [self buildMessageCategoryListWith: builder]. + (0.75@0 corner: 1@max) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + + ^builder build: windowSpec! Item was changed: ----- Method: Browser>>buildMessageCategoryBrowserEditString: (in category 'message category functions') ----- buildMessageCategoryBrowserEditString: aString + "Create and schedule a new class browser for the current selection, + with initial textual contents set to aString. This is used specifically in + spawning where a class is established but a method-category is not." + ^ self hasMessageCategorySelected ifTrue: [Browser + newOnClass: self selectedClassOrMetaClass + messageCategory: self selectedMessageCategoryName + selector: self selectedMessageName + editString: aString + label: 'Message category Browser: ' , self selectedClassOrMetaClass name , self categoryOfCurrentMethod]! - "Create and schedule a message category browser for the currently - selected message category. The initial text view contains the characters - in aString." - - ^ self hasMessageCategorySelected ifTrue: [ - (self class - newOnMessageCategory: self selectedMessageCategoryName - inClass: self selectedClassOrMetaClass) - "Select my message." - selectMessageNamed: self selectedMessageName; - yourself]! Item was changed: ----- Method: Browser>>buildSystemCategoryBrowser (in category 'system category functions') ----- buildSystemCategoryBrowser + "Open a new system category browser on the selelcted category, if there is one" - "Create and schedule a new system category browser." + self hasSystemCategorySelected + ifTrue: + [self class newOnCategory: self selectedSystemCategory]! - self buildSystemCategoryBrowserEditString: nil! Item was changed: ----- Method: Browser>>buildSystemCategoryBrowserEditString: (in category 'system category functions') ----- buildSystemCategoryBrowserEditString: aString + "Open a new system category browser on the selelcted category, if + there is one" - "Create and schedule a new system category browser with initial textual - contents set to aString." - - | newBrowser | self hasSystemCategorySelected + ifTrue: [self class + newOnCategory: self selectedSystemCategory + editString: aString + label: 'Classes in category ' , self selectedSystemCategory]! - ifTrue: - [newBrowser := self class new. - newBrowser selectSystemCategory: self selectedSystemCategory. - newBrowser setClass: self selectedClassOrMetaClass selector: self selectedMessageName. - self class openBrowserView: (newBrowser openSystemCatEditString: aString) - label: 'Classes in category ', newBrowser selectedSystemCategory]! Item was changed: ----- Method: Browser>>buildWith: (in category 'toolbuilder') ----- buildWith: builder "Create the ui for the browser" + "Browser is a bit of an oddity in the ToolBuilder>build: world since the class provides several dfferent UIs rather than the one-per-class idiom of ToolBuilder. Here we are building the full browser version" + + ^self buildDefaultBrowserWith: builder ! - | windowSpec max | - max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. - windowSpec := self buildWindowWith: builder specs: { - (0@0 corner: 0.25@max) -> [self buildSystemCategoryListWith: builder]. - (self classListFrame: max fromLeft: 0.25 width: 0.25) -> [self buildClassListWith: builder]. - (self switchesFrame: max fromLeft: 0.25 width: 0.25) -> [self buildSwitchesWith: builder]. - (0.5@0 corner: 0.75@max) -> [self buildMessageCategoryListWith: builder]. - (0.75@0 corner: 1@max) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }. - ^builder build: windowSpec! Item was removed: - ----- Method: Browser>>openEditString: (in category 'initialize-release') ----- - openEditString: aString - "Create a pluggable version of all the views for a Browser, including views and controllers." - "Example: - Browser fullOnClass: Browser. - " - | builder max | - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. - ^self buildWindowWith: builder specs: { - (0@0 corner: 0.25@max) -> [self buildSystemCategoryListWith: builder]. - (self classListFrame: max) -> [self buildClassListWith: builder]. - (self switchesFrame: max) -> [self buildSwitchesWith: builder]. - (0.5@0 corner: 0.75@max) -> [self buildMessageCategoryListWith: builder]. - (0.75@0 corner: 1@max) -> [self buildMessageListWith: builder]. - "(0@max corner: 1(a)0.5) -> [self buildOptionalButtonsWith: builder]." - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }! Item was removed: - ----- Method: Browser>>openMessageCatEditString: (in category 'initialize-release') ----- - openMessageCatEditString: aString - "Create a pluggable version of the views for a Browser that just shows one message category." - "Example: - Preferences browseThemes. - " - | builder max | - aString ifNotNil:[ - "Note: The views aren't actually built yet after we've called buildWindowWith:. - Since we can't send changed: #editString before the views have been built - we just shoot the #changed: message into the #future. This is the easiest - way to solve this issue locally." - self future changed: #editString with: aString]. - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. - ^self buildWindowWith: builder specs: { - (0@0 corner: 1.0(a)0.08) -> [self buildMessageListCatSingletonWith: builder]. - (0.0(a)0.08 corner: 1.0@max) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }.! Item was removed: - ----- Method: Browser>>openOnClassWithEditString: (in category 'initialize-release') ----- - openOnClassWithEditString: aString - "Create a pluggable version of all the views for a Browser, including views and controllers." - "Example: - Browser newOnClass: Browser. - " - | builder max | - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. - ^self buildWindowWith: builder specs: { - (self topConstantHeightFrame: self buttonHeight fromLeft: 0 width: 0.5) -> [self buildClassListSingletonWith: builder]. - (self frameOffsetFromTop: self buttonHeight fromLeft: 0 width: 0.5 bottomFraction: max) -> [self buildMessageCategoryListWith: builder]. - (self topConstantHeightFrame: self buttonHeight fromLeft: 0.5 width: 0.5) -> [self buildSwitchesWith: builder]. - (self frameOffsetFromTop: self buttonHeight fromLeft: 0.5 width: 0.5 bottomFraction: max) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - } - ! Item was removed: - ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') ----- - openSystemCatEditString: aString - "Create a pluggable version of all the views for a Browser, including views and controllers. The top list view is of the currently selected system class category--a single item list." - "Example: - Browser new browseAllClasses. - " - | builder catPaneHeight max | - catPaneHeight := Preferences standardListFont height + 5 "top margin/border" + 5 "bottom margin/border". - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. - ^self buildWindowWith: builder specs: { - (LayoutFrame fractions: (0@0 corner: 1.0@0) offsets: (0@0 corner: 0@catPaneHeight)) -> [self buildSystemCatListSingletonWith: builder]. - ((self classListFrame: max fromTop: 0 fromLeft: 0 width: 0.333) - topOffset: catPaneHeight) -> [self buildClassListWith: builder]. - (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder]. - (LayoutFrame fractions: (0.333@0 corner: 0.666@max) offsets: (0@catPaneHeight corner: 0@0)) -> [self buildMessageCategoryListWith: builder]. - (LayoutFrame fractions: (0.666@0 corner: 1@max) offsets: (0@catPaneHeight corner: 0@0)) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }! Item was added: + ----- Method: Browser>>setMultiWindowFor: (in category 'toolbuilder') ----- + setMultiWindowFor: windowSpec + "set the multi-window style for the windowSpec according to both the users preference and the browser's ability" + (self class canUseMultiWindowBrowsers and: [self class useMultiWindowBrowsers]) + ifTrue: [windowSpec multiWindowStyle: #labelButton]. + + ! Item was changed: ----- Method: Browser>>setSelector: (in category 'initialize-release') ----- setSelector: aSymbol + "Make the receiver point at the given selector, in the currently chosen class. If the selector is found in the class organization we also set the message category to suit" - "Make the receiver point at the given selector, in the currently chosen class" | aClass | aSymbol ifNil: [^ self]. (aClass := self selectedClassOrMetaClass) ifNil: [^ self]. (aClass organization categoryOfElement: aSymbol) ifNil: [^ self] ifNotNil: [:category | self selectMessageCategoryNamed: category; selectMessageNamed: aSymbol].! Item was changed: ----- Method: Browser>>spawn: (in category 'accessing') ----- spawn: aString "Create and schedule a fresh browser and place aString in its code pane. This method is called when the user issues the #spawn command (cmd-o) in any code pane. Whatever text was in the original code pane comes in to this method as the aString argument; the changes in the original code pane have already been cancelled by the time this method is called, so aString is the only copy of what the user had in his code pane." self selectedClassOrMetaClass ifNotNil: [^ super spawn: aString]. self hasSystemCategorySelected ifTrue: + ["Open a browser with the initial codepane string set" - ["This choice is slightly useless but is the historical implementation" ^ self buildSystemCategoryBrowserEditString: aString]. ^ super spawn: aString "This bail-out at least saves the text being spawned, which would otherwise be lost"! Item was changed: HierarchyBrowser subclass: #ClassListBrowser instanceVariableNames: 'defaultTitle' classVariableNames: '' poolDictionaries: '' category: 'Tools-Browser'! + !ClassListBrowser commentStamp: 'tpr 10/15/2017 16:46' prior: 0! - !ClassListBrowser commentStamp: '<historical>' prior: 0! A ClassListBrowser displays the code for an arbitrary list of classes. ClassListBrowser example1. "all classes that have the string 'Pluggable' in their names" ClassListBrowser example2. "all classes whose names start with the letter S" ClassListBrowser example3. "all variable classes" ClassListBrowser example4. "all classes with more than 100 methods" ClassListBrowser example5. "all classes that lack class comments" ClassListBrowser example6. "all classes that have class instance variables" + ClassListBrowser newOnClassesNamed: #(Browser Boolean) label: 'Browser and Boolean!!'. + ClassListBrowser newOnAllClasses "all classes listed alphabetically" - ClassListBrowser new initForClassesNamed: #(Browser Boolean) title: 'Browser and Boolean!!'. ! Item was changed: ----- Method: ClassListBrowser class>>browseClassesSatisfying:title: (in category 'instance creation') ----- browseClassesSatisfying: classBlock title: aTitle "Put up a ClassListBrowser showing all classes that satisfy the classBlock." + self newOnClassesNamed: + (self systemNavigation allClasses select: [:c | (classBlock value: c) == true] + thenCollect: [:c | c name]) + label: aTitle! - self new - initForClassesNamed: - (self systemNavigation allClasses select: - [:c | (classBlock value: c) == true] - thenCollect: - [:c | c name]) - title: - aTitle! Item was changed: ----- Method: ClassListBrowser class>>example2 (in category 'examples') ----- example2 "Put up a ClassListBrowser that shows all classes whose names start with the letter S" + self newOnClassesNamed: (self systemNavigation allClasses - self new - initForClassesNamed: (self systemNavigation allClasses collect: [:c | c name] thenSelect: [:aName | aName first == $S]) + label: 'All classes starting with S' - title: 'All classes starting with S' "ClassListBrowser example2"! Item was added: + ----- Method: ClassListBrowser class>>newOnAllClasses (in category 'instance creation') ----- + newOnAllClasses + "Open a browser on all the classes in the system, listed alphabetically" + "NB - what meaning does 'all classes' have in an environment that is not the root? + - what might alphabetic ordering need to do for non-latin languages?" + "ClassListBrowser newOnAllClasses" + + | newBrowser | + + newBrowser := self new. + ^ newBrowser buildAndOpenBrowserLabel: 'All Classes Alphabetically' + ! Item was added: + ----- Method: ClassListBrowser class>>newOnClassesNamed:label: (in category 'instance creation') ----- + newOnClassesNamed: aListOfClassNames label: aString + "Open a browser on all the classes in the list, set the label to aString since we may need to specify to the user what the list includes" + "ClassListBrowser newOnClassesNamed: #(Browser Boolean) label: 'Browser and Boolean!!'." + | newBrowser | + + newBrowser := self new. + newBrowser initForClassesNamed: aListOfClassNames. + ^ newBrowser buildAndOpenBrowserLabel: aString + ! Item was added: + ----- Method: ClassListBrowser>>defaultBrowserTitle (in category 'initialization') ----- + defaultBrowserTitle + ^ 'Class List Browser' ! Item was added: + ----- Method: ClassListBrowser>>initAlphabeticListing (in category 'initialization') ----- + initAlphabeticListing + | tab stab index | + self systemOrganizer: SystemOrganization. + metaClassIndicated := false. + classDisplayList := Smalltalk classNames.! Item was added: + ----- Method: ClassListBrowser>>initForClassesNamed: (in category 'initialization') ----- + initForClassesNamed: nameList + "Initialize the receiver for the class-name-list" + + self systemOrganizer: SystemOrganization. + metaClassIndicated := false. + classDisplayList := nameList copy! Item was removed: - ----- Method: ClassListBrowser>>initForClassesNamed:title: (in category 'initialization') ----- - initForClassesNamed: nameList title: aTitle - "Initialize the receiver for the class-name-list and title provided" - - self systemOrganizer: SystemOrganization. - metaClassIndicated := false. - defaultTitle := aTitle. - classDisplayList := nameList copy. - self class openBrowserView: (self openSystemCatEditString: nil) - label: aTitle - - "ClassListBrowser new initForClassesNamed: #(Browser CategoryViewer) title: 'Frogs'"! Item was added: + ----- Method: ClassListBrowser>>setupIfNotInitialisedYet (in category 'toolbuilder') ----- + setupIfNotInitialisedYet + "ClassListBrowser needs some initialisation to work in the ToolBuilder>build: world since there has to be a list of classes ready to be listed. As a default we use the full list of classes in the system" + + classDisplayList ifNil:[self initAlphabeticListing]! Item was changed: ----- Method: CodeHolder>>buildClassBrowserEditString: (in category 'construction') ----- buildClassBrowserEditString: aString "Create and schedule a new class browser for the current selection, with initial textual contents set to aString. This is used specifically in spawning where a class is established but a method-category is not." + ^Browser newOnClass: self selectedClassOrMetaClass editString: aString label: 'Class Browser: ', self selectedClassOrMetaClass name - | newBrowser | - newBrowser := Browser new. - newBrowser setClass: self selectedClassOrMetaClass selector: nil. - newBrowser editSelection: #newMessage. - Browser openBrowserView: (newBrowser openOnClassWithEditString: aString) - label: 'Class Browser: ', self selectedClassOrMetaClass name ! Item was added: + ----- Method: CodeHolder>>buildMessageBrowserEditString: (in category 'construction') ----- + buildMessageBrowserEditString: aString + "Create and schedule a new message browser for the current selection, + with initial textual contents set to aString." + ^ Browser + newOnClass: self selectedClassOrMetaClass + messageCategory: self categoryOfCurrentMethod + selector: self selectedMessageName + editString: aString + label: 'Message Browser: ' , self selectedClassOrMetaClass name , self categoryOfCurrentMethod! Item was added: + ----- Method: CodeHolder>>buildMessageCategoryBrowserForClass:selector:editString: (in category 'construction') ----- + buildMessageCategoryBrowserForClass: aClass selector: aSelectorOrNil editString: aString + "Create and schedule a new class browser for the current selection, + with initial textual contents set to aString. This is used specifically in + spawning where a class is established but a method-category is not." + ^ Browser + newOnClass: aClass + messageCategory: self categoryOfCurrentMethod + selector: aSelectorOrNil + editString: aString + label: 'Message category Browser: ' , self selectedClassOrMetaClass name , self categoryOfCurrentMethod! Item was changed: ----- Method: CodeHolder>>spawn: (in category 'commands') ----- spawn: aString "Create and schedule a spawned message category browser for the currently selected message category. The initial text view contains the characters in aString. In the spawned browser, preselect the current selector (if any) as the going-in assumption, though upon acceptance this will often change" + | aCategory aClass | - | newBrowser aCategory aClass | (aClass := self selectedClassOrMetaClass) isNil ifTrue: [^ aString isEmptyOrNil ifFalse: [(Workspace new contents: aString) openLabel: 'spawned workspace']]. (aCategory := self categoryOfCurrentMethod) ifNil: [self buildClassBrowserEditString: aString] ifNotNil: + [self buildMessageCategoryBrowserForClass: aClass selector: self selectedMessageName editString: aString ]! - [newBrowser := Browser new setClass: aClass selector: self selectedMessageName. - self suggestCategoryToSpawnedBrowser: newBrowser. - ^ Browser openBrowserView: (newBrowser openMessageCatEditString: aString) - label: 'category "', aCategory, '" in ', - newBrowser selectedClassOrMetaClassName]! Item was changed: ----- Method: CodeHolder>>spawnToClass: (in category 'commands') ----- spawnToClass: aClass "Used to copy down code from a superclass to a subclass in one easy step, if you know what you're doing. Spawns a new message-category browser for the indicated class, populating it with the source code seen in the current tool." + self categoryOfCurrentMethod - | aCategory newBrowser org | - (aCategory := self categoryOfCurrentMethod) ifNil: [self buildClassBrowserEditString: self contents] ifNotNil: + [self buildMessageCategoryBrowserForClass: aClass selector: nil editString: self contents]! - [((org := aClass organization) categories includes: aCategory) - ifFalse: [org addCategory: aCategory]. - newBrowser := Browser new setClass: aClass selector: nil. - newBrowser selectMessageCategoryNamed: aCategory. - Browser openBrowserView: (newBrowser openMessageCatEditString: self contents) - label: 'category "', aCategory, '" in ', - newBrowser selectedClassOrMetaClassName]! Item was changed: ----- Method: FileContentsBrowser class>>browseFiles: (in category 'instance creation') ----- browseFiles: fileList + "Open a browser on the packages found within the files in the list; we expect the list to contain acceptable filename strings. + If there is more than one package found the browser will be a full system browser, otherwise it will be a category browser" - | browser | Cursor wait showWhile: [ | organizer packageDict | packageDict := Dictionary new. organizer := SystemOrganizer defaultList: Array new. fileList do: [:fileName | | package | package := FilePackage fromFileNamed: fileName. packageDict at: package packageName put: package. organizer classifyAll: package classes keys under: package packageName]. (browser := self systemOrganizer: organizer) packages: packageDict]. + ^ browser buildAndOpenBrowser - self - openBrowserView: browser createViews - label: 'File Contents Browser'. ! Item was changed: ----- Method: FileContentsBrowser class>>browseStream: (in category 'instance creation') ----- browseStream: aStream + + aStream setConverterForCode. - aStream setConverterForCode. self browseStream: aStream named: aStream name! Item was changed: ----- Method: FileContentsBrowser class>>browseStream:named: (in category 'instance creation') ----- browseStream: aStream named: aString + "Read an already opened file stream into a browser" - | browser | Cursor wait showWhile: [ | package packageDict organizer | packageDict := Dictionary new. browser := self new. organizer := SystemOrganizer defaultList: Array new. package := (FilePackage new fullName: aString; fileInFrom: aStream). packageDict at: package packageName put: package. organizer classifyAll: package classes keys under: package packageName. (browser := self systemOrganizer: organizer) packages: packageDict]. + ^ browser buildAndOpenBrowser - self - openBrowserView: browser createViews - label: 'File Contents Browser'. ! Item was added: + ----- Method: FileContentsBrowser>>buildAndOpenBrowser (in category 'toolbuilder') ----- + buildAndOpenBrowser + "assemble the spec for a file contents browser, build it and open it" + "The browser may have either the full 4-pane layout or the simpler 3-pane version, depending on whether we have 1 or more packages to look at" + + contentsSymbol := self defaultDiffsSymbol. "#showDiffs or #prettyDiffs" + + ^ self packages size = 1 + ifTrue:[ + self systemCategoryListIndex: 1. + self buildAndOpenCategoryBrowser] + ifFalse: [self buildAndOpenFullBrowser]! Item was changed: ----- Method: FileContentsBrowser>>buildWith: (in category 'toolbuilder') ----- buildWith: builder + "Depending upon whether we have a single package or multiple packages, we use different window specs. " + self packages ifNil:[^self error: self class name, ' cannot be built without any packages; see class instance creation methods' ]. ^ self packages size = 1 ifTrue:[ + self systemCategoryListIndex: 1; + buildCategoryBrowserWith: builder] - self systemCategoryListIndex: 1. - self openSystemCatEditString: ''] ifFalse: [super buildWith: builder]! Item was removed: - ----- Method: FileContentsBrowser>>createViews (in category 'creation') ----- - createViews - "Create a pluggable version of all the views for a Browser, including views and controllers." - contentsSymbol := self defaultDiffsSymbol. "#showDiffs or #prettyDiffs" - ^self buildWith: ToolBuilder default! Item was changed: + ----- Method: FileContentsBrowser>>defaultBrowserTitle (in category 'toolbuilder') ----- - ----- Method: FileContentsBrowser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle + ^ 'File Contents Browser' ! - ^ 'File Contents Browser'! Item was added: + ----- Method: HierarchyBrowser class>>openBrowser (in category 'instance creation') ----- + openBrowser + "Open a default hierarchy browser on Object - ie the entire class tree, so it may take a moment - with class/protocol/message lists" + "HierarchyBrowser openBrowser" + | newBrowser | + newBrowser := self new initHierarchyForClass: Object. + ^ newBrowser buildAndOpenBrowserLabel: nil + ! Item was removed: - ----- Method: HierarchyBrowser>>assureSelectionsShow (in category 'class list') ----- - assureSelectionsShow - "This is a workaround for the fact that a hierarchy browser, when launched, often does not show the selected class" - - | saveMsgName saveCatName | - saveCatName := self selectedMessageCategoryName. - saveMsgName := self selectedMessageName. - self selectClassNamed: selectedClassName. - self selectMessageCategoryNamed: saveCatName. - self selectMessageNamed: saveMsgName! Item was added: + ----- Method: HierarchyBrowser>>buildAndOpenBrowserLabel: (in category 'toolbuilder') ----- + buildAndOpenBrowserLabel: aLabelString + "assemble the spec for a class list/hierarchy browser, build it and open it" + + | builder windowSpec | + builder := ToolBuilder default. + + windowSpec := self buildDefaultBrowserWith: builder. + aLabelString ifNotNil:[:str| windowSpec label: str]. + + builder open: windowSpec. + + ^self + ! Item was changed: ----- Method: HierarchyBrowser>>buildClassBrowserEditString: (in category 'menu messages') ----- buildClassBrowserEditString: aString + "Open a hierarchy browser on the currently selected class; the string has to be ignored in this case" - "Create and schedule a new class browser for the current selection, if one - exists, with initial textual contents set to aString." self spawnHierarchy! Item was added: + ----- Method: HierarchyBrowser>>buildDefaultBrowserWith: (in category 'toolbuilder') ----- + buildDefaultBrowserWith: builder + "assemble the spec for a hierarchical browser, build it and return the built but not opened morph" + "this build-but-don't-open phase is factored out to support the prototypicalToolWindow facility" + + | max windowSpec | + + + self setupIfNotInitialisedYet. + max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. + + windowSpec := self buildWindowWith: builder specs: { + (self classListFrame: max fromTop: 0 fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder]. + (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder]. + (LayoutFrame fractions: (0.333@0 corner: 0.666@max) offsets: (0@0 corner: 0@0)) -> [self buildMessageCategoryListWith: builder]. + (LayoutFrame fractions: (0.666@0 corner: 1@max) offsets: (0@0 corner: 0@0)) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + + ^builder build: windowSpec! Item was removed: - ----- Method: HierarchyBrowser>>buildWith: (in category 'toolbuilder') ----- - buildWith: builder - ^builder build: (self openSystemCatEditString: '')! Item was changed: ----- Method: HierarchyBrowser>>classList (in category 'class list') ----- classList + "each time we update the class list make sure to check that all the classes we think we should display are in fact in the environment" classDisplayList := classDisplayList select: [:each | (self environment valueOf: each withBlanksTrimmed asSymbol) notNil]. ^ classDisplayList! Item was removed: - ----- Method: HierarchyBrowser>>initAlphabeticListing (in category 'initialization') ----- - initAlphabeticListing - | tab stab index | - self systemOrganizer: SystemOrganization. - metaClassIndicated := false. - classDisplayList := Smalltalk classNames.! Item was changed: ----- Method: HierarchyBrowser>>isHierarchy (in category 'multi-window support') ----- isHierarchy + "This almost certainly needs implementing in ClassListBrowser to return false" ^true! Item was removed: - ----- Method: HierarchyBrowser>>openEditString: (in category 'initialization') ----- - openEditString: aString - "Create a pluggable version of all the views for a HierarchyBrowser, including views and controllers. The top list view is of the currently selected system class category--a single item list." - - ^ self openSystemCatEditString: aString! Item was removed: - ----- Method: HierarchyBrowser>>openSystemCatEditString: (in category 'toolbuilder') ----- - openSystemCatEditString: aString - "Create a pluggable version of all the views for a Browser, including views and controllers. The top list view is of the currently selected system class category--a single item list." - "Example: - Browser new browseAllClasses. - " - | builder catPaneHeight max | - catPaneHeight := Preferences standardListFont height + 5 "top margin/border" + 5 "bottom margin/border". - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4]. - ^self buildWindowWith: builder specs: { - (self classListFrame: max fromTop: 0 fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder]. - (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder]. - (LayoutFrame fractions: (0.333@0 corner: 0.666@max) offsets: (0@0 corner: 0@0)) -> [self buildMessageCategoryListWith: builder]. - (LayoutFrame fractions: (0.666@0 corner: 1@max) offsets: (0@0 corner: 0@0)) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }! Item was added: + ----- Method: HierarchyBrowser>>setupIfNotInitialisedYet (in category 'toolbuilder') ----- + setupIfNotInitialisedYet + "HierarchyBrowser needs some initialisation to work in the ToolBuilder>build: world since there has to be a list of classes ready to be listed. As a default we use the full Object class tree" + classDisplayList ifNil:[ self initHierarchyForClass: Object]! Item was changed: ----- Method: HierarchyBrowser>>systemCatSingletonKey:from: (in category 'menu messages') ----- systemCatSingletonKey: aChar from: aView + "This appears to be obsolete now that the hierarchybrowser has not category view" ^ self systemCatListKey: aChar from: aView! Item was changed: ----- Method: HierarchyBrowser>>systemCatSingletonMenu: (in category 'menu messages') ----- systemCatSingletonMenu: aMenu + "This appears to be obsolete now that the hierarchybrowser has not category view" - ^ aMenu labels: 'find class... (f) browse printOut fileOut update rename... remove' lines: #(1 4) selections: #(findClass buildSystemCategoryBrowser printOutSystemCategory fileOutSystemCategory updateSystemCategories renameSystemCategory removeSystemCategory ) ! Item was removed: - ----- Method: PackagePaneBrowser class>>prototypicalToolWindow (in category 'instance creation') ----- - prototypicalToolWindow - "Answer an example of myself seen in a tool window, for the benefit of parts-launching tools" - - | aWindow | - aWindow := self new openEditString: nil. - ^ ToolBuilder build: aWindow! Item was added: + ----- Method: PackagePaneBrowser>>buildDefaultBrowserWith: (in category 'toolbuilder') ----- + buildDefaultBrowserWith: builder + "assemble the spec for a full 5-pane browser - package, category, class, protocol & message lists, build it and return the built but not opened morph. + the build-but-don't-open phase is factored out to support the prototypicalToolWindow facility" + + "PackagePaneBrowser fullOnClass: Browser." + + | max windowSpec | + max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. + windowSpec := self buildWindowWith: builder specs: { + (0@0 corner: 0.15@max) -> [self buildPackageListWith: builder]. + (0.15@0 corner: 0.35@max) -> [self buildSystemCategoryListWith: builder]. + (self classListFrame: max fromLeft: 0.35 width: 0.25) -> [self buildClassListWith: builder]. + (self switchesFrame: max fromLeft: 0.35 width: 0.25) -> [self buildSwitchesWith: builder]. + (0.6@0 corner: 0.75@max) -> [self buildMessageCategoryListWith: builder]. + (0.75@0 corner: 1@max) -> [self buildMessageListWith: builder]. + (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. + }. + self setMultiWindowFor:windowSpec. + + ^builder build: windowSpec! Item was changed: + ----- Method: PackagePaneBrowser>>buildPackageListWith: (in category 'toolbuilder') ----- - ----- Method: PackagePaneBrowser>>buildPackageListWith: (in category 'initialize-release') ----- buildPackageListWith: builder | listSpec | listSpec := builder pluggableListSpec new. listSpec model: self; list: #packageList; getIndex: #packageListIndex; setIndex: #packageListIndex:; menu: #packageMenu:; keyPress: #packageListKey:from:. ^listSpec ! Item was removed: - ----- Method: PackagePaneBrowser>>openEditString: (in category 'initialize-release') ----- - openEditString: aString - "Create a pluggable version of all the views for a Browser, including views and controllers." - "Example: - PackagePaneBrowser fullOnClass: Browser. - " - | builder max | - builder := ToolBuilder default. - max := self wantsOptionalButtons ifTrue:[0.42] ifFalse:[0.5]. - ^self buildWindowWith: builder specs: { - (0@0 corner: 0.15@max) -> [self buildPackageListWith: builder]. - (0.15@0 corner: 0.35@max) -> [self buildSystemCategoryListWith: builder]. - (self classListFrame: max fromLeft: 0.35 width: 0.25) -> [self buildClassListWith: builder]. - (self switchesFrame: max fromLeft: 0.35 width: 0.25) -> [self buildSwitchesWith: builder]. - (0.6@0 corner: 0.75@max) -> [self buildMessageCategoryListWith: builder]. - (0.75@0 corner: 1@max) -> [self buildMessageListWith: builder]. - (0@max corner: 1@1) -> [self buildCodePaneWith: builder]. - }! Item was changed: StringHolder subclass: #SelectorBrowser instanceVariableNames: 'selectorIndex selectorList classListIndex classList' classVariableNames: '' poolDictionaries: '' category: 'Tools-Browser'! + + !SelectorBrowser commentStamp: 'tpr 10/15/2017 16:42' prior: 0! + A SelectorBrowser is more commonly referred to as the method finder; you can enter message names or more interestingly, example inputs and results to have the system try to find plausible methods that would satisfy the parameters. See SelectorBrowser>>#byExample for much more detail.! Item was changed: ----- Method: StandardToolSet class>>browseMessageCategory:inClass: (in category 'browsing') ----- browseMessageCategory: aCategory inClass: aClass "Open a message category browser." ^ SystemBrowser default + newOnClass: aClass messageCategory: aCategory! - newOnMessageCategory: aCategory inClass: aClass.! Item was changed: ----- Method: StandardToolSet class>>openClassListBrowser:title: (in category 'browsing') ----- openClassListBrowser: anArray title: aString + "Open a class list browser on the list of classes named" + + ^ClassListBrowser newOnClassesNamed: anArray label: aString - "Open a class list browser" - ^ClassListBrowser new initForClassesNamed: anArray title: aString !

1 0

The Trunk: Morphic-eem.1354.mcz
by commits＠source.squeak.org 27 Oct '17

27 Oct '17

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1354.mcz ==================== Summary ==================== Name: Morphic-eem.1354 Author: eem Time: 26 October 2017, 6:19:15.4235 pm UUID: c23cb387-6977-4e21-9a27-f70292843182 Ancestors: Morphic-tpr.1353 Revert change to eyedropper hotspot On 64-bits the ColorPicker gives visibly bogus results with the 6@31 offset. =============== Diff against Morphic-tpr.1353 =============== Item was changed: ----- Method: ColorPickerMorph>>pickUpColorFor: (in category 'menu') ----- pickUpColorFor: aMorph "Show the eyedropper cursor, and modally track the mouse through a mouse-down and mouse-up cycle" | aHand localPt c | aHand := aMorph ifNil: [self activeHand] ifNotNil: [aMorph activeHand]. aHand ifNil: [aHand := self currentHand]. self addToWorld: aHand world near: (aMorph ifNil: [aHand world]) fullBounds. self owner ifNil: [^ self]. aHand showTemporaryCursor: (ScriptingSystem formAtKey: #Eyedropper) + hotSpotOffset: 6 negated @ 4 negated. "<<<< the form was changed a bit??" - hotSpotOffset: 6 @ 31. "<<<< the form was changed a bit??" self updateContinuously: false. [Sensor anyButtonPressed] whileFalse: [self trackColorUnderMouse]. self deleteAllBalloons. localPt := Sensor cursorPoint - self topLeft. self inhibitDragging ifFalse: [ (DragBox containsPoint: localPt) ifTrue: ["Click or drag the drag-dot means to anchor as a modeless picker" ^ self anchorAndRunModeless: aHand]. ]. (clickedTranslucency := TransparentBox containsPoint: localPt) ifTrue: [selectedColor := originalColor]. self updateContinuously: true. [Sensor anyButtonPressed] whileTrue: [self updateTargetColorWith: self indicateColorUnderMouse]. c := self getColorFromKedamaWorldIfPossible: Sensor cursorPoint. c ifNotNil: [selectedColor := c]. aHand newMouseFocus: nil; showTemporaryCursor: nil; flushEvents. self delete. !

1 0

The Trunk: Sound-pre.64.mcz
by commits＠source.squeak.org 27 Oct '17

27 Oct '17

Patrick Rein uploaded a new version of Sound to project The Trunk: http://source.squeak.org/trunk/Sound-pre.64.mcz ==================== Summary ==================== Name: Sound-pre.64 Author: pre Time: 26 October 2017, 5:35:26.194417 pm UUID: 1e82fad7-2c1d-ea42-9b55-cfa86185e99b Ancestors: Sound-eem.63 Enables drag and drop for wave files from the host system. =============== Diff against Sound-eem.63 =============== Item was added: + ----- Method: SampledSound class>>fileReaderServicesForFile:suffix: (in category 'file reader services') ----- + fileReaderServicesForFile: fullName suffix: suffix + + ^ (suffix = 'wav') + ifTrue: [Array with: self serviceLoadingWav] + ifFalse: [#()]! Item was added: + ----- Method: SampledSound class>>fromDroppedWaveFileNamed: (in category 'file reader services') ----- + fromDroppedWaveFileNamed: fileName + + (self fromWaveFileNamed: fileName) explore! Item was changed: ----- Method: SampledSound class>>initialize (in category 'class initialization') ----- initialize "SampledSound initialize" IncrementFractionBits := 16. IncrementScaleFactor := 2 raisedTo: IncrementFractionBits. ScaledIndexOverflow := 2 raisedTo: 29. "handle overflow before needing LargePositiveIntegers" self useCoffeeCupClink. SoundLibrary ifNil: [SoundLibrary := Dictionary new]. Beeper setDefault: (self new setSamples: self coffeeCupClink samplingRate: 12000). + + FileServices registerFileReader: self ! Item was added: + ----- Method: SampledSound class>>serviceLoadingWav (in category 'file reader services') ----- + serviceLoadingWav + + ^ SimpleServiceEntry + provider: self + label: 'load as sound' + selector: #fromDroppedWaveFileNamed: + description: 'load the sound' + buttonLabel: 'load as sound'!

1 0

The Inbox: FFI-Win32-cbc.13.mcz
by commits＠source.squeak.org 25 Oct '17

25 Oct '17

Chris Cunningham uploaded a new version of FFI-Win32 to project The Inbox: http://source.squeak.org/inbox/FFI-Win32-cbc.13.mcz ==================== Summary ==================== Name: FFI-Win32-cbc.13 Author: cbc Time: 25 October 2017, 8:25:54.022628 am UUID: 66fa70bb-22f1-5748-b805-2a201a834489 Ancestors: FFI-Win32-cbc.12 Add descriptive errors for return codes from Wind32Shell. =============== Diff against FFI-Win32-cbc.12 =============== Item was added: + ----- Method: Win32Shell>>error: (in category 'operations') ----- + error: code + Win32ShellErrors signal: code! Item was changed: ----- Method: Win32Shell>>shellExecute: (in category 'operations') ----- shellExecute: aFileString "Opens (without opening a window) the file specified by aFileString. The file can be an executable file, a document file, or a folder." | result fileUrlString | "@@@@ CHECKME - jrd - Hackity, hack, hack, hack. Apparently the Win32 url parser doesn't handle %-encoded colons in file paths properly. So we do the conversion ourselves. I'm not sure if the real problem is that we shouldnt be encoding the colons in the first place." fileUrlString := (aFileString asLowercase beginsWith: 'file:') ifTrue: [(aFileString copyReplaceAll: '%3A' with: ':') copyReplaceAll: '%3a' with: ':' ] ifFalse: [aFileString]. result := self shellExecute: nil lpOperation: 'open' lpFile: fileUrlString lpParameters: nil lpDirectory: nil nShowCmd: 0. + (result <= 32 and: [result >= 0]) ifTrue: [self error: result]! - result <= 32 ifTrue: [self error: 'system error, code:', result printString]! Item was changed: ----- Method: Win32Shell>>shellExplore: (in category 'operations') ----- shellExplore: aPathString "Explores the folder specified by aPathString" | result | result := self shellExecute: nil lpOperation: 'explore' lpFile: aPathString lpParameters: nil lpDirectory: nil nShowCmd: 1. + (result <= 32 and: [result >= 0]) ifTrue: [self error: result]! - result <= 32 ifTrue: [self error: 'system error, code:', result printString]! Item was changed: ----- Method: Win32Shell>>shellFind: (in category 'operations') ----- shellFind: aPathString "Initiates a search starting from the specified directory." | result | result := self shellExecute: nil lpOperation: 'find' lpFile: nil lpParameters: nil lpDirectory: aPathString nShowCmd: 1. + (result <= 32 and: [result >= 0]) ifTrue: [self error: result]! - result <= 32 ifTrue: [self error: 'system error, code:', result printString]! Item was changed: ----- Method: Win32Shell>>shellOpen: (in category 'operations') ----- shellOpen: aFileString "Opens the file specified by aFileString. The file can be an executable file, a document file, or a folder." | result fileUrlString | "@@@@ CHECKME - jrd - Hackity, hack, hack, hack. Apparently the Win32 url parser doesn't handle %-encoded colons in file paths properly. So we do the conversion ourselves. I'm not sure if the real problem is that we shouldnt be encoding the colons in the first place." fileUrlString := (aFileString asLowercase beginsWith: 'file:') ifTrue: [(aFileString copyReplaceAll: '%3A' with: ':') copyReplaceAll: '%3a' with: ':' ] ifFalse: [aFileString]. result := self shellExecute: nil lpOperation: 'open' lpFile: fileUrlString lpParameters: nil lpDirectory: nil nShowCmd: 1. + (result <= 32 and: [result >= 0]) ifTrue: [self error: result]! - result <= 32 ifTrue: [self error: 'system error, code:', result printString]! Item was added: + SharedPool subclass: #Win32ShellErrors + instanceVariableNames: 'errorNumber description' + classVariableNames: 'ERROR_BAD_FORMAT ERROR_FILE_NOT_FOUND ERROR_PATH_NOT_FOUND OUT_OF_MEMORY_OR_RESOURCES SE_ERR_ACCESSDENIED SE_ERR_ACCOSINCOMPLETE SE_ERR_DDEBUSY SE_ERR_DDEFAIL SE_ERR_DDETIMEOUT SE_ERR_DDLNOTFOUND SE_ERR_FNF SE_ERR_NOASSOC SE_ERR_OOM SE_ERR_PNF SE_ERR_SHARE' + poolDictionaries: '' + category: 'FFI-Win32-Examples'! + Win32ShellErrors class + instanceVariableNames: 'errors'! + Win32ShellErrors class + instanceVariableNames: 'errors'! Item was added: + ----- Method: Win32ShellErrors class>>initialize (in category 'as yet unclassified') ----- + initialize + self initializeWindowConstants! Item was added: + ----- Method: Win32ShellErrors class>>initializeWindowConstants (in category 'as yet unclassified') ----- + initializeWindowConstants + OUT_OF_MEMORY_OR_RESOURCES := self new errorNumber: 0; description: 'The operating system is out of memory or resources'. + SE_ERR_FNF := self new errorNumber: 2; description: 'The specified file was not found'. + SE_ERR_PNF := self new errorNumber: 3; description: 'The specified path was not found'. + SE_ERR_ACCESSDENIED := self new errorNumber: 5; description: 'The operating system denied access to the specified file'. + SE_ERR_OOM := self new errorNumber: 8; description: 'There was not enough memory to complete the operation'. + ERROR_BAD_FORMAT := self new errorNumber: 11; description: 'The .EXE file is invalid (non-Win32 .EXE or error in .EXE image)'. + SE_ERR_SHARE := self new errorNumber: 26; description: 'A sharing violation occurred'. + SE_ERR_ACCOSINCOMPLETE := self new errorNumber: 27; description: 'The filename association is incomplete or invalid'. + SE_ERR_DDETIMEOUT := self new errorNumber: 28; description: 'The DDE transaction could not be completed because the request timed out'. + SE_ERR_DDEFAIL := self new errorNumber: 29; description: 'The DDE transaction failed'. + SE_ERR_DDEBUSY := self new errorNumber: 30; description: 'The DDE transaction could not be completed because other DDE transactions were being processed'. + SE_ERR_NOASSOC := self new errorNumber: 31; description: 'There is no application associated with the given filename extension'. + SE_ERR_DDLNOTFOUND := self new errorNumber: 32; description: 'The specified dynamic-link library was not found'. + errors := Dictionary new: (self allInstances size). + self allInstances do: [:err| + errors at: err errorNumber put: err + ].! Item was added: + ----- Method: Win32ShellErrors class>>signal: (in category 'as yet unclassified') ----- + signal: code + | err | + err := errors at: code ifAbsent: [Error signal: 'system error, code:', code]. + Error signal: err errorString! Item was added: + ----- Method: Win32ShellErrors>>description (in category 'accessing') ----- + description + + ^ description + ! Item was added: + ----- Method: Win32ShellErrors>>description: (in category 'accessing') ----- + description: anObject + + description := anObject. + ! Item was added: + ----- Method: Win32ShellErrors>>errorNumber (in category 'accessing') ----- + errorNumber + + ^ errorNumber + ! Item was added: + ----- Method: Win32ShellErrors>>errorNumber: (in category 'accessing') ----- + errorNumber: anObject + + errorNumber := anObject. + ! Item was added: + ----- Method: Win32ShellErrors>>errorString (in category 'accessing') ----- + errorString + ^'system error, code: ', errorNumber, ' "', description, '"'!

2 1

Re: [squeak-dev] [Pharo-dev] [ANNOUNCE] ParrotTalk release/design change considerations
by henry 24 Oct '17

24 Oct '17

Please see version 3.6 proposed for a new dual protocol. https://github.com/ZiroZimbarra/callistohouse/blob/master/docs/ParrotTalkFr… - HH > -------- Original Message -------- > Subject: Re: [Pharo-dev] [ANNOUNCE] ParrotTalk release/design change considerations > Local Time: October 24, 2017 1:42 PM > UTC Time: October 24, 2017 5:42 PM > From: henry(a)callistohouse.club > To: Stephane Ducasse <stepharo.self(a)gmail.com>, Pharo Development List <pharo-dev(a)lists.pharo.org> > > Please excuse all the low-level detail, if inappropriate to the discussion. The protocol changes are here specified. > > - HH > > On Tue, Oct 24, 2017 at 13:40, henry <[henry(a)callistohouse.club]("mailto:henry@callistohouse.club")> wrote: > >> In order to bring ParrotTalk-3.6 support, alongside historical 3.5 support, the frame header stays the same and the processing of the ProtocolOffered would select "ParrotTalk-3.6" to use the compact protocol of >> >> - ProtocolOffered { offered, preferred } >> - ProtocolAccepted { accepted } >> - IWant|GiveInfo|ReplyInfo { vatId, domain, publicKey, cryptoProtocols, dataEncoders } >> - IAm|ReplyInfo { vatId, domain, publicKey, cryptoProtocol, dataEncoder, dhParam } >> - Go { cryptoProtocol, dataEncoder, dhParam, signature } >> - GoToo { signature } >> >> Using eLinda : >> >> [http://www.squeaksource.com/Cryptography/elinda-HenryHouse.14.mcz]("http://www.squeaksource.com/Cryptography/elinda-HenryHouse.14.mcz") >> >> Above the FrameBuffer, below the SessionOperations for each version of the protocol, an ELindaSession could be inserted. This session think would have the stacks for each protocol version SessionOperation registered by protocol in a Tuple, for eventual callback. When the ProtocolOffered comes in we publish the tuple frame, with set selected version, to route to the correct SessionOperation to support each version of the protocol. >> >> With a non-specific vatId required, anonymous connections would be supported. >> >> - HH >> >> On Tue, Oct 24, 2017 at 12:52, Stephane Ducasse <[stepharo.self(a)gmail.com](""mailto:stepharo.self@gmail.com"")> wrote: >> >>> Hi henry thanks for this announce. Can you tell where such protocols are used? Stef On Tue, Oct 24, 2017 at 6:33 PM, henry wrote: > Hi all, > > I am happy to announce the release of version 3.5 of ParrotTalk, for Squeak > and Pharo, found here: > > http://www.squeaksource.com/Cryptography/ParrotTalk-zzz.2.mcz > > It follows this specification: > https://github.com/ZiroZimbarra/callistohouse/blob/master/docs/ParrotTalkFr… > > One item of note, in version 3.5, the system connecting to a server, sending > the IWant msg, must know the vatId of the system being connected to. I am > considering changing this to version 3.6 by removing one round-trip in > messaging. Therefore, these messages would be combined: IWant/GiveInfo, > IAm/ReplyInfo. I will keep ProtocolOffered and ProtocolAccepted to allow > eLindaSession to support both versions: 3.5 and 3.6. > > Thoughts please? > > - HH

1 0

← Newer
1
2
3
4
5
6
7
...
14
Older →

Jump to page: