Squeak-dev August 2020

squeak-dev@lists.squeakfoundation.org

47 participants
169 discussions

The Trunk: SUnitGUI-ct.81.mcz
by commits＠source.squeak.org 23 Aug '20

23 Aug '20

Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-ct.81.mcz ==================== Summary ==================== Name: SUnitGUI-ct.81 Author: ct Time: 22 August 2020, 8:03:59.041378 pm UUID: 73e8b227-7520-354a-986c-5e8a5991afc6 Ancestors: SUnitGUI-mt.79 Fix selection updates in TestRunner by sending missing observer updates. Same reason as ToolBuilder-Morphic-ct.253. =============== Diff against SUnitGUI-mt.79 =============== Item was changed: ----- Method: TestRunner>>categoryAt:put: (in category 'accessing-categories') ----- categoryAt: anInteger put: aBoolean categoriesSelected := categoriesSelected perform: (aBoolean ifTrue: [ #copyWith: ] ifFalse: [ #copyWithout: ]) with: (categories at: anInteger ifAbsent: [ ^ self ]). + self + changed: #categoryAt:; + changed: #categorySelected; + updateClasses.! - self changed: #categorySelected; updateClasses.! Item was changed: ----- Method: TestRunner>>classAt:put: (in category 'accessing-classes') ----- classAt: anInteger put: aBoolean classesSelected := classesSelected perform: (aBoolean ifTrue: [ #copyWith: ] ifFalse: [ #copyWithout: ]) with: (classes at: anInteger ifAbsent: [ ^ self ]). + self + changed: #classAt:; + changed: #classSelected; + changed: #hasRunnable.! - self changed: #classSelected; changed: #hasRunnable.!

1 0

The Trunk: Tools-ct.985.mcz
by commits＠source.squeak.org 23 Aug '20

23 Aug '20

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.985.mcz ==================== Summary ==================== Name: Tools-ct.985 Author: ct Time: 22 August 2020, 8:05:25.644378 pm UUID: fcb716be-e917-2646-ade9-4c4550088392 Ancestors: Tools-eem.984 Fix selection updates in ChangeList by sending missing observer updates. Same reason as ToolBuilder-Morphic-ct.253. I also re-checked all other senders of #setSelectionList: in the Trunk image and did not found any further invalidation problems. =============== Diff against Tools-eem.984 =============== Item was changed: ----- Method: ChangeList>>listSelectionAt:put: (in category 'viewing access') ----- listSelectionAt: index put: value listSelections at: index put: value. + self + changed: #listSelectionAt:; + changed: #listIndex. - self changed: #listIndex. ^ value!

1 0

The Trunk: Kernel-ct.1338.mcz
by commits＠source.squeak.org 23 Aug '20

23 Aug '20

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1338.mcz ==================== Summary ==================== Name: Kernel-ct.1338 Author: ct Time: 22 August 2020, 8:18:22.970378 pm UUID: 2ab1921f-016a-7044-9b35-75f940130863 Ancestors: Kernel-dtl.1336 Break dependents when copying a model For the full discussion, see this thread: http://forum.world.st/Bug-in-copy-td5120761.html =============== Diff against Kernel-dtl.1336 =============== Item was added: + ----- Method: Model>>postCopy (in category 'copying') ----- + postCopy + + super postCopy. + self breakDependents.!

1 0

The Trunk: KernelTests-ct.385.mcz
by commits＠source.squeak.org 23 Aug '20

23 Aug '20

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.385.mcz ==================== Summary ==================== Name: KernelTests-ct.385 Author: ct Time: 22 August 2020, 8:20:01.189378 pm UUID: 7b38e1cc-215c-8446-999e-0b702ed39766 Ancestors: KernelTests-eem.384 Test copying of the dependents array Complements Kernel-ct.1338. For more details, see http://forum.world.st/Bug-in-copy-td5120761.html. =============== Diff against KernelTests-eem.384 =============== Item was changed: SystemOrganization addCategory: #'KernelTests-Classes'! SystemOrganization addCategory: #'KernelTests-Methods'! SystemOrganization addCategory: #'KernelTests-Numbers'! SystemOrganization addCategory: #'KernelTests-Objects'! SystemOrganization addCategory: #'KernelTests-Processes'! SystemOrganization addCategory: #'KernelTests-WriteBarrier'! + SystemOrganization addCategory: #'KernelTests-Models'! Item was added: + TestCase subclass: #ModelTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Models'! Item was added: + ----- Method: ModelTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Model new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.! Item was added: + ----- Method: ObjectTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Object new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.!

1 0

Bug in #copy?
by Thiede, Christoph 23 Aug '20

23 Aug '20

Hi all, please consider the following snippet and its output: o := Object new. o addDependent: 42. o copy dependents. "#()" In my opinion, this behavior is misleading for two reasons: 1. #copy is documented as to "answer another instance just like the receiver." From an abstract view of the object, this should include the object's dependents, too. Afaik, DependentsFields is only an implementation detail, but in common sense, the dependents are just another part of the object. 2. If you run exactly the same snippet with a Model instead of an Object (which implements dependencies in a different way under the hood), the copied object will contain the original dependencies, still. I think we should unify this undocumented and unintuitive discrepancy. The Model documentation states it features "fast dependents maintenance" so the behavior should be kept, just optimized. How do you think about this? Can we change the Object behavior or could this introduce any unpredictable consequences? And how could we fix it? And what about #shallowCopy? Unfortunately, it is called directly by more than a hundred senders in the Trunk image. Because DependentsFields is an implementation detail, I wonder whether #shallowCopy should copy the dependents as well. Should we move the actual primitive method to something like #primShallowCopy and in #shallowCopy, update DependentsFields after calling the primitive? Or do we rather consider #shallowCopy as a low-level method (similar to #veryDeepCopyWith: as apposed to #veryDeepCopy) and call it a code smell to call #shallowCopy from a far-away place? And LBNL: What should the following snippet output in your opinion? o1 := Object new. o1 addDependent: 42. o2 := o1 shallowCopy. o1 addDependent: 43. o2 dependents asArray. Should it answer: a) #(), b) #(42), or c) #(42 43)? :D I am looking forward to your opinions! :-) Best, Christoph

5 6

The Inbox: KernelTests-ct.385.mcz
by commits＠source.squeak.org 22 Aug '20

22 Aug '20

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-ct.385.mcz ==================== Summary ==================== Name: KernelTests-ct.385 Author: ct Time: 22 August 2020, 8:20:01.189378 pm UUID: 7b38e1cc-215c-8446-999e-0b702ed39766 Ancestors: KernelTests-eem.384 Test copying of the dependents array Complements Kernel-ct.1338. For more details, see http://forum.world.st/Bug-in-copy-td5120761.html. =============== Diff against KernelTests-eem.384 =============== Item was changed: SystemOrganization addCategory: #'KernelTests-Classes'! SystemOrganization addCategory: #'KernelTests-Methods'! SystemOrganization addCategory: #'KernelTests-Numbers'! SystemOrganization addCategory: #'KernelTests-Objects'! SystemOrganization addCategory: #'KernelTests-Processes'! SystemOrganization addCategory: #'KernelTests-WriteBarrier'! + SystemOrganization addCategory: #'KernelTests-Models'! Item was added: + TestCase subclass: #ModelTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Models'! Item was added: + ----- Method: ModelTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Model new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.! Item was added: + ----- Method: ObjectTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Object new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.!

1 0

The Inbox: Kernel-ct.1338.mcz
by commits＠source.squeak.org 22 Aug '20

22 Aug '20

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1338.mcz ==================== Summary ==================== Name: Kernel-ct.1338 Author: ct Time: 22 August 2020, 8:18:22.970378 pm UUID: 2ab1921f-016a-7044-9b35-75f940130863 Ancestors: Kernel-dtl.1336 Break dependents when copying a model For the full discussion, see this thread: http://forum.world.st/Bug-in-copy-td5120761.html =============== Diff against Kernel-dtl.1336 =============== Item was added: + ----- Method: Model>>postCopy (in category 'copying') ----- + postCopy + + super postCopy. + self breakDependents.!

1 0

The Inbox: Tools-ct.985.mcz
by commits＠source.squeak.org 22 Aug '20

22 Aug '20

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.985.mcz ==================== Summary ==================== Name: Tools-ct.985 Author: ct Time: 22 August 2020, 8:05:25.644378 pm UUID: fcb716be-e917-2646-ade9-4c4550088392 Ancestors: Tools-eem.984 Fix selection updates in ChangeList by sending missing observer updates. Same reason as ToolBuilder-Morphic-ct.253. I also re-checked all other senders of #setSelectionList: in the Trunk image and did not found any further invalidation problems. =============== Diff against Tools-eem.984 =============== Item was changed: ----- Method: ChangeList>>listSelectionAt:put: (in category 'viewing access') ----- listSelectionAt: index put: value listSelections at: index put: value. + self + changed: #listSelectionAt:; + changed: #listIndex. - self changed: #listIndex. ^ value!

1 0

The Inbox: SUnitGUI-ct.81.mcz
by commits＠source.squeak.org 22 Aug '20

22 Aug '20

A new version of SUnitGUI was added to project The Inbox: http://source.squeak.org/inbox/SUnitGUI-ct.81.mcz ==================== Summary ==================== Name: SUnitGUI-ct.81 Author: ct Time: 22 August 2020, 8:03:59.041378 pm UUID: 73e8b227-7520-354a-986c-5e8a5991afc6 Ancestors: SUnitGUI-mt.79 Fix selection updates in TestRunner by sending missing observer updates. Same reason as ToolBuilder-Morphic-ct.253. =============== Diff against SUnitGUI-mt.79 =============== Item was changed: ----- Method: TestRunner>>categoryAt:put: (in category 'accessing-categories') ----- categoryAt: anInteger put: aBoolean categoriesSelected := categoriesSelected perform: (aBoolean ifTrue: [ #copyWith: ] ifFalse: [ #copyWithout: ]) with: (categories at: anInteger ifAbsent: [ ^ self ]). + self + changed: #categoryAt:; + changed: #categorySelected; + updateClasses.! - self changed: #categorySelected; updateClasses.! Item was changed: ----- Method: TestRunner>>classAt:put: (in category 'accessing-classes') ----- classAt: anInteger put: aBoolean classesSelected := classesSelected perform: (aBoolean ifTrue: [ #copyWith: ] ifFalse: [ #copyWithout: ]) with: (classes at: anInteger ifAbsent: [ ^ self ]). + self + changed: #classAt:; + changed: #classSelected; + changed: #hasRunnable.! - self changed: #classSelected; changed: #hasRunnable.!

1 0

base64 encoding and CRs
by tim Rowledge 22 Aug '20

22 Aug '20

As best I can see base64 encoding never results in the output having Character cr embedded, right? Why would I ask such a dumb question? Because I'm looking at some code that carefully does a copyReplaceAll: on a base64 encoded String that was a bitmap, and I can't imagine how that could ever not corrupt the bitmap *if* there were any chance it did indeed include CRs. And it's late on a Friday and to be honest, anything could be possible in 2020. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- His spirit guide is a three-toed sloth.

5 7

← Newer
1
...
8
9
10
11
12
13
14
...
17
Older →

Jump to page: