Squeak-dev August 2020

squeak-dev@lists.squeakfoundation.org

47 participants
169 discussions

The Inbox: EToys-ct.401.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.401.mcz ==================== Summary ==================== Name: EToys-ct.401 Author: ct Time: 20 August 2020, 2:36:39.45064 pm UUID: 5a05fe89-08aa-424a-b94a-b55283faff49 Ancestors: EToys-eem.400 Complements 60Deprecated-ct.80 (deprecation #doWithIndex: & Co.). =============== Diff against EToys-eem.400 =============== Item was changed: ----- Method: BookMorph>>saveBookForRevert (in category '*Etoys-Squeakland-master pages') ----- saveBookForRevert "Consider this the master version of the book, with regard to which pages are in it, what their order is, and what their content is" | forRevert | forRevert := OrderedCollection new. + pages withIndexDo: - pages doWithIndex: [: pg :index | pg setProperty: #revertKey toValue: index. forRevert add: (index -> pg copy)]. self setProperty:# pagesForRevert toValue: forRevert! Item was changed: ----- Method: Chess960Morph>>reinstallPieces (in category 'resizing') ----- reinstallPieces + board whitePlayer pieces withIndexDo: [:pc :n | - board whitePlayer pieces doWithIndex: [:pc :n | pc isZero ifFalse: [ self addedPiece: pc at: n white: true]]. + board blackPlayer pieces withIndexDo: [:pc :n | - board blackPlayer pieces doWithIndex: [:pc :n | pc isZero ifFalse: [ self addedPiece: pc at: n white: false]].! Item was changed: ----- Method: Chess960Player>>addBlackPieces: (in category 'adding/removing') ----- addBlackPieces: aChess960Configuration self configuration: aChess960Configuration. + configuration positions withIndexDo: [:p :n | self addPiece: p at: 56+n]. - configuration positions doWithIndex: [:p :n | self addPiece: p at: 56+n]. 49 to: 56 do:[:i| self addPiece: Pawn at: i].! Item was changed: ----- Method: Chess960Player>>addWhitePieces: (in category 'adding/removing') ----- addWhitePieces: aChess960Configuration self configuration: aChess960Configuration. + configuration positions withIndexDo: [:p :n | self addPiece: p at: n]. - configuration positions doWithIndex: [:p :n | self addPiece: p at: n]. 9 to: 16 do:[:i| self addPiece: Pawn at: i]. ! Item was changed: ----- Method: ChineseCheckers>>drawOn: (in category 'drawing') ----- drawOn: aCanvas | row1 row2 offset dotExtent | super drawOn: aCanvas. "Draw square board" "Only draw rows in the clipping region" dotExtent := (self width//25) asPoint. offset := self pieceSize - dotExtent + 1 // 2. "Offset of smaller dots rel to larger" row1 := (self boardLocAt: aCanvas clipRect topLeft) x max: 1. row2 := (self boardLocAt: aCanvas clipRect bottomRight) x min: board size. row1 to: row2 do: + [:row | (board at: row) withIndexDo: - [:row | (board at: row) doWithIndex: [:cell :i | cell ifNotNil: [aCanvas fillOval: ((self cellPointAt: (row@i)) + offset extent: dotExtent) color: (colors at: cell+1)]]]! Item was changed: ----- Method: CipherPanel>>encodedQuote: (in category 'initialization') ----- encodedQuote: aString "World addMorph: CipherPanel new" | morph prev | aString isEmpty ifTrue: [^ self]. (letterMorphs isNil or: [self isClean]) ifFalse: [(self confirm: 'Are you sure you want to discard all typing?' translated) ifFalse: [^ self]]. haveTypedHere := false. quote := aString asUppercase. prev := nil. originalMorphs := quote asArray + withIndexCollect: [:c :i | WordGameLetterMorph new plain indexInQuote: i id1: nil; - collectWithIndex: [:c :i | WordGameLetterMorph new plain indexInQuote: i id1: nil; setLetter: (quote at: i)]. letterMorphs := OrderedCollection new. decodingMorphs := quote asArray + withIndexCollect: [:c :i | (quote at: i) isLetter - collectWithIndex: [:c :i | (quote at: i) isLetter ifTrue: [morph := WordGameLetterMorph new underlined indexInQuote: i id1: nil. morph on: #mouseDown send: #mouseDownEvent:letterMorph: to: self. morph on: #keyStroke send: #keyStrokeEvent:letterMorph: to: self. letterMorphs addLast: morph. morph predecessor: prev. prev ifNotNil: [prev successor: morph]. prev := morph] ifFalse: [WordGameLetterMorph new plain indexInQuote: i id1: nil; setLetter: (quote at: i)]]. self color: originalMorphs first color. self extent: 500 @ 500! Item was changed: ----- Method: DocLibrary>>saveDocCheck: (in category 'doc pane') ----- saveDocCheck: aMorph "Make sure the document gets attached to the version of the code that the user was looking at. Is there a version of this method in a changeSet beyond the updates we know about? Works even when the user has internal update numbers and the documentation is for external updates (It always is)." | classAndMethod parts selector class lastUp beyond ours docFor unNum ok key verList ext response | classAndMethod := aMorph valueOfProperty: #classAndMethod. classAndMethod ifNil: [ ^ self error: 'need to know the class and method']. "later let user set it" parts := classAndMethod findTokens: ' .'. selector := parts last asSymbol. class := Smalltalk at: (parts first asSymbol) ifAbsent: [^ self saveDoc: aMorph]. parts size = 3 ifTrue: [class := class class]. "Four indexes we are looking for: docFor = highest numbered below lastUpdate that has method. unNum = a higher unnumbered set that has method. lastUp = lastUpdate we know about in methodVersions beyond = any set about lastUp that has the method." + ChangeSet allChangeSets withIndexDo: [:cs :ind | "youngest first" - ChangeSet allChangeSets doWithIndex: [:cs :ind | "youngest first" (cs name includesSubstring: lastUpdateName) ifTrue: [lastUp := ind]. (cs atSelector: selector class: class) ~~ #none ifTrue: [ lastUp ifNotNil: [beyond := ind. ours := cs name] ifNil: [cs name first isDigit ifTrue: [docFor := ind] ifFalse: [unNum := ind. ours := cs name]]]]. "See if version the user sees is the version he is documenting" ok := beyond == nil. unNum ifNotNil: [docFor ifNotNil: [ok := docFor > unNum] ifNil: [ok := false]]. "old changeSets gone" ok ifTrue: [^ self saveDoc: aMorph]. key := DocLibrary properStemFor: classAndMethod. verList := (methodVersions at: key ifAbsent: [#()]), #(0 0). ext := verList first. "external update number we will write to" response := (PopUpMenu labels: 'Cancel\Broadcast Page' withCRs) startUpWithCaption: 'You are documenting a method in External Update ', ext asString, '.\There is a more recent version of that method in ' withCRs, ours, '.\If you are explaining the newer version, please Cancel.\Wait until that version appears in an External Update.' withCRs. response = 2 ifTrue: [self saveDoc: aMorph]. ! Item was changed: ----- Method: EventRollMorph>>setMediaEventMorphs (in category 'display') ----- setMediaEventMorphs "Place morphs representing the media track on the roll." | aMorph aWheel | mediaTrack ifEmpty: [^ self]. aWheel := Color wheel: mediaTrack size. + mediaTrack withIndexDo: - mediaTrack doWithIndex: [:evt :index | aMorph := MediaEventMorph new. aMorph hResizing: #shrinkWrap. aMorph vResizing: #shrinkWrap. aMorph color: ((aWheel at: index) alpha: 0.5). aMorph event: evt. aMorph extent: ((evt durationInMilliseconds / millisecondsPerPixel) @ 32). aMorph left: ((evt timeStamp - startTime)/ millisecondsPerPixel). aMorph top: 84. actualRoll addMorphBack: aMorph]! Item was changed: ----- Method: MentoringEventRecorder>>mergeMediaEvent: (in category 'event handling') ----- mergeMediaEvent: anEvent "Merge the event, presently time-stamped with a relative time-stamp., with my existing tape. Answer the merged tape. It is the responsibility of the sender to notify other objects that may be interested in the change, such as an event roll." | itsTimeStamp eventFollowingIt newTape anIndex itsCopy copysTimeStamp | itsTimeStamp := anEvent timeStamp. itsCopy := anEvent copy. itsCopy timeStamp: (copysTimeStamp := itsTimeStamp + tape first timeStamp). eventFollowingIt := tape detect: [:evt | evt timeStamp > copysTimeStamp] ifNone: [nil]. anIndex := eventFollowingIt ifNil: [tape size + 1] ifNotNil: [tape indexOf: eventFollowingIt]. newTape := Array streamContents: [:aStream | + tape withIndexDo: - tape doWithIndex: [:evt :index | index = anIndex ifTrue: [aStream nextPut: itsCopy]. aStream nextPut: evt]. anIndex > tape size ifTrue: [aStream nextPut: itsCopy]]. tape := newTape! Item was changed: ----- Method: MouseEventEditor>>initializeFor:forEventRoll: (in category 'initialization') ----- initializeFor: aMouseEventSequenceMorph forEventRoll: aRoll "Initialize the receiver as an editor for the given mouse-event-sequence and event-roll." | aTheatre aMorph | self color: (Color green muchLighter alpha: 0.7). aTheatre := aRoll eventTheatre. mouseEventSequenceMorph := aMouseEventSequenceMorph. self extent: aTheatre initialContentArea extent. self setNameTo: 'mouse event editor'. + mouseEventSequenceMorph events withIndexDo: - mouseEventSequenceMorph events doWithIndex: [:evt :index | aMorph := self discRepresentingEvent: evt index: index. aMorph center: evt position - aTheatre initialContentArea topLeft. self addMorphFront: aMorph]! Item was changed: ----- Method: Player>>absorbBackgroundDataFrom:forInstanceVariables: (in category 'slots-kernel') ----- absorbBackgroundDataFrom: aLine forInstanceVariables: slotNames "Fill my background fields from the substrings in a tab-delimited line of data. At the moment this only really cateres to string-valued items" + slotNames withIndexDo: - slotNames doWithIndex: [:aSlotName :anIndex | aLine do: [:aValue | self instVarNamed: aSlotName put: aValue] toFieldNumber: anIndex]! Item was changed: ----- Method: Player>>universalTilesForInterface: (in category 'scripts-kernel') ----- universalTilesForInterface: aMethodInterface "Return universal tiles for the given method interface. Record who self is." | ms itsSelector argList makeSelfGlobal phrase aType | itsSelector := aMethodInterface selector. argList := OrderedCollection new. + aMethodInterface argumentVariables withIndexDo: - aMethodInterface argumentVariables doWithIndex: [:anArgumentVariable :anIndex | | argTile | argTile := ScriptingSystem tileForArgType: (aType := aMethodInterface typeForArgumentNumber: anIndex). argList add: (aType == #Player ifTrue: [argTile actualObject] ifFalse: [argTile literal]). "default value for each type"]. ms := MessageSend receiver: self selector: itsSelector arguments: argList asArray. "For CardPlayers, use 'self'. For others, name me, and use my global name." makeSelfGlobal := self class officialClass ~~ CardPlayer. phrase := ms asTilesIn: self class globalNames: makeSelfGlobal. makeSelfGlobal ifFalse: [phrase setProperty: #scriptedPlayer toValue: self]. ^ phrase ! Item was changed: ----- Method: QuickGuideMorph class>>getWordyName:forCategory: (in category 'initialization') ----- getWordyName: guideName forCategory: guideCategory "With guideName and category already filled in, make a name in words. Remove the cat name, and trailing digits. Separate words at capital letters. NavBarHowToUse3 -> 'How To Use' " | gn mm tt | gn := guideName allButFirst: guideCategory size. gn := gn withoutTrailingDigits. mm := gn size. + gn reversed withIndexDo: [:cc :ind | - gn reversed doWithIndex: [:cc :ind | ind < mm ifTrue: [ cc isUppercase ifTrue: [ tt := mm + 1 - ind. gn := (gn copyFrom: 1 to: tt-1), ' ', (gn copyFrom: tt to: gn size)]. cc == $- ifTrue: [ tt := mm + 1 - ind. gn at: tt put: $ ]. "convert dash to space" ]]. ^ gn! Item was changed: ----- Method: ScriptEditorMorph>>indexOfMorphAbove: (in category 'dropping/grabbing') ----- indexOfMorphAbove: aPoint "Return index of lowest morph whose bottom is above aPoint. Will return 0 if the first morph is not above aPoint" + submorphs withIndexDo: - submorphs doWithIndex: [:m :i | m fullBounds bottom >= aPoint y ifTrue: [^ (i max: firstTileRow) - 1]]. ^ submorphs size! Item was changed: ----- Method: ScriptEditorMorph>>reinsertSavedTiles: (in category 'other') ----- reinsertSavedTiles: savedTiles "Revert the scriptor to show the saved tiles" + self submorphs withIndexDo: [:m :i | i > 1 ifTrue: [m delete]]. - self submorphs doWithIndex: [:m :i | i > 1 ifTrue: [m delete]]. self addAllMorphs: savedTiles. self allMorphsDo: [:m | m isTileScriptingElement ifTrue: [m bringUpToDate]]. self install. self showingMethodPane: false! Item was changed: ----- Method: SmalltalkImage>>macVmMajorMinorBuildVersion (in category '*Etoys-Squeakland-system attribute') ----- macVmMajorMinorBuildVersion "SmalltalkImage current macVmMajorMinorBuildVersion" | aString rawTokens versionPart versionTokens versionArray | aString := self vmVersion. aString ifNil: [^ #(0 0 0)]. rawTokens := ((aString copyAfterLast: $]) findTokens: $ ). versionPart := rawTokens detect: [:each | each includes: $.] ifNone: [^#(0 0 0)]. versionTokens := versionPart findTokens: $.. + versionArray := #(0 0 0) withIndexCollect: [:each :index | - versionArray := #(0 0 0) collectWithIndex: [:each :index | (versionTokens at: index ifAbsent:['']) initialIntegerOrNil ifNil: [each]]. ^versionArray! Item was changed: ----- Method: StackMorph>>getAllText (in category 'menu') ----- getAllText "Collect the text for each card. Just point at strings so don't have to recopy them. (Parallel array of urls for ID of cards. Remote cards not working yet.) allText = Array (cards size) of arrays (fields in it) of strings of text. allTextUrls = Array (cards size) of urls or card numbers." | oldUrls oldStringLists allText allTextUrls | self writeSingletonData. oldUrls := self valueOfProperty: #allTextUrls ifAbsent: [#()]. oldStringLists := self valueOfProperty: #allText ifAbsent: [#()]. allText := self privateCards collect: [:pg | OrderedCollection new]. allTextUrls := Array new: self privateCards size. + self privateCards withIndexDo: [:aCard :ind | | aUrl which | - self privateCards doWithIndex: [:aCard :ind | | aUrl which | aUrl := aCard url. aCard isInMemory ifTrue: [(allText at: ind) addAll: (aCard allStringsAfter: nil). aUrl ifNil: [aUrl := ind]. allTextUrls at: ind put: aUrl] ifFalse: ["Order of cards on server may be different. (later keep up to date?)" "*** bug in this algorithm if delete a page?" which := oldUrls indexOf: aUrl. allTextUrls at: ind put: aUrl. which = 0 ifFalse: [allText at: ind put: (oldStringLists at: which)]]]. self setProperty: #allText toValue: allText. self setProperty: #allTextUrls toValue: allTextUrls. ^ allText!

1 0

The Inbox: CollectionsTests-ct.342.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-ct.342.mcz ==================== Summary ==================== Name: CollectionsTests-ct.342 Author: ct Time: 20 August 2020, 2:35:38.06964 pm UUID: 7e7af0d0-11d0-f847-b55d-abef876fed46 Ancestors: CollectionsTests-ul.341 Complements 60Deprecated-ct.80 (deprecation #doWithIndex: & Co.). =============== Diff against CollectionsTests-ul.341 =============== Item was changed: ----- Method: DictionaryTest>>testIntegrityOfDictionaries (in category 'tests - integrity') ----- testIntegrityOfDictionaries #( Dictionary IdentityDictionary SystemDictionary LiteralDictionary PluggableDictionary WeakValueDictionary) do: [ :dictionaryClassName | Smalltalk at: dictionaryClassName ifPresent: [ :dictionaryClass | dictionaryClass allInstancesDo: [ :dictionary | dictionary keysAndValuesDo: [ :key :value | self assert: (dictionary at: key) == value ]. + dictionary array withIndexDo: [ :association :index | - dictionary array doWithIndex: [ :association :index | association ifNotNil: [ self assert: (dictionary scanFor: association key) = index ] ] ] ] ]!

1 0

The Inbox: Collections-ct.908.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.908.mcz ==================== Summary ==================== Name: Collections-ct.908 Author: ct Time: 20 August 2020, 2:35:10.09764 pm UUID: b22d8a31-b3dd-ba49-924a-3f470da838c2 Ancestors: Collections-eem.907 Complements 60Deprecated-ct.80 (deprecation #doWithIndex: & Co.). =============== Diff against Collections-eem.907 =============== Item was removed: - ----- Method: HashedCollection>>doWithIndex: (in category 'enumerating') ----- - doWithIndex: aBlock2 - "Support Set enumeration with a counter, even though not ordered" - | index | - index := 0. - self do: [:item | aBlock2 value: item value: (index := index+1)]! Item was added: + ----- Method: HashedCollection>>withIndexDo: (in category 'enumerating') ----- + withIndexDo: elementAndIndexBlock + "Support Set enumeration with a counter, even though not ordered" + | index | + index := 0. + self do: [:item | elementAndIndexBlock value: item value: (index := index + 1)].! Item was removed: - ----- Method: SequenceableCollection>>collectWithIndex: (in category 'enumerating') ----- - collectWithIndex: elementAndIndexBlock - "Use the new version with consistent naming" - ^ self withIndexCollect: elementAndIndexBlock! Item was removed: - ----- Method: SequenceableCollection>>doWithIndex: (in category 'enumerating') ----- - doWithIndex: elementAndIndexBlock - "Use the new version with consistent naming" - ^ self withIndexDo: elementAndIndexBlock! Item was changed: ----- Method: String>>compressWithTable: (in category 'converting') ----- compressWithTable: tokens "Return a string with all substrings that occur in tokens replaced by a character with ascii code = 127 + token index. This will work best if tokens are sorted by size. Assumes this string contains no characters > 127, or that they are intentionally there and will not interfere with this process." | str null finalSize result ri c | null := Character null. str := self copyFrom: 1 to: self size. "Working string will get altered" finalSize := str size. + tokens withIndexDo: - tokens doWithIndex: [:token :tIndex | | start ts | start := 1. [(start := str findString: token startingAt: start) > 0] whileTrue: [ts := token size. ((start + ts) <= str size and: [(str at: start + ts) = $ and: [tIndex*2 <= 128]]) ifTrue: [ts := token size + 1. "include training blank" str at: start put: (Character value: tIndex*2 + 127)] ifFalse: [str at: start put: (Character value: tIndex + 127)]. str at: start put: (Character value: tIndex + 127). 1 to: ts-1 do: [:i | str at: start+i put: null]. finalSize := finalSize - (ts - 1). start := start + ts]]. result := String new: finalSize. ri := 0. 1 to: str size do: [:i | (c := str at: i) = null ifFalse: [result at: (ri := ri+1) put: c]]. ^ result!

1 0

The Inbox: Balloon-ct.34.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

A new version of Balloon was added to project The Inbox: http://source.squeak.org/inbox/Balloon-ct.34.mcz ==================== Summary ==================== Name: Balloon-ct.34 Author: ct Time: 20 August 2020, 2:34:34.01964 pm UUID: 76909964-5192-1f49-a074-e265c772e3a6 Ancestors: Balloon-nice.33 Complements 60Deprecated-ct.80 (deprecation #doWithIndex: & Co.). =============== Diff against Balloon-nice.33 =============== Item was changed: ----- Method: BalloonEngineConstants class>>initializeInstVarNames:prefixedBy: (in category 'pool definition') ----- initializeInstVarNames: aClass prefixedBy: aString | token | + aClass instVarNames withIndexDo: [:instVarName :index | | value | + token := (aString, instVarName first asUppercase asString, (instVarName copyFrom: 2 to: instVarName size), 'Index') asSymbol. - aClass instVarNames doWithIndex:[:instVarName :index| | value | - token := (aString, instVarName first asUppercase asString, (instVarName copyFrom: 2 to: instVarName size),'Index') asSymbol. value := index - 1. + (self bindingOf: token) ifNil: [self addClassVarName: token]. - (self bindingOf: token) ifNil:[self addClassVarName: token]. (self bindingOf: token) value: value. ]. + token := (aString, aClass name, 'Size') asSymbol. + (self bindingOf: token) ifNil: [self addClassVarName: token]. - token := (aString, aClass name,'Size') asSymbol. - (self bindingOf: token) ifNil:[self addClassVarName: token]. (self bindingOf: token) value: aClass instSize.!

1 0

What is primitiveDropRequestFileHandle and do we really need it?
by Thiede, Christoph 20 Aug '20

20 Aug '20

Hi all, as some of you already might have noticed [1, 2], I am currently working at a more powerful Drag and Drop (DnD) handling at the VM level of Squeak, heavily inspired by Marcel's ideas. While studying the existing source code, I was wondering what is the actual purpose of primitiveDropRequestFileHandle compared to primitiveDropRequestFileName which both are called by StandardFileStream >> #requestDropStream:. I had a very short look at all the different DropPlugin implementations and in a nutshell, dropRequestFileHandle appears to call dropRequestFileName and then sqFileOpen() that path using the FilePlugin. Compared to this, the regular primitiveFileOpen from the FilePlugin which is called by StandardFileStream >> #open:forWrite: leads to fileOpenNamesizewritesecure() which first performs some ominous security checks (basically whether the file path is valid and the file is writable if needed) and then, again, calls sqFileOpen(). So at the end of the day, both primitives appear to call the same logic. So please allow me my naive question: Does anyone remember or imagine any good reason why we have an additional primitive for this purpose? My overall guess (from what I have learned so far about the VM side) would have been that you should be as frugal as possible when it comes to introducing a primitive, because developing, debugging, and exploring VM code is so much less simple and intuitive than Smalltalk code. For this reason, I would not expect to find any redundant "convenience primitives" in the OSVM interface. I have two hypothetical explanations so far which however both I do not find satisfying: * Optimization: Could there have been some ancient times where it might have been wise to save a redundant call to the SecurityPlugin after you have got a trusted file path from the host system? * Buggy SecurityPlugin: Could there be any situation in which the SecurityPlugin would refuse a special file path returned by the DropPlugin though it can be opened by sqFileOpen()? But I cannot experience such a situation. <http://www.hpi.de/> Tl;dr: What is the reason for the existence of primitiveDropRequestFileHandle and should it still be used? Why not simply nuke it and always use primitiveDropRequestFileName + primitiveFileOpen? Looking forward to your suggestions! Best, Christoph [1] https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508 [2] https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/514

2 2

The Trunk: Tests-pre.436.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

Patrick Rein uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-pre.436.mcz ==================== Summary ==================== Name: Tests-pre.436 Author: pre Time: 20 August 2020, 10:20:39.808828 am UUID: 19d0bec2-5710-1a42-9dda-8bb0cadbf1b0 Ancestors: Tests-mt.435 Adds regression tests for a parser issue with pragma parsing matching a string or symbol literal with an angle bracket as an opening pragma bracket and correspondingly a closing string or symbol literal as a closing pragma. =============== Diff against Tests-mt.435 =============== Item was added: + TestCase subclass: #ParserTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Compiler'! Item was added: + ----- Method: ParserTest>>testRegressionPragmasParsing (in category 'tests - pragmas') ----- + testRegressionPragmasParsing + + self + shouldnt: [Parser new + parse: 'methodHeader + <first>' + class: ParserTest] + raise: SyntaxErrorNotification! Item was added: + ----- Method: ParserTest>>testRegressionPragmasParsingClosingToken (in category 'tests - pragmas') ----- + testRegressionPragmasParsingClosingToken + + self + should: [Parser new + parse: 'methodHeader + <first''>''' + class: ParserTest] + raise: SyntaxErrorNotification! Item was added: + ----- Method: ParserTest>>testRegressionPragmasParsingIsTooPossessive (in category 'tests - pragmas') ----- + testRegressionPragmasParsingIsTooPossessive + "The parser might interpret angle bracket literals as opening pragmas" + + self + shouldnt: [Parser new + parse: 'methodHeader + ''<'' asciiValue' + class: ParserTest] + raise: SyntaxErrorNotification. + + self + shouldnt: [Parser new + parse: 'methodHeader + #< asciiValue' + class: ParserTest] + raise: SyntaxErrorNotification. + + self + shouldnt: [Parser new + parse: 'methodHeader + $< asciiValue' + class: ParserTest] + raise: SyntaxErrorNotification!

1 0

The Trunk: Compiler-pre.441.mcz
by commits＠source.squeak.org 20 Aug '20

20 Aug '20

Patrick Rein uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-pre.441.mcz ==================== Summary ==================== Name: Compiler-pre.441 Author: pre Time: 20 August 2020, 10:19:13.607828 am UUID: 25de8b68-cea6-db46-9d6a-f400bd5f8b82 Ancestors: Compiler-eem.440 Fixes an issue with pragma parsing matching a string or symbol literal with an angle bracket as an opening pragma bracket and correspondingly a closing string or symbol literal as a closing pragma. =============== Diff against Compiler-eem.440 =============== Item was changed: ----- Method: Parser>>pragmaSequence (in category 'pragmas') ----- pragmaSequence "Parse a sequence of method pragmas." + [ (hereType == #binary and: [self matchToken: #<]) - [ - (self matchToken: #<) ifFalse: [ ^ self ]. self pragmaStatement. + (hereType == #binary and: [self matchToken: #>]) - (self matchToken: #>) ifFalse: [ ^ self expected: '>' ] ] repeat!

1 0

Parser Pragma Issue and Fix
by Rein, Patrick 20 Aug '20

20 Aug '20

Hi everyone, while working on a parser framework I recently discovered an issue when parsing the following method: someTestMethod '<' first This method can not be parsed by the current Squeak parser, as it expects a closing angle bracket after the message send. The parser misinterprets the bracket in the string as the beginning of a pragma. The fault is in the Parser class which did not respect the type of the token to be parsed. The attached changeset is a proposed fix for the fault. It boils down to checking for the #binary token type in the the responsible parser method: Parser>>#pragmaSequence "Parse a sequence of method pragmas." [ (hereType == #binary and: [self matchToken: #<]) ifFalse: [ ^ self ]. self pragmaStatement. (self matchToken: #>) ifFalse: [ ^ self expected: '>' ] ] repeat As this is somewhat of a fundamental change, I wanted to bring this up for discussion before merging it. Thanks and best wishes, Patrick

3 3

Is it dangerous to ignore Dangerous?
by David T. Lewis 19 Aug '20

19 Aug '20

Following the removal of Classbuilder>>format:variable:words:pointers:weak: I had planned to remove a reference to that method (and one or two others) in MethodFinder>>noteDangerous. But to my surprise, I see that the set of Dangerous methods in MethodFinder is completely unused (except by a method that is itself unused). How is this even possible? I had assumed that the Dangerous methods were important to the fundamental functioning of MethodFinder, which explores the system looking for methods that produce results matching some example pattern. How could this possibly be working if we do not pay attention to the set of methods that are too dangerous to be invoked by the method finder? This is not a new situation, I looked at a Squeak 3.6 image and see the same thing. Dave

3 2

The Trunk: System-mt.1169.mcz
by commits＠source.squeak.org 19 Aug '20

19 Aug '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1169.mcz ==================== Summary ==================== Name: System-mt.1169 Author: mt Time: 17 August 2020, 12:54:05.667289 pm UUID: dfd26c6f-79f7-f146-95c1-78751d5f8f13 Ancestors: System-eem.1168 Clarify implementation of method timestamps. Note that #hhmm24 cannot be used here, because it has no colon separator. =============== Diff against System-eem.1168 =============== Item was changed: ----- Method: Utilities class>>changeStamp (in category 'identification') ----- changeStamp "Answer a string to be pasted into source code to mark who changed it and when." ^ self authorInitials , ' ' , Date today mmddyyyy, ' ', + (String streamContents: [:s | Time now print24: true showSeconds: false on: s])! - ((String streamContents: [:s | Time now print24: true on: s]) copyFrom: 1 to: 5)!

3 2

← Newer
1
...
10
11
12
13
14
15
16
17
Older →

Jump to page: