Squeak-dev August 2020

squeak-dev@lists.squeakfoundation.org

47 participants
168 discussions

Rounding in MatrixTransform2x3
by Stephan Lutz 12 Aug '20

12 Aug '20

While transforming points using MatrixTransform2x3 we noticed some strange rounding behavior: "with plugin" (MatrixTransform2x3 withOffset: 5 @ 10) localPointToGlobal: 0@0. "5@10" (MatrixTransform2x3 withOffset: -5 @ -10) localPointToGlobal: 0@0. "-4@ -9" "without plugin" ((MatrixTransform2x3 withOffset: 5 @ 10) transformPoint: 0@0) rounded. "5@10" ((MatrixTransform2x3 withOffset: -5 @ -10) transformPoint: 0@0) rounded. "-5@ -10" It appears the code used to round in the plugin simply adds 0.5 and truncates the result, which does not work correctly for negative numbers. This code can be found in Matrix2x3Plugin >> #roundAndStoreResultPoint: and Matrix2x3Plugin >> #roundAndStoreResultRect:x0:y0:x1:y1: . ---- On a kind of related note: Is there even a reason to round the resulting floats? While the class comment of MatrixTransform2x3 notes that this behavior is intentional, glancing quickly over its uses we could not find anything taking advantage or benefiting from it. It's also not a limitation of the DisplayTransform interface, since MorphicTransform does produce floating point values. Wouldn't it be much more versatile and easier to leave rounding to users if they actually need it? Stephan

3 3

Sound in Linux?
by Eric Gade 11 Aug '20

11 Aug '20

Hey all, My Google-fu is failing me on this one. When I try to play sounds in Linux (using the class methods in AbstractSound), nothing happens and I don't hear anything. I assume there are some extra steps I need to take in my system but I cannot find the information online. I'm currently running Pop_os 20.04, which is based on Ubuntu 20.04. Any ideas? -- Eric

2 1

GIFs and the Color black
by Eric Gade 09 Aug '20

09 Aug '20

Hi all, I've noticed that in the current implementation of GIFReadWriter, we cannot faithfully reproduce the color black when writing it and reading it back in. Quick note: before I rewrote large parts of the GIF stuff in Pharo a while back, it had the same implementation as Squeak. But both then and now, Pharo does not have the problem that I am describing. This leads me to believe that the problem is actually at some low level that I'm not equipped to understand. I'm hoping that the collective wisdom on this list might have some ideas. I'm thinking there's something going on with color mapping and Bitmaps (maybe color depths and conversions as well?) which I don't understand very well. On the other hand, I do have a good understanding of the GIF format since I worked on it. The LZW compression is a real nightmare, and even in my Pharo rewrite I had to keep the LZW encoding portions from the original implementation. The following code, when done in a workspace, will clearly demonstrate the issue: ``` blackForm := Form extent: 100@100. blackForm getCanvas fillColor: Color black. "Write to a bytestream" out := WriteStream on: ByteArray new. writer := GIFReadWriter on: out. writer nextPutImage: blackForm. writer close. "Read from the bytestream" in := ReadStream on: out contents. reader := GIFReadWriter on: in. result := reader nextImage. (result colorAt: 50@50) inspect. ``` The resulting color is not what we expect (Color black). It is (Color r: 0.0 g: 0.0 b: 0.004) Any ideas what's going on? -- Eric

3 4

The Trunk: Collections-eem.907.mcz
by commits＠source.squeak.org 09 Aug '20

09 Aug '20

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.907.mcz ==================== Summary ==================== Name: Collections-eem.907 Author: eem Time: 6 August 2020, 12:51:46.481296 pm UUID: 4ea594f7-b7bf-4d48-9e7e-2e7cb3af5e70 Ancestors: Collections-mt.906 2.7x faster ByteArray>>readHexFrom: =============== Diff against Collections-mt.906 =============== Item was changed: ----- Method: ByteArray>>readHexFrom: (in category 'initialize') ----- readHexFrom: aStream "Initialize the receiver from a hexadecimal string representation" + + 1 to: self size do: + [:i| | n v1 v2 | + n := aStream next asInteger. + v1 := n > 57 "$9 asInteger = 57" + ifTrue: + [n > 96 "$a asInteger 97" + ifTrue: [n - 87] + ifFalse: [n > 64 "$A asInteger = 65" + ifTrue: [n - 55] + ifFalse: [-1]]] + ifFalse: [n - 48]. "$0 asInteger = 48" + (v1 between: 0 and: 15) ifFalse: [^self error: 'Hex digit expected']. + n := aStream next asInteger. + v2 := n > 57 "$9 asInteger = 57" + ifTrue: + [n > 96 "$a asInteger 97" + ifTrue: [n - 87] + ifFalse: [n > 64 "$A asInteger = 65" + ifTrue: [n - 55] + ifFalse: [-1]]] + ifFalse: [n - 48]. "$0 asInteger = 48" + (v2 between: 0 and: 15) ifFalse: [^self error: 'Hex digit expected']. + self at: i put: (v1 bitShift: 4) + v2] + + "Proof that our filter selects only hexadecimal characters: + (0 to: 255) + select: + [:n| + (n > 57 + ifTrue: + [n > 96 + ifTrue: [n - 87] + ifFalse: [n > 64 + ifTrue: [n - 55] + ifFalse: [-1]]] + ifFalse: [n - 48]) between: 0 and: 15] + thenCollect: + [:n| Character value: n]"! - | map v ch value | - map := '0123456789abcdefABCDEF'. - 1 to: self size do:[:i| - ch := aStream next. - v := (map indexOf: ch) - 1. - ((v between: 0 and: 15) or: [((v:= v - 6) between: 0 and: 15)]) ifFalse:[^self error: 'Hex digit expected']. - value := v bitShift: 4. - ch := aStream next. - v := (map indexOf: ch) - 1. - ((v between: 0 and: 15) or: [((v:= v - 6) between: 0 and: 15)]) ifFalse:[^self error: 'Hex digit expected']. - value := value + v. - self at: i put: value. - ]. - !

3 3

FileTree in Squeak 5.3 can't load Grease repo, but issue was fixed in 2016
by Tim Johnson 09 Aug '20

09 Aug '20

Hi all, I filed an issue against FileTree[1] and spent some time crafting a solution, only to find that @krono had already crafted & submitted a fix in 2016: https://github.com/dalehenrich/filetree/commit/262b0288b113bca0b3aff1bee005… https://github.com/dalehenrich/filetree/commit/30628e0b646eede0823e05fab1c3… So: why isn't the fix loaded into a fresh Squeak 5.3 image after performing "Installer ensureRecentMetacello"? The two commits related to the fix seem to have been properly merged into the squeak4.3 dialect branch. Could it be that ConfigurationOfFileTree needs updating to include this commit? It seems the #stable version, 1.0.6.2, has a timestamp of 10/29/2014 12:48. It includes the following for Squeak: spec for: #'squeak' do: [ spec package: 'MonticelloFileTree-Core' with: 'MonticelloFileTree-Core.squeak43-dkh.169'; package: 'MonticelloFileTree-FileDirectory-Utilities' with: 'MonticelloFileTree-FileDirectory-Utilities.squeak43-dkh.12'. ]. Would the solution be to update this spec to a newer package version? Thanks, Tim [1] https://github.com/dalehenrich/filetree/issues/229

1 0

classVariableNames auto-sort is a nice touch.
by gettimothy 09 Aug '20

09 Aug '20

Quick slow-clap for whoever added the auto-sort when a new classVariableName is added from a method prompt. very nice touch, thx

1 0

The Inbox: Collections-EG.908.mcz
by commits＠source.squeak.org 08 Aug '20

08 Aug '20

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-EG.908.mcz ==================== Summary ==================== Name: Collections-EG.908 Author: EG Time: 7 August 2020, 8:17:30.343164 pm UUID: d02855a8-a339-4f1d-bede-89a50f07892e Ancestors: Collections-eem.907 Changing behavior of #peekBack to (correctly) return first element of underlying collection when stream position is 1. =============== Diff against Collections-eem.907 =============== Item was changed: ----- Method: PositionableStream>>peekBack (in category 'accessing') ----- peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." - | element | self position = 0 ifTrue: [self errorCantGoBack]. + element := self back. - self position = 1 ifTrue: [self position: 0. ^ nil]. - self skip: -2. - element := self next. self skip: 1. ^ element!

4 6

[CRON] Passed: squeak-smalltalk/squeak-app#1786 (squeak-trunk - 25ebaf1)
by Travis CI 08 Aug '20

08 Aug '20

Build Update for squeak-smalltalk/squeak-app ------------------------------------- Build: #1786 Status: Passed Duration: 16 mins and 45 secs Commit: 25ebaf1 (squeak-trunk) Author: Marcel Taeumel Message: Hi all! The project "squeak-app" is part of the continuous build infrastructure (short: CI) for Squeak's bundles, which you can download at https://files.squeak.org/, followed by the version tag you are looking for. All bundles are updated on a regular basis, which is daily for Trunk (i.e. the current alpha version) and monthly for release versions. Note that there won't be new bundles if Squeak's build number, which reflects in-image code updates, did not change between CI jobs. -- The Squeak Oversight Board [ci skip] View the changeset: https://github.com/squeak-smalltalk/squeak-app/compare/fb55517f583fe544f922… View the full build log and details: https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/716121833?u… -- You can unsubscribe from build emails from the squeak-smalltalk/squeak-app repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8901856&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

The Inbox: CollectionsTests-EG.342.mcz
by commits＠source.squeak.org 08 Aug '20

08 Aug '20

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-EG.342.mcz ==================== Summary ==================== Name: CollectionsTests-EG.342 Author: EG Time: 7 August 2020, 8:18:24.376363 pm UUID: cd08c4bb-0a50-4a33-9fd1-96876f07f3e0 Ancestors: CollectionsTests-ul.341 Adding tests for the updated #peekBack behavior =============== Diff against CollectionsTests-ul.341 =============== Item was added: + ----- Method: ReadStreamTest>>testPeekBack (in category 'tests - back') ----- + testPeekBack + "Test the ability to peek backwards on the stream" + | stream | + stream := ReadStream on: 'abcd'. + stream skip: 2. + self assert: $b equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPosition1 (in category 'tests - back') ----- + testPeekBackOnPosition1 + "Ensure that #peekBack works from position 1, + giving us the first element in the stream" + | stream | + stream := ReadStream on: 'abcde'. + stream skip: 1. + self assert: $a equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPositionZero (in category 'tests - back') ----- + testPeekBackOnPositionZero + "Ensure that we *cannot* peekBack on a stream + that is currently at the start (zero) position" + | stream | + stream := ReadStream on: 'abcd'. + self + should: [ stream peekBack ] + raise: Error!

1 0

[CRON] Errored: squeak-smalltalk/squeak-app#1785 (squeak-trunk - 25ebaf1)
by Travis CI 07 Aug '20

07 Aug '20

Build Update for squeak-smalltalk/squeak-app ------------------------------------- Build: #1785 Status: Errored Duration: 17 mins and 30 secs Commit: 25ebaf1 (squeak-trunk) Author: Marcel Taeumel Message: Hi all! The project "squeak-app" is part of the continuous build infrastructure (short: CI) for Squeak's bundles, which you can download at https://files.squeak.org/, followed by the version tag you are looking for. All bundles are updated on a regular basis, which is daily for Trunk (i.e. the current alpha version) and monthly for release versions. Note that there won't be new bundles if Squeak's build number, which reflects in-image code updates, did not change between CI jobs. -- The Squeak Oversight Board [ci skip] View the changeset: https://github.com/squeak-smalltalk/squeak-app/compare/fb55517f583fe544f922… View the full build log and details: https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/715856958?u… -- You can unsubscribe from build emails from the squeak-smalltalk/squeak-app repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8901856&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Jump to page: