I did some fix and enhancement for OB. What do you think about them ? Should we include them in 3.9 ?
Cheers, Alexandre
Anfang der weitergeleiteten E-Mail:
Von: stéphane ducasse ducasse@iam.unibe.ch Datum: July 6, 2006 8:44:49 AM GMT+01:00 An: The general-purpose Squeak developers list <squeak- dev@lists.squeakfoundation.org> Betreff: CALL FOR 3.9 Final changes Antwort an: The general-purpose Squeak developers list <squeak- dev@lists.squeakfoundation.org>
Hi all
next week we will gather at my place and work on 3.9 final. We would ****really**** appreciate that the other package maintainers mention the new versions of packages for 3.9.
This is the third time I asked and so far I got nearly no feedback except from the network and morphic packages maintainer. May be we should fork for the other packages.
If you have important bugs fixes that you want to see harvested please reply to this email and put link to the mantis entry.
Stef
This sounds important to me to push OB. But I didn't had a look at the source code.
Could you have a look at the code I sent ? They are very short in general...
Alexandre
Alexandre Bergel wrote:
This sounds important to me to push OB. But I didn't had a look at the source code.
Could you have a look at the code I sent ? They are very short in general...
I do not know anything about OB design (does SCG still plan do publish something ? with you maybe) and you are a better programmer than I'm.
However, I'll have a look at it and tell you if I find something that need to be talked about.
I do not know anything about OB design (does SCG still plan do publish something ? with you maybe)
We cannot release it before the notification of ESUG.
However, I'll have a look at it and tell you if I find something that need to be talked about.
Ok, thanks. But before next week :-) As everything has to be shipped to Stef.
Cheers, Alexandre
First file: OBFixFindClass.3
You wrote:
" Bug: cannot see the comment of a class with OB.
Enhancement: When you find a class by pressing Alt-f for example, you may have a very long list. Even if you type the exact name of the class. This changeset place as the first choice the class you entered. "
I do not see the relation between the bug and your enhancement. In fact, there is not bug you correct here. You just propose a very good enhancement to the browser.
In your fix, you write:
potentialClassNames := (anEnvironment classNames, anEnvironment traitNames) asArray.
which is different from what I had in my version:
potentialClassNames := anEnvironment classNames asArray.
This may be an enhancement too, but not the one you talk about in the changeset. I know that you cannot do much about this because you have multiple overrides on this method.
Next file later
Heu... Sorry about that :-) I will pay attention next time.
Thanks for reviewing...
Alexandre
Am Jul 6, 2006 um 11:18 AM schrieb Damien Cassou:
First file: OBFixFindClass.3
You wrote:
" Bug: cannot see the comment of a class with OB.
Enhancement: When you find a class by pressing Alt-f for example, you may have a very long list. Even if you type the exact name of the class. This changeset place as the first choice the class you entered. "
I do not see the relation between the bug and your enhancement. In fact, there is not bug you correct here. You just propose a very good enhancement to the browser.
In your fix, you write:
potentialClassNames := (anEnvironment classNames, anEnvironment traitNames) asArray.
which is different from what I had in my version:
potentialClassNames := anEnvironment classNames asArray.
This may be an enhancement too, but not the one you talk about in the changeset. I know that you cannot do much about this because you have multiple overrides on this method.
Next file later _______________________________________________ Setools mailing list Setools@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/setools
First file: OBFixFindClass.3
Your enhancement doesn't work if I use lowercases for my classes. For example, using 'object' does not place 'Object' on top of the list.
Here is your version:
(classNames includes: pattern) ifTrue: [classNames := (Array with: pattern), classNames].
Here is a possible correction:
(classNames detect: [:nm | nm asString asLowercase = pattern asLowercase] ifNone: [nil]) ifNotNilDo: [:nm | classNames _ (Array with: nm), classNames].
Bye
Thanks Damien, I will correct it later today.
Alexandre
Am Jul 6, 2006 um 11:50 AM schrieb Damien Cassou:
First file: OBFixFindClass.3
Your enhancement doesn't work if I use lowercases for my classes. For example, using 'object' does not place 'Object' on top of the list.
Here is your version:
(classNames includes: pattern) ifTrue: [classNames := (Array with: pattern), classNames].
Here is a possible correction:
(classNames detect: [:nm | nm asString asLowercase = pattern asLowercase] ifNone: [nil]) ifNotNilDo: [:nm | classNames _ (Array with: nm), classNames].
Bye _______________________________________________ Setools mailing list Setools@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/setools
Second file: ObEnhMoveMethodInPackage.1.cs
There is no comment.
The following expression:
packagesNames := (MCWorkingCopy allManagers asSortedCollection: [:a :b | a package name <= b package name ]) collect: [:p| p package name].
can be shortened to:
packagesNames := ((MCWorkingCopy allManagers) collect: [:p| p package name]) asSortedCollection.
In fact, I'm trying to find things to improve in your code ;-) It's already ready to go in the image, you don't need me.
In fact, I'm trying to find things to improve in your code ;-) It's already ready to go in the image, you don't need me.
Good, the best way to learn...
Alexandre
packagesNames := (MCWorkingCopy allManagers asSortedCollection: [:a :b | a package name <= b package name ]) collect: [:p| p package name].
can be shortened to:
packagesNames := ((MCWorkingCopy allManagers) collect: [:p| p package name]) asSortedCollection.
The two expression are not equivalent. The second one gives a sorted collection and not the first one.
Did I miss something ?
Cheers, Alexandre
Alexandre Bergel wrote:
packagesNames := (MCWorkingCopy allManagers asSortedCollection: [:a :b | a package name <= b package name ]) collect: [:p| p package name].
can be shortened to:
packagesNames := ((MCWorkingCopy allManagers) collect: [:p| p package name]) asSortedCollection.
The two expression are not equivalent. The second one gives a sorted collection and not the first one.
You are right, I didn't noticed that. Is it a problem ?
Alexandre Bergel wrote:
packagesNames := (MCWorkingCopy allManagers asSortedCollection: [:a :b | a package name <= b package name ]) collect: [:p| p package name].
can be shortened to:
packagesNames := ((MCWorkingCopy allManagers) collect: [:p| p package name]) asSortedCollection.
The two expression are not equivalent. The second one gives a sorted collection and not the first one.
You are right, I didn't noticed that. Is it a problem ?
Is it a problem to have the list ordered ?
Alexandre
Alexandre Bergel wrote:
Alexandre Bergel wrote:
packagesNames := (MCWorkingCopy allManagers asSortedCollection: [:a :b | a package name <= b package name ]) collect: [:p| p package name].
can be shortened to:
packagesNames := ((MCWorkingCopy allManagers) collect: [:p| p package name]) asSortedCollection.
The two expression are not equivalent. The second one gives a sorted collection and not the first one.
You are right, I didn't noticed that. Is it a problem ?
Is it a problem to have the list ordered ?
This is my question. Is it a problem to get a SortedCollection for this menu ?
Third file: OBSearchingTraits.2.cs
This one is useless because the change is already in OBFixFindClass. Moreover, it might remove the correct behaviour if it loaded after.
I would advice to make just one changeset named 'FindClassEnhancements' with a comment describing the two changes.
Bye
setools@lists.squeakfoundation.org