Squeak-dev August 2018

squeak-dev@lists.squeakfoundation.org

41 participants
83 discussions

The Trunk: Compiler-eem.391.mcz
by commits＠source.squeak.org 22 Aug '18

22 Aug '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.391.mcz ==================== Summary ==================== Name: Compiler-eem.391 Author: eem Time: 21 August 2018, 3:37:49.438481 pm UUID: 95e267a4-cfe8-4aa4-8e83-876603470983 Ancestors: Compiler-bf.390 Fix pc highlighting for ifNil:[ifNotNil:] et al, as in {char ifNil: [ Error signal ]} in | str char | str := '1234' readStream. char := str next. char ifNil: [ Error signal ]. char caseOf: { [$4] -> ['four']. [$3] -> ['three' asUppercase]. [$2] -> ['two']. [$1] -> ['one' asUppercase]. } otherwise: [ 'No' ]. =============== Diff against Compiler-bf.390 =============== Item was changed: ----- Method: MessageNode>>emitCodeForIfNil:encoder:value: (in category 'code generation') ----- emitCodeForIfNil: stack encoder: encoder value: forValue | theNode theSize ifNotNilSelector | theNode := arguments first. theSize := sizes at: 1. ifNotNilSelector := #ifNotNil:. receiver emitCodeForValue: stack encoder: encoder. forValue ifTrue: [encoder genDup. stack push: 1]. encoder genPushSpecialLiteral: nil. stack push: 1. equalNode emitCode: stack args: 1 encoder: encoder. + pc := encoder pc. self emitCodeForBranchOn: (selector key == ifNotNilSelector) dist: theSize pop: stack encoder: encoder. - pc := encoder pc. forValue ifTrue: [encoder genPop. stack pop: 1. theNode emitCodeForEvaluatedValue: stack encoder: encoder] ifFalse: [theNode emitCodeForEvaluatedEffect: stack encoder: encoder]!

1 0

The Inbox: Collections-eem.803.mcz
by commits＠source.squeak.org 21 Aug '18

21 Aug '18

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-eem.803.mcz ==================== Summary ==================== Name: Collections-eem.803 Author: eem Time: 21 August 2018, 2:09:17.558296 pm UUID: 86665c06-0176-4eb8-b9dd-2b8dc3677fd6 Ancestors: Collections-dtl.802 More rational Dictionary>>fillFrom:with: so that collect:as: Dictionary matches e.g. Dictionary withAll: Since 2010 Dictionary withAll: { 2->3 } => a Dictionary(2->3 ). But 'abc' collect: [ :each | each -> each asciiValue ] as: Dictionary => a Dictionary(1->$a->97 2->$b->98 3->$c->99 ) With this change no tests appear to break (at least none that explicitly call collect:as:) and 'abc' collect: [ :each | each -> each asciiValue ] as: Dictionary => a Dictionary($a->97 $b->98 $c->99 ) =============== Diff against Collections-dtl.802 =============== Item was changed: ----- Method: Dictionary>>fillFrom:with: (in category 'private') ----- fillFrom: aCollection with: aBlock "Evaluate aBlock with each of aCollections's elements as the argument. Collect the resulting values into self. Answer self." + aCollection isSequenceable + ifTrue: + [aCollection associationsDo: + [ :element | self add: (aBlock value: element)]] + ifFalse: + [aCollection keysAndValuesDo: + [ :key :value | self at: key put: (aBlock value: value)]]! - aCollection keysAndValuesDo: [ :key :value | - self at: key put: (aBlock value: value) ]!

1 0

On authentic learning and Dynabook
by Hilaire 21 Aug '18

21 Aug '18

Hi, Short notes on how authentic learning pedagogy and Dynabook could be related http://blog.drgeo.eu/post/2018/Authentic-learning Comments wellcome Hilaire -- Dr. Geo http://drgeo.eu

3 5

[ANN] Good bye FunSqueak
by Edgar J. De Cleene 21 Aug '18

21 Aug '18

http://squeakros.org/FunSqueak5dot2alpha.zip Take as a proof of concept. Let's us discover many troubles coming from old code. Mostly works. So my days of building Fun is over. Gladly help any wishing do this kind of .image in the future.

3 4

The Trunk: Services-Base-cmm.65.mcz
by commits＠source.squeak.org 21 Aug '18

21 Aug '18

Chris Muller uploaded a new version of Services-Base to project The Trunk: http://source.squeak.org/trunk/Services-Base-cmm.65.mcz ==================== Summary ==================== Name: Services-Base-cmm.65 Author: cmm Time: 20 August 2018, 7:50:42.081643 pm UUID: 6070147d-ed58-4d1b-b078-4aeda587a3f2 Ancestors: Services-Base-tpr.64 Fixes a minor bug with the use of up/down arrow keys in the message list of an "inheritance (i)" browser, when traceMessages and reuseWindows are both active, and the inheritance window was already open but with a different method selected than the one it was invoked from. =============== Diff against Services-Base-tpr.64 =============== Item was added: + ----- Method: MessageTrace>>selectReference: (in category '*services-base') ----- + selectReference: aMethodReference + super selectReference: aMethodReference. + self okToChange ifTrue: [ anchorIndex := messageListIndex ]!

1 0

The Trunk: Compiler-bf.390.mcz
by commits＠source.squeak.org 20 Aug '18

20 Aug '18

Bert Freudenberg uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-bf.390.mcz ==================== Summary ==================== Name: Compiler-bf.390 Author: bf Time: 19 August 2018, 11:24:12.350952 pm UUID: d76ef6ae-8303-476d-bb1e-640b2476c276 Ancestors: Compiler-eem.389 Fix source range for caseOf: debugging =============== Diff against Compiler-eem.389 =============== Item was changed: ----- Method: MessageNode>>emitCodeForCase:encoder:value: (in category 'code generation') ----- emitCodeForCase: stack encoder: encoder value: forValue | braceNode sizeStream allReturn | forValue ifFalse: [^super emitCodeForEffect: stack encoder: encoder]. braceNode := arguments first. sizeStream := ReadStream on: sizes. receiver emitCodeForValue: stack encoder: encoder. "There must be at least one branch around the otherwise/caseError so the decompiler can identify the end of the otherwise/caseError." allReturn := true. "assume every case ends with a return" braceNode casesForwardDo: [:keyNode :valueNode :last | | thenSize elseSize | thenSize := sizeStream next. elseSize := sizeStream next. last ifFalse: [encoder genDup. stack push: 1]. keyNode emitCodeForEvaluatedValue: stack encoder: encoder. + keyNode pc: encoder pc. equalNode emitCode: stack args: 1 encoder: encoder. self emitCodeForBranchOn: false dist: thenSize pop: stack encoder: encoder. last ifFalse: [encoder genPop. stack pop: 1]. valueNode emitCodeForEvaluatedValue: stack encoder: encoder. last ifTrue: [stack pop: 1]. valueNode returns ifFalse: [self emitCodeForJump: elseSize encoder: encoder. allReturn := false]. (last and: [allReturn]) ifTrue: [self emitCodeForJump: elseSize encoder: encoder]]. arguments size = 2 ifTrue: [arguments last emitCodeForEvaluatedValue: stack encoder: encoder] "otherwise: [...]" ifFalse: [NodeSelf emitCodeForValue: stack encoder: encoder. caseErrorNode emitCode: stack args: 0 encoder: encoder]!

1 0

VM 5.0-201807260206 test results
by Chris Muller 19 Aug '18

19 Aug '18

I've tested the Squeak 64-bit Linux HT version on Ubuntu 14.04 and 16.04. I've put it through several paces and it's been quite stable for me. My apps pass their tests and seem to be running at least as well as before. Debugging is a dream. It just works. Performance still feels snappy, but I didn't do any benchmarks against 201608171728. Looks like yesterday was the old VM's two-year annniversary. It seems good enough that I've upgraded to it everywhere. 64-bit Squeak with a mature VM is finally a reality! What an incredible engine, congratulations Eliot! Cheers! Chris

2 1

The Trunk: Tools-tcj.827.mcz
by commits＠source.squeak.org 19 Aug '18

19 Aug '18

David T. Lewis uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tcj.827.mcz ==================== Summary ==================== Name: Tools-tcj.827 Author: tcj Time: 3 July 2018, 1:26:17.691671 pm UUID: 1faf6a9f-6246-4b95-a3aa-13b113afd08b Ancestors: Tools-cmm.826 Revert the change to File Contents Browser introduced in Tools-eem.660 which broke version browsing in the File Contents Browser. "Browse versions" now works again to browse versions of a given selector while browsing through a changeset. =============== Diff against Tools-cmm.826 =============== Item was changed: ----- Method: FileContentsBrowser>>browseVersions (in category 'other') ----- browseVersions + "Create and schedule a message set browser on all versions of the + currently selected message selector." + | class selector | + (selector := self selectedMessageName) ifNotNil: + [class := self selectedClassOrMetaClass. + (class exists and: [class realClass includesSelector: selector]) ifTrue: + [VersionsBrowser + browseVersionsOf: (class realClass compiledMethodAt: selector) + class: class realClass theNonMetaClass + meta: class realClass isMeta + category: self selectedMessageCategoryName + selector: selector]]! - "Create and schedule a message set browser on all versions of the currently selected message selector." - (ToolSet - browseVersionsOf: self selectedClassOrMetaClass - selector: self selectedMessageName) ifNil: [self changed: #flash]!

2 1

The Inbox: Tools-LM.829.mcz
by commits＠source.squeak.org 18 Aug '18

18 Aug '18

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-LM.829.mcz ==================== Summary ==================== Name: Tools-LM.829 Author: LM Time: 16 August 2018, 2:01:04.706807 am UUID: 46879fde-2c09-ca4a-9b63-b14a1e21e4c0 Ancestors: Tools-LM.828 In response to the feedback I received to Tools-LM.828 ( http://forum.world.st/The-Inbox-Tools-LM-828-mcz-td5082873.html ). I now made the ObjectExplorer only exclude those ObjectExplorerWrappers from the "chase pointers" search that are a submorph of the ActiveWorld. This is helpful if, for example, one reference to the object in question is held by an ObjectExplorer in another project that you forgot about. The findDeepSubmorphsIn:that: method should probably be moved into the Morph class, because it is a classic case of feature envy and Morph already contains a findDeepSubmorphThat:ifAbsent: method, which is similar. I just didn't want to mess with one of the core Morphic classes. I know that the way I find which ObjectExplorerWrappers are visible is not ideal, because it violates the principle of MVC that the model should not know about the implementation specifics of the view. So any feedback and suggestions in that regard would be appreciated. =============== Diff against Tools-LM.828 =============== Item was changed: ----- Method: ObjectExplorer>>chasePointersForSelection (in category 'menus - actions') ----- chasePointersForSelection + PointerFinder on: self object except: self possibleReferencesToSelection! - PointerFinder on: self object except: {self}, ObjectExplorerWrapper allInstances! Item was added: + ----- Method: ObjectExplorer>>findDeepSubmorphsIn:that: (in category 'accessing - view') ----- + findDeepSubmorphsIn: aMorph that: aBlock + + | selectedSubmorphs | + selectedSubmorphs := aMorph submorphs select: aBlock. + ^ selectedSubmorphs, (aMorph submorphs collect: [:each | + self findDeepSubmorphsIn: each that: aBlock]) flatten! Item was added: + ----- Method: ObjectExplorer>>possibleReferencesToSelection (in category 'accessing - view') ----- + possibleReferencesToSelection + + ^ {self}, self visibleObjectExplorerWrappers! Item was added: + ----- Method: ObjectExplorer>>views (in category 'accessing - view') ----- + views + + ^ self findDeepSubmorphsIn: ActiveWorld that: [:morph | + morph modelOrNil = self]! Item was added: + ----- Method: ObjectExplorer>>visibleListItems (in category 'accessing - view') ----- + visibleListItems + + | lists | + lists := self views select: [:morph | + (morph isKindOf: PluggableTreeMorph)]. + ^ (lists collect: [:each| + each items]) flatten! Item was added: + ----- Method: ObjectExplorer>>visibleObjectExplorerWrappers (in category 'accessing - view') ----- + visibleObjectExplorerWrappers + + | listItems | + listItems := self visibleListItems. + ^ listItems collect: [:each | each complexContents]! Item was changed: ----- Method: PointerFinder>>buildList (in category 'application') ----- buildList | list obj parent object key | list := OrderedCollection new. obj := goal. - [list addFirst: obj. + obj := parents at: obj ifAbsent: []. - obj := parents at: obj ifAbsent: [nil]. obj == nil] whileFalse. list removeFirst. parent := Smalltalk. objectList := OrderedCollection new. pointerList := OrderedCollection new. [list isEmpty] whileFalse: [object := list removeFirst. key := nil. (parent isKindOf: Dictionary) ifTrue: [list size >= 2 ifTrue: [key := parent keyAtValue: list second ifAbsent: []. key == nil ifFalse: [object := list removeFirst; removeFirst. pointerList add: key printString , ' -> ' , object class name]]]. key == nil ifTrue: [parent class == object ifTrue: [key := 'CLASS']. key == nil ifTrue: [1 to: parent class instSize do: [:i | key == nil ifTrue: [(parent instVarAt: i) == object ifTrue: [key := parent class instVarNameForIndex: i]]]]. key == nil ifTrue: [parent isCompiledCode ifTrue: [key := 'literals?']]. key == nil ifTrue: [1 to: parent basicSize do: [:i | key == nil ifTrue: [(parent basicAt: i) == object ifTrue: [key := i printString]]]]. key == nil ifTrue: [(parent isMorph and: [object isKindOf: Array]) ifTrue: [key := 'submorphs?']]. key == nil ifTrue: [key := '???']. pointerList add: key , ': ' , object class name, (object isMorph ifTrue: [' (', object identityHash asString, ')'] ifFalse: [ String empty ]) ]. objectList add: object. parent := object]!

6 13

The Trunk: Tools-cmm.831.mcz
by commits＠source.squeak.org 17 Aug '18

17 Aug '18

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.831.mcz ==================== Summary ==================== Name: Tools-cmm.831 Author: cmm Time: 17 August 2018, 2:47:24.570535 pm UUID: 4eb798e4-2a62-41b1-b0bb-2910f80e1273 Ancestors: Tools-dtl.830 - The hierarchy is inverted in a PointerExplorer such that the top line represents a (presumed) 'leaf' of the model (to be consistent with the language of 'root'), not to be confused with the opposite direction of the hierarchy presented in regular Explorers. Render the key names in 'instVar' syntax. - Pointer exploring and finding tools must be concerned with the identity of objects. They must find (and, exclude) references to *this* object, not just any other object of equal value. =============== Diff against Tools-dtl.830 =============== Item was changed: ----- Method: Inspector>>chasePointers (in category 'menu commands') ----- chasePointers | selected saved | self selectionIndex = 0 ifTrue: [^ self changed: #flash]. selected := self selection. saved := self object. [self object: nil. (Smalltalk includesKey: #PointerFinder) ifTrue: [PointerFinder on: selected] ifFalse: [self inspectPointers]] ensure: [self object: saved]! Item was changed: ----- Method: PointerExplorer>>rootObject: (in category 'accessing') ----- rootObject: anObject + self root key: 'leaf'. + super rootObject: anObject! - - self root key: 'root'. - super rootObject: anObject.! Item was changed: ----- Method: PointerExplorerWrapper>>memberNameFrom:to: (in category 'accessing') ----- memberNameFrom: aParent to: aChild 1 to: aParent class instSize do: [ :instVarIndex | + (aParent instVarAt: instVarIndex) == aChild + ifTrue: [ ^ '''', (aParent class instVarNameForIndex: instVarIndex), '''' ]]. - (aParent instVarAt: instVarIndex) = aChild - ifTrue: [ ^ '#', (aParent class instVarNameForIndex: instVarIndex)]]. "This also covers arrays" 1 to: aParent basicSize do: [ :index | + (aParent basicAt: index) == aChild - (aParent basicAt: index) = aChild ifTrue: [^ index asString]]. ^ '???'! Item was changed: ----- Method: PointerFinder class>>on: (in category 'instance creation') ----- + on: anObject + ^ self + on: anObject + except: Array empty! - on: anObject - ^ self new goal: anObject; search; open! Item was changed: + ----- Method: PointerFinder>>buildList (in category 'initialize-release') ----- - ----- Method: PointerFinder>>buildList (in category 'application') ----- buildList | list obj parent object key | list := OrderedCollection new. obj := goal. + [list addFirst: obj. obj := parents at: obj ifAbsent: []. obj == nil] whileFalse. list removeFirst. parent := Smalltalk. objectList := OrderedCollection new. pointerList := OrderedCollection new. [list isEmpty] whileFalse: [object := list removeFirst. key := nil. (parent isKindOf: Dictionary) ifTrue: [list size >= 2 ifTrue: [key := parent keyAtValue: list second ifAbsent: []. key == nil ifFalse: [object := list removeFirst; removeFirst. pointerList add: key printString , ' -> ' , object class name]]]. key == nil ifTrue: [parent class == object ifTrue: [key := 'CLASS']. key == nil ifTrue: [1 to: parent class instSize do: [:i | key == nil ifTrue: [(parent instVarAt: i) == object ifTrue: [key := parent class instVarNameForIndex: i]]]]. key == nil ifTrue: [parent isCompiledCode ifTrue: [key := 'literals?']]. key == nil ifTrue: [1 to: parent basicSize do: [:i | key == nil ifTrue: [(parent basicAt: i) == object ifTrue: [key := i printString]]]]. key == nil ifTrue: [(parent isMorph and: [object isKindOf: Array]) ifTrue: [key := 'submorphs?']]. key == nil ifTrue: [key := '???']. pointerList add: key , ': ' , object class name, (object isMorph ifTrue: [' (', object identityHash asString, ')'] ifFalse: [ String empty ]) ]. objectList add: object. parent := object]! Item was changed: ----- Method: PointerFinder>>excludedObjects (in category 'accessing') ----- excludedObjects + ^ excludedObjects! - - ^ excludedObjects ifNil: [excludedObjects := OrderedCollection new]! Item was changed: + ----- Method: PointerFinder>>excludedObjects: (in category 'initialize-release') ----- + excludedObjects: aCollection + excludedObjects := aCollection asIdentitySet! - ----- Method: PointerFinder>>excludedObjects: (in category 'accessing') ----- - excludedObjects: aCollection - - excludedObjects := aCollection! Item was changed: + ----- Method: PointerFinder>>follow:from: (in category 'private') ----- - ----- Method: PointerFinder>>follow:from: (in category 'application') ----- follow: anObject from: parentObject anObject == goal ifTrue: [ parents at: anObject put: parentObject. ^ true ]. anObject shouldFollowOutboundPointers ifFalse: [ ^ false ]. ((parents includesKey: anObject) or: [ anObject class = self class ]) ifTrue: [ ^ false ]. parents at: anObject put: parentObject. toDoNext add: anObject. ^ false! Item was changed: + ----- Method: PointerFinder>>followObject: (in category 'private') ----- - ----- Method: PointerFinder>>followObject: (in category 'application') ----- followObject: anObject (self excludedObjects includes: anObject) ifTrue: [^ false]. anObject outboundPointersDo: [:ea | (self follow: ea from: anObject) ifTrue: [^ true]]. ^ false! Item was changed: + ----- Method: PointerFinder>>goal: (in category 'initialize-release') ----- - ----- Method: PointerFinder>>goal: (in category 'application') ----- goal: anObject goal := anObject! Item was changed: + ----- Method: PointerFinder>>initialize (in category 'initialize-release') ----- - ----- Method: PointerFinder>>initialize (in category 'application') ----- initialize parents := IdentityDictionary new: 20000. parents at: Smalltalk put: nil. parents at: Processor put: nil. parents at: self put: nil. toDo := OrderedCollection new: 5000. toDo add: Smalltalk. + toDoNext := OrderedCollection new: 5000. + + excludedObjects := IdentitySet new! - toDoNext := OrderedCollection new: 5000.!

2 1

← Newer
1
2
3
4
5
6
7
8
9
Older →