Ok, now we're talking.
Send in a mail with changesets 9,7,4, and I'll approve them, I've already seen that part. The others until 10 are either tests (which no longer go into the image, since we'll be removing SUnit into a package), or your internal tools, or already in the image.
When you've reviewed another bunch, let me know which.
Daniel
Stephane Ducasse ducasse@iam.unibe.ch wrote:
Ok so let us know. I think that making a try on the current changes could help to tighten the process and see if we can work this way. What I suggest is the following (depending on the availability of Noury's and Roel's time there is a deadline for ESUG for the end of the week)
- we proceed to an internal/external review as soon as possible.
- we let you know.
- you try to assess the changes as fast as you can and report how we
can improve communication. 4. If in the meantime you/harvesters evaluate the proposed changes which are simple (the only design point is that we introduced a new class for the navigation and UI related actions that the tools can reuse), and accept them we just pass to the next ones.
Stef
Prof. Dr. Stéphane DUCASSE http://www.iam.unibe.ch/~ducasse/ "if you knew today was your last day on earth, what would you do different? ... especially if, by doing something different, today might not be your last day on earth" Calvin&Hobbes
"The best way to predict the future is to invent it..." Alan Kay.
Open Source Smalltalks: http://www.squeak.org, http://www.gnu.org/software/smalltalk/smalltalk.html Free books for Universities at http://www.esug.org/sponsoring/promotionProgram.html Free Online Book at http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html _______________________________________________ Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
Okay, this sounds like a pretty good process.
I guess Daniel is sort of promising to look at these bundles of changesets from the KCP as they come in? If we want to have a reasonably quick turnaround for these changes, it probably is good to have one harvester that promises to review them, so that they aren't ignored accidentally.
On the other hand, if someone like Noury is already externally reviewing these and adding comments, then perhaps it would be sufficient for Daniel or anyone to "rubber stamp" these as approved without looking too hard at them. (It would need to be clear from the comments that they were really externally reviewed, of course.) But if Daniel is able to review them himself, that is ideal.
These will still follow the usual harvesting process steps which I posted about yesterday at http://minnow.cc.gatech.edu/squeak/3152 .
For example, I see that Daniel has already [approved] one item (rmSubclassModule). According to the process, this will sit around for at least 3 days to see if anyone objects to it, and if no one does, it will go into the update stream.
Hopefully this process will be fast enough for what Stephane has in mind.
(I see that the Morphic Cleanup Project (MCP) folks are now submitting changesets. Ideally, it might be good to have an "interested harvester" devoted to looking at those, too...)
- Doug
On Sunday, April 6, 2003, at 07:16 PM, Daniel Vainsencher wrote:
Ok, now we're talking.
Send in a mail with changesets 9,7,4, and I'll approve them, I've already seen that part. The others until 10 are either tests (which no longer go into the image, since we'll be removing SUnit into a package), or your internal tools, or already in the image.
When you've reviewed another bunch, let me know which.
Daniel
Stephane Ducasse ducasse@iam.unibe.ch wrote:
Ok so let us know. I think that making a try on the current changes could help to tighten the process and see if we can work this way. What I suggest is the following (depending on the availability of Noury's and Roel's time there is a deadline for ESUG for the end of the week)
- we proceed to an internal/external review as soon as possible.
- we let you know.
- you try to assess the changes as fast as you can and report how we
can improve communication. 4. If in the meantime you/harvesters evaluate the proposed changes which are simple (the only design point is that we introduced a new class for the navigation and UI related actions that the tools can reuse), and accept them we just pass to the next ones.
Stef
Prof. Dr. Stéphane DUCASSE http://www.iam.unibe.ch/~ducasse/ "if you knew today was your last day on earth, what would you do different? ... especially if, by doing something different, today might not be your last day on earth" Calvin&Hobbes
"The best way to predict the future is to invent it..." Alan Kay.
Open Source Smalltalks: http://www.squeak.org, http://www.gnu.org/software/smalltalk/smalltalk.html Free books for Universities at http://www.esug.org/sponsoring/promotionProgram.html Free Online Book at http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html _______________________________________________ Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
hi doug
I was discussing recently with noury and he will look at that after friday (paper deadline).
After we have been discussing internally here and we will have our own internal reviewing process. What we plan is the following: - some guys will focus on the fine grained (method level refactoring) - some others will focus on bigger parts: - nathanael will design a new systemOrganization because this one is a real ***bad*** beast, classBuilder, compiler funnel, - roel may look at the change notification - and we will have our own internal review - then noury will have a look and participate because he cleaned already part of the kernel for metaclassTalk
This means that all the changes will be at least review by three **experts** before been sent out.
- at the end of the process, daniel will have less hard time to understand what we will be doing
Stef
PS: What is important to know if that we really need all those changes for the new generation of traits/classBoxes/and other programming experiments
The step after will be the implementation of a ****completely new browser**** because we are fedup. But we will see if people like it they will get it, else we will just use it and do not have to touch this dirty part of Squeak.
On Wednesday, April 9, 2003, at 07:21 AM, Doug Way wrote:
Okay, this sounds like a pretty good process.
I guess Daniel is sort of promising to look at these bundles of changesets from the KCP as they come in? If we want to have a reasonably quick turnaround for these changes, it probably is good to have one harvester that promises to review them, so that they aren't ignored accidentally.
On the other hand, if someone like Noury is already externally reviewing these and adding comments, then perhaps it would be sufficient for Daniel or anyone to "rubber stamp" these as approved without looking too hard at them. (It would need to be clear from the comments that they were really externally reviewed, of course.) But if Daniel is able to review them himself, that is ideal.
These will still follow the usual harvesting process steps which I posted about yesterday at http://minnow.cc.gatech.edu/squeak/3152 .
For example, I see that Daniel has already [approved] one item (rmSubclassModule). According to the process, this will sit around for at least 3 days to see if anyone objects to it, and if no one does, it will go into the update stream.
Hopefully this process will be fast enough for what Stephane has in mind.
(I see that the Morphic Cleanup Project (MCP) folks are now submitting changesets. Ideally, it might be good to have an "interested harvester" devoted to looking at those, too...)
- Doug
On Sunday, April 6, 2003, at 07:16 PM, Daniel Vainsencher wrote:
Ok, now we're talking.
Send in a mail with changesets 9,7,4, and I'll approve them, I've already seen that part. The others until 10 are either tests (which no longer go into the image, since we'll be removing SUnit into a package), or your internal tools, or already in the image.
When you've reviewed another bunch, let me know which.
Daniel
Stephane Ducasse ducasse@iam.unibe.ch wrote:
Ok so let us know. I think that making a try on the current changes could help to tighten the process and see if we can work this way. What I suggest is the following (depending on the availability of Noury's and Roel's time there is a deadline for ESUG for the end of the week)
- we proceed to an internal/external review as soon as possible.
- we let you know.
- you try to assess the changes as fast as you can and report how we
can improve communication. 4. If in the meantime you/harvesters evaluate the proposed changes which are simple (the only design point is that we introduced a new class for the navigation and UI related actions that the tools can reuse), and accept them we just pass to the next ones.
Stef
Prof. Dr. Stéphane DUCASSE http://www.iam.unibe.ch/~ducasse/ "if you knew today was your last day on earth, what would you do different? ... especially if, by doing something different, today might not be your last day on earth" Calvin&Hobbes
"The best way to predict the future is to invent it..." Alan Kay.
Open Source Smalltalks: http://www.squeak.org, http://www.gnu.org/software/smalltalk/smalltalk.html Free books for Universities at http://www.esug.org/sponsoring/promotionProgram.html Free Online Book at http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html _______________________________________________ Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
Squeakfoundation mailing list Squeakfoundation@lists.squeakfoundation.org http://lists.squeakfoundation.org/listinfo/squeakfoundation
Prof. Dr. Stéphane DUCASSE http://www.iam.unibe.ch/~ducasse/ "if you knew today was your last day on earth, what would you do different? ... especially if, by doing something different, today might not be your last day on earth" Calvin&Hobbes
"The best way to predict the future is to invent it..." Alan Kay.
Open Source Smalltalks: http://www.squeak.org, http://www.gnu.org/software/smalltalk/smalltalk.html Free books for Universities at http://www.esug.org/sponsoring/promotionProgram.html Free Online Book at http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html
squeakfoundation@lists.squeakfoundation.org
-
Daniel Vainsencher -
Doug Way -
Stephane Ducasse